* [PR PATCH] maxima: fix build with -o ~sbcl
@ 2023-10-16 2:56 tornaria
2023-10-16 14:32 ` [PR PATCH] [Updated] " tornaria
` (13 more replies)
0 siblings, 14 replies; 15+ messages in thread
From: tornaria @ 2023-10-16 2:56 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1700 bytes --]
There is a new pull request by tornaria against master on the void-packages repository
https://github.com/tornaria/void-packages maxima
https://github.com/void-linux/void-packages/pull/46709
maxima: fix build with -o ~sbcl
This is the default for aarch64.
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **briefly**
Rework the patch `use-shared-library.patch` so the ecl binaries work as built, no need to use `patchelf` anymore. This way there should be no problem if maxima is needed to build the documentation.
OTOH, the documentation is currently shipped in the tarball, so we touch the correct files so that it won't be rebuilt.
This won't change the binary package, no need to revbump.
Cc: @dkwo
Fixes: #46293
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/46709.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-maxima-46709.patch --]
[-- Type: text/x-diff, Size: 4059 bytes --]
From a54a643586b9286343d501e001b5ae072551a604 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Gonzalo=20Tornar=C3=ADa?= <tornaria@cmat.edu.uy>
Date: Sun, 15 Oct 2023 20:32:11 -0300
Subject: [PATCH] maxima: fix build with -o ~sbcl
This is the default for aarch64.
---
.../maxima/patches/use-shared-library.patch | 17 ++++++-----
srcpkgs/maxima/template | 28 ++++++++-----------
2 files changed, 20 insertions(+), 25 deletions(-)
diff --git a/srcpkgs/maxima/patches/use-shared-library.patch b/srcpkgs/maxima/patches/use-shared-library.patch
index a8f986ac7033c..56dff9be517ea 100644
--- a/srcpkgs/maxima/patches/use-shared-library.patch
+++ b/srcpkgs/maxima/patches/use-shared-library.patch
@@ -1,21 +1,20 @@
---- a/src/maxima.system 2021-12-02 00:26:23.955984864 -0300
-+++ b/src/maxima.system 2021-12-02 00:31:22.299541969 -0300
-@@ -87,13 +87,15 @@
- (let ((obj (mapcar #'(lambda (p)
+--- a/src/maxima.system
++++ b/src/maxima.system
+@@ -88,12 +88,15 @@
;; Convert dir/foo.fas to dir/foo.o
(make-pathname :type "o" :defaults p))
-- files)))
+ files)))
- (c::build-fasl "binary-ecl/maxima" :lisp-files obj
-+ files))
-+ (lib '("binary-ecl/libmaxima-ecl.so")))
+ (c::build-shared-library "binary-ecl/maxima-ecl" :lisp-files obj)
-+ (c::build-fasl "binary-ecl/maxima" :lisp-files lib
++ (si::chdir "binary-ecl")
++ (defparameter c::*ld-rpath* "-Wl,-rpath=$ORIGIN")
++ (c::build-fasl "maxima" :lisp-files '("libmaxima-ecl.so")
:ld-flags
(let ((x (symbol-value (find-symbol "*AUTOCONF-LD-FLAGS*"
(find-package "MAXIMA")))))
(if (and x (not (string= x ""))) (split-string x))))
- (c::build-program "binary-ecl/maxima" :lisp-files obj
-+ (c::build-program "binary-ecl/maxima" :lisp-files lib
++ (c::build-program "maxima" :lisp-files '("libmaxima-ecl.so")
:ld-flags
(let ((x (symbol-value (find-symbol "*AUTOCONF-LD-FLAGS*"
(find-package "MAXIMA")))))
diff --git a/srcpkgs/maxima/template b/srcpkgs/maxima/template
index ef46df5b713ce..43e0e25cc3ec2 100644
--- a/srcpkgs/maxima/template
+++ b/srcpkgs/maxima/template
@@ -3,8 +3,8 @@ pkgname=maxima
version=5.47.0
revision=3
build_style=gnu-configure
-configure_args="$(vopt_enable clisp) $(vopt_enable sbcl sbcl-exec) $(vopt_enable ecl)"
-hostmakedepends="python3 perl texinfo patchelf $(vopt_if ecl ecl)"
+configure_args="$(vopt_enable clisp) $(vopt_enable sbcl) $(vopt_enable ecl)
+ makeinfo_found=true"
makedepends="$(vopt_if clisp clisp) $(vopt_if sbcl sbcl) $(vopt_if ecl ecl)"
depends="$(vopt_if clisp clisp) rlwrap"
checkdepends="gnuplot"
@@ -41,26 +41,17 @@ esac
vopt_conflict clisp sbcl
-post_configure() {
+pre_build() {
# do not rebuild these files if they exist
touch -c doc/info/*.html
touch -c doc/info/maxima.info*
touch -c doc/info/maxima_toc.html
+ touch -c doc/info/maxima-index.lisp
+ touch -c doc/info/maxima-index-html.lisp
+ touch -c interfaces/xmaxima/doc/xmaxima.info
touch -c interfaces/xmaxima/doc/xmaxima.html
}
-post_build() {
- if [ "$build_option_ecl" ]; then
- # everything will go in the same directory, use rpath=$ORIGIN
- patchelf --remove-rpath src/binary-ecl/libmaxima-ecl.so
- patchelf --set-rpath \$ORIGIN \
- src/binary-ecl/{maxima,maxima.fas}
- patchelf \
- --replace-needed binary-ecl/libmaxima-ecl.so libmaxima-ecl.so \
- src/binary-ecl/{maxima,maxima.fas}
- fi
-}
-
do_check() {
if [ "$build_option_ecl" ]; then
echo "maxima-ecl: check that maxima.fas works (#34273)"
@@ -93,6 +84,11 @@ do_check() {
fi
}
+pre_install() {
+ # do not rebuild these files if they exist
+ touch -c interfaces/emacs/imaxima/imaxima.info
+}
+
post_install() {
vmkdir usr/share/doc
ln -sf ../maxima/${version}/doc ${DESTDIR}/usr/share/doc/maxima
@@ -103,7 +99,7 @@ post_install() {
# info files are used for maxima help, and need to be uncompressed
# removing this file prevents compression of info files
- rm ${DESTDIR}/usr/share/info/dir
+ rm -f ${DESTDIR}/usr/share/info/dir
}
maxima-src_package() {
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PR PATCH] [Updated] maxima: fix build with -o ~sbcl
2023-10-16 2:56 [PR PATCH] maxima: fix build with -o ~sbcl tornaria
@ 2023-10-16 14:32 ` tornaria
2023-10-16 14:33 ` tornaria
` (12 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: tornaria @ 2023-10-16 14:32 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1705 bytes --]
There is an updated pull request by tornaria against master on the void-packages repository
https://github.com/tornaria/void-packages maxima
https://github.com/void-linux/void-packages/pull/46709
maxima: fix build with -o ~sbcl
This is the default for aarch64.
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **briefly**
Rework the patch `use-shared-library.patch` so the ecl binaries work as built, no need to use `patchelf` anymore. This way there should be no problem if maxima is needed to build the documentation.
OTOH, the documentation is currently shipped in the tarball, so we touch the correct files so that it won't be rebuilt.
This won't change the binary package, no need to revbump.
Cc: @dkwo
Fixes: #46293
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/46709.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-maxima-46709.patch --]
[-- Type: text/x-diff, Size: 3797 bytes --]
From a1539319af062a97d06030e395849effe49f9fd3 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Gonzalo=20Tornar=C3=ADa?= <tornaria@cmat.edu.uy>
Date: Sun, 15 Oct 2023 20:32:11 -0300
Subject: [PATCH] maxima: fix build with -o ~sbcl
This is the default for aarch64.
---
.../maxima/patches/use-shared-library.patch | 17 +++++++-------
srcpkgs/maxima/template | 22 ++++++++-----------
2 files changed, 17 insertions(+), 22 deletions(-)
diff --git a/srcpkgs/maxima/patches/use-shared-library.patch b/srcpkgs/maxima/patches/use-shared-library.patch
index a8f986ac7033c..56dff9be517ea 100644
--- a/srcpkgs/maxima/patches/use-shared-library.patch
+++ b/srcpkgs/maxima/patches/use-shared-library.patch
@@ -1,21 +1,20 @@
---- a/src/maxima.system 2021-12-02 00:26:23.955984864 -0300
-+++ b/src/maxima.system 2021-12-02 00:31:22.299541969 -0300
-@@ -87,13 +87,15 @@
- (let ((obj (mapcar #'(lambda (p)
+--- a/src/maxima.system
++++ b/src/maxima.system
+@@ -88,12 +88,15 @@
;; Convert dir/foo.fas to dir/foo.o
(make-pathname :type "o" :defaults p))
-- files)))
+ files)))
- (c::build-fasl "binary-ecl/maxima" :lisp-files obj
-+ files))
-+ (lib '("binary-ecl/libmaxima-ecl.so")))
+ (c::build-shared-library "binary-ecl/maxima-ecl" :lisp-files obj)
-+ (c::build-fasl "binary-ecl/maxima" :lisp-files lib
++ (si::chdir "binary-ecl")
++ (defparameter c::*ld-rpath* "-Wl,-rpath=$ORIGIN")
++ (c::build-fasl "maxima" :lisp-files '("libmaxima-ecl.so")
:ld-flags
(let ((x (symbol-value (find-symbol "*AUTOCONF-LD-FLAGS*"
(find-package "MAXIMA")))))
(if (and x (not (string= x ""))) (split-string x))))
- (c::build-program "binary-ecl/maxima" :lisp-files obj
-+ (c::build-program "binary-ecl/maxima" :lisp-files lib
++ (c::build-program "maxima" :lisp-files '("libmaxima-ecl.so")
:ld-flags
(let ((x (symbol-value (find-symbol "*AUTOCONF-LD-FLAGS*"
(find-package "MAXIMA")))))
diff --git a/srcpkgs/maxima/template b/srcpkgs/maxima/template
index ef46df5b713ce..eae9cad3a85e9 100644
--- a/srcpkgs/maxima/template
+++ b/srcpkgs/maxima/template
@@ -3,8 +3,8 @@ pkgname=maxima
version=5.47.0
revision=3
build_style=gnu-configure
-configure_args="$(vopt_enable clisp) $(vopt_enable sbcl sbcl-exec) $(vopt_enable ecl)"
-hostmakedepends="python3 perl texinfo patchelf $(vopt_if ecl ecl)"
+configure_args="$(vopt_enable clisp) $(vopt_enable sbcl) $(vopt_enable ecl)
+ makeinfo_found=true"
makedepends="$(vopt_if clisp clisp) $(vopt_if sbcl sbcl) $(vopt_if ecl ecl)"
depends="$(vopt_if clisp clisp) rlwrap"
checkdepends="gnuplot"
@@ -41,24 +41,20 @@ esac
vopt_conflict clisp sbcl
-post_configure() {
+pre_build() {
# do not rebuild these files if they exist
touch -c doc/info/*.html
touch -c doc/info/maxima.info*
touch -c doc/info/maxima_toc.html
+ touch -c doc/info/maxima-index.lisp
+ touch -c doc/info/maxima-index-html.lisp
+ touch -c interfaces/xmaxima/doc/xmaxima.info
touch -c interfaces/xmaxima/doc/xmaxima.html
}
post_build() {
- if [ "$build_option_ecl" ]; then
- # everything will go in the same directory, use rpath=$ORIGIN
- patchelf --remove-rpath src/binary-ecl/libmaxima-ecl.so
- patchelf --set-rpath \$ORIGIN \
- src/binary-ecl/{maxima,maxima.fas}
- patchelf \
- --replace-needed binary-ecl/libmaxima-ecl.so libmaxima-ecl.so \
- src/binary-ecl/{maxima,maxima.fas}
- fi
+ # this one needs to be done after building
+ touch -c interfaces/emacs/imaxima/imaxima.info
}
do_check() {
@@ -103,7 +99,7 @@ post_install() {
# info files are used for maxima help, and need to be uncompressed
# removing this file prevents compression of info files
- rm ${DESTDIR}/usr/share/info/dir
+ rm -f ${DESTDIR}/usr/share/info/dir
}
maxima-src_package() {
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: maxima: fix build with -o ~sbcl
2023-10-16 2:56 [PR PATCH] maxima: fix build with -o ~sbcl tornaria
2023-10-16 14:32 ` [PR PATCH] [Updated] " tornaria
@ 2023-10-16 14:33 ` tornaria
2023-10-16 18:01 ` dkwo
` (11 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: tornaria @ 2023-10-16 14:33 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 158 bytes --]
New comment by tornaria on void-packages repository
https://github.com/void-linux/void-packages/pull/46709#issuecomment-1764615535
Comment:
Ready to merge.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: maxima: fix build with -o ~sbcl
2023-10-16 2:56 [PR PATCH] maxima: fix build with -o ~sbcl tornaria
2023-10-16 14:32 ` [PR PATCH] [Updated] " tornaria
2023-10-16 14:33 ` tornaria
@ 2023-10-16 18:01 ` dkwo
2023-10-16 18:01 ` dkwo
` (10 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: dkwo @ 2023-10-16 18:01 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 171 bytes --]
New comment by dkwo on void-packages repository
https://github.com/void-linux/void-packages/pull/46709#issuecomment-1764999849
Comment:
any reason we keep it `nocross`?
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: maxima: fix build with -o ~sbcl
2023-10-16 2:56 [PR PATCH] maxima: fix build with -o ~sbcl tornaria
` (2 preceding siblings ...)
2023-10-16 18:01 ` dkwo
@ 2023-10-16 18:01 ` dkwo
2023-10-16 18:05 ` tornaria
` (9 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: dkwo @ 2023-10-16 18:01 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 184 bytes --]
New comment by dkwo on void-packages repository
https://github.com/void-linux/void-packages/pull/46709#issuecomment-1765000220
Comment:
other than that, it looks good to me, thanks.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: maxima: fix build with -o ~sbcl
2023-10-16 2:56 [PR PATCH] maxima: fix build with -o ~sbcl tornaria
` (3 preceding siblings ...)
2023-10-16 18:01 ` dkwo
@ 2023-10-16 18:05 ` tornaria
2023-10-16 18:29 ` dkwo
` (8 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: tornaria @ 2023-10-16 18:05 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 213 bytes --]
New comment by tornaria on void-packages repository
https://github.com/void-linux/void-packages/pull/46709#issuecomment-1765006643
Comment:
> any reason we keep it `nocross`?
It doesn't cross build, does it?
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: maxima: fix build with -o ~sbcl
2023-10-16 2:56 [PR PATCH] maxima: fix build with -o ~sbcl tornaria
` (4 preceding siblings ...)
2023-10-16 18:05 ` tornaria
@ 2023-10-16 18:29 ` dkwo
2023-10-16 18:57 ` dkwo
` (7 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: dkwo @ 2023-10-16 18:29 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1007 bytes --]
New comment by dkwo on void-packages repository
https://github.com/void-linux/void-packages/pull/46709#issuecomment-1765059813
Comment:
Well, if I remove `nocross` and set `$makedepends=hostmakedepends`, then it almost does:
```
=> maxima-ecl-5.47.0_3: running post-install hook: 06-strip-and-debug-pkgs ...
/usr/bin/aarch64-linux-gnu-strip: Unable to recognise the format of the input file `/destdir/aarch64-linux-gnu/maxima-ecl-5.47.0/usr/lib/maxima/5.47.0/binary-ecl/libmaxima-ecl.so'
=> ERROR: maxima-ecl-5.47.0_3: failed to strip /usr/lib/maxima/5.47.0/binary-ecl/libmaxima-ecl.so
=> ERROR: maxima-ecl-5.47.0_3: post-install_06-strip-and-debug-pkgs: 'find ${PKGDESTDIR} -type f' exited with 1
=> ERROR: in hook() at common/hooks/post-install/06-strip-and-debug-pkgs.sh:68
=> ERROR: in run_func() at common/xbps-src/shutils/common.sh:57
=> ERROR: in run_pkg_hooks() at common/xbps-src/shutils/common.sh:298
=> ERROR: in main() at common/xbps-src/libexec/xbps-src-doinstall.sh:66
```
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: maxima: fix build with -o ~sbcl
2023-10-16 2:56 [PR PATCH] maxima: fix build with -o ~sbcl tornaria
` (5 preceding siblings ...)
2023-10-16 18:29 ` dkwo
@ 2023-10-16 18:57 ` dkwo
2023-10-16 19:38 ` tornaria
` (6 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: dkwo @ 2023-10-16 18:57 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 569 bytes --]
New comment by dkwo on void-packages repository
https://github.com/void-linux/void-packages/pull/46709#issuecomment-1765099914
Comment:
if I also remove the patch, then it builds fine
```
=> maxima-ecl-5.47.0_3: running pkg_install ...
=> ERROR: maxima-ecl-5.47.0_3: vinstall: cannot find 'src/binary-ecl/libmaxima-ecl.so'...
=> ERROR: maxima-ecl-5.47.0_3: pkg_install: 'return 1' exited with 1
=> ERROR: in _noglob_helper() at common/environment/setup/install.sh:12
=> ERROR: in pkg_install() at srcpkgs/maxima-ecl/template:134
```
I'll try again later.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: maxima: fix build with -o ~sbcl
2023-10-16 2:56 [PR PATCH] maxima: fix build with -o ~sbcl tornaria
` (6 preceding siblings ...)
2023-10-16 18:57 ` dkwo
@ 2023-10-16 19:38 ` tornaria
2023-10-16 22:01 ` dkwo
` (5 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: tornaria @ 2023-10-16 19:38 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1192 bytes --]
New comment by tornaria on void-packages repository
https://github.com/void-linux/void-packages/pull/46709#issuecomment-1765153271
Comment:
> if I also remove the patch, then it builds fine
>
> ```
> => maxima-ecl-5.47.0_3: running pkg_install ...
> => ERROR: maxima-ecl-5.47.0_3: vinstall: cannot find 'src/binary-ecl/libmaxima-ecl.so'...
> => ERROR: maxima-ecl-5.47.0_3: pkg_install: 'return 1' exited with 1
> => ERROR: in _noglob_helper() at common/environment/setup/install.sh:12
> => ERROR: in pkg_install() at srcpkgs/maxima-ecl/template:134
> ```
>
> I'll try again later.
I'm not sure ecl will cross build. It's no good if the binary that you build is x86_64 instead of aarch64. The strip hook just happens to barf at `libmaxima-ecl.so` and not at `maxima`; that doesn't mean the `maxima` binary will work.
Just use `file` to see whether the binaries have been built for aarch64 or not. You can try that with `maxima`, `maxima.fas` and `libmaxima-ecl.so` after running `do_build()`, it doesn't matter if the `do_install()` step succeeds or not, the files are there. If they are good, we can figure out a way to fix the install, if they are not good, then no.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: maxima: fix build with -o ~sbcl
2023-10-16 2:56 [PR PATCH] maxima: fix build with -o ~sbcl tornaria
` (7 preceding siblings ...)
2023-10-16 19:38 ` tornaria
@ 2023-10-16 22:01 ` dkwo
2023-10-16 22:17 ` tornaria
` (4 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: dkwo @ 2023-10-16 22:01 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 520 bytes --]
New comment by dkwo on void-packages repository
https://github.com/void-linux/void-packages/pull/46709#issuecomment-1765344881
Comment:
file gives `/destdir/aarch64-linux-gnu/maxima-5.47.0/usr/bin/maxima: POSIX shell script, ASCII text executable`
it seems one needs to do something like https://gitlab.com/spaghettisalat/jffi_repl_example/blob/master/app/src/main/lisp/asdf_libs/compile.lisp or https://gist.github.com/YasuakiHonda/98b2496f10642cdc080666b02b3db001 in order for ecl to use to the cross tool chain.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: maxima: fix build with -o ~sbcl
2023-10-16 2:56 [PR PATCH] maxima: fix build with -o ~sbcl tornaria
` (8 preceding siblings ...)
2023-10-16 22:01 ` dkwo
@ 2023-10-16 22:17 ` tornaria
2023-10-17 15:16 ` dkwo
` (3 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: tornaria @ 2023-10-16 22:17 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 738 bytes --]
New comment by tornaria on void-packages repository
https://github.com/void-linux/void-packages/pull/46709#issuecomment-1765361004
Comment:
> file gives `/destdir/aarch64-linux-gnu/maxima-5.47.0/usr/bin/maxima: POSIX shell script, ASCII text executable`
>
> it seems one needs to do something like https://gitlab.com/spaghettisalat/jffi_repl_example/blob/master/app/src/main/lisp/asdf_libs/compile.lisp or https://gist.github.com/YasuakiHonda/98b2496f10642cdc080666b02b3db001 in order for ecl to use to the cross tool chain.
You have to do it on the binaries, that's just a script to decide which binary to run.
The binaries go into the `binary-ecl` subdir (while building, this is in `src/binary-ecl` in the build directory).
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: maxima: fix build with -o ~sbcl
2023-10-16 2:56 [PR PATCH] maxima: fix build with -o ~sbcl tornaria
` (9 preceding siblings ...)
2023-10-16 22:17 ` tornaria
@ 2023-10-17 15:16 ` dkwo
2023-10-17 15:17 ` dkwo
` (2 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: dkwo @ 2023-10-17 15:16 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 417 bytes --]
New comment by dkwo on void-packages repository
https://github.com/void-linux/void-packages/pull/46709#issuecomment-1766631959
Comment:
I see, thanks, then it gives `src/binary-ecl/maxima: ELF 64-bit LSB pie executable, x86-64, version 1 (SYSV), dynamically linked, interpreter /lib64/ld-linux-x86-64.so.2, BuildID[sha1]=769c16a0c389d08792450a4cdd8663e0371273aa, for GNU/Linux 3.2.0, with debug_info, not stripped`
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: maxima: fix build with -o ~sbcl
2023-10-16 2:56 [PR PATCH] maxima: fix build with -o ~sbcl tornaria
` (10 preceding siblings ...)
2023-10-17 15:16 ` dkwo
@ 2023-10-17 15:17 ` dkwo
2023-10-17 15:18 ` dkwo
2023-10-17 15:59 ` [PR PATCH] [Merged]: " leahneukirchen
13 siblings, 0 replies; 15+ messages in thread
From: dkwo @ 2023-10-17 15:17 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 174 bytes --]
New comment by dkwo on void-packages repository
https://github.com/void-linux/void-packages/pull/46709#issuecomment-1766632714
Comment:
let's fix `nocross` another time :)
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: maxima: fix build with -o ~sbcl
2023-10-16 2:56 [PR PATCH] maxima: fix build with -o ~sbcl tornaria
` (11 preceding siblings ...)
2023-10-17 15:17 ` dkwo
@ 2023-10-17 15:18 ` dkwo
2023-10-17 15:59 ` [PR PATCH] [Merged]: " leahneukirchen
13 siblings, 0 replies; 15+ messages in thread
From: dkwo @ 2023-10-17 15:18 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 174 bytes --]
New comment by dkwo on void-packages repository
https://github.com/void-linux/void-packages/pull/46709#issuecomment-1766635630
Comment:
@leahneukirchen Can this be merged?
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PR PATCH] [Merged]: maxima: fix build with -o ~sbcl
2023-10-16 2:56 [PR PATCH] maxima: fix build with -o ~sbcl tornaria
` (12 preceding siblings ...)
2023-10-17 15:18 ` dkwo
@ 2023-10-17 15:59 ` leahneukirchen
13 siblings, 0 replies; 15+ messages in thread
From: leahneukirchen @ 2023-10-17 15:59 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1548 bytes --]
There's a merged pull request on the void-packages repository
maxima: fix build with -o ~sbcl
https://github.com/void-linux/void-packages/pull/46709
Description:
This is the default for aarch64.
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **briefly**
Rework the patch `use-shared-library.patch` so the ecl binaries work as built, no need to use `patchelf` anymore. This way there should be no problem if maxima is needed to build the documentation.
OTOH, the documentation is currently shipped in the tarball, so we touch the correct files so that it won't be rebuilt.
This won't change the binary package, no need to revbump.
Cc: @dkwo
Fixes: #46293
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2023-10-17 15:59 UTC | newest]
Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-16 2:56 [PR PATCH] maxima: fix build with -o ~sbcl tornaria
2023-10-16 14:32 ` [PR PATCH] [Updated] " tornaria
2023-10-16 14:33 ` tornaria
2023-10-16 18:01 ` dkwo
2023-10-16 18:01 ` dkwo
2023-10-16 18:05 ` tornaria
2023-10-16 18:29 ` dkwo
2023-10-16 18:57 ` dkwo
2023-10-16 19:38 ` tornaria
2023-10-16 22:01 ` dkwo
2023-10-16 22:17 ` tornaria
2023-10-17 15:16 ` dkwo
2023-10-17 15:17 ` dkwo
2023-10-17 15:18 ` dkwo
2023-10-17 15:59 ` [PR PATCH] [Merged]: " leahneukirchen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).