* [PR PATCH] New package: python3-zombie-imp-0.0.2, gpodder: use zombie-imp
@ 2023-10-15 10:06 paper42
2023-10-15 10:07 ` [PR PATCH] [Updated] " paper42
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: paper42 @ 2023-10-15 10:06 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 648 bytes --]
There is a new pull request by paper42 against master on the void-packages repository
https://github.com/paper42/void-packages gpodder-zombie-imp
https://github.com/void-linux/void-packages/pull/46693
New package: python3-zombie-imp-0.0.2, gpodder: use zombie-imp
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
it would be better if we could fix gpodder and other packages properly, but this is a hacky solution to make it easily work, opinions?
A patch file from https://github.com/void-linux/void-packages/pull/46693.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gpodder-zombie-imp-46693.patch --]
[-- Type: text/x-diff, Size: 2078 bytes --]
From f71407adc4a4f24757c6d5412f60e9694e59ff18 Mon Sep 17 00:00:00 2001
From: Emi Vasilek <emi.vasilek@gmail.com>
Date: Sun, 15 Oct 2023 12:02:35 +0200
Subject: [PATCH 1/2] New package: python3-zombie-imp-0.0.2
---
srcpkgs/python3-zombie-imp/template | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
create mode 100644 srcpkgs/python3-zombie-imp/template
diff --git a/srcpkgs/python3-zombie-imp/template b/srcpkgs/python3-zombie-imp/template
new file mode 100644
index 0000000000000..595185e9af7ee
--- /dev/null
+++ b/srcpkgs/python3-zombie-imp/template
@@ -0,0 +1,16 @@
+# Template file for 'python3-zombie-imp'
+pkgname=python3-zombie-imp
+version=0.0.2
+revision=1
+build_style=python3-pep517
+hostmakedepends="python3-setuptools python3-wheel"
+short_desc="Copy of the imp module that was removed in Python 3.12"
+maintainer="Emi Vasilek <emi.vasilek@gmail.com>"
+license="Python-2.0"
+homepage="https://github.com/encukou/zombie-imp"
+distfiles="https://github.com/encukou/zombie-imp/archive/refs/tags/v${version}.tar.gz"
+checksum=08c6c53fc78f5ff45508b4d515f723f9dc07891e6b978435fb8eab1fe3185380
+
+post_install() {
+ vlicense LICENSE
+}
From 27ad4f61ed2055dac9c2e62566cf4e3be36a7f92 Mon Sep 17 00:00:00 2001
From: Emi Vasilek <emi.vasilek@gmail.com>
Date: Sun, 15 Oct 2023 12:02:42 +0200
Subject: [PATCH 2/2] gpodder: fix no such module imp with Python 3.12
---
srcpkgs/gpodder/template | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/srcpkgs/gpodder/template b/srcpkgs/gpodder/template
index 7d4161ee3e429..ea812c4274fdf 100644
--- a/srcpkgs/gpodder/template
+++ b/srcpkgs/gpodder/template
@@ -5,7 +5,7 @@ revision=2
hostmakedepends="python3-setuptools intltool"
depends="eyeD3 gtk+3 hicolor-icon-theme python3-dbus python3-gobject
python3-html5lib python3-mygpoclient python3-podcastparser python3-mutagen
- python3-requests"
+ python3-requests python3-zombie-imp"
checkdepends="${depends} python3-MiniMock python3-coverage desktop-file-utils
python3-pytest python3-pytest-httpserver python3-pytest-cov python3-requests
which"
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PR PATCH] [Updated] New package: python3-zombie-imp-0.0.2, gpodder: use zombie-imp
2023-10-15 10:06 [PR PATCH] New package: python3-zombie-imp-0.0.2, gpodder: use zombie-imp paper42
@ 2023-10-15 10:07 ` paper42
2023-10-15 12:08 ` ahesford
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: paper42 @ 2023-10-15 10:07 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 671 bytes --]
There is an updated pull request by paper42 against master on the void-packages repository
https://github.com/paper42/void-packages gpodder-zombie-imp
https://github.com/void-linux/void-packages/pull/46693
New package: python3-zombie-imp-0.0.2, gpodder: use zombie-imp
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
it would be better if we could fix gpodder and other packages properly, but this is a hacky solution to make it easily work, opinions?
Closes: #46683
A patch file from https://github.com/void-linux/void-packages/pull/46693.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gpodder-zombie-imp-46693.patch --]
[-- Type: text/x-diff, Size: 2161 bytes --]
From f71407adc4a4f24757c6d5412f60e9694e59ff18 Mon Sep 17 00:00:00 2001
From: Emi Vasilek <emi.vasilek@gmail.com>
Date: Sun, 15 Oct 2023 12:02:35 +0200
Subject: [PATCH 1/2] New package: python3-zombie-imp-0.0.2
---
srcpkgs/python3-zombie-imp/template | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
create mode 100644 srcpkgs/python3-zombie-imp/template
diff --git a/srcpkgs/python3-zombie-imp/template b/srcpkgs/python3-zombie-imp/template
new file mode 100644
index 0000000000000..595185e9af7ee
--- /dev/null
+++ b/srcpkgs/python3-zombie-imp/template
@@ -0,0 +1,16 @@
+# Template file for 'python3-zombie-imp'
+pkgname=python3-zombie-imp
+version=0.0.2
+revision=1
+build_style=python3-pep517
+hostmakedepends="python3-setuptools python3-wheel"
+short_desc="Copy of the imp module that was removed in Python 3.12"
+maintainer="Emi Vasilek <emi.vasilek@gmail.com>"
+license="Python-2.0"
+homepage="https://github.com/encukou/zombie-imp"
+distfiles="https://github.com/encukou/zombie-imp/archive/refs/tags/v${version}.tar.gz"
+checksum=08c6c53fc78f5ff45508b4d515f723f9dc07891e6b978435fb8eab1fe3185380
+
+post_install() {
+ vlicense LICENSE
+}
From 9ea0a8fd1176d65751e2ddb35eff8cc6828593ae Mon Sep 17 00:00:00 2001
From: Emi Vasilek <emi.vasilek@gmail.com>
Date: Sun, 15 Oct 2023 12:02:42 +0200
Subject: [PATCH 2/2] gpodder: fix no such module imp with Python 3.12
---
srcpkgs/gpodder/template | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/gpodder/template b/srcpkgs/gpodder/template
index 7d4161ee3e429..8ad8b0b313cc4 100644
--- a/srcpkgs/gpodder/template
+++ b/srcpkgs/gpodder/template
@@ -1,11 +1,11 @@
# Template file for 'gpodder'
pkgname=gpodder
version=3.11.1
-revision=2
+revision=3
hostmakedepends="python3-setuptools intltool"
depends="eyeD3 gtk+3 hicolor-icon-theme python3-dbus python3-gobject
python3-html5lib python3-mygpoclient python3-podcastparser python3-mutagen
- python3-requests"
+ python3-requests python3-zombie-imp"
checkdepends="${depends} python3-MiniMock python3-coverage desktop-file-utils
python3-pytest python3-pytest-httpserver python3-pytest-cov python3-requests
which"
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: New package: python3-zombie-imp-0.0.2, gpodder: use zombie-imp
2023-10-15 10:06 [PR PATCH] New package: python3-zombie-imp-0.0.2, gpodder: use zombie-imp paper42
2023-10-15 10:07 ` [PR PATCH] [Updated] " paper42
@ 2023-10-15 12:08 ` ahesford
2023-10-20 9:50 ` auouymous
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: ahesford @ 2023-10-15 12:08 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 728 bytes --]
New comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/46693#issuecomment-1763369432
Comment:
In this case, I think it's better to just patch `gpodder`. The patch seems to be the replacement of a single `import imp` and call to `imp.load_source` in `src/gpodder/extensions.py` with the alternative `load_source` function [recommended by Python](https://docs.python.org/dev/whatsnew/3.12.html#imp).
If the patch were more extensive, it might be worth carrying this package (even though upstream says not to use it and `imp` has been deprecated for nine years). I also think it would be more tolerable as a build dependency for some complex package than as a runtime dependency.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: New package: python3-zombie-imp-0.0.2, gpodder: use zombie-imp
2023-10-15 10:06 [PR PATCH] New package: python3-zombie-imp-0.0.2, gpodder: use zombie-imp paper42
2023-10-15 10:07 ` [PR PATCH] [Updated] " paper42
2023-10-15 12:08 ` ahesford
@ 2023-10-20 9:50 ` auouymous
2023-10-27 20:42 ` Piraty
2023-11-13 6:04 ` [PR PATCH] [Closed]: " classabbyamp
4 siblings, 0 replies; 6+ messages in thread
From: auouymous @ 2023-10-20 9:50 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 337 bytes --]
New comment by auouymous on void-packages repository
https://github.com/void-linux/void-packages/pull/46693#issuecomment-1772423221
Comment:
https://github.com/gpodder/gpodder/pull/1571 contains a patch to replace imp. I have not tested gPodder on 3.12, so it might require additional patches.
@ahesford Thanks for the information.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: New package: python3-zombie-imp-0.0.2, gpodder: use zombie-imp
2023-10-15 10:06 [PR PATCH] New package: python3-zombie-imp-0.0.2, gpodder: use zombie-imp paper42
` (2 preceding siblings ...)
2023-10-20 9:50 ` auouymous
@ 2023-10-27 20:42 ` Piraty
2023-11-13 6:04 ` [PR PATCH] [Closed]: " classabbyamp
4 siblings, 0 replies; 6+ messages in thread
From: Piraty @ 2023-10-27 20:42 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 221 bytes --]
New comment by Piraty on void-packages repository
https://github.com/void-linux/void-packages/pull/46693#issuecomment-1783489940
Comment:
thank you @auouymous , i picked the relevant parts from your branch, see #46934
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PR PATCH] [Closed]: New package: python3-zombie-imp-0.0.2, gpodder: use zombie-imp
2023-10-15 10:06 [PR PATCH] New package: python3-zombie-imp-0.0.2, gpodder: use zombie-imp paper42
` (3 preceding siblings ...)
2023-10-27 20:42 ` Piraty
@ 2023-11-13 6:04 ` classabbyamp
4 siblings, 0 replies; 6+ messages in thread
From: classabbyamp @ 2023-11-13 6:04 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 504 bytes --]
There's a closed pull request on the void-packages repository
New package: python3-zombie-imp-0.0.2, gpodder: use zombie-imp
https://github.com/void-linux/void-packages/pull/46693
Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
it would be better if we could fix gpodder and other packages properly, but this is a hacky solution to make it easily work, opinions?
Closes: #46683
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-11-13 6:04 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-15 10:06 [PR PATCH] New package: python3-zombie-imp-0.0.2, gpodder: use zombie-imp paper42
2023-10-15 10:07 ` [PR PATCH] [Updated] " paper42
2023-10-15 12:08 ` ahesford
2023-10-20 9:50 ` auouymous
2023-10-27 20:42 ` Piraty
2023-11-13 6:04 ` [PR PATCH] [Closed]: " classabbyamp
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).