[PR PATCH] bCNC: fix breakage

[PR PATCH] bCNC: fix breakage

[Luciogi]

[-- Attachment #1: Type: text/plain, Size: 468 bytes --]

There is a new pull request by Luciogi against master on the void-packages repository

https://github.com/Luciogi/void-packages bCNC
https://github.com/void-linux/void-packages/pull/46817

bCNC: fix breakage
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)


A patch file from https://github.com/void-linux/void-packages/pull/46817.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-bCNC-46817.patch --]
[-- Type: text/x-diff, Size: 1934 bytes --]

From 33e6f63e585257c9b6fa4089987b4c01bf7ce883 Mon Sep 17 00:00:00 2001
From: Luciogi <lucigithubcommit@skiff.com>
Date: Sat, 21 Oct 2023 22:06:14 +0500
Subject: [PATCH] bCNC: fix breakage

---
 srcpkgs/bCNC/patches/import_sys.patch | 36 +++++++++++++++++++++++++++
 srcpkgs/bCNC/template                 |  2 +-
 2 files changed, 37 insertions(+), 1 deletion(-)
 create mode 100644 srcpkgs/bCNC/patches/import_sys.patch

diff --git a/srcpkgs/bCNC/patches/import_sys.patch b/srcpkgs/bCNC/patches/import_sys.patch
new file mode 100644
index 0000000000000..e498f7596298f
--- /dev/null
+++ b/srcpkgs/bCNC/patches/import_sys.patch
@@ -0,0 +1,36 @@
+diff --git a/bCNC/FilePage.py b/bCNC/FilePage.py
+index 0bb436a..fca11ce 100644
+--- a/bCNC/FilePage.py
++++ b/bCNC/FilePage.py
+@@ -16,6 +16,7 @@ try:
+ except ImportError:
+ 	from tkinter import *
+ 
++import sys
+ import tkExtra
+ import Utils
+ import Sender
+diff --git a/bCNC/ToolsPage.py b/bCNC/ToolsPage.py
+index f550186..30d27cb 100644
+--- a/bCNC/ToolsPage.py
++++ b/bCNC/ToolsPage.py
+@@ -18,6 +18,7 @@ except ImportError:
+ 	import tkinter.messagebox as tkMessageBox
+ from operator import attrgetter
+ 
++import sys
+ import os
+ import time
+ import glob
+diff --git a/bCNC/Utils.py b/bCNC/Utils.py
+index 2a0b231..8d3b57b 100644
+--- a/bCNC/Utils.py
++++ b/bCNC/Utils.py
+@@ -9,6 +9,7 @@ from __future__ import print_function
+ __author__ = "Vasilis Vlachoudis"
+ __email__  = "vvlachoudis@gmail.com"
+ 
++import sys
+ import os
+ import glob
+ import traceback
diff --git a/srcpkgs/bCNC/template b/srcpkgs/bCNC/template
index 4bfdbe16cca19..850eb4e3dc15c 100644
--- a/srcpkgs/bCNC/template
+++ b/srcpkgs/bCNC/template
@@ -1,7 +1,7 @@
 # Template file for 'bCNC'
 pkgname=bCNC
 version=0.9.14.307
-revision=4
+revision=5
 build_style=python3-module
 hostmakedepends="python3-setuptools"
 depends="python3-pyserial python3-Pillow python3-tkinter python3-numpy python3-scipy"

Re: bCNC: fix breakage

[Luciogi]

[-- Attachment #1: Type: text/plain, Size: 157 bytes --]

New comment by Luciogi on void-packages repository

https://github.com/void-linux/void-packages/pull/46817#issuecomment-1773866423

Comment:
fixes : #46723 

Re: bCNC: fix breakage

[Luciogi]

[-- Attachment #1: Type: text/plain, Size: 782 bytes --]

New comment by Luciogi on void-packages repository

https://github.com/void-linux/void-packages/pull/46817#issuecomment-1773871606

Comment:
`checkdepends="python3-wheel python3-imageio libopencv-python3"`
I added libopencv-python3 as checkdepends, but it still compain about it
```
  ir_d = dist.fetch_build_eggs(dist.install_requires)
/usr/bin/python3: No module named pip
error: Command '['/usr/bin/python3', '-m', 'pip', '--disable-pip-version-check', 'wheel', '--no-deps', '-w', '/tmp/tmpox3gdhhv', '--quiet', 'opencv-python>=2.4']' returned non-zero exit status 1.
=> ERROR: bCNC-0.9.14.307_5: do_check: '${make_check_pre} python3 setup.py ${make_check_target} ${make_check_args}' exited with 1
=> ERROR:   in do_check() at common/build-style/python3-module.sh:28
```

Re: bCNC: fix breakage

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 235 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/46817#issuecomment-1779057991

Comment:
You should start with

    checkdepends="python3-pytest $depends"

and work from there. 

Re: bCNC: fix breakage

[Luciogi]

[-- Attachment #1: Type: text/plain, Size: 379 bytes --]

New comment by Luciogi on void-packages repository

https://github.com/void-linux/void-packages/pull/46817#issuecomment-1779082187

Comment:
> You should start with
> 
> ```
> checkdepends="python3-pytest $depends"
> ```
> 
> and work from there.
test failed with : with error
```
ModuleNotFoundError: No module named 'pyautogui'
```
`pyautogui` is not  in void repos

Re: bCNC: fix breakage

[Luciogi]

[-- Attachment #1: Type: text/plain, Size: 381 bytes --]

New comment by Luciogi on void-packages repository

https://github.com/void-linux/void-packages/pull/46817#issuecomment-1779082187

Comment:
> You should start with
> 
> ```
> checkdepends="python3-pytest $depends"
> ```
> 
> and work from there.

test failed with : with error
```
ModuleNotFoundError: No module named 'pyautogui'
```
`pyautogui` is not  in void repos

Re: bCNC: fix breakage

[paper42]

[-- Attachment #1: Type: text/plain, Size: 231 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/46817#issuecomment-1779152037

Comment:
you will have to add it as a new commit here or disable tests with an appropriate comment

Re: [PR PATCH] [Updated] bCNC: fix breakage

[Luciogi]

[-- Attachment #1: Type: text/plain, Size: 473 bytes --]

There is an updated pull request by Luciogi against master on the void-packages repository

https://github.com/Luciogi/void-packages bCNC
https://github.com/void-linux/void-packages/pull/46817

bCNC: fix breakage
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)


A patch file from https://github.com/void-linux/void-packages/pull/46817.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-bCNC-46817.patch --]
[-- Type: text/x-diff, Size: 2745 bytes --]

From e7d092b3e95ca8db743160cd821e8ae5c94a3b9e Mon Sep 17 00:00:00 2001
From: Luciogi <lucigithubcommit@skiff.com>
Date: Sat, 21 Oct 2023 22:06:14 +0500
Subject: [PATCH 1/2] bCNC: fix breakage

---
 srcpkgs/bCNC/patches/import_sys.patch | 36 +++++++++++++++++++++++++++
 srcpkgs/bCNC/template                 |  2 +-
 2 files changed, 37 insertions(+), 1 deletion(-)
 create mode 100644 srcpkgs/bCNC/patches/import_sys.patch

diff --git a/srcpkgs/bCNC/patches/import_sys.patch b/srcpkgs/bCNC/patches/import_sys.patch
new file mode 100644
index 0000000000000..e498f7596298f
--- /dev/null
+++ b/srcpkgs/bCNC/patches/import_sys.patch
@@ -0,0 +1,36 @@
+diff --git a/bCNC/FilePage.py b/bCNC/FilePage.py
+index 0bb436a..fca11ce 100644
+--- a/bCNC/FilePage.py
++++ b/bCNC/FilePage.py
+@@ -16,6 +16,7 @@ try:
+ except ImportError:
+ 	from tkinter import *
+ 
++import sys
+ import tkExtra
+ import Utils
+ import Sender
+diff --git a/bCNC/ToolsPage.py b/bCNC/ToolsPage.py
+index f550186..30d27cb 100644
+--- a/bCNC/ToolsPage.py
++++ b/bCNC/ToolsPage.py
+@@ -18,6 +18,7 @@ except ImportError:
+ 	import tkinter.messagebox as tkMessageBox
+ from operator import attrgetter
+ 
++import sys
+ import os
+ import time
+ import glob
+diff --git a/bCNC/Utils.py b/bCNC/Utils.py
+index 2a0b231..8d3b57b 100644
+--- a/bCNC/Utils.py
++++ b/bCNC/Utils.py
+@@ -9,6 +9,7 @@ from __future__ import print_function
+ __author__ = "Vasilis Vlachoudis"
+ __email__  = "vvlachoudis@gmail.com"
+ 
++import sys
+ import os
+ import glob
+ import traceback
diff --git a/srcpkgs/bCNC/template b/srcpkgs/bCNC/template
index 4bfdbe16cca19..850eb4e3dc15c 100644
--- a/srcpkgs/bCNC/template
+++ b/srcpkgs/bCNC/template
@@ -1,7 +1,7 @@
 # Template file for 'bCNC'
 pkgname=bCNC
 version=0.9.14.307
-revision=4
+revision=5
 build_style=python3-module
 hostmakedepends="python3-setuptools"
 depends="python3-pyserial python3-Pillow python3-tkinter python3-numpy python3-scipy"

From dfe56e48c0e1ac54f46b34242c62ee2a7fcfca64 Mon Sep 17 00:00:00 2001
From: Luciogi <lucigithubcommit@skiff.com>
Date: Wed, 25 Oct 2023 17:55:23 +0500
Subject: [PATCH 2/2] bCNC: fix breakage

---
 srcpkgs/bCNC/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/bCNC/template b/srcpkgs/bCNC/template
index 850eb4e3dc15c..7e1d147d1220f 100644
--- a/srcpkgs/bCNC/template
+++ b/srcpkgs/bCNC/template
@@ -11,7 +11,7 @@ license="GPL-2.0-only"
 homepage="https://github.com/vlachoudis/bCNC"
 distfiles="${PYPI_SITE}/b/${pkgname}/${pkgname}-${version}.tar.gz"
 checksum=005c3f2a0b244abab81dc3f6df2001f530db655165611165e7009e28b94cda5f
-
+make_check=no # tests require pyautogui, which is not packaged
 post_install() {
 	vmkdir usr/share/applications
 	vmkdir usr/share/pixmaps

Re: [PR PATCH] [Closed]: bCNC: fix breakage

[Luciogi]

[-- Attachment #1: Type: text/plain, Size: 320 bytes --]

There's a closed pull request on the void-packages repository

bCNC: fix breakage
https://github.com/void-linux/void-packages/pull/46817

Description:
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)