[PR PATCH] Add msitools package.

[PR PATCH] Add msitools package.

[afranchuk]

[-- Attachment #1: Type: text/plain, Size: 1080 bytes --]

There is a new pull request by afranchuk against master on the void-packages repository

https://github.com/afranchuk/void-packages msitools
https://github.com/void-linux/void-packages/pull/43321

Add msitools package.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc


A patch file from https://github.com/void-linux/void-packages/pull/43321.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-msitools-43321.patch --]
[-- Type: text/x-diff, Size: 1088 bytes --]

From c8c1741e17c629d738b2e933f817c0c0619482da Mon Sep 17 00:00:00 2001
From: Alex Franchuk <afranchuk@mozilla.com>
Date: Fri, 7 Apr 2023 09:03:16 -0400
Subject: [PATCH] Add msitools package.

---
 srcpkgs/msitools/template | 12 ++++++++++++
 1 file changed, 12 insertions(+)
 create mode 100644 srcpkgs/msitools/template

diff --git a/srcpkgs/msitools/template b/srcpkgs/msitools/template
new file mode 100644
index 000000000000..5d562a2338fc
--- /dev/null
+++ b/srcpkgs/msitools/template
@@ -0,0 +1,12 @@
+# Template file for 'msitools'
+pkgname=msitools
+version=0.101
+revision=1
+short_desc="A set of programs to inspect and build Windows Installer (.MSI) files"
+maintainer="Alex Franchuk <alex.franchuk@gmail.com>"
+license="LGPL-2.1-or-later"
+homepage="https://wiki.gnome.org/msitools"
+distfiles="https://download.gnome.org/sources/msitools/${version}/msitools-${version}.tar.xz"
+checksum="0cc4d2e0d108fa6f2b4085b9a97dd5bc6d9fcadecdd933f2094f86bafdbe85fe"
+build_style=meson
+hostmakedepends="bison gcab-devel glib-devel gobject-introspection libgsf-devel perl pkg-config vala"

Re: [PR REVIEW] New package: msitools

[paper42]

[-- Attachment #1: Type: text/plain, Size: 260 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/43321#discussion_r1160714886

Comment:
The copyright file suggests it's not this simple https://gitlab.gnome.org/GNOME/msitools/-/blob/master/copyright

Re: [PR REVIEW] New package: msitools

[afranchuk]

[-- Attachment #1: Type: text/plain, Size: 313 bytes --]

New review comment by afranchuk on void-packages repository

https://github.com/void-linux/void-packages/pull/43321#discussion_r1160722890

Comment:
Ah, I see. I was negligent in reading the specification of the copyright file and assumed that `Files: *` meant that all files were permissible under that license.

Re: [PR PATCH] [Updated] New package: msitools

[afranchuk]

[-- Attachment #1: Type: text/plain, Size: 1085 bytes --]

There is an updated pull request by afranchuk against master on the void-packages repository

https://github.com/afranchuk/void-packages msitools
https://github.com/void-linux/void-packages/pull/43321

New package: msitools
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc


A patch file from https://github.com/void-linux/void-packages/pull/43321.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-msitools-43321.patch --]
[-- Type: text/x-diff, Size: 1122 bytes --]

From 73f1040f2e6275fa23f94bd7d45ada0298de8b6b Mon Sep 17 00:00:00 2001
From: Alex Franchuk <afranchuk@mozilla.com>
Date: Fri, 7 Apr 2023 09:03:16 -0400
Subject: [PATCH] Add msitools package.

---
 srcpkgs/msitools/template | 12 ++++++++++++
 1 file changed, 12 insertions(+)
 create mode 100644 srcpkgs/msitools/template

diff --git a/srcpkgs/msitools/template b/srcpkgs/msitools/template
new file mode 100644
index 000000000000..22bfd94d863e
--- /dev/null
+++ b/srcpkgs/msitools/template
@@ -0,0 +1,12 @@
+# Template file for 'msitools'
+pkgname=msitools
+version=0.101
+revision=1
+short_desc="Programs to inspect and build Windows Installer (.MSI) files"
+maintainer="Alex Franchuk <alex.franchuk@gmail.com>"
+license="LGPL-2.1-or-later, GPL-2.0-or-later, GPL-3.0-or-later, MS-RL"
+homepage="https://wiki.gnome.org/msitools"
+build_style=meson
+hostmakedepends="bison gcab-devel glib-devel gobject-introspection libgsf-devel perl pkg-config vala"
+distfiles="https://download.gnome.org/sources/msitools/${version}/msitools-${version}.tar.xz"
+checksum="0cc4d2e0d108fa6f2b4085b9a97dd5bc6d9fcadecdd933f2094f86bafdbe85fe"

Re: [PR REVIEW] New package: msitools

[afranchuk]

[-- Attachment #1: Type: text/plain, Size: 252 bytes --]

New review comment by afranchuk on void-packages repository

https://github.com/void-linux/void-packages/pull/43321#discussion_r1160736828

Comment:
I've updated it. The `DISCLAIMED` copyright is omitted since it is explicitly releasing any copyright.

Re: [PR REVIEW] New package: msitools

[afranchuk]

[-- Attachment #1: Type: text/plain, Size: 348 bytes --]

New review comment by afranchuk on void-packages repository

https://github.com/void-linux/void-packages/pull/43321#discussion_r1160736828

Comment:
I've updated it. The `DISCLAIMED` copyright is omitted since it is explicitly releasing any copyright, though if that doesn't track with what is usually done we can distribute a copy of the license.

Re: New package: msitools

[afranchuk]

[-- Attachment #1: Type: text/plain, Size: 241 bytes --]

New comment by afranchuk on void-packages repository

https://github.com/void-linux/void-packages/pull/43321#issuecomment-1500337898

Comment:
I'm not exactly sure why the `do_check` is failing in CI; I cannot reproduce the failure locally.

Re: New package: msitools

[afranchuk]

[-- Attachment #1: Type: text/plain, Size: 391 bytes --]

New comment by afranchuk on void-packages repository

https://github.com/void-linux/void-packages/pull/43321#issuecomment-1500337898

Comment:
I'm not exactly sure why the `do_check` is failing in CI; I cannot reproduce the failure locally. Does the masterdir chroot effectively ignore my own installed packages when running checks? That's the first potential difference that comes to mind.

Re: [PR PATCH] [Updated] New package: msitools

[afranchuk]

[-- Attachment #1: Type: text/plain, Size: 1085 bytes --]

There is an updated pull request by afranchuk against master on the void-packages repository

https://github.com/afranchuk/void-packages msitools
https://github.com/void-linux/void-packages/pull/43321

New package: msitools
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc


A patch file from https://github.com/void-linux/void-packages/pull/43321.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-msitools-43321.patch --]
[-- Type: text/x-diff, Size: 1122 bytes --]

From c6b75e8008e127c1527858cb7357481ba887a20d Mon Sep 17 00:00:00 2001
From: Alex Franchuk <afranchuk@mozilla.com>
Date: Fri, 7 Apr 2023 09:03:16 -0400
Subject: [PATCH] Add msitools package.

---
 srcpkgs/msitools/template | 12 ++++++++++++
 1 file changed, 12 insertions(+)
 create mode 100644 srcpkgs/msitools/template

diff --git a/srcpkgs/msitools/template b/srcpkgs/msitools/template
new file mode 100644
index 000000000000..a7c8685b61e3
--- /dev/null
+++ b/srcpkgs/msitools/template
@@ -0,0 +1,12 @@
+# Template file for 'msitools'
+pkgname=msitools
+version=0.101
+revision=1
+build_style=meson
+hostmakedepends="bison gcab-devel glib-devel gobject-introspection libgsf-devel perl pkg-config vala"
+short_desc="Programs to inspect and build Windows Installer (.MSI) files"
+maintainer="Alex Franchuk <alex.franchuk@gmail.com>"
+license="LGPL-2.1-or-later, GPL-2.0-or-later, GPL-3.0-or-later, MS-RL"
+homepage="https://wiki.gnome.org/msitools"
+distfiles="https://download.gnome.org/sources/msitools/${version}/msitools-${version}.tar.xz"
+checksum="0cc4d2e0d108fa6f2b4085b9a97dd5bc6d9fcadecdd933f2094f86bafdbe85fe"

Re: New package: msitools

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/43321#issuecomment-1624538799

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

Re: New package: msitools

[afranchuk]

[-- Attachment #1: Type: text/plain, Size: 278 bytes --]

New comment by afranchuk on void-packages repository

https://github.com/void-linux/void-packages/pull/43321#issuecomment-1625529106

Comment:
If someone with more familiarity could figure out the CI issue I'd appreciate it. Otherwise this will have to be stale-closed I guess.

Re: New package: msitools

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/43321#issuecomment-1751552206

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

Re: [PR PATCH] [Closed]: New package: msitools

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 924 bytes --]

There's a closed pull request on the void-packages repository

New package: msitools
https://github.com/void-linux/void-packages/pull/43321

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc

[PR PATCH] New package: msitools

[afranchuk]

[-- Attachment #1: Type: text/plain, Size: 947 bytes --]

There is a new pull request by afranchuk against master on the void-packages repository

https://github.com/afranchuk/void-packages msitools
https://github.com/void-linux/void-packages/pull/49528

New package: msitools
Resubmitting since #43321 was closed and I needed the package on another machine!

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)

Note that I've added `python3-setuptools` as a host dependency, but really `gobject-instrospection` needs this! Otherwise it breaks with python 3.12 (due to the use of `distutils` which was removed).

A patch file from https://github.com/void-linux/void-packages/pull/49528.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-msitools-49528.patch --]
[-- Type: text/x-diff, Size: 2497 bytes --]

From c6b75e8008e127c1527858cb7357481ba887a20d Mon Sep 17 00:00:00 2001
From: Alex Franchuk <afranchuk@mozilla.com>
Date: Fri, 7 Apr 2023 09:03:16 -0400
Subject: [PATCH 1/2] Add msitools package.

---
 srcpkgs/msitools/template | 12 ++++++++++++
 1 file changed, 12 insertions(+)
 create mode 100644 srcpkgs/msitools/template

diff --git a/srcpkgs/msitools/template b/srcpkgs/msitools/template
new file mode 100644
index 00000000000000..a7c8685b61e304
--- /dev/null
+++ b/srcpkgs/msitools/template
@@ -0,0 +1,12 @@
+# Template file for 'msitools'
+pkgname=msitools
+version=0.101
+revision=1
+build_style=meson
+hostmakedepends="bison gcab-devel glib-devel gobject-introspection libgsf-devel perl pkg-config vala"
+short_desc="Programs to inspect and build Windows Installer (.MSI) files"
+maintainer="Alex Franchuk <alex.franchuk@gmail.com>"
+license="LGPL-2.1-or-later, GPL-2.0-or-later, GPL-3.0-or-later, MS-RL"
+homepage="https://wiki.gnome.org/msitools"
+distfiles="https://download.gnome.org/sources/msitools/${version}/msitools-${version}.tar.xz"
+checksum="0cc4d2e0d108fa6f2b4085b9a97dd5bc6d9fcadecdd933f2094f86bafdbe85fe"

From b041d972fb1ca1fea86b1cc0f3b6ce11821ed654 Mon Sep 17 00:00:00 2001
From: Alex Franchuk <afranchuk@mozilla.com>
Date: Mon, 25 Mar 2024 12:54:17 -0400
Subject: [PATCH 2/2] Update to 0.103.

Add python3-setuptools for compatibility with python 3.12.
---
 srcpkgs/msitools/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/msitools/template b/srcpkgs/msitools/template
index a7c8685b61e304..30ed38eb6b521d 100644
--- a/srcpkgs/msitools/template
+++ b/srcpkgs/msitools/template
@@ -1,12 +1,12 @@
 # Template file for 'msitools'
 pkgname=msitools
-version=0.101
+version=0.103
 revision=1
 build_style=meson
-hostmakedepends="bison gcab-devel glib-devel gobject-introspection libgsf-devel perl pkg-config vala"
+hostmakedepends="bison gcab-devel glib-devel gobject-introspection libgsf-devel perl pkg-config vala python3-setuptools"
 short_desc="Programs to inspect and build Windows Installer (.MSI) files"
 maintainer="Alex Franchuk <alex.franchuk@gmail.com>"
 license="LGPL-2.1-or-later, GPL-2.0-or-later, GPL-3.0-or-later, MS-RL"
 homepage="https://wiki.gnome.org/msitools"
 distfiles="https://download.gnome.org/sources/msitools/${version}/msitools-${version}.tar.xz"
-checksum="0cc4d2e0d108fa6f2b4085b9a97dd5bc6d9fcadecdd933f2094f86bafdbe85fe"
+checksum="d17622eebbf37fa4c09b59be0bc8db08b26be300a6731c74da1ebce262bce839"

Re: [PR PATCH] [Closed]: New package: msitools

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 791 bytes --]

There's a closed pull request on the void-packages repository

New package: msitools
https://github.com/void-linux/void-packages/pull/49528

Description:
Resubmitting since #43321 was closed and I needed the package on another machine!

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)

Note that I've added `python3-setuptools` as a host dependency, but really `gobject-instrospection` needs this! Otherwise it breaks with python 3.12 (due to the use of `distutils` which was removed).