[PR PATCH] mkinitcpio: update source, add zstd dependency

[PR PATCH] mkinitcpio: update source, add zstd dependency

[tranzystorekk]

[-- Attachment #1: Type: text/plain, Size: 1293 bytes --]

There is a new pull request by tranzystorekk against master on the void-packages repository

https://github.com/tranzystorekk/void-packages mkinitcpio
https://github.com/void-linux/void-packages/pull/47031

mkinitcpio: update source, add zstd dependency
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

cc @ahesford

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/47031.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-mkinitcpio-47031.patch --]
[-- Type: text/x-diff, Size: 1567 bytes --]

From 85bf714c4decdb7a405e1c07d1a9c21a4d097fb1 Mon Sep 17 00:00:00 2001
From: Marcin Puc <tranzystorek.io@protonmail.com>
Date: Thu, 2 Nov 2023 21:51:01 +0100
Subject: [PATCH] mkinitcpio: update source, add zstd dependency

---
 srcpkgs/mkinitcpio/template | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/srcpkgs/mkinitcpio/template b/srcpkgs/mkinitcpio/template
index 0271589ea115b..c0ff0c72b7104 100644
--- a/srcpkgs/mkinitcpio/template
+++ b/srcpkgs/mkinitcpio/template
@@ -1,17 +1,17 @@
 # Template file for 'mkinitcpio'
 pkgname=mkinitcpio
 version=36
-revision=2
+revision=3
 build_style=gnu-makefile
 hostmakedepends="asciidoc"
-depends="busybox-static bsdtar bash"
+depends="busybox-static bsdtar bash zstd"
 checkdepends="busybox-static bats-assert lz4 xz zstd"
 short_desc="Next generation of initramfs creation"
 maintainer="Andrew J. Hesford <ajh@sideband.org>"
 license="GPL-2.0-only"
-homepage="https://git.archlinux.org/mkinitcpio.git"
-distfiles="https://sources.archlinux.org/other/${pkgname}/${pkgname}-${version}.tar.gz"
-checksum=7b3b1cdf546922f47845a3ac4353ca97899a4bb68cfff29098c45135e5fb8b5e
+homepage="https://gitlab.archlinux.org/archlinux/mkinitcpio/mkinitcpio"
+distfiles="https://gitlab.archlinux.org/archlinux/mkinitcpio/mkinitcpio/-/archive/v${version}/mkinitcpio-v${version}.tar.gz"
+checksum=21e6983c6f2bd3637c966a5435e538e70cfd8c38a2826ca6fa74984aff14ba62
 conf_files="/etc/mkinitcpio.conf"
 alternatives="
  initramfs:/etc/kernel.d/post-install/20-initramfs:/usr/libexec/mkinitcpio/kernel-hook-postinst

Re: mkinitcpio: update source, add zstd dependency

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 203 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/47031#issuecomment-1791639253

Comment:
new version is coming pretty soon, is this super urgent?

Re: mkinitcpio: update source, add zstd dependency

[tranzystorekk]

[-- Attachment #1: Type: text/plain, Size: 231 bytes --]

New comment by tranzystorekk on void-packages repository

https://github.com/void-linux/void-packages/pull/47031#issuecomment-1791641044

Comment:
@classabbyamp not really, i can close, just gotta remember to include these changes

Re: mkinitcpio: update source, add zstd dependency

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 554 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/47031#issuecomment-1791658743

Comment:
`zstd` is optional because not all kernels we ship use zstd-compressed modules and, even for those that do, the errors printed when `mkinitcpio` tries to decompress the modules by default (which can be disabled) don't prevent the original, compressed modules from being included.

Nevertheless, if the errors are alarming to users and the solution (installing `zstd`) isn't obvious, we can add the dependency.

Re: mkinitcpio: update source, add zstd dependency

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 507 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/47031#issuecomment-1816742101

Comment:
I pushed the update to v37 and included the `homepage` change. Using the Gitlab archive in `distfiles` breaks the version number recorded in `/usr/bin/mkinitcpio`, so I reverted to `sources.archlinux.org` for a tarball that contains proper version information.

I'm still on the fence about `zstd` and didn't include that in the `depends` with the latest update.

Re: mkinitcpio: update source, add zstd dependency

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 469 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/47031#issuecomment-1816757246

Comment:
It turns out that Arch considers `zstd` a hard requirement even as they use the `optdepends` mechanism for other compressors: https://gitlab.archlinux.org/archlinux/packaging/packages/mkinitcpio/-/blob/main/PKGBUILD

That makes a convincing enough argument that we should just pull it in, so we can merge this if you rebase.

Re: [PR PATCH] [Updated] mkinitcpio: update source, add zstd dependency

[tranzystorekk]

[-- Attachment #1: Type: text/plain, Size: 1298 bytes --]

There is an updated pull request by tranzystorekk against master on the void-packages repository

https://github.com/tranzystorekk/void-packages mkinitcpio
https://github.com/void-linux/void-packages/pull/47031

mkinitcpio: update source, add zstd dependency
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

cc @ahesford

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/47031.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-mkinitcpio-47031.patch --]
[-- Type: text/x-diff, Size: 888 bytes --]

From 436448310c6d08b75e26e7d318ea0fff42b66b15 Mon Sep 17 00:00:00 2001
From: Marcin Puc <tranzystorek.io@protonmail.com>
Date: Sat, 18 Nov 2023 11:05:48 +0100
Subject: [PATCH] mkinitcpio: add zstd dependency

---
 srcpkgs/mkinitcpio/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/mkinitcpio/template b/srcpkgs/mkinitcpio/template
index 48a8adab7513c..ed2290b37601c 100644
--- a/srcpkgs/mkinitcpio/template
+++ b/srcpkgs/mkinitcpio/template
@@ -1,10 +1,10 @@
 # Template file for 'mkinitcpio'
 pkgname=mkinitcpio
 version=37
-revision=2
+revision=3
 build_style=gnu-makefile
 hostmakedepends="asciidoc"
-depends="busybox-static bsdtar bash"
+depends="busybox-static bsdtar bash zstd"
 checkdepends="busybox-static bats-assert lz4 xz zstd lzop"
 short_desc="Next generation of initramfs creation"
 maintainer="Andrew J. Hesford <ajh@sideband.org>"

Re: [PR PATCH] [Merged]: mkinitcpio: add zstd dependency

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 1112 bytes --]

There's a merged pull request on the void-packages repository

mkinitcpio: add zstd dependency
https://github.com/void-linux/void-packages/pull/47031

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

cc @ahesford

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->