Github messages for voidlinux
 help / color / mirror / Atom feed
From: juipeltje <juipeltje@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: Request Review of `Liquidctl` Package Template and Guidance on Maintaining it
Date: Thu, 16 Nov 2023 22:04:03 +0100	[thread overview]
Message-ID: <20231116210403.HnEI6BgWcoXFPS-O3PmzZdJ_4TAAXgBq72gSAPrV7tw@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-24123@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 2507 bytes --]

New comment by juipeltje on void-packages repository

https://github.com/void-linux/void-packages/issues/24123#issuecomment-1815307417

Comment:
i'm not sure if i should make a new issue or necrobump this one, but i came across this when i was looking to see if someone had already made a template file for liquidctl, and i decided to update the one in this post to practice making templates.

```
# Template file for 'liquidctl'
pkgname=liquidctl
version=1.13.0
revision=1
build_style=python3-pep517
hostmakedepends="python3-setuptools python3-setuptools_scm python3-wheel"
depends="python3-setuptools python3-usb python3-crcmod python3-hid python3-docopt python3-Pillow python3-smbus python3-colorlog libusb"
short_desc="Monitor and control liquid coolers and other devices"
maintainer="juipeltje <joppe4444@outlook.com>"
license="GPL-3.0-or-later"
homepage="https://github.com/jonasmalacofilho/liquidctl"
distfiles="https://github.com/liquidctl/liquidctl/releases/download/v1.13.0/liquidctl-1.13.0.tar.gz"
checksum="ee17241689c0bf3de43cf4d97822e344f5b57513d16dd160e37fa0e389a158c7"

pre_build() {
    # upstream encourages the use of these env vars, at setup.py build time, to
    # customize the output of liquidctl --version
    export DIST_NAME="Void Linux"
    export DIST_PACKAGE="$pkgname $version-$revision"
}

post_install() {
	vman liquidctl.8
	for f in docs/*.md; do
		vdoc "$f"
	done
}
```
liquidctl also requires python3-colorlog to be installed though, which is not in the void repos, so i made a template file for that as well:
```
# Template file for 'python3-colorlog'
pkgname=python3-colorlog
version=6.7.0
revision=1
build_style=python3-module
hostmakedepends="python3-setuptools"
short_desc="Add colours to the output of Python's logging module"
maintainer="juipeltje <joppe4444@outlook.com>"
license="MIT"
homepage="https://pypi.org/project/colorlog/#description"
distfiles="https://files.pythonhosted.org/packages/78/6b/4e5481ddcdb9c255b2715f54c863629f1543e97bc8c309d1c5c131ad14f2/colorlog-6.7.0.tar.gz"
checksum="bd94bd21c1e13fac7bd3153f4bc3a7dc0eb0974b8bc2fdf1a989e474f6e582e5"
```
i'm still a noob when it comes to making templates, so i'm not sure if there's anything else that should be added to the template for the sake of completeness, but they do install succesfully and i got liquidctl running with these. i think the distfiles url in python3-colorlog could be shortened with the pypi site variable, but i'm not entirely sure.

      parent reply	other threads:[~2023-11-16 21:04 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-07  2:26 [ISSUE] " Frick-David
2020-08-07  2:40 ` ericonr
2020-08-07  2:40 ` ericonr
2020-08-07 11:24 ` sgn
2020-08-07 11:25 ` sgn
2020-08-07 11:32 ` sgn
2020-12-03  2:08 ` Frick-David
2020-12-03  2:09 ` Frick-David
2020-12-03  2:58 ` ericonr
2020-12-03 15:51 ` Frick-David
2020-12-03 16:53 ` jonasmalacofilho
2020-12-04  0:14 ` jonasmalacofilho
2020-12-04 21:09 ` Frick-David
2022-04-18  2:11 ` github-actions
2022-05-02  2:15 ` [ISSUE] [CLOSED] " github-actions
2023-10-10 16:04 ` cat-marin
2023-11-16 21:01 ` juipeltje
2023-11-16 21:04 ` juipeltje [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231116210403.HnEI6BgWcoXFPS-O3PmzZdJ_4TAAXgBq72gSAPrV7tw@z \
    --to=juipeltje@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).