Github messages for voidlinux
 help / color / mirror / Atom feed
From: Frick-David <Frick-David@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: [ISSUE] Request Review of `Liquidctl` Package Template and Guidance on Maintaining it
Date: Fri, 07 Aug 2020 04:26:24 +0200	[thread overview]
Message-ID: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-24123@inbox.vuxu.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 2146 bytes --]

New issue by Frick-David on void-packages repository

https://github.com/void-linux/void-packages/issues/24123

Description:
Hey there voiders,

I am working with the creator of `liquidctl` to get it into a void linux package. The creator provided a template file for me to submit to help get it started. I hope to help maintain and get it going.

The template we have is as follows:
```
# Template file for 'liquidctl'
pkgname=liquidctl
version=1.3.3
revision=1
archs=noarch
build_style=python3-module
hostmakedepends="python3-setuptools"
depends="python3-setuptools python3-usb libusb python3-hidapi python3-docopt"
short_desc="Monitor and control liquid coolers and other devices"
maintainer="David Frick <name@domain>"
license="GPL-3.0-or-later"
homepage="https://github.com/jonasmalacofilho/liquidctl"
distfile="${PYPI_SITE}/l/liquidctl/liquidctl-${version}.tar.gz"
checksum=d13180867e07420c5890fe1110e8f45fe343794549a9ed7d5e8e76663bc10c24

pre_build() {
    # upstream encourages the use of these env vars, at setup.py build time, to
    # customize the output of liquidctl --version
    export DIST_NAME="$(source /etc/os-release && echo "$PRETTY_NAME")"
    export DIST_PACKAGE="$pkgname $version-$revision"
}

post_install() {
	vman liquidctl.8
	for f in docs/*.md; do
		vdoc "$f"
	done
}

# liquidctl can be used as a CLI or as a Python module, but unsure on how to
# split the packages, especially because the CLI is a setuptools script:
# setup.py will generate the actual executable, a Python script that simply
# calls liquidctl.cli.main
python3-liquidctl_package() {
	depends="liquidctl>=${version}_${revision}"
	build_style=meta
	short_desc+=" (transitional dummy package)"
}

# TODO package trezor/cython-hidapi as python3-hidapi
# QUESTION shouldn't python3-usb depend on libusb or another backend?
# QUESTION does Void populate os-release $PRETTY_NAME with something useful?
# QUESTION how should the split be handled?
```

Can I have someone help me review this, finialize it then help me set it up to wear I can maintain it?
That would be much appreciated.

Best,
David

             reply	other threads:[~2020-08-07  2:26 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-07  2:26 Frick-David [this message]
2020-08-07  2:40 ` ericonr
2020-08-07  2:40 ` ericonr
2020-08-07 11:24 ` sgn
2020-08-07 11:25 ` sgn
2020-08-07 11:32 ` sgn
2020-12-03  2:08 ` Frick-David
2020-12-03  2:09 ` Frick-David
2020-12-03  2:58 ` ericonr
2020-12-03 15:51 ` Frick-David
2020-12-03 16:53 ` jonasmalacofilho
2020-12-04  0:14 ` jonasmalacofilho
2020-12-04 21:09 ` Frick-David
2022-04-18  2:11 ` github-actions
2022-05-02  2:15 ` [ISSUE] [CLOSED] " github-actions
2023-10-10 16:04 ` cat-marin
2023-11-16 21:01 ` juipeltje
2023-11-16 21:04 ` juipeltje

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-24123@inbox.vuxu.org \
    --to=frick-david@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).