[PR PATCH] tuimoji: fix test

[PR PATCH] tuimoji: fix test

[Luciogi]

[-- Attachment #1: Type: text/plain, Size: 471 bytes --]

There is a new pull request by Luciogi against master on the void-packages repository

https://github.com/Luciogi/void-packages tuimoji
https://github.com/void-linux/void-packages/pull/46810

tuimoji: fix test

#### Testing the changes
- I tested the changes in this PR: **YES**
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glib)



A patch file from https://github.com/void-linux/void-packages/pull/46810.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-tuimoji-46810.patch --]
[-- Type: text/x-diff, Size: 868 bytes --]

From 047da4f571fd06f2d0cf01b77eba4cf3f05a226e Mon Sep 17 00:00:00 2001
From: Luciogi <lucigithubcommit@skiff.com>
Date: Sat, 21 Oct 2023 11:33:28 +0500
Subject: [PATCH] tuimoji: fix test

---
 srcpkgs/tuimoji/template | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/tuimoji/template b/srcpkgs/tuimoji/template
index c5421ecdaada1..757cecc2bd497 100644
--- a/srcpkgs/tuimoji/template
+++ b/srcpkgs/tuimoji/template
@@ -1,11 +1,12 @@
 # Template file for 'tuimoji'
 pkgname=tuimoji
 version=1.0.0
-revision=7
+revision=8
 build_style=python3-module
-pycompile_module="tuimoji"
+#pycompile_module="tuimoji"
 hostmakedepends="python3-setuptools"
 depends="python3-urwid xclip python3-setuptools"
+checkdepends="python3-pip"
 short_desc="Terminal based emoji chooser"
 maintainer="travankor <travankor@tuta.io>"
 license="GPL-3.0-or-later"

Re: [PR REVIEW] tuimoji: fix test

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 335 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/46810#discussion_r1367681165

Comment:
this is probably wrong, something saying "module pip not found" generally means something else wasn't found and needs to be added, so it was trying and failing to install it with pip

Re: [PR REVIEW] tuimoji: fix test

[Luciogi]

[-- Attachment #1: Type: text/plain, Size: 1432 bytes --]

New review comment by Luciogi on void-packages repository

https://github.com/void-linux/void-packages/pull/46810#discussion_r1367682412

Comment:
```
=> tuimoji-1.0.0_8: running do_check ...
running test
WARNING: Testing via this command is deprecated and will be removed in a future version. Users looking for a generic test entry point independent of test runner are encouraged to use tox.
/usr/lib/python3.12/site-packages/setuptools/command/test.py:193: _DeprecatedInstaller: setuptools.installer and fetch_build_eggs are deprecated.
!!

        ********************************************************************************
        Requirements should be satisfied by a PEP 517 installer.
        If you are using pip, you can try `pip install --use-pep517`.
        ********************************************************************************

!!
  ir_d = dist.fetch_build_eggs(dist.install_requires)
/usr/bin/python3: No module named pip
error: Command '['/usr/bin/python3', '-m', 'pip', '--disable-pip-version-check', 'wheel', '--no-deps', '-w', '/tmp/tmpqi9nfp5u', '--quiet', 'urwid']' returned non-zero exit status 1.
=> ERROR: tuimoji-1.0.0_8: do_check: '${make_check_pre} python3 setup.py ${make_check_target} ${make_check_args}' exited with 1
=> ERROR:   in do_check() at common/build-style/python3-module.sh:28

```
it want to install `wheel` using pip, while `checkdepends="python3-wheel'`

Re: [PR REVIEW] tuimoji: fix test

[Luciogi]

[-- Attachment #1: Type: text/plain, Size: 199 bytes --]

New review comment by Luciogi on void-packages repository

https://github.com/void-linux/void-packages/pull/46810#discussion_r1367682901

Comment:
I realized that this project does not have any test

Re: [PR REVIEW] tuimoji: fix test

[Luciogi]

[-- Attachment #1: Type: text/plain, Size: 171 bytes --]

New review comment by Luciogi on void-packages repository

https://github.com/void-linux/void-packages/pull/46810#discussion_r1367683436

Comment:
ok i figured out thanks

Re: [PR PATCH] [Updated] tuimoji: fix test

[Luciogi]

[-- Attachment #1: Type: text/plain, Size: 476 bytes --]

There is an updated pull request by Luciogi against master on the void-packages repository

https://github.com/Luciogi/void-packages tuimoji
https://github.com/void-linux/void-packages/pull/46810

tuimoji: fix test

#### Testing the changes
- I tested the changes in this PR: **YES**
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glib)



A patch file from https://github.com/void-linux/void-packages/pull/46810.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-tuimoji-46810.patch --]
[-- Type: text/x-diff, Size: 884 bytes --]

From d623cdb9a01887f5c5bac36cd97e00e48cd3f3d2 Mon Sep 17 00:00:00 2001
From: Luciogi <lucigithubcommit@skiff.com>
Date: Sat, 21 Oct 2023 11:33:28 +0500
Subject: [PATCH] tuimoji: fix test

---
 srcpkgs/tuimoji/template | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/tuimoji/template b/srcpkgs/tuimoji/template
index c5421ecdaada1..8c485455e0dfe 100644
--- a/srcpkgs/tuimoji/template
+++ b/srcpkgs/tuimoji/template
@@ -1,11 +1,12 @@
 # Template file for 'tuimoji'
 pkgname=tuimoji
 version=1.0.0
-revision=7
+revision=8
 build_style=python3-module
-pycompile_module="tuimoji"
+#pycompile_module="tuimoji"
 hostmakedepends="python3-setuptools"
 depends="python3-urwid xclip python3-setuptools"
+checkdepends="python3-wheel python3-urwid"
 short_desc="Terminal based emoji chooser"
 maintainer="travankor <travankor@tuta.io>"
 license="GPL-3.0-or-later"

Re: [PR REVIEW] tuimoji: fix test

[Luciogi]

[-- Attachment #1: Type: text/plain, Size: 276 bytes --]

New review comment by Luciogi on void-packages repository

https://github.com/void-linux/void-packages/pull/46810#discussion_r1367684465

Comment:
Just a question: test passes without `python3-wheel` leave a warning of missing `wheel`
so should I be added in `checkdepends=`

Re: [PR PATCH] [Updated] tuimoji: fix test

[Luciogi]

[-- Attachment #1: Type: text/plain, Size: 476 bytes --]

There is an updated pull request by Luciogi against master on the void-packages repository

https://github.com/Luciogi/void-packages tuimoji
https://github.com/void-linux/void-packages/pull/46810

tuimoji: fix test

#### Testing the changes
- I tested the changes in this PR: **YES**
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glib)



A patch file from https://github.com/void-linux/void-packages/pull/46810.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-tuimoji-46810.patch --]
[-- Type: text/x-diff, Size: 836 bytes --]

From bbc95f58f0d77848f1d2aee262102e3a8f3d2aca Mon Sep 17 00:00:00 2001
From: Luciogi <lucigithubcommit@skiff.com>
Date: Sat, 21 Oct 2023 11:33:28 +0500
Subject: [PATCH] tuimoji: fix test

---
 srcpkgs/tuimoji/template | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/tuimoji/template b/srcpkgs/tuimoji/template
index c5421ecdaada1..5806acadc85a1 100644
--- a/srcpkgs/tuimoji/template
+++ b/srcpkgs/tuimoji/template
@@ -3,9 +3,10 @@ pkgname=tuimoji
 version=1.0.0
 revision=7
 build_style=python3-module
-pycompile_module="tuimoji"
+#pycompile_module="tuimoji"
 hostmakedepends="python3-setuptools"
 depends="python3-urwid xclip python3-setuptools"
+checkdepends="python3-wheel python3-urwid"
 short_desc="Terminal based emoji chooser"
 maintainer="travankor <travankor@tuta.io>"
 license="GPL-3.0-or-later"

Re: [PR REVIEW] tuimoji: fix test

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 245 bytes --]

New review comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/46810#discussion_r1405403869

Comment:
Don't leave template directives commented out. Remove the directive if it is no longer relevant.

Re: [PR PATCH] [Updated] tuimoji: fix test

[Luciogi]

[-- Attachment #1: Type: text/plain, Size: 476 bytes --]

There is an updated pull request by Luciogi against master on the void-packages repository

https://github.com/Luciogi/void-packages tuimoji
https://github.com/void-linux/void-packages/pull/46810

tuimoji: fix test

#### Testing the changes
- I tested the changes in this PR: **YES**
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glib)



A patch file from https://github.com/void-linux/void-packages/pull/46810.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-tuimoji-46810.patch --]
[-- Type: text/x-diff, Size: 804 bytes --]

From 3f9bece18ecff82bb915aae761f1517eb4db1baa Mon Sep 17 00:00:00 2001
From: Luciogi <lucigithubcommit@skiff.com>
Date: Sat, 21 Oct 2023 11:33:28 +0500
Subject: [PATCH] tuimoji: fix test

---
 srcpkgs/tuimoji/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/tuimoji/template b/srcpkgs/tuimoji/template
index c5421ecdaada1..aba2a527dc000 100644
--- a/srcpkgs/tuimoji/template
+++ b/srcpkgs/tuimoji/template
@@ -3,9 +3,9 @@ pkgname=tuimoji
 version=1.0.0
 revision=7
 build_style=python3-module
-pycompile_module="tuimoji"
 hostmakedepends="python3-setuptools"
 depends="python3-urwid xclip python3-setuptools"
+checkdepends="python3-wheel python3-urwid"
 short_desc="Terminal based emoji chooser"
 maintainer="travankor <travankor@tuta.io>"
 license="GPL-3.0-or-later"

Re: [PR REVIEW] tuimoji: fix test

[Luciogi]

[-- Attachment #1: Type: text/plain, Size: 153 bytes --]

New review comment by Luciogi on void-packages repository

https://github.com/void-linux/void-packages/pull/46810#discussion_r1405407695

Comment:
done 

Re: tuimoji: fix test

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 284 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/46810#issuecomment-1826802523

Comment:
This isn't actually running tests.

https://github.com/void-linux/void-packages/actions/runs/6996075093/job/19031580372?pr=46810#step:7:125

Re: tuimoji: fix test

[Luciogi]

[-- Attachment #1: Type: text/plain, Size: 322 bytes --]

New comment by Luciogi on void-packages repository

https://github.com/void-linux/void-packages/pull/46810#issuecomment-1826803430

Comment:
> This isn't actually running tests.
> 
> https://github.com/void-linux/void-packages/actions/runs/6996075093/job/19031580372?pr=46810#step:7:125

actually tests does not exist

Re: tuimoji: fix test

[Luciogi]

[-- Attachment #1: Type: text/plain, Size: 358 bytes --]

New comment by Luciogi on void-packages repository

https://github.com/void-linux/void-packages/pull/46810#issuecomment-1826803430

Comment:
> This isn't actually running tests.
> 
> https://github.com/void-linux/void-packages/actions/runs/6996075093/job/19031580372?pr=46810#step:7:125

actually tests does not exist (https://github.com/Fingel/tuimoji)

Re: tuimoji: fix test

[Luciogi]

[-- Attachment #1: Type: text/plain, Size: 396 bytes --]

New comment by Luciogi on void-packages repository

https://github.com/void-linux/void-packages/pull/46810#issuecomment-1826803430

Comment:
> This isn't actually running tests.
> 
> https://github.com/void-linux/void-packages/actions/runs/6996075093/job/19031580372?pr=46810#step:7:125

actually tests does not exist (https://github.com/Fingel/tuimoji)

Is it fine to use `make_check=no`?

Re: tuimoji: fix test

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 458 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/46810#issuecomment-1826812049

Comment:
> > This isn't actually running tests.
> > https://github.com/void-linux/void-packages/actions/runs/6996075093/job/19031580372?pr=46810#step:7:125
> 
> actually tests does not exist (https://github.com/Fingel/tuimoji)
> 
> Is it fine to use `make_check=no`?

Yes, remove the `checkdepends` and disable tests.

Re: [PR PATCH] [Updated] tuimoji: fix test

[Luciogi]

[-- Attachment #1: Type: text/plain, Size: 476 bytes --]

There is an updated pull request by Luciogi against master on the void-packages repository

https://github.com/Luciogi/void-packages tuimoji
https://github.com/void-linux/void-packages/pull/46810

tuimoji: fix test

#### Testing the changes
- I tested the changes in this PR: **YES**
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glib)



A patch file from https://github.com/void-linux/void-packages/pull/46810.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-tuimoji-46810.patch --]
[-- Type: text/x-diff, Size: 960 bytes --]

From 5de6fb0c7541b8f2cc9e68fea7177cf1ee9a3f5d Mon Sep 17 00:00:00 2001
From: Luciogi <lucigithubcommit@skiff.com>
Date: Sat, 21 Oct 2023 11:33:28 +0500
Subject: [PATCH] tuimoji: fix test

---
 srcpkgs/tuimoji/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/tuimoji/template b/srcpkgs/tuimoji/template
index c5421ecdaada1..590a68baeb7d2 100644
--- a/srcpkgs/tuimoji/template
+++ b/srcpkgs/tuimoji/template
@@ -3,7 +3,6 @@ pkgname=tuimoji
 version=1.0.0
 revision=7
 build_style=python3-module
-pycompile_module="tuimoji"
 hostmakedepends="python3-setuptools"
 depends="python3-urwid xclip python3-setuptools"
 short_desc="Terminal based emoji chooser"
@@ -12,3 +11,4 @@ license="GPL-3.0-or-later"
 homepage="https://github.com/Fingel/tuimoji"
 distfiles="https://github.com/Fingel/tuimoji/archive/v${version}.tar.gz"
 checksum=1c20f19a8a96dcc450ae7fef0815203da0a59106263b756b07cb4b984cfc6d1b
+make_check=no # no test to run

Re: [PR PATCH] [Updated] tuimoji: fix test

[Luciogi]

[-- Attachment #1: Type: text/plain, Size: 476 bytes --]

There is an updated pull request by Luciogi against master on the void-packages repository

https://github.com/Luciogi/void-packages tuimoji
https://github.com/void-linux/void-packages/pull/46810

tuimoji: fix test

#### Testing the changes
- I tested the changes in this PR: **YES**
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glib)



A patch file from https://github.com/void-linux/void-packages/pull/46810.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-tuimoji-46810.patch --]
[-- Type: text/x-diff, Size: 965 bytes --]

From e37f624e19ac87b972a1c806a75a7fa0f158f0b8 Mon Sep 17 00:00:00 2001
From: Luciogi <lucigithubcommit@skiff.com>
Date: Sat, 21 Oct 2023 11:33:28 +0500
Subject: [PATCH] tuimoji: disable tests

---
 srcpkgs/tuimoji/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/tuimoji/template b/srcpkgs/tuimoji/template
index c5421ecdaada1..590a68baeb7d2 100644
--- a/srcpkgs/tuimoji/template
+++ b/srcpkgs/tuimoji/template
@@ -3,7 +3,6 @@ pkgname=tuimoji
 version=1.0.0
 revision=7
 build_style=python3-module
-pycompile_module="tuimoji"
 hostmakedepends="python3-setuptools"
 depends="python3-urwid xclip python3-setuptools"
 short_desc="Terminal based emoji chooser"
@@ -12,3 +11,4 @@ license="GPL-3.0-or-later"
 homepage="https://github.com/Fingel/tuimoji"
 distfiles="https://github.com/Fingel/tuimoji/archive/v${version}.tar.gz"
 checksum=1c20f19a8a96dcc450ae7fef0815203da0a59106263b756b07cb4b984cfc6d1b
+make_check=no # no test to run

Re: tuimoji: disable test

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/46810#issuecomment-1963177250

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

Re: [PR PATCH] [Closed]: tuimoji: disable test

[Luciogi]

[-- Attachment #1: Type: text/plain, Size: 324 bytes --]

There's a closed pull request on the void-packages repository

tuimoji: disable test
https://github.com/void-linux/void-packages/pull/46810

Description:

#### Testing the changes
- I tested the changes in this PR: **YES**
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glib)