* Re: [PR PATCH] [Updated] New package: grub2-theme-preview-2.8.0
2023-05-10 13:42 [PR PATCH] New package: grub2-theme-preview-2.8.0 Animeshz
@ 2023-05-10 20:23 ` Animeshz
2023-05-10 20:42 ` Animeshz
` (13 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: Animeshz @ 2023-05-10 20:23 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 755 bytes --]
There is an updated pull request by Animeshz against master on the void-packages repository
https://github.com/Animeshz/void-packages tp/grub2-theme-preview
https://github.com/void-linux/void-packages/pull/43830
New package: grub2-theme-preview-2.8.0
#### Testing the changes
- I tested the changes in this PR: **YES**
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**
#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
CC: https://github.com/hartwork/grub2-theme-preview/pull/172
A patch file from https://github.com/void-linux/void-packages/pull/43830.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-tp/grub2-theme-preview-43830.patch --]
[-- Type: text/x-diff, Size: 1236 bytes --]
From b60239b3e60488343c9b940c4c12ce7488ae5c12 Mon Sep 17 00:00:00 2001
From: Animesh Sahu <animeshsahu19@yahoo.com>
Date: Wed, 10 May 2023 19:09:44 +0530
Subject: [PATCH] New package: grub2-theme-preview-2.8.0
---
srcpkgs/grub2-theme-preview/template | 15 +++++++++++++++
1 file changed, 15 insertions(+)
create mode 100644 srcpkgs/grub2-theme-preview/template
diff --git a/srcpkgs/grub2-theme-preview/template b/srcpkgs/grub2-theme-preview/template
new file mode 100644
index 000000000000..bff8f602db03
--- /dev/null
+++ b/srcpkgs/grub2-theme-preview/template
@@ -0,0 +1,15 @@
+# Template file for 'grub2-theme-preview'
+pkgname=grub2-theme-preview
+version=2.8.0
+revision=1
+archs="x86_64 x86_64-musl i386 i386-musl"
+build_style=python3-module
+hostmakedepends="python3-setuptools"
+depends="grub grub-${XBPS_TARGET_MACHINE}-efi mtools qemu xorriso"
+checkdepends="${depends} python3-parameterized"
+short_desc="Preview a full GRUB 2.x theme using KVM / QEMU"
+maintainer="Animesh Sahu <animeshsahu19@yahoo.com>"
+license="GPL-2.0-or-later"
+homepage="https://github.com/hartwork/grub2-theme-preview"
+distfiles="${homepage}/archive/${version}.tar.gz"
+checksum=f96dda1dce58b3336ccae7697640490941bcfcce567352c7f4f5a8f4d2b193df
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PR PATCH] [Updated] New package: grub2-theme-preview-2.8.0
2023-05-10 13:42 [PR PATCH] New package: grub2-theme-preview-2.8.0 Animeshz
2023-05-10 20:23 ` [PR PATCH] [Updated] " Animeshz
@ 2023-05-10 20:42 ` Animeshz
2023-05-11 4:00 ` [PR REVIEW] " classabbyamp
` (12 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: Animeshz @ 2023-05-10 20:42 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 755 bytes --]
There is an updated pull request by Animeshz against master on the void-packages repository
https://github.com/Animeshz/void-packages tp/grub2-theme-preview
https://github.com/void-linux/void-packages/pull/43830
New package: grub2-theme-preview-2.8.0
#### Testing the changes
- I tested the changes in this PR: **YES**
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**
#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
CC: https://github.com/hartwork/grub2-theme-preview/pull/172
A patch file from https://github.com/void-linux/void-packages/pull/43830.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-tp/grub2-theme-preview-43830.patch --]
[-- Type: text/x-diff, Size: 1425 bytes --]
From 59391eb44159408048f3a165bc76c899ac8d8a9e Mon Sep 17 00:00:00 2001
From: Animesh Sahu <animeshsahu19@yahoo.com>
Date: Wed, 10 May 2023 19:09:44 +0530
Subject: [PATCH] New package: grub2-theme-preview-2.8.0
---
srcpkgs/grub2-theme-preview/template | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)
create mode 100644 srcpkgs/grub2-theme-preview/template
diff --git a/srcpkgs/grub2-theme-preview/template b/srcpkgs/grub2-theme-preview/template
new file mode 100644
index 000000000000..90e8a3354e92
--- /dev/null
+++ b/srcpkgs/grub2-theme-preview/template
@@ -0,0 +1,21 @@
+# Template file for 'grub2-theme-preview'
+pkgname=grub2-theme-preview
+version=2.8.0
+revision=1
+archs="x86_64 x86_64-musl i386 i386-musl"
+build_style=python3-module
+hostmakedepends="python3-setuptools"
+depends="grub mtools qemu xorriso"
+checkdepends="${depends} python3-parameterized"
+short_desc="Preview a full GRUB 2.x theme using KVM / QEMU"
+maintainer="Animesh Sahu <animeshsahu19@yahoo.com>"
+license="GPL-2.0-or-later"
+homepage="https://github.com/hartwork/grub2-theme-preview"
+distfiles="${homepage}/archive/${version}.tar.gz"
+checksum=f96dda1dce58b3336ccae7697640490941bcfcce567352c7f4f5a8f4d2b193df
+
+case $XBPS_TARGET_MACHINE in
+ x86_64*) depends+=" grub-x86_64-efi"; checkdepends+=" grub-x86_64-efi" ;;
+ i686*) depends+=" grub-i386-efi"; checkdepends+=" grub-i386-efi" ;;
+ *) broken="not supported" ;;
+esac
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PR REVIEW] New package: grub2-theme-preview-2.8.0
2023-05-10 13:42 [PR PATCH] New package: grub2-theme-preview-2.8.0 Animeshz
2023-05-10 20:23 ` [PR PATCH] [Updated] " Animeshz
2023-05-10 20:42 ` Animeshz
@ 2023-05-11 4:00 ` classabbyamp
2023-05-11 4:00 ` classabbyamp
` (11 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: classabbyamp @ 2023-05-11 4:00 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 220 bytes --]
New review comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/43830#discussion_r1190610838
Comment:
don't think you need grub here as it's a dependency of `grub-*-efi`
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PR REVIEW] New package: grub2-theme-preview-2.8.0
2023-05-10 13:42 [PR PATCH] New package: grub2-theme-preview-2.8.0 Animeshz
` (2 preceding siblings ...)
2023-05-11 4:00 ` [PR REVIEW] " classabbyamp
@ 2023-05-11 4:00 ` classabbyamp
2023-05-11 4:00 ` classabbyamp
` (10 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: classabbyamp @ 2023-05-11 4:00 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 177 bytes --]
New review comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/43830#discussion_r1190609729
Comment:
don't use $homepage here
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PR REVIEW] New package: grub2-theme-preview-2.8.0
2023-05-10 13:42 [PR PATCH] New package: grub2-theme-preview-2.8.0 Animeshz
` (3 preceding siblings ...)
2023-05-11 4:00 ` classabbyamp
@ 2023-05-11 4:00 ` classabbyamp
2023-05-11 4:00 ` classabbyamp
` (9 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: classabbyamp @ 2023-05-11 4:00 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 250 bytes --]
New review comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/43830#discussion_r1190609663
Comment:
i386 is not an arch on void, also, use `x86_64*` etc instead of explicitly both musl and non-musl
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PR REVIEW] New package: grub2-theme-preview-2.8.0
2023-05-10 13:42 [PR PATCH] New package: grub2-theme-preview-2.8.0 Animeshz
` (4 preceding siblings ...)
2023-05-11 4:00 ` classabbyamp
@ 2023-05-11 4:00 ` classabbyamp
2023-05-11 4:04 ` Animeshz
` (8 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: classabbyamp @ 2023-05-11 4:00 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 201 bytes --]
New review comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/43830#discussion_r1190610646
Comment:
not necessary, this is already implied by archs=
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PR REVIEW] New package: grub2-theme-preview-2.8.0
2023-05-10 13:42 [PR PATCH] New package: grub2-theme-preview-2.8.0 Animeshz
` (5 preceding siblings ...)
2023-05-11 4:00 ` classabbyamp
@ 2023-05-11 4:04 ` Animeshz
2023-05-11 4:05 ` Animeshz
` (7 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: Animeshz @ 2023-05-11 4:04 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 360 bytes --]
New review comment by Animeshz on void-packages repository
https://github.com/void-linux/void-packages/pull/43830#discussion_r1190612339
Comment:
A valid grub-efi implementation is required for both runtime to work as well as tests to pass. I don't think there's an easy way to embed this in `depends=` at the metadata declaration itself. What do you think?
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PR REVIEW] New package: grub2-theme-preview-2.8.0
2023-05-10 13:42 [PR PATCH] New package: grub2-theme-preview-2.8.0 Animeshz
` (6 preceding siblings ...)
2023-05-11 4:04 ` Animeshz
@ 2023-05-11 4:05 ` Animeshz
2023-05-11 4:07 ` [PR PATCH] [Updated] " Animeshz
` (6 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: Animeshz @ 2023-05-11 4:05 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 413 bytes --]
New review comment by Animeshz on void-packages repository
https://github.com/void-linux/void-packages/pull/43830#discussion_r1190612339
Comment:
A valid grub-efi implementation is required for both runtime to work as well as tests to pass. I don't think there's an easy way to embed this in `depends=` at the metadata declaration itself. What do you think?
Or did you mean about `*)` default handler? 👀
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PR PATCH] [Updated] New package: grub2-theme-preview-2.8.0
2023-05-10 13:42 [PR PATCH] New package: grub2-theme-preview-2.8.0 Animeshz
` (7 preceding siblings ...)
2023-05-11 4:05 ` Animeshz
@ 2023-05-11 4:07 ` Animeshz
2023-05-11 4:08 ` Animeshz
` (5 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: Animeshz @ 2023-05-11 4:07 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 755 bytes --]
There is an updated pull request by Animeshz against master on the void-packages repository
https://github.com/Animeshz/void-packages tp/grub2-theme-preview
https://github.com/void-linux/void-packages/pull/43830
New package: grub2-theme-preview-2.8.0
#### Testing the changes
- I tested the changes in this PR: **YES**
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**
#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
CC: https://github.com/hartwork/grub2-theme-preview/pull/172
A patch file from https://github.com/void-linux/void-packages/pull/43830.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-tp/grub2-theme-preview-43830.patch --]
[-- Type: text/x-diff, Size: 1404 bytes --]
From 252080748195c50c9f96e14c49f9efb69149d868 Mon Sep 17 00:00:00 2001
From: Animesh Sahu <animeshsahu19@yahoo.com>
Date: Wed, 10 May 2023 19:09:44 +0530
Subject: [PATCH] New package: grub2-theme-preview-2.8.0
---
srcpkgs/grub2-theme-preview/template | 20 ++++++++++++++++++++
1 file changed, 20 insertions(+)
create mode 100644 srcpkgs/grub2-theme-preview/template
diff --git a/srcpkgs/grub2-theme-preview/template b/srcpkgs/grub2-theme-preview/template
new file mode 100644
index 000000000000..a008ff71718a
--- /dev/null
+++ b/srcpkgs/grub2-theme-preview/template
@@ -0,0 +1,20 @@
+# Template file for 'grub2-theme-preview'
+pkgname=grub2-theme-preview
+version=2.8.0
+revision=1
+archs="x86_64* i686*"
+build_style=python3-module
+hostmakedepends="python3-setuptools"
+depends="mtools qemu xorriso"
+checkdepends="${depends} python3-parameterized"
+short_desc="Preview a full GRUB 2.x theme using KVM / QEMU"
+maintainer="Animesh Sahu <animeshsahu19@yahoo.com>"
+license="GPL-2.0-or-later"
+homepage="https://github.com/hartwork/grub2-theme-preview"
+distfiles="https://github.com/hartwork/grub2-theme-preview/archive/${version}.tar.gz"
+checksum=f96dda1dce58b3336ccae7697640490941bcfcce567352c7f4f5a8f4d2b193df
+
+case $XBPS_TARGET_MACHINE in
+ x86_64*) depends+=" grub-x86_64-efi"; checkdepends+=" grub-x86_64-efi" ;;
+ i686*) depends+=" grub-i386-efi"; checkdepends+=" grub-i386-efi" ;;
+esac
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: New package: grub2-theme-preview-2.8.0
2023-05-10 13:42 [PR PATCH] New package: grub2-theme-preview-2.8.0 Animeshz
` (8 preceding siblings ...)
2023-05-11 4:07 ` [PR PATCH] [Updated] " Animeshz
@ 2023-05-11 4:08 ` Animeshz
2023-05-30 7:27 ` Animeshz
` (4 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: Animeshz @ 2023-05-11 4:08 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 163 bytes --]
New comment by Animeshz on void-packages repository
https://github.com/void-linux/void-packages/pull/43830#issuecomment-1543303653
Comment:
Applied the changes!
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: New package: grub2-theme-preview-2.8.0
2023-05-10 13:42 [PR PATCH] New package: grub2-theme-preview-2.8.0 Animeshz
` (9 preceding siblings ...)
2023-05-11 4:08 ` Animeshz
@ 2023-05-30 7:27 ` Animeshz
2023-08-29 1:45 ` github-actions
` (3 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: Animeshz @ 2023-05-30 7:27 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 148 bytes --]
New comment by Animeshz on void-packages repository
https://github.com/void-linux/void-packages/pull/43830#issuecomment-1567907967
Comment:
ping!
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: New package: grub2-theme-preview-2.8.0
2023-05-10 13:42 [PR PATCH] New package: grub2-theme-preview-2.8.0 Animeshz
` (10 preceding siblings ...)
2023-05-30 7:27 ` Animeshz
@ 2023-08-29 1:45 ` github-actions
2023-08-29 11:13 ` Animeshz
` (2 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: github-actions @ 2023-08-29 1:45 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 305 bytes --]
New comment by github-actions[bot] on void-packages repository
https://github.com/void-linux/void-packages/pull/43830#issuecomment-1696649156
Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: New package: grub2-theme-preview-2.8.0
2023-05-10 13:42 [PR PATCH] New package: grub2-theme-preview-2.8.0 Animeshz
` (11 preceding siblings ...)
2023-08-29 1:45 ` github-actions
@ 2023-08-29 11:13 ` Animeshz
2023-11-28 1:46 ` github-actions
2023-12-12 1:46 ` [PR PATCH] [Closed]: " github-actions
14 siblings, 0 replies; 16+ messages in thread
From: Animeshz @ 2023-08-29 11:13 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 148 bytes --]
New comment by Animeshz on void-packages repository
https://github.com/void-linux/void-packages/pull/43830#issuecomment-1697241889
Comment:
Bump!
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: New package: grub2-theme-preview-2.8.0
2023-05-10 13:42 [PR PATCH] New package: grub2-theme-preview-2.8.0 Animeshz
` (12 preceding siblings ...)
2023-08-29 11:13 ` Animeshz
@ 2023-11-28 1:46 ` github-actions
2023-12-12 1:46 ` [PR PATCH] [Closed]: " github-actions
14 siblings, 0 replies; 16+ messages in thread
From: github-actions @ 2023-11-28 1:46 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 305 bytes --]
New comment by github-actions[bot] on void-packages repository
https://github.com/void-linux/void-packages/pull/43830#issuecomment-1828929921
Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PR PATCH] [Closed]: New package: grub2-theme-preview-2.8.0
2023-05-10 13:42 [PR PATCH] New package: grub2-theme-preview-2.8.0 Animeshz
` (13 preceding siblings ...)
2023-11-28 1:46 ` github-actions
@ 2023-12-12 1:46 ` github-actions
14 siblings, 0 replies; 16+ messages in thread
From: github-actions @ 2023-12-12 1:46 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 582 bytes --]
There's a closed pull request on the void-packages repository
New package: grub2-theme-preview-2.8.0
https://github.com/void-linux/void-packages/pull/43830
Description:
#### Testing the changes
- I tested the changes in this PR: **YES**
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**
#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
CC: https://github.com/hartwork/grub2-theme-preview/pull/172
^ permalink raw reply [flat|nested] 16+ messages in thread