Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] pnpm: update to 8.12.0.
@ 2023-12-11 19:55 Bnyro
  2023-12-13  7:11 ` kwshi
                   ` (5 more replies)
  0 siblings, 6 replies; 7+ messages in thread
From: Bnyro @ 2023-12-11 19:55 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 464 bytes --]

There is a new pull request by Bnyro against master on the void-packages repository

https://github.com/Bnyro/void-packages pnpm
https://github.com/void-linux/void-packages/pull/47696

pnpm: update to 8.12.0.

#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc



A patch file from https://github.com/void-linux/void-packages/pull/47696.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pnpm-47696.patch --]
[-- Type: text/x-diff, Size: 1384 bytes --]

From 48f1168e0c5941f4fed629dc154821510c6d6bf0 Mon Sep 17 00:00:00 2001
From: Bnyro <bnyro@tutanota.com>
Date: Mon, 11 Dec 2023 20:41:45 +0100
Subject: [PATCH] pnpm: update to 8.12.0.

---
 srcpkgs/pnpm/template | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/srcpkgs/pnpm/template b/srcpkgs/pnpm/template
index a06709331100f..1b882eacf1764 100644
--- a/srcpkgs/pnpm/template
+++ b/srcpkgs/pnpm/template
@@ -1,6 +1,6 @@
 # Template file for 'pnpm'
 pkgname=pnpm
-version=8.11.0
+version=8.12.0
 revision=1
 build_style=fetch
 hostmakedepends="nodejs jq"
@@ -10,17 +10,13 @@ maintainer="Bnyro <bnyro@tutanota.com>"
 license="MIT"
 homepage="https://pnpm.io/"
 distfiles="https://registry.npmjs.org/pnpm/-/pnpm-${version}.tgz"
-checksum=5858806c3b292cbec89b5533662168a957358e2bbd86431516d441dc1aface89
+checksum=553e4eb0e2a2c9abcb419b3262bdc7aee8ae3c42e2301a1807d44575786160c9
 python_version=3
 
 do_install() {
 	npm install -g --user root --prefix "${DESTDIR}/usr" "${XBPS_SRCDISTDIR}/${pkgname}-${version}/${pkgname}-${version}.tgz"
 	local _npmdir="${DESTDIR}/usr/lib/node_modules/${pkgname}"
 
-	# Sort and cleanup package.json
-	jq '.|=with_entries(select(.key|test("_.+")|not))' "$_npmdir/package.json" > "$_npmdir/package.json"
-	chmod 644 "$_npmdir/package.json"
-
 	# Delete JS SourceMaps
 	find "${DESTDIR}/usr/lib" -depth -name '*.map' -delete
 

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: pnpm: update to 8.12.0.
  2023-12-11 19:55 [PR PATCH] pnpm: update to 8.12.0 Bnyro
@ 2023-12-13  7:11 ` kwshi
  2023-12-13  7:15 ` [PR REVIEW] " kwshi
                   ` (4 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: kwshi @ 2023-12-13  7:11 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 676 bytes --]

New comment by kwshi on void-packages repository

https://github.com/void-linux/void-packages/pull/47696#issuecomment-1853378291

Comment:
By the way, the current pnpm package in void-packages (version 8.11.0) is broken-- the `/usr/lib/node_modules/pnpm/package.json` is empty, such that running `pnpm` results in the following error:

![image](https://github.com/void-linux/void-packages/assets/3887189/7e82a1a0-ff12-44c0-8724-5168fddce166)

I'm not sure what was wrong with the 8.11 build script causing this to happen. However, I just tested this PR and that error no longer appears, so I think it fixes the issue-- in which case it would be best to merge this ASAP.


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PR REVIEW] pnpm: update to 8.12.0.
  2023-12-11 19:55 [PR PATCH] pnpm: update to 8.12.0 Bnyro
  2023-12-13  7:11 ` kwshi
@ 2023-12-13  7:15 ` kwshi
  2023-12-13 13:15 ` Bnyro
                   ` (3 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: kwshi @ 2023-12-13  7:15 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 338 bytes --]

New review comment by kwshi on void-packages repository

https://github.com/void-linux/void-packages/pull/47696#discussion_r1424935323

Comment:
Actually, now that I'm reading through the diffs, I'm pretty sure the 8.11.0 issue with the empty package.json was caused precisely by this line, which is now deleted. So that's good, I think.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PR REVIEW] pnpm: update to 8.12.0.
  2023-12-11 19:55 [PR PATCH] pnpm: update to 8.12.0 Bnyro
  2023-12-13  7:11 ` kwshi
  2023-12-13  7:15 ` [PR REVIEW] " kwshi
@ 2023-12-13 13:15 ` Bnyro
  2023-12-13 13:16 ` Bnyro
                   ` (2 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: Bnyro @ 2023-12-13 13:15 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 196 bytes --]

New review comment by Bnyro on void-packages repository

https://github.com/void-linux/void-packages/pull/47696#discussion_r1425340239

Comment:
Yes, that's exactly why I removed these lines :+1;

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PR REVIEW] pnpm: update to 8.12.0.
  2023-12-11 19:55 [PR PATCH] pnpm: update to 8.12.0 Bnyro
                   ` (2 preceding siblings ...)
  2023-12-13 13:15 ` Bnyro
@ 2023-12-13 13:16 ` Bnyro
  2023-12-13 13:17 ` Bnyro
  2023-12-13 17:45 ` [PR PATCH] [Merged]: " classabbyamp
  5 siblings, 0 replies; 7+ messages in thread
From: Bnyro @ 2023-12-13 13:16 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 196 bytes --]

New review comment by Bnyro on void-packages repository

https://github.com/void-linux/void-packages/pull/47696#discussion_r1425340239

Comment:
Yes, that's exactly why I removed these lines :+1:

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: pnpm: update to 8.12.0.
  2023-12-11 19:55 [PR PATCH] pnpm: update to 8.12.0 Bnyro
                   ` (3 preceding siblings ...)
  2023-12-13 13:16 ` Bnyro
@ 2023-12-13 13:17 ` Bnyro
  2023-12-13 17:45 ` [PR PATCH] [Merged]: " classabbyamp
  5 siblings, 0 replies; 7+ messages in thread
From: Bnyro @ 2023-12-13 13:17 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1567 bytes --]

New comment by Bnyro on void-packages repository

https://github.com/void-linux/void-packages/pull/47696#issuecomment-1853902414

Comment:
> By the way, the current pnpm package in void-packages (version 8.11.0) is broken-- the `/usr/lib/node_modules/pnpm/package.json` is empty, such that running `pnpm` results in the following error:
> 
> ![image](https://private-user-images.githubusercontent.com/3887189/290104717-7e82a1a0-ff12-44c0-8724-5168fddce166.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTEiLCJleHAiOjE3MDI0NzM2NzMsIm5iZiI6MTcwMjQ3MzM3MywicGF0aCI6Ii8zODg3MTg5LzI5MDEwNDcxNy03ZTgyYTFhMC1mZjEyLTQ0YzAtODcyNC01MTY4ZmRkY2UxNjYucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQUlXTkpZQVg0Q1NWRUg1M0ElMkYyMDIzMTIxMyUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyMzEyMTNUMTMxNjEzWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9OTljMWEwN2Y0Y2YyOWI0YTJhYWVhNDM2MTU2NjFiMjY1Zjk0MzNhNjJiMmYwZmRmZTA4YWM4YjExODIyMzYwNiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.d9QF0-QlH1lLB5-q0mMinIYFGA49PDguq1hIaW50Aps)
> 
> I'm not sure what was wrong with the 8.11 build script causing this to happen. However, I just tested this PR and that error no longer appears, so I think it fixes the issue-- in which case it would be best to merge this ASAP.
>
Yes, that's my bad, not sure what went wrong when I tested 8.11.0 ... I likely tested the old version and forgot to actually install the new one back then.


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PR PATCH] [Merged]: pnpm: update to 8.12.0.
  2023-12-11 19:55 [PR PATCH] pnpm: update to 8.12.0 Bnyro
                   ` (4 preceding siblings ...)
  2023-12-13 13:17 ` Bnyro
@ 2023-12-13 17:45 ` classabbyamp
  5 siblings, 0 replies; 7+ messages in thread
From: classabbyamp @ 2023-12-13 17:45 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 320 bytes --]

There's a merged pull request on the void-packages repository

pnpm: update to 8.12.0.
https://github.com/void-linux/void-packages/pull/47696

Description:

#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc



^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2023-12-13 17:45 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-11 19:55 [PR PATCH] pnpm: update to 8.12.0 Bnyro
2023-12-13  7:11 ` kwshi
2023-12-13  7:15 ` [PR REVIEW] " kwshi
2023-12-13 13:15 ` Bnyro
2023-12-13 13:16 ` Bnyro
2023-12-13 13:17 ` Bnyro
2023-12-13 17:45 ` [PR PATCH] [Merged]: " classabbyamp

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).