Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] android-file-transfer-linux: Add missing dependency
@ 2023-12-24 11:05 meator
  2023-12-25  8:28 ` [PR PATCH] [Merged]: " sgn
  0 siblings, 1 reply; 2+ messages in thread
From: meator @ 2023-12-24 11:05 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 645 bytes --]

There is a new pull request by meator against master on the void-packages repository

https://github.com/meator/void-packages aft
https://github.com/void-linux/void-packages/pull/47893

android-file-transfer-linux: Add missing dependency
android-file-transfer-linux doesn't depend on its icons, which can be confusing if someone doesn't have them. This is not a problem when the user is running Kde, but if someone (like me) is using aft "standalone", `qt5-svg` doesn't get pulled.

#### Testing the changes
- I tested the changes in this PR: **YES**

A patch file from https://github.com/void-linux/void-packages/pull/47893.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-aft-47893.patch --]
[-- Type: text/x-diff, Size: 1050 bytes --]

From dfbae8598feb784989cad4cccca9cab9984edc02 Mon Sep 17 00:00:00 2001
From: meator <meator.dev@gmail.com>
Date: Sun, 24 Dec 2023 11:53:52 +0100
Subject: [PATCH] android-file-transfer-linux: Add missing dep

---
 srcpkgs/android-file-transfer-linux/template | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/android-file-transfer-linux/template b/srcpkgs/android-file-transfer-linux/template
index 4480fb0ab6692..d223ff0ee2aab 100644
--- a/srcpkgs/android-file-transfer-linux/template
+++ b/srcpkgs/android-file-transfer-linux/template
@@ -1,12 +1,13 @@
 # Template file for 'android-file-transfer-linux'
 pkgname=android-file-transfer-linux
 version=4.2
-revision=3
+revision=4
 build_style=cmake
 configure_args="-DBUILD_SHARED_LIB=1"
 hostmakedepends="qt5-qmake qt5-host-tools ninja pkg-config"
 makedepends="file-devel fuse-devel qt5-devel readline-devel
  qt5-tools-devel"
+depends="qt5-svg"
 short_desc="Android File Transfer for Linux"
 maintainer="Toyam Cox <Vaelatern@voidlinux.org>"
 license="LGPL-2.1-or-later"

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PR PATCH] [Merged]: android-file-transfer-linux: Add missing dependency
  2023-12-24 11:05 [PR PATCH] android-file-transfer-linux: Add missing dependency meator
@ 2023-12-25  8:28 ` sgn
  0 siblings, 0 replies; 2+ messages in thread
From: sgn @ 2023-12-25  8:28 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 500 bytes --]

There's a merged pull request on the void-packages repository

android-file-transfer-linux: Add missing dependency
https://github.com/void-linux/void-packages/pull/47893

Description:
android-file-transfer-linux doesn't depend on its icons, which can be confusing if someone doesn't have them. This is not a problem when the user is running Kde, but if someone (like me) is using aft "standalone", `qt5-svg` doesn't get pulled.

#### Testing the changes
- I tested the changes in this PR: **YES**

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-12-25  8:28 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-24 11:05 [PR PATCH] android-file-transfer-linux: Add missing dependency meator
2023-12-25  8:28 ` [PR PATCH] [Merged]: " sgn

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).