Github messages for voidlinux
 help / color / mirror / Atom feed
From: tornaria <tornaria@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Closed]: [RFC] do not install checkdepends when check is not going to run
Date: Tue, 26 Dec 2023 16:59:25 +0100	[thread overview]
Message-ID: <20231226155925.SbhgFTw9_BDyzpc1XxmrdVqrcgxlMN1oLLZPSff_M-0@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-46207@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1800 bytes --]

There's a closed pull request on the void-packages repository

[RFC] do not install checkdepends when check is not going to run
https://github.com/void-linux/void-packages/pull/46207

Description:
This is useful e.g. to break build <-> check cycles.

For instance, one can set `make_check=extended` so check doesn't run on CI or -Q (maybe the check depencies are updated at the same time), but it's still easy to run check using -K after dependencies have been built.

I'm working on jupyter notebook packages, and there are a few build <-> check cycles. I want to try to arrange checks so that `-Q` will check as much as possible without cycles, and `-K` will do full check (assuming all dependencies are already packaged).

Without this patch one needs to add packages to `checkdepends` conditionally on `$XBPS_CHECK_PKGS`, but it seems simpler this way.


<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


  parent reply	other threads:[~2023-12-26 15:59 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-23 19:29 [PR PATCH] " tornaria
2023-12-23  1:45 ` github-actions
2023-12-23 16:42 ` tornaria
2023-12-26 15:59 ` tornaria [this message]
2023-12-26 15:59 ` tornaria

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231226155925.SbhgFTw9_BDyzpc1XxmrdVqrcgxlMN1oLLZPSff_M-0@z \
    --to=tornaria@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).