[PR PATCH] Rocket.Chat-Desktop: update to 3.9.11

[PR PATCH] Rocket.Chat-Desktop: update to 3.9.11

[ju-ef]

[-- Attachment #1: Type: text/plain, Size: 502 bytes --]

There is a new pull request by ju-ef against master on the void-packages repository

https://github.com/ju-ef/void-packages rocket.chat-desktop
https://github.com/void-linux/void-packages/pull/47975

Rocket.Chat-Desktop: update to 3.9.11
#### Testing the changes
- I tested the changes in this PR: **briefly**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)


A patch file from https://github.com/void-linux/void-packages/pull/47975.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-rocket.chat-desktop-47975.patch --]
[-- Type: text/x-diff, Size: 1914 bytes --]

From b59c9e2e875e92f9d006c5e03cf5b5a65c42d294 Mon Sep 17 00:00:00 2001
From: juef <juef@juef.net>
Date: Fri, 29 Dec 2023 16:02:36 +0200
Subject: [PATCH] Rocket.Chat-Desktop: update to 3.9.11

---
 srcpkgs/Rocket.Chat-Desktop/template | 23 +++++------------------
 1 file changed, 5 insertions(+), 18 deletions(-)

diff --git a/srcpkgs/Rocket.Chat-Desktop/template b/srcpkgs/Rocket.Chat-Desktop/template
index d7ecb67b7473f..6e75899df44d2 100644
--- a/srcpkgs/Rocket.Chat-Desktop/template
+++ b/srcpkgs/Rocket.Chat-Desktop/template
@@ -1,8 +1,8 @@
 # Template file for 'Rocket.Chat-Desktop'
 pkgname=Rocket.Chat-Desktop
-version=3.8.7
-revision=2
-_electron_ver=19
+version=3.9.11
+revision=1
+_electron_ver=24
 hostmakedepends="yarn nodejs python3 pkg-config app-builder"
 makedepends="electron${_electron_ver} libvips-devel"
 depends="electron${_electron_ver}"
@@ -11,26 +11,13 @@ maintainer="John <me@johnnynator.dev>"
 license="MIT"
 homepage="https://rocket.chat/"
 distfiles="https://github.com/RocketChat/Rocket.Chat.Electron/archive/${version}.tar.gz"
-checksum=ac46390b4ae9e193efa92d5a38947c99fa94140604302b6850b9167e49eea453
+checksum=936525dd74dcc9050bfb91ecf4ce80d6a5be38de8bfbb9b05f2faac7b3a9a580
 
 export USE_SYSTEM_APP_BUILDER=true
 
-do_configure() {
-	# we can't make electron skip binary download as that fails in do_build
-	# so instead, force a bogus architecture so it downloads its binary
-	# artifact, it will use the system one later anyway
-	# but this appears to fail on i686, so don't override there
-	local carch=x64
-	case "$XBPS_TARGET_MACHINE" in
-		i686*) carch=ia32 ;;
-	esac
-	npm_config_arch=$carch \
-		yarn upgrade electron@"$(</usr/lib/electron${_electron_ver}/version)" \
-			--non-interactive
-}
-
 do_build() {
 	export NODE_ENV=production
+	yarn install
 	yarn build
 	yarn run electron-builder --linux --x64 --dir \
 		-c.electronDist=/usr/lib/electron${_electron_ver} \

Re: Rocket.Chat-Desktop: update to 3.9.11

[ju-ef]

[-- Attachment #1: Type: text/plain, Size: 1026 bytes --]

New comment by ju-ef on void-packages repository

https://github.com/void-linux/void-packages/pull/47975#issuecomment-1872544035

Comment:
Couldn't build i686 version (locally built `electron24` for i686 arch as there is [no such version](https://github.com/void-linux/void-packages/actions/runs/7357321097/job/20031535972?pr=47975#step:7:50)), even with removed [`do_configure()`](https://github.com/void-linux/void-packages/pull/47975/files#diff-658ecfaac699c5a51b33119d7128a237a5d02753d1bd77e314e52c0d47899311L18-L31) block;
also tried to set env variable [`ELECTRON_SKIP_BINARY_DOWNLOAD=1`](https://releases.electronjs.org/release/v6.0.12) - no changes.
```
[!] Error: Electron failed to install correctly, please delete node_modules/electron and try installing again
```

Don't know how to fix it.
But maybe because there is yarn set to 3.2.2 version:
https://github.com/RocketChat/Rocket.Chat.Electron/blob/3.9.11/package.json#L161
https://github.com/RocketChat/Rocket.Chat.Electron/blob/3.9.11/.yarnrc.yml#L13

Re: Rocket.Chat-Desktop: update to 3.9.11

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/47975#issuecomment-2027865581

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

Re: [PR PATCH] [Closed]: Rocket.Chat-Desktop: update to 3.9.11

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 343 bytes --]

There's a closed pull request on the void-packages repository

Rocket.Chat-Desktop: update to 3.9.11
https://github.com/void-linux/void-packages/pull/47975

Description:
#### Testing the changes
- I tested the changes in this PR: **briefly**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)