* [PR PATCH] xbps-src: fix NOCOLORS
@ 2023-12-29 13:49 tornaria
2023-12-29 13:57 ` tornaria
2023-12-31 15:05 ` [PR PATCH] [Merged]: " leahneukirchen
0 siblings, 2 replies; 3+ messages in thread
From: tornaria @ 2023-12-29 13:49 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1362 bytes --]
There is a new pull request by tornaria against master on the void-packages repository
https://github.com/tornaria/void-packages fix-nocolors
https://github.com/void-linux/void-packages/pull/47974
xbps-src: fix NOCOLORS
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
Easy way to reproduce: `./xbps-src show-build-deps xyz | cat` which should not print colors, in fact prints colors.
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/47974.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fix-nocolors-47974.patch --]
[-- Type: text/x-diff, Size: 902 bytes --]
From a5287a46737ffd95ec05f8a0eaed570705378e43 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Gonzalo=20Tornar=C3=ADa?= <tornaria@cmat.edu.uy>
Date: Fri, 29 Dec 2023 10:48:23 -0300
Subject: [PATCH] xbps-src: fix NOCOLORS
---
common/environment/setup/sourcepkg.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/environment/setup/sourcepkg.sh b/common/environment/setup/sourcepkg.sh
index 6c016dbd191a9..b08379acdd35f 100644
--- a/common/environment/setup/sourcepkg.sh
+++ b/common/environment/setup/sourcepkg.sh
@@ -11,7 +11,7 @@ for var in $(awk 'BEGIN{for (i in ENVIRON) {print i}}' </dev/null); do
var="${var#BASH_FUNC_}"
unset -f "$var"
;;
- XBPS_* | IN_CHROOT | CHROOT_READY | SOURCE_DATE_EPOCH)
+ XBPS_* | IN_CHROOT | CHROOT_READY | SOURCE_DATE_EPOCH | NOCOLORS)
# xbps-src specific
;;
SOURCEFORGE_SITE | NONGNU_SITE | XORG_SITE | DEBIAN_SITE | GNOME_SITE)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: xbps-src: fix NOCOLORS
2023-12-29 13:49 [PR PATCH] xbps-src: fix NOCOLORS tornaria
@ 2023-12-29 13:57 ` tornaria
2023-12-31 15:05 ` [PR PATCH] [Merged]: " leahneukirchen
1 sibling, 0 replies; 3+ messages in thread
From: tornaria @ 2023-12-29 13:57 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 275 bytes --]
New comment by tornaria on void-packages repository
https://github.com/void-linux/void-packages/pull/47974#issuecomment-1872109558
Comment:
btw, this breaks xbulk when using -E, since found packages will print a normal msg which xbulk filters out but not if it has colors.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PR PATCH] [Merged]: xbps-src: fix NOCOLORS
2023-12-29 13:49 [PR PATCH] xbps-src: fix NOCOLORS tornaria
2023-12-29 13:57 ` tornaria
@ 2023-12-31 15:05 ` leahneukirchen
1 sibling, 0 replies; 3+ messages in thread
From: leahneukirchen @ 2023-12-31 15:05 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1204 bytes --]
There's a merged pull request on the void-packages repository
xbps-src: fix NOCOLORS
https://github.com/void-linux/void-packages/pull/47974
Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
Easy way to reproduce: `./xbps-src show-build-deps xyz | cat` which should not print colors, in fact prints colors.
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-12-31 15:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-29 13:49 [PR PATCH] xbps-src: fix NOCOLORS tornaria
2023-12-29 13:57 ` tornaria
2023-12-31 15:05 ` [PR PATCH] [Merged]: " leahneukirchen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).