From: classabbyamp <classabbyamp@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Merged]: Fix xbps-src colours in CI
Date: Sat, 06 Jan 2024 01:18:33 +0100 [thread overview]
Message-ID: <20240106001833.obss0OlU5HrWNON9x3wQaBfGpnTCnzWRXUtjsS_lMXA@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-37283@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1176 bytes --]
There's a merged pull request on the void-packages repository
Fix xbps-src colours in CI
https://github.com/void-linux/void-packages/pull/37283
Description:
~~This PR adds a new config variable `XBPS_FORCE_COLORS`, which overrides the "is this not a tty" and `NO_COLOR` checks, and adds it to config entries for CI.~~
**EDIT** Github has changed the way CI is run; xbps-src now thinks it is running in a terminal and prints with colour. This part of the PR has been removed.
The `msg_normal()` colour is changed from "bold" (`1`) to "bright white, bold" (`97`, `1`) since Github workflows render `1` as bold letters of the current colour. This should have no effect on the vast majority of terminals setups, as `1` is already rendered as bright white with or without bolded font.
I also setup [a demo](https://github.com/0x5c/void-packages/pull/4/checks) on my fork.
#### Testing the changes
- I tested the changes in this PR: **YES**
prev parent reply other threads:[~2024-01-06 0:18 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-25 4:09 [PR PATCH] Enable " 0x5c
2022-05-25 4:17 ` [PR REVIEW] " 0x5c
2022-05-25 6:22 ` classabbyamp
2022-05-25 6:33 ` 0x5c
2022-05-25 12:25 ` ahesford
2022-05-25 20:55 ` 0x5c
2022-05-30 19:25 ` [PR PATCH] [Updated] " 0x5c
2022-06-07 0:37 ` 0x5c
2022-06-12 1:28 ` 0x5c
2022-06-12 1:43 ` 0x5c
2022-06-13 16:38 ` [PR REVIEW] " ericonr
2022-06-14 4:34 ` 0x5c
2022-06-14 4:57 ` 0x5c
2022-09-13 2:14 ` github-actions
2022-09-26 2:37 ` [PR PATCH] [Updated] " 0x5c
2022-12-31 1:55 ` github-actions
2023-01-13 3:12 ` [PR PATCH] [Updated] " 0x5c
2023-02-20 2:08 ` 0x5c
2023-02-20 3:50 ` 0x5c
2023-02-20 3:51 ` [PR REVIEW] " 0x5c
2023-02-20 3:52 ` 0x5c
2023-02-20 3:59 ` Fix " 0x5c
2023-05-22 1:57 ` github-actions
2023-05-25 0:34 ` [PR PATCH] [Updated] " 0x5c
2023-09-23 1:44 ` github-actions
2023-09-28 23:12 ` [PR PATCH] [Updated] " 0x5c
2023-12-28 1:45 ` github-actions
2024-01-05 23:47 ` [PR PATCH] [Updated] " 0x5c
2024-01-05 23:50 ` 0x5c
2024-01-05 23:51 ` [PR PATCH] [Updated] " 0x5c
2024-01-06 0:02 ` 0x5c
2024-01-06 0:13 ` 0x5c
2024-01-06 0:17 ` 0x5c
2024-01-06 0:18 ` classabbyamp [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240106001833.obss0OlU5HrWNON9x3wQaBfGpnTCnzWRXUtjsS_lMXA@z \
--to=classabbyamp@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).