From: 0x5c <0x5c@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] Enable xbps-src colours in CI
Date: Tue, 14 Jun 2022 06:34:20 +0200 [thread overview]
Message-ID: <20220614043420.FlyIclGTG3-t5IxKl1A4rX1SX7XtWcDHlvBVyrwHdRA@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-37283@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 841 bytes --]
New review comment by 0x5c on void-packages repository
https://github.com/void-linux/void-packages/pull/37283#discussion_r896364863
Comment:
`NOCOLORS` is set used by both the tty check and the `NO_COLOR` check here:
https://github.com/void-linux/void-packages/blob/f7e694733df137bc5957d62a43bb81b27a5af130/xbps-src#L408-L413
and by the argument parsing just above it. The configuration is loaded much later than those 3 points, so detection of `-L`/`NO_COLOR` would be faked by the tty check.
Not sure what the best way to go is, would it be fine to move tty/NO_COLORS to where the override currently is, and change the var set by arg parsing to an intermediary var?
Another way would be to move the tty check to where the override is, where it could simply be skipped in the presence of the command. This might be the better way
next prev parent reply other threads:[~2022-06-14 4:34 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-25 4:09 [PR PATCH] " 0x5c
2022-05-25 4:17 ` [PR REVIEW] " 0x5c
2022-05-25 6:22 ` classabbyamp
2022-05-25 6:33 ` 0x5c
2022-05-25 12:25 ` ahesford
2022-05-25 20:55 ` 0x5c
2022-05-30 19:25 ` [PR PATCH] [Updated] " 0x5c
2022-06-07 0:37 ` 0x5c
2022-06-12 1:28 ` 0x5c
2022-06-12 1:43 ` 0x5c
2022-06-13 16:38 ` [PR REVIEW] " ericonr
2022-06-14 4:34 ` 0x5c [this message]
2022-06-14 4:57 ` 0x5c
2022-09-13 2:14 ` github-actions
2022-09-26 2:37 ` [PR PATCH] [Updated] " 0x5c
2022-12-31 1:55 ` github-actions
2023-01-13 3:12 ` [PR PATCH] [Updated] " 0x5c
2023-02-20 2:08 ` 0x5c
2023-02-20 3:50 ` 0x5c
2023-02-20 3:51 ` [PR REVIEW] " 0x5c
2023-02-20 3:52 ` 0x5c
2023-02-20 3:59 ` Fix " 0x5c
2023-05-22 1:57 ` github-actions
2023-05-25 0:34 ` [PR PATCH] [Updated] " 0x5c
2023-09-23 1:44 ` github-actions
2023-09-28 23:12 ` [PR PATCH] [Updated] " 0x5c
2023-12-28 1:45 ` github-actions
2024-01-05 23:47 ` [PR PATCH] [Updated] " 0x5c
2024-01-05 23:50 ` 0x5c
2024-01-05 23:51 ` [PR PATCH] [Updated] " 0x5c
2024-01-06 0:02 ` 0x5c
2024-01-06 0:13 ` 0x5c
2024-01-06 0:17 ` 0x5c
2024-01-06 0:18 ` [PR PATCH] [Merged]: " classabbyamp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220614043420.FlyIclGTG3-t5IxKl1A4rX1SX7XtWcDHlvBVyrwHdRA@z \
--to=0x5c@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).