* [PR PATCH] wpa_supplicant: log to stdout instead of syslog
@ 2023-09-26 15:04 deepcube
2023-12-26 1:45 ` github-actions
2024-01-09 1:47 ` [PR PATCH] [Closed]: " github-actions
0 siblings, 2 replies; 3+ messages in thread
From: deepcube @ 2023-09-26 15:04 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1026 bytes --]
There is a new pull request by deepcube against master on the void-packages repository
https://github.com/deepcube/void-packages emg-wpa_supplicant-log-stdout
https://github.com/void-linux/void-packages/pull/46269
wpa_supplicant: log to stdout instead of syslog
A long time ago the wpa_supplicant service was changed[0] to log to syslog by default instead of the stdout. This setting was carrier through a number of changes and persists to this day. As such, wpa_supplicant will not log via the log/run mechanism as expected by default.
Remove the -s flag from the default and auto options so wpa_supplicant logs to stdout (and hence log/run) as expected for runit services.
[0] 62ae6738b59 (wpa_supplicant: log to syslog by default)
#### Testing the changes
- I tested the changes in this PR: **YES**
#### Local build testing
- I built this PR locally for my native architectures, (x86_64-musl, armv6l-musl)
A patch file from https://github.com/void-linux/void-packages/pull/46269.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-emg-wpa_supplicant-log-stdout-46269.patch --]
[-- Type: text/x-diff, Size: 1963 bytes --]
From f150907234a88c88736022171540ec6f07d904ea Mon Sep 17 00:00:00 2001
From: Evan Gates <evan.gates@gmail.com>
Date: Tue, 26 Sep 2023 08:02:39 -0600
Subject: [PATCH] wpa_supplicant: log to stdout instead of syslog
A long time ago the wpa_supplicant service was changed[0] to log to syslog
by default instead of the stdout. This setting was carrier through a
number of changes and persists to this day. As such, wpa_supplicant
will not log via the log/run mechanism as expected by default.
Remove the -s flag from the default and auto options so wpa_supplicant
logs to stdout (and hence log/run) as expected for runit services.
[0] 62ae6738b59 (wpa_supplicant: log to syslog by default)
---
srcpkgs/wpa_supplicant/files/wpa_supplicant/run | 4 ++--
srcpkgs/wpa_supplicant/template | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/srcpkgs/wpa_supplicant/files/wpa_supplicant/run b/srcpkgs/wpa_supplicant/files/wpa_supplicant/run
index d96bac26d1a5b..109a9e8339f50 100644
--- a/srcpkgs/wpa_supplicant/files/wpa_supplicant/run
+++ b/srcpkgs/wpa_supplicant/files/wpa_supplicant/run
@@ -1,10 +1,10 @@
#!/bin/sh
if [ -r ./conf ]; then
. ./conf
- : ${OPTS:=-M -c ${CONF_FILE:-/etc/wpa_supplicant/wpa_supplicant.conf} ${WPA_INTERFACE:+-i ${WPA_INTERFACE}} ${DRIVER:+-D ${DRIVER}} -s}
+ : ${OPTS:=-M -c ${CONF_FILE:-/etc/wpa_supplicant/wpa_supplicant.conf} ${WPA_INTERFACE:+-i ${WPA_INTERFACE}} ${DRIVER:+-D ${DRIVER}} }
else
. ./auto
- OPTS="${AUTO} -s"
+ OPTS="${AUTO}"
fi
exec 2>&1
diff --git a/srcpkgs/wpa_supplicant/template b/srcpkgs/wpa_supplicant/template
index 87203097b009e..1706dbcfa7b71 100644
--- a/srcpkgs/wpa_supplicant/template
+++ b/srcpkgs/wpa_supplicant/template
@@ -1,7 +1,7 @@
# Template file for 'wpa_supplicant'
pkgname=wpa_supplicant
version=2.10
-revision=3
+revision=4
build_wrksrc="$pkgname"
short_desc="WPA/WPA2/IEEE 802.1X Supplicant"
maintainer="Enno Boland <gottox@voidlinux.org>"
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: wpa_supplicant: log to stdout instead of syslog
2023-09-26 15:04 [PR PATCH] wpa_supplicant: log to stdout instead of syslog deepcube
@ 2023-12-26 1:45 ` github-actions
2024-01-09 1:47 ` [PR PATCH] [Closed]: " github-actions
1 sibling, 0 replies; 3+ messages in thread
From: github-actions @ 2023-12-26 1:45 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 305 bytes --]
New comment by github-actions[bot] on void-packages repository
https://github.com/void-linux/void-packages/pull/46269#issuecomment-1869188335
Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PR PATCH] [Closed]: wpa_supplicant: log to stdout instead of syslog
2023-09-26 15:04 [PR PATCH] wpa_supplicant: log to stdout instead of syslog deepcube
2023-12-26 1:45 ` github-actions
@ 2024-01-09 1:47 ` github-actions
1 sibling, 0 replies; 3+ messages in thread
From: github-actions @ 2024-01-09 1:47 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 851 bytes --]
There's a closed pull request on the void-packages repository
wpa_supplicant: log to stdout instead of syslog
https://github.com/void-linux/void-packages/pull/46269
Description:
A long time ago the wpa_supplicant service was changed[0] to log to syslog by default instead of the stdout. This setting was carrier through a number of changes and persists to this day. As such, wpa_supplicant will not log via the log/run mechanism as expected by default.
Remove the -s flag from the default and auto options so wpa_supplicant logs to stdout (and hence log/run) as expected for runit services.
[0] 62ae6738b59 (wpa_supplicant: log to syslog by default)
#### Testing the changes
- I tested the changes in this PR: **YES**
#### Local build testing
- I built this PR locally for my native architectures, (x86_64-musl, armv6l-musl)
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-01-09 1:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-26 15:04 [PR PATCH] wpa_supplicant: log to stdout instead of syslog deepcube
2023-12-26 1:45 ` github-actions
2024-01-09 1:47 ` [PR PATCH] [Closed]: " github-actions
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).