* [PR PATCH] libwacom: add missing dep for -devel subpkg
@ 2024-01-13 21:41 chrysos349
2024-01-14 0:33 ` sgn
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: chrysos349 @ 2024-01-13 21:41 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1021 bytes --]
There is a new pull request by chrysos349 against master on the void-packages repository
https://github.com/chrysos349/void-packages libwacom
https://github.com/void-linux/void-packages/pull/48205
libwacom: add missing dep for -devel subpkg
`libwacom-devel-2.9.0` requires `libevdev-devel` as a dependency.
`mutter` which depends on `libwacom-devel` fails to build and spits out this error:
```
meson.build:284:17: ERROR: Dependency lookup for libwacom with method 'pkgconfig' failed: Could not generate cflags for libwacom:
Package libevdev was not found in the pkg-config search path.
Perhaps you should add the directory containing `libevdev.pc'
to the PKG_CONFIG_PATH environment variable
Package 'libevdev', required by 'libwacom', not found
```
#### Testing the changes
- I tested the changes in this PR: **YES**
#### Local build testing
- I built this PR locally for my native architecture, (x86_64)
A patch file from https://github.com/void-linux/void-packages/pull/48205.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-libwacom-48205.patch --]
[-- Type: text/x-diff, Size: 965 bytes --]
From 0ba59fc7f3cc1b1b851deaae877aaf4238bf431f Mon Sep 17 00:00:00 2001
From: chrysos349 <chrysostom349@gmail.com>
Date: Sun, 14 Jan 2024 00:37:19 +0300
Subject: [PATCH] libwacom: add missing dep for -devel subpkg
---
srcpkgs/libwacom/template | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/libwacom/template b/srcpkgs/libwacom/template
index ebe5df5f3997e..bed9da08525ce 100644
--- a/srcpkgs/libwacom/template
+++ b/srcpkgs/libwacom/template
@@ -1,7 +1,7 @@
# Template file for 'libwacom'
pkgname=libwacom
version=2.9.0
-revision=1
+revision=2
build_style=meson
configure_args="-Ddocumentation=disabled"
hostmakedepends="pkg-config"
@@ -26,7 +26,8 @@ post_install() {
}
libwacom-devel_package() {
- depends="libgudev-devel ${sourcepkg}>=${version}_${revision}"
+ depends="libgudev-devel ${sourcepkg}>=${version}_${revision}
+ libevdev-devel"
short_desc+=" - development files"
pkg_install() {
vmove usr/include
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: libwacom: add missing dep for -devel subpkg
2024-01-13 21:41 [PR PATCH] libwacom: add missing dep for -devel subpkg chrysos349
@ 2024-01-14 0:33 ` sgn
2024-01-14 0:36 ` [PR REVIEW] " sgn
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: sgn @ 2024-01-14 0:33 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 228 bytes --]
New comment by sgn on void-packages repository
https://github.com/void-linux/void-packages/pull/48205#issuecomment-1890807171
Comment:
This is wrong, libwacom only `Requires.private: gudev-1.0, glib-2.0, libevdev`. Hence, no.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PR REVIEW] libwacom: add missing dep for -devel subpkg
2024-01-13 21:41 [PR PATCH] libwacom: add missing dep for -devel subpkg chrysos349
2024-01-14 0:33 ` sgn
@ 2024-01-14 0:36 ` sgn
2024-01-14 0:44 ` sgn
2024-01-14 6:46 ` [PR PATCH] [Merged]: " sgn
3 siblings, 0 replies; 5+ messages in thread
From: sgn @ 2024-01-14 0:36 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 334 bytes --]
New review comment by sgn on void-packages repository
https://github.com/void-linux/void-packages/pull/48205#discussion_r1451632074
Comment:
```suggestion
depends="${sourcepkg}>=${version}_${revision}"
```
libwacom only `Requires.private: gudev-1.0, glib-2.0, libevdev` hence, it shouldn't depend on `libgudev-devel` either.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: libwacom: add missing dep for -devel subpkg
2024-01-13 21:41 [PR PATCH] libwacom: add missing dep for -devel subpkg chrysos349
2024-01-14 0:33 ` sgn
2024-01-14 0:36 ` [PR REVIEW] " sgn
@ 2024-01-14 0:44 ` sgn
2024-01-14 6:46 ` [PR PATCH] [Merged]: " sgn
3 siblings, 0 replies; 5+ messages in thread
From: sgn @ 2024-01-14 0:44 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 333 bytes --]
New comment by sgn on void-packages repository
https://github.com/void-linux/void-packages/pull/48205#issuecomment-1890808832
Comment:
Hm, may be I was wrong, `Requires.private: gudev-1.0, glib-2.0, libevdev` cause `pkg-config --cflags` failure if it's not exists.
I think in libwacom case, it should be `Libs.private` instead.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PR PATCH] [Merged]: libwacom: add missing dep for -devel subpkg
2024-01-13 21:41 [PR PATCH] libwacom: add missing dep for -devel subpkg chrysos349
` (2 preceding siblings ...)
2024-01-14 0:44 ` sgn
@ 2024-01-14 6:46 ` sgn
3 siblings, 0 replies; 5+ messages in thread
From: sgn @ 2024-01-14 6:46 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 863 bytes --]
There's a merged pull request on the void-packages repository
libwacom: add missing dep for -devel subpkg
https://github.com/void-linux/void-packages/pull/48205
Description:
`libwacom-devel-2.9.0` requires `libevdev-devel` as a dependency.
`mutter` which depends on `libwacom-devel` fails to build and spits out this error:
```
meson.build:284:17: ERROR: Dependency lookup for libwacom with method 'pkgconfig' failed: Could not generate cflags for libwacom:
Package libevdev was not found in the pkg-config search path.
Perhaps you should add the directory containing `libevdev.pc'
to the PKG_CONFIG_PATH environment variable
Package 'libevdev', required by 'libwacom', not found
```
#### Testing the changes
- I tested the changes in this PR: **YES**
#### Local build testing
- I built this PR locally for my native architecture, (x86_64)
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-01-14 6:46 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-13 21:41 [PR PATCH] libwacom: add missing dep for -devel subpkg chrysos349
2024-01-14 0:33 ` sgn
2024-01-14 0:36 ` [PR REVIEW] " sgn
2024-01-14 0:44 ` sgn
2024-01-14 6:46 ` [PR PATCH] [Merged]: " sgn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).