Github messages for voidlinux
 help / color / mirror / Atom feed
From: firasuke <firasuke@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [squashfs-tools]: do not create symlinks manually
Date: Mon, 15 Jan 2024 07:27:49 +0100	[thread overview]
Message-ID: <20240115062749.B3FFA2980B@inbox.vuxu.org> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-48214@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 391 bytes --]

New comment by firasuke on void-packages repository

https://github.com/void-linux/void-packages/pull/48214#issuecomment-1891381157

Comment:
> if that's the case, then your patch is wrong: you're just removing the symlinks from the package altogether

Ah I see, you were not using `make install` in the first place, and the manual binary installation should also be removed, makes sense.

      parent reply	other threads:[~2024-01-15  6:27 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-14 19:49 [PR PATCH] " firasuke
2024-01-14 23:50 ` classabbyamp
2024-01-15  4:52 ` firasuke
2024-01-15  5:31 ` classabbyamp
2024-01-15  5:32 ` [PR PATCH] [Closed]: " classabbyamp
2024-01-15  5:32 ` classabbyamp
2024-01-15  6:27 ` firasuke [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240115062749.B3FFA2980B@inbox.vuxu.org \
    --to=firasuke@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).