* [PR PATCH] [squashfs-tools]: do not create symlinks manually
@ 2024-01-14 19:49 firasuke
2024-01-14 23:50 ` classabbyamp
` (5 more replies)
0 siblings, 6 replies; 7+ messages in thread
From: firasuke @ 2024-01-14 19:49 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1318 bytes --]
There is a new pull request by firasuke against master on the void-packages repository
https://github.com/firasuke/void-packages patch-1
https://github.com/void-linux/void-packages/pull/48214
[squashfs-tools]: do not create symlinks manually
These symlinks are created automatically upon installation.
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **NO**
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/48214.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-1-48214.patch --]
[-- Type: text/x-diff, Size: 839 bytes --]
From 36386cc266c51a9e74c28398364830e66ea80f93 Mon Sep 17 00:00:00 2001
From: Firas Khalil Khana <firasuke@gmail.com>
Date: Sun, 14 Jan 2024 22:26:49 +0300
Subject: [PATCH] [squashfs-tools]: do not create symlinks manually
These symlinks are created automatically upon installation.
---
srcpkgs/squashfs-tools/template | 2 --
1 file changed, 2 deletions(-)
diff --git a/srcpkgs/squashfs-tools/template b/srcpkgs/squashfs-tools/template
index 98dee0a4a6a26..a8bc7e7f2a927 100644
--- a/srcpkgs/squashfs-tools/template
+++ b/srcpkgs/squashfs-tools/template
@@ -18,8 +18,6 @@ checksum=94201754b36121a9f022a190c75f718441df15402df32c2b520ca331a107511c
do_install() {
vbin mksquashfs
vbin unsquashfs
- ln -sf mksquashfs ${DESTDIR}/usr/bin/sqfstar
- ln -sf unsquashfs ${DESTDIR}/usr/bin/sqfscat
for f in ../manpages/*.1; do
vman $f
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [squashfs-tools]: do not create symlinks manually
2024-01-14 19:49 [PR PATCH] [squashfs-tools]: do not create symlinks manually firasuke
@ 2024-01-14 23:50 ` classabbyamp
2024-01-15 4:52 ` firasuke
` (4 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: classabbyamp @ 2024-01-14 23:50 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 209 bytes --]
New comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/48214#issuecomment-1891115769
Comment:
what do you mean by "created automatically upon installation"?
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [squashfs-tools]: do not create symlinks manually
2024-01-14 19:49 [PR PATCH] [squashfs-tools]: do not create symlinks manually firasuke
2024-01-14 23:50 ` classabbyamp
@ 2024-01-15 4:52 ` firasuke
2024-01-15 5:31 ` classabbyamp
` (3 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: firasuke @ 2024-01-15 4:52 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 266 bytes --]
New comment by firasuke on void-packages repository
https://github.com/void-linux/void-packages/pull/48214#issuecomment-1891299916
Comment:
`make install` should handle both binary installation and symlink creation, yet it seems you are doing manual installation.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [squashfs-tools]: do not create symlinks manually
2024-01-14 19:49 [PR PATCH] [squashfs-tools]: do not create symlinks manually firasuke
2024-01-14 23:50 ` classabbyamp
2024-01-15 4:52 ` firasuke
@ 2024-01-15 5:31 ` classabbyamp
2024-01-15 5:32 ` [PR PATCH] [Closed]: " classabbyamp
` (2 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: classabbyamp @ 2024-01-15 5:31 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 254 bytes --]
New comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/48214#issuecomment-1891327905
Comment:
if that's the case, then your patch is wrong: you're just removing the symlinks from the package altogether
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PR PATCH] [Closed]: [squashfs-tools]: do not create symlinks manually
2024-01-14 19:49 [PR PATCH] [squashfs-tools]: do not create symlinks manually firasuke
` (2 preceding siblings ...)
2024-01-15 5:31 ` classabbyamp
@ 2024-01-15 5:32 ` classabbyamp
2024-01-15 5:32 ` classabbyamp
2024-01-15 6:27 ` firasuke
5 siblings, 0 replies; 7+ messages in thread
From: classabbyamp @ 2024-01-15 5:32 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1165 bytes --]
There's a closed pull request on the void-packages repository
[squashfs-tools]: do not create symlinks manually
https://github.com/void-linux/void-packages/pull/48214
Description:
These symlinks are created automatically upon installation.
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **NO**
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [squashfs-tools]: do not create symlinks manually
2024-01-14 19:49 [PR PATCH] [squashfs-tools]: do not create symlinks manually firasuke
` (3 preceding siblings ...)
2024-01-15 5:32 ` [PR PATCH] [Closed]: " classabbyamp
@ 2024-01-15 5:32 ` classabbyamp
2024-01-15 6:27 ` firasuke
5 siblings, 0 replies; 7+ messages in thread
From: classabbyamp @ 2024-01-15 5:32 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 260 bytes --]
New comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/48214#issuecomment-1891328837
Comment:
https://github.com/void-linux/void-packages/commit/d29d187fda697d0c601aabeceb4ce8ebe87967db does it the right way
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [squashfs-tools]: do not create symlinks manually
2024-01-14 19:49 [PR PATCH] [squashfs-tools]: do not create symlinks manually firasuke
` (4 preceding siblings ...)
2024-01-15 5:32 ` classabbyamp
@ 2024-01-15 6:27 ` firasuke
5 siblings, 0 replies; 7+ messages in thread
From: firasuke @ 2024-01-15 6:27 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 391 bytes --]
New comment by firasuke on void-packages repository
https://github.com/void-linux/void-packages/pull/48214#issuecomment-1891381157
Comment:
> if that's the case, then your patch is wrong: you're just removing the symlinks from the package altogether
Ah I see, you were not using `make install` in the first place, and the manual binary installation should also be removed, makes sense.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2024-01-15 6:27 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-14 19:49 [PR PATCH] [squashfs-tools]: do not create symlinks manually firasuke
2024-01-14 23:50 ` classabbyamp
2024-01-15 4:52 ` firasuke
2024-01-15 5:31 ` classabbyamp
2024-01-15 5:32 ` [PR PATCH] [Closed]: " classabbyamp
2024-01-15 5:32 ` classabbyamp
2024-01-15 6:27 ` firasuke
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).