[PR PATCH] lcms2: disable plugins for now

[PR PATCH] lcms2: disable plugins for now

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 1878 bytes --]

There is a new pull request by oreo639 against master on the void-packages repository

https://github.com/oreo639/void-packages lmcs2
https://github.com/void-linux/void-packages/pull/48438

lcms2: disable plugins for now
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

Plugins were enabled in https://github.com/void-linux/void-packages/commit/b9b9189c8a7c6f2e8e600958dbc298b7c69c7417
The plugins get linked to applications (`dlopen()` is not used). However they were not added to `common/shlibs` causing packages to link against the plugins but error due to the shlibs not having an associated package.

The plugins don't have a soversion, however as this is inconsistent between configuring with autoconf vs meson, I assume this is a mistake, as such disable until the following is addressed: https://github.com/mm2/Little-CMS/issues/432

Fixes building gimp, Krita, libraw, etc.

cc: @sgn 

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/48438.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-lmcs2-48438.patch --]
[-- Type: text/x-diff, Size: 1072 bytes --]

From 2975c860961843a52da604d12a02dfb819dc23bc Mon Sep 17 00:00:00 2001
From: oreo639 <oreo6391@gmail.com>
Date: Mon, 29 Jan 2024 18:28:12 -0800
Subject: [PATCH] lcms2: disable plugins for now

---
 srcpkgs/lcms2/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/lcms2/template b/srcpkgs/lcms2/template
index 0116b8698b670..0806df5234561 100644
--- a/srcpkgs/lcms2/template
+++ b/srcpkgs/lcms2/template
@@ -1,7 +1,7 @@
 # Template file for 'lcms2'
 pkgname=lcms2
 version=2.16
-revision=1
+revision=2
 build_style=meson
 configure_args="-Dutils=true -Dsamples=true $(vopt_bool plugins fastfloat) $(vopt_bool plugins threaded)"
 hostmakedepends="pkg-config"
@@ -13,7 +13,7 @@ homepage="https://littlecms.com"
 distfiles="${SOURCEFORGE_SITE}/lcms/lcms2-${version}.tar.gz"
 checksum=d873d34ad8b9b4cea010631f1a6228d2087475e4dc5e763eb81acc23d9d45a51
 build_options="plugins"
-build_options_default="plugins"
+build_options_default=""
 desc_option_plugins="Build with threaded and fast float plugins (GPL-3.0-or-later)"
 
 post_install() {

Re: [PR PATCH] [Updated] lcms2: disable plugins for now

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 1885 bytes --]

There is an updated pull request by oreo639 against master on the void-packages repository

https://github.com/oreo639/void-packages lmcs2
https://github.com/void-linux/void-packages/pull/48438

lcms2: disable plugins for now
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

Plugins were enabled in https://github.com/void-linux/void-packages/commit/b9b9189c8a7c6f2e8e600958dbc298b7c69c7417
The plugins get linked to applications (`dlopen()` is not used). However they were not added to `common/shlibs` causing packages to link against the plugins but error due to the shlibs not having an associated package.

The plugins don't have a soversion, however, as this is inconsistent between configuring with autoconf vs meson, I assume this is a mistake. As such, disable until the following is addressed: https://github.com/mm2/Little-CMS/issues/432

Fixes building gimp, Krita, libraw, etc.

cc: @sgn 

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/48438.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-lmcs2-48438.patch --]
[-- Type: text/x-diff, Size: 1073 bytes --]

From c8aa91e3f23efdc5c5a6d03b9fd986619b52b610 Mon Sep 17 00:00:00 2001
From: oreo639 <oreo6391@gmail.com>
Date: Mon, 29 Jan 2024 18:28:12 -0800
Subject: [PATCH] lcms2: disable plugins for now

---
 srcpkgs/lcms2/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/lcms2/template b/srcpkgs/lcms2/template
index 0116b8698b670..2c74aa4f5ee4d 100644
--- a/srcpkgs/lcms2/template
+++ b/srcpkgs/lcms2/template
@@ -1,7 +1,7 @@
 # Template file for 'lcms2'
 pkgname=lcms2
 version=2.16
-revision=1
+revision=2
 build_style=meson
 configure_args="-Dutils=true -Dsamples=true $(vopt_bool plugins fastfloat) $(vopt_bool plugins threaded)"
 hostmakedepends="pkg-config"
@@ -13,7 +13,7 @@ homepage="https://littlecms.com"
 distfiles="${SOURCEFORGE_SITE}/lcms/lcms2-${version}.tar.gz"
 checksum=d873d34ad8b9b4cea010631f1a6228d2087475e4dc5e763eb81acc23d9d45a51
 build_options="plugins"
-build_options_default="plugins"
+build_options_default=" "
 desc_option_plugins="Build with threaded and fast float plugins (GPL-3.0-or-later)"
 
 post_install() {

Re: lcms2: disable plugins for now

[sgn]

[-- Attachment #1: Type: text/plain, Size: 229 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/48438#issuecomment-1915992614

Comment:
That's is fine at is. Not sure if it would work when we split the plugins into subpackages?

Re: lcms2: disable plugins for now

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 311 bytes --]

New comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/48438#issuecomment-1915999294

Comment:
> Not sure if it would work when we split the plugins into subpackages?

imo, probably best to wait for upstream's response regarding soversions before packaging them.

Re: lcms2: disable plugins for now

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 393 bytes --]

New comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/48438#issuecomment-1915999294

Comment:
> Not sure if it would work when we split the plugins into subpackages?

imo, probably best to wait for upstream's response regarding soversions before packaging them. (also they get added to the `lcms2.pc` file, so I'm not sure how that would work)

Re: lcms2: disable plugins for now

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 400 bytes --]

New comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/48438#issuecomment-1915999294

Comment:
> Not sure if it would work when we split the plugins into subpackages?

imo, probably best to wait for upstream's response regarding soversions before packaging them. (also the plugins get added to the `lcms2.pc` file, so I'm not sure how that would work)

Re: [PR PATCH] [Merged]: lcms2: disable plugins for now

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 1731 bytes --]

There's a merged pull request on the void-packages repository

lcms2: disable plugins for now
https://github.com/void-linux/void-packages/pull/48438

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

Plugins were enabled in https://github.com/void-linux/void-packages/commit/b9b9189c8a7c6f2e8e600958dbc298b7c69c7417
The plugins get linked to applications (`dlopen()` is not used). However they were not added to `common/shlibs` causing packages to link against the plugins but error due to the shlibs not having an associated package.

The plugins don't have a soversion, however, as this is inconsistent between configuring with autoconf vs meson, I assume this is a mistake. As such, disable until the following is addressed: https://github.com/mm2/Little-CMS/issues/432

Fixes building gimp, Krita, libraw, etc.

cc: @sgn 

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->