* [PR PATCH] android-file-transfer-linux: add libmtp to depends
@ 2023-11-24 21:57 dkwo
2023-11-25 16:37 ` biopsin
` (23 more replies)
0 siblings, 24 replies; 25+ messages in thread
From: dkwo @ 2023-11-24 21:57 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 442 bytes --]
There is a new pull request by dkwo against master on the void-packages repository
https://github.com/dkwo/void-packages aft
https://github.com/void-linux/void-packages/pull/47378
android-file-transfer-linux: add libmtp to depends
its own libmtp-ng.so does not do the job for me.
- I tested the changes in this PR: yes
cc @Vaelatern @biopsin
A patch file from https://github.com/void-linux/void-packages/pull/47378.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-aft-47378.patch --]
[-- Type: text/x-diff, Size: 1107 bytes --]
From 658c4fe10b76420e148f77091bdcc3a8500f18e4 Mon Sep 17 00:00:00 2001
From: dkwo <nicolopiazzalunga@gmail.com>
Date: Fri, 24 Nov 2023 16:55:28 -0500
Subject: [PATCH] android-file-transfer-linux: add libmtp to depends
its own libmtp-ng.so.4.2.0 does not do the job
---
srcpkgs/android-file-transfer-linux/template | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/android-file-transfer-linux/template b/srcpkgs/android-file-transfer-linux/template
index 4480fb0ab6692..39f6204348d54 100644
--- a/srcpkgs/android-file-transfer-linux/template
+++ b/srcpkgs/android-file-transfer-linux/template
@@ -1,12 +1,13 @@
# Template file for 'android-file-transfer-linux'
pkgname=android-file-transfer-linux
version=4.2
-revision=3
+revision=4
build_style=cmake
configure_args="-DBUILD_SHARED_LIB=1"
hostmakedepends="qt5-qmake qt5-host-tools ninja pkg-config"
makedepends="file-devel fuse-devel qt5-devel readline-devel
qt5-tools-devel"
+depends="libmtp"
short_desc="Android File Transfer for Linux"
maintainer="Toyam Cox <Vaelatern@voidlinux.org>"
license="LGPL-2.1-or-later"
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: android-file-transfer-linux: add libmtp to depends
2023-11-24 21:57 [PR PATCH] android-file-transfer-linux: add libmtp to depends dkwo
@ 2023-11-25 16:37 ` biopsin
2023-12-12 20:12 ` [PR PATCH] [Closed]: " dkwo
` (22 subsequent siblings)
23 siblings, 0 replies; 25+ messages in thread
From: biopsin @ 2023-11-25 16:37 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 380 bytes --]
New comment by biopsin on void-packages repository
https://github.com/void-linux/void-packages/pull/47378#issuecomment-1826372725
Comment:
@dkwo Im unable to test as I use other means to mount.
If adding libmtp as a dependancy and that works I would venture creating a extra libmtp symlink to -ng, however it makes conflicts with other packages. Question remains why the fork.
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: android-file-transfer-linux: add libmtp to depends
2023-11-24 21:57 [PR PATCH] android-file-transfer-linux: add libmtp to depends dkwo
2023-11-25 16:37 ` biopsin
2023-12-12 20:12 ` [PR PATCH] [Closed]: " dkwo
@ 2023-12-12 20:12 ` dkwo
2023-12-12 21:15 ` dkwo
` (20 subsequent siblings)
23 siblings, 0 replies; 25+ messages in thread
From: dkwo @ 2023-12-12 20:12 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 342 bytes --]
New comment by dkwo on void-packages repository
https://github.com/void-linux/void-packages/pull/47378#issuecomment-1852734293
Comment:
according to upstream https://github.com/whoozle/android-file-transfer-linux/issues/337
> No, AFTL has its own MTP implementation and does not use libmtp.
so my pr does not seem the right solution
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PR PATCH] [Closed]: android-file-transfer-linux: add libmtp to depends
2023-11-24 21:57 [PR PATCH] android-file-transfer-linux: add libmtp to depends dkwo
2023-11-25 16:37 ` biopsin
@ 2023-12-12 20:12 ` dkwo
2023-12-12 20:12 ` dkwo
` (21 subsequent siblings)
23 siblings, 0 replies; 25+ messages in thread
From: dkwo @ 2023-12-12 20:12 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 301 bytes --]
There's a closed pull request on the void-packages repository
android-file-transfer-linux: add libmtp to depends
https://github.com/void-linux/void-packages/pull/47378
Description:
its own libmtp-ng.so does not do the job for me.
- I tested the changes in this PR: yes
cc @Vaelatern @biopsin
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: android-file-transfer-linux: add libmtp to depends
2023-11-24 21:57 [PR PATCH] android-file-transfer-linux: add libmtp to depends dkwo
` (2 preceding siblings ...)
2023-12-12 20:12 ` dkwo
@ 2023-12-12 21:15 ` dkwo
2023-12-12 21:15 ` [PR PATCH] [Updated] " dkwo
` (19 subsequent siblings)
23 siblings, 0 replies; 25+ messages in thread
From: dkwo @ 2023-12-12 21:15 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 203 bytes --]
New comment by dkwo on void-packages repository
https://github.com/void-linux/void-packages/pull/47378#issuecomment-1852822489
Comment:
actually, it needs udev rules. how about splitting libmtp as so?
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PR PATCH] [Updated] android-file-transfer-linux: add libmtp to depends
2023-11-24 21:57 [PR PATCH] android-file-transfer-linux: add libmtp to depends dkwo
` (3 preceding siblings ...)
2023-12-12 21:15 ` dkwo
@ 2023-12-12 21:15 ` dkwo
2023-12-12 21:25 ` dkwo
` (18 subsequent siblings)
23 siblings, 0 replies; 25+ messages in thread
From: dkwo @ 2023-12-12 21:15 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 447 bytes --]
There is an updated pull request by dkwo against master on the void-packages repository
https://github.com/dkwo/void-packages aft
https://github.com/void-linux/void-packages/pull/47378
android-file-transfer-linux: add libmtp to depends
its own libmtp-ng.so does not do the job for me.
- I tested the changes in this PR: yes
cc @Vaelatern @biopsin
A patch file from https://github.com/void-linux/void-packages/pull/47378.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-aft-47378.patch --]
[-- Type: text/x-diff, Size: 2275 bytes --]
From 8690d3eba4af14cfd96110584d3e929e95917768 Mon Sep 17 00:00:00 2001
From: dkwo <nicolopiazzalunga@gmail.com>
Date: Fri, 24 Nov 2023 16:55:28 -0500
Subject: [PATCH 1/2] android-file-transfer-linux: add libmtp to depends
it ships libmtp-ng but no udev rules
---
srcpkgs/android-file-transfer-linux/template | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/android-file-transfer-linux/template b/srcpkgs/android-file-transfer-linux/template
index 4480fb0ab6692..39f6204348d54 100644
--- a/srcpkgs/android-file-transfer-linux/template
+++ b/srcpkgs/android-file-transfer-linux/template
@@ -1,12 +1,13 @@
# Template file for 'android-file-transfer-linux'
pkgname=android-file-transfer-linux
version=4.2
-revision=3
+revision=4
build_style=cmake
configure_args="-DBUILD_SHARED_LIB=1"
hostmakedepends="qt5-qmake qt5-host-tools ninja pkg-config"
makedepends="file-devel fuse-devel qt5-devel readline-devel
qt5-tools-devel"
+depends="libmtp"
short_desc="Android File Transfer for Linux"
maintainer="Toyam Cox <Vaelatern@voidlinux.org>"
license="LGPL-2.1-or-later"
From fdc0e49e7916ba71a181d04814cb4dcaf3b35a8c Mon Sep 17 00:00:00 2001
From: dkwo <nicolopiazzalunga@gmail.com>
Date: Tue, 12 Dec 2023 16:13:31 -0500
Subject: [PATCH 2/2] libmtp: split tools/examples
---
srcpkgs/libmtp/template | 10 +++++++++-
srcpkgs/mtp-tools | 1 +
2 files changed, 10 insertions(+), 1 deletion(-)
create mode 120000 srcpkgs/mtp-tools
diff --git a/srcpkgs/libmtp/template b/srcpkgs/libmtp/template
index 8f87793b08e4d..2a15d86b7cd7e 100644
--- a/srcpkgs/libmtp/template
+++ b/srcpkgs/libmtp/template
@@ -1,7 +1,7 @@
# Template file for 'libmtp'
pkgname=libmtp
version=1.1.21
-revision=1
+revision=2
build_style=gnu-configure
configure_args="--disable-static --with-udev=/usr/lib/udev
--with-udev-group=plugdev"
@@ -35,3 +35,11 @@ libmtp-devel_package() {
vmove "usr/lib/*.so"
}
}
+
+mtp-tools_package() {
+ depends="${sourcepkg}>=${version}_${revision}"
+ short_desc+=" - example tools"
+ pkg_install() {
+ vmove "usr/bin/*"
+ }
+}
diff --git a/srcpkgs/mtp-tools b/srcpkgs/mtp-tools
new file mode 120000
index 0000000000000..e966e1f9db2e5
--- /dev/null
+++ b/srcpkgs/mtp-tools
@@ -0,0 +1 @@
+libmtp
\ No newline at end of file
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PR PATCH] [Updated] android-file-transfer-linux: add libmtp to depends
2023-11-24 21:57 [PR PATCH] android-file-transfer-linux: add libmtp to depends dkwo
` (4 preceding siblings ...)
2023-12-12 21:15 ` [PR PATCH] [Updated] " dkwo
@ 2023-12-12 21:25 ` dkwo
2023-12-13 17:15 ` dkwo
` (17 subsequent siblings)
23 siblings, 0 replies; 25+ messages in thread
From: dkwo @ 2023-12-12 21:25 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 447 bytes --]
There is an updated pull request by dkwo against master on the void-packages repository
https://github.com/dkwo/void-packages aft
https://github.com/void-linux/void-packages/pull/47378
android-file-transfer-linux: add libmtp to depends
its own libmtp-ng.so does not do the job for me.
- I tested the changes in this PR: yes
cc @Vaelatern @biopsin
A patch file from https://github.com/void-linux/void-packages/pull/47378.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-aft-47378.patch --]
[-- Type: text/x-diff, Size: 2518 bytes --]
From cce38c509ac8f71fbd209d11d96748cb5500c712 Mon Sep 17 00:00:00 2001
From: dkwo <nicolopiazzalunga@gmail.com>
Date: Tue, 12 Dec 2023 16:13:31 -0500
Subject: [PATCH 1/2] libmtp: split tools/examples
---
srcpkgs/libmtp/template | 12 ++++++++++--
srcpkgs/mtp-tools | 1 +
2 files changed, 11 insertions(+), 2 deletions(-)
create mode 120000 srcpkgs/mtp-tools
diff --git a/srcpkgs/libmtp/template b/srcpkgs/libmtp/template
index 8f87793b08e4d..77c87ddb45342 100644
--- a/srcpkgs/libmtp/template
+++ b/srcpkgs/libmtp/template
@@ -1,7 +1,7 @@
# Template file for 'libmtp'
pkgname=libmtp
version=1.1.21
-revision=1
+revision=2
build_style=gnu-configure
configure_args="--disable-static --with-udev=/usr/lib/udev
--with-udev-group=plugdev"
@@ -17,7 +17,7 @@ checksum=c4ffa5ab8c8f48c91b0047f2e253c101c418d5696a5ed65c839922a4280872a7
if [ "$CROSS_BUILD" ]; then
# XXX needs host mtp-hotplug
- hostmakedepends+=" libmtp"
+ hostmakedepends+=" mtp-tools"
fi
pre_configure() {
@@ -35,3 +35,11 @@ libmtp-devel_package() {
vmove "usr/lib/*.so"
}
}
+
+mtp-tools_package() {
+ depends="${sourcepkg}>=${version}_${revision}"
+ short_desc+=" - example tools"
+ pkg_install() {
+ vmove "usr/bin/*"
+ }
+}
diff --git a/srcpkgs/mtp-tools b/srcpkgs/mtp-tools
new file mode 120000
index 0000000000000..e966e1f9db2e5
--- /dev/null
+++ b/srcpkgs/mtp-tools
@@ -0,0 +1 @@
+libmtp
\ No newline at end of file
From eb41d565a8348770a6dd7ecad249a23020464501 Mon Sep 17 00:00:00 2001
From: dkwo <nicolopiazzalunga@gmail.com>
Date: Fri, 24 Nov 2023 16:55:28 -0500
Subject: [PATCH 2/2] android-file-transfer-linux: add libmtp to depends
it ships libmtp-ng but no udev rules
---
srcpkgs/android-file-transfer-linux/template | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/android-file-transfer-linux/template b/srcpkgs/android-file-transfer-linux/template
index 4480fb0ab6692..39f6204348d54 100644
--- a/srcpkgs/android-file-transfer-linux/template
+++ b/srcpkgs/android-file-transfer-linux/template
@@ -1,12 +1,13 @@
# Template file for 'android-file-transfer-linux'
pkgname=android-file-transfer-linux
version=4.2
-revision=3
+revision=4
build_style=cmake
configure_args="-DBUILD_SHARED_LIB=1"
hostmakedepends="qt5-qmake qt5-host-tools ninja pkg-config"
makedepends="file-devel fuse-devel qt5-devel readline-devel
qt5-tools-devel"
+depends="libmtp"
short_desc="Android File Transfer for Linux"
maintainer="Toyam Cox <Vaelatern@voidlinux.org>"
license="LGPL-2.1-or-later"
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PR PATCH] [Updated] android-file-transfer-linux: add libmtp to depends
2023-11-24 21:57 [PR PATCH] android-file-transfer-linux: add libmtp to depends dkwo
` (5 preceding siblings ...)
2023-12-12 21:25 ` dkwo
@ 2023-12-13 17:15 ` dkwo
2023-12-14 15:43 ` dkwo
` (16 subsequent siblings)
23 siblings, 0 replies; 25+ messages in thread
From: dkwo @ 2023-12-13 17:15 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 395 bytes --]
There is an updated pull request by dkwo against master on the void-packages repository
https://github.com/dkwo/void-packages aft
https://github.com/void-linux/void-packages/pull/47378
android-file-transfer-linux: add libmtp to depends
it's missing udev rules
- I tested the changes in this PR: yes
A patch file from https://github.com/void-linux/void-packages/pull/47378.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-aft-47378.patch --]
[-- Type: text/x-diff, Size: 2864 bytes --]
From 56e3efd6113ecda9d074c167dd3d1215866cbaaf Mon Sep 17 00:00:00 2001
From: dkwo <nicolopiazzalunga@gmail.com>
Date: Tue, 12 Dec 2023 16:13:31 -0500
Subject: [PATCH 1/2] libmtp: split tools/examples
---
srcpkgs/libmtp/template | 12 ++++++++++--
srcpkgs/mtp-tools | 1 +
2 files changed, 11 insertions(+), 2 deletions(-)
create mode 120000 srcpkgs/mtp-tools
diff --git a/srcpkgs/libmtp/template b/srcpkgs/libmtp/template
index 8f87793b08e4d..77c87ddb45342 100644
--- a/srcpkgs/libmtp/template
+++ b/srcpkgs/libmtp/template
@@ -1,7 +1,7 @@
# Template file for 'libmtp'
pkgname=libmtp
version=1.1.21
-revision=1
+revision=2
build_style=gnu-configure
configure_args="--disable-static --with-udev=/usr/lib/udev
--with-udev-group=plugdev"
@@ -17,7 +17,7 @@ checksum=c4ffa5ab8c8f48c91b0047f2e253c101c418d5696a5ed65c839922a4280872a7
if [ "$CROSS_BUILD" ]; then
# XXX needs host mtp-hotplug
- hostmakedepends+=" libmtp"
+ hostmakedepends+=" mtp-tools"
fi
pre_configure() {
@@ -35,3 +35,11 @@ libmtp-devel_package() {
vmove "usr/lib/*.so"
}
}
+
+mtp-tools_package() {
+ depends="${sourcepkg}>=${version}_${revision}"
+ short_desc+=" - example tools"
+ pkg_install() {
+ vmove "usr/bin/*"
+ }
+}
diff --git a/srcpkgs/mtp-tools b/srcpkgs/mtp-tools
new file mode 120000
index 0000000000000..e966e1f9db2e5
--- /dev/null
+++ b/srcpkgs/mtp-tools
@@ -0,0 +1 @@
+libmtp
\ No newline at end of file
From f97150b9962c2bc8907f042cb97923622f72acdb Mon Sep 17 00:00:00 2001
From: dkwo <nicolopiazzalunga@gmail.com>
Date: Fri, 24 Nov 2023 16:55:28 -0500
Subject: [PATCH 2/2] android-file-transfer-linux: add libmtp to depends,
update to 4.3
it ships libmtp-ng but no udev rules
---
srcpkgs/android-file-transfer-linux/template | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/srcpkgs/android-file-transfer-linux/template b/srcpkgs/android-file-transfer-linux/template
index 4480fb0ab6692..77617200cc1b9 100644
--- a/srcpkgs/android-file-transfer-linux/template
+++ b/srcpkgs/android-file-transfer-linux/template
@@ -1,15 +1,16 @@
# Template file for 'android-file-transfer-linux'
pkgname=android-file-transfer-linux
-version=4.2
-revision=3
+version=4.3
+revision=1
build_style=cmake
configure_args="-DBUILD_SHARED_LIB=1"
hostmakedepends="qt5-qmake qt5-host-tools ninja pkg-config"
makedepends="file-devel fuse-devel qt5-devel readline-devel
qt5-tools-devel"
+depends="libmtp"
short_desc="Android File Transfer for Linux"
maintainer="Toyam Cox <Vaelatern@voidlinux.org>"
license="LGPL-2.1-or-later"
homepage="https://github.com/whoozle/android-file-transfer-linux"
distfiles="https://github.com/whoozle/android-file-transfer-linux/archive/v${version}.tar.gz"
-checksum=cc607d68e8a18273c9b56975a70a0e68fbdf9d5b903b2727a345a605ff48a19f
+checksum=8ff658630fc820a7ca0b70025aa47d235b7fb64f5cb6a72ca76a7acbf3435128
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PR PATCH] [Updated] android-file-transfer-linux: add libmtp to depends
2023-11-24 21:57 [PR PATCH] android-file-transfer-linux: add libmtp to depends dkwo
` (6 preceding siblings ...)
2023-12-13 17:15 ` dkwo
@ 2023-12-14 15:43 ` dkwo
2023-12-14 15:44 ` dkwo
` (15 subsequent siblings)
23 siblings, 0 replies; 25+ messages in thread
From: dkwo @ 2023-12-14 15:43 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 395 bytes --]
There is an updated pull request by dkwo against master on the void-packages repository
https://github.com/dkwo/void-packages aft
https://github.com/void-linux/void-packages/pull/47378
android-file-transfer-linux: add libmtp to depends
it's missing udev rules
- I tested the changes in this PR: yes
A patch file from https://github.com/void-linux/void-packages/pull/47378.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-aft-47378.patch --]
[-- Type: text/x-diff, Size: 3582 bytes --]
From 2e6e0eb0e73bf4b6554c34ccdf0e99cbdfa8ac58 Mon Sep 17 00:00:00 2001
From: dkwo <nicolopiazzalunga@gmail.com>
Date: Tue, 12 Dec 2023 16:13:31 -0500
Subject: [PATCH 1/2] libmtp: split tools/examples, udev rules
---
srcpkgs/libmtp-udev | 1 +
srcpkgs/libmtp/template | 21 +++++++++++++++++++--
srcpkgs/mtp-tools | 1 +
3 files changed, 21 insertions(+), 2 deletions(-)
create mode 120000 srcpkgs/libmtp-udev
create mode 120000 srcpkgs/mtp-tools
diff --git a/srcpkgs/libmtp-udev b/srcpkgs/libmtp-udev
new file mode 120000
index 0000000000000..e966e1f9db2e5
--- /dev/null
+++ b/srcpkgs/libmtp-udev
@@ -0,0 +1 @@
+libmtp
\ No newline at end of file
diff --git a/srcpkgs/libmtp/template b/srcpkgs/libmtp/template
index 8f87793b08e4d..f280d0869854c 100644
--- a/srcpkgs/libmtp/template
+++ b/srcpkgs/libmtp/template
@@ -1,12 +1,13 @@
# Template file for 'libmtp'
pkgname=libmtp
version=1.1.21
-revision=1
+revision=2
build_style=gnu-configure
configure_args="--disable-static --with-udev=/usr/lib/udev
--with-udev-group=plugdev"
hostmakedepends="pkg-config"
makedepends="libgcrypt-devel libusb-devel"
+depends="libmtp-udev"
short_desc="Library for Microsoft's Media Transfer Protocol (MTP)"
maintainer="Orphaned <orphan@voidlinux.org>"
license="LGPL-2.1-or-later"
@@ -17,7 +18,7 @@ checksum=c4ffa5ab8c8f48c91b0047f2e253c101c418d5696a5ed65c839922a4280872a7
if [ "$CROSS_BUILD" ]; then
# XXX needs host mtp-hotplug
- hostmakedepends+=" libmtp"
+ hostmakedepends+=" mtp-tools"
fi
pre_configure() {
@@ -35,3 +36,19 @@ libmtp-devel_package() {
vmove "usr/lib/*.so"
}
}
+
+libmtp-udev_package() {
+ short_desc+=" - udev rules"
+ pkg_install() {
+ vmove usr/lib/udev/hwdb.d/69-libmtp.hwdb
+ vmove usr/lib/udev/rules.d/69-libmtp.rules
+ }
+}
+
+mtp-tools_package() {
+ depends="${sourcepkg}>=${version}_${revision}"
+ short_desc+=" - example tools"
+ pkg_install() {
+ vmove "usr/bin/*"
+ }
+}
diff --git a/srcpkgs/mtp-tools b/srcpkgs/mtp-tools
new file mode 120000
index 0000000000000..e966e1f9db2e5
--- /dev/null
+++ b/srcpkgs/mtp-tools
@@ -0,0 +1 @@
+libmtp
\ No newline at end of file
From d96401df51e0e23d969eb8bbc84f5c948be76946 Mon Sep 17 00:00:00 2001
From: dkwo <nicolopiazzalunga@gmail.com>
Date: Fri, 24 Nov 2023 16:55:28 -0500
Subject: [PATCH 2/2] android-file-transfer-linux: add libmtp-udev to depends,
update to 4.3
it ships libmtp-ng but no udev rules
---
srcpkgs/android-file-transfer-linux/template | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/srcpkgs/android-file-transfer-linux/template b/srcpkgs/android-file-transfer-linux/template
index 4480fb0ab6692..430deb820282f 100644
--- a/srcpkgs/android-file-transfer-linux/template
+++ b/srcpkgs/android-file-transfer-linux/template
@@ -1,15 +1,16 @@
# Template file for 'android-file-transfer-linux'
pkgname=android-file-transfer-linux
-version=4.2
-revision=3
+version=4.3
+revision=1
build_style=cmake
configure_args="-DBUILD_SHARED_LIB=1"
hostmakedepends="qt5-qmake qt5-host-tools ninja pkg-config"
makedepends="file-devel fuse-devel qt5-devel readline-devel
qt5-tools-devel"
+depends="libmtp-udev"
short_desc="Android File Transfer for Linux"
maintainer="Toyam Cox <Vaelatern@voidlinux.org>"
license="LGPL-2.1-or-later"
homepage="https://github.com/whoozle/android-file-transfer-linux"
distfiles="https://github.com/whoozle/android-file-transfer-linux/archive/v${version}.tar.gz"
-checksum=cc607d68e8a18273c9b56975a70a0e68fbdf9d5b903b2727a345a605ff48a19f
+checksum=8ff658630fc820a7ca0b70025aa47d235b7fb64f5cb6a72ca76a7acbf3435128
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: android-file-transfer-linux: add libmtp to depends
2023-11-24 21:57 [PR PATCH] android-file-transfer-linux: add libmtp to depends dkwo
` (7 preceding siblings ...)
2023-12-14 15:43 ` dkwo
@ 2023-12-14 15:44 ` dkwo
2023-12-14 15:44 ` dkwo
` (14 subsequent siblings)
23 siblings, 0 replies; 25+ messages in thread
From: dkwo @ 2023-12-14 15:44 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 342 bytes --]
New comment by dkwo on void-packages repository
https://github.com/void-linux/void-packages/pull/47378#issuecomment-1852734293
Comment:
according to upstream https://github.com/whoozle/android-file-transfer-linux/issues/337
> No, AFTL has its own MTP implementation and does not use libmtp.
so my pr does not seem the right solution
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: android-file-transfer-linux: add libmtp to depends
2023-11-24 21:57 [PR PATCH] android-file-transfer-linux: add libmtp to depends dkwo
` (8 preceding siblings ...)
2023-12-14 15:44 ` dkwo
@ 2023-12-14 15:44 ` dkwo
2023-12-23 19:07 ` [PR PATCH] [Updated] android-file-transfer-linux: depend on libmtp-udev (newly split) dkwo
` (13 subsequent siblings)
23 siblings, 0 replies; 25+ messages in thread
From: dkwo @ 2023-12-14 15:44 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 203 bytes --]
New comment by dkwo on void-packages repository
https://github.com/void-linux/void-packages/pull/47378#issuecomment-1852822489
Comment:
actually, it needs udev rules. how about splitting libmtp as so?
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PR PATCH] [Updated] android-file-transfer-linux: depend on libmtp-udev (newly split)
2023-11-24 21:57 [PR PATCH] android-file-transfer-linux: add libmtp to depends dkwo
` (9 preceding siblings ...)
2023-12-14 15:44 ` dkwo
@ 2023-12-23 19:07 ` dkwo
2023-12-24 8:30 ` dkwo
` (12 subsequent siblings)
23 siblings, 0 replies; 25+ messages in thread
From: dkwo @ 2023-12-23 19:07 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 409 bytes --]
There is an updated pull request by dkwo against master on the void-packages repository
https://github.com/dkwo/void-packages aft
https://github.com/void-linux/void-packages/pull/47378
android-file-transfer-linux: depend on libmtp-udev (newly split)
it's missing udev rules
- I tested the changes in this PR: yes
A patch file from https://github.com/void-linux/void-packages/pull/47378.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-aft-47378.patch --]
[-- Type: text/x-diff, Size: 3582 bytes --]
From 7c35cec8cc0f3e51a859c86a854e6487b5cf845f Mon Sep 17 00:00:00 2001
From: dkwo <nicolopiazzalunga@gmail.com>
Date: Tue, 12 Dec 2023 16:13:31 -0500
Subject: [PATCH 1/2] libmtp: split tools/examples, udev rules
---
srcpkgs/libmtp-udev | 1 +
srcpkgs/libmtp/template | 21 +++++++++++++++++++--
srcpkgs/mtp-tools | 1 +
3 files changed, 21 insertions(+), 2 deletions(-)
create mode 120000 srcpkgs/libmtp-udev
create mode 120000 srcpkgs/mtp-tools
diff --git a/srcpkgs/libmtp-udev b/srcpkgs/libmtp-udev
new file mode 120000
index 0000000000000..e966e1f9db2e5
--- /dev/null
+++ b/srcpkgs/libmtp-udev
@@ -0,0 +1 @@
+libmtp
\ No newline at end of file
diff --git a/srcpkgs/libmtp/template b/srcpkgs/libmtp/template
index 8f87793b08e4d..f280d0869854c 100644
--- a/srcpkgs/libmtp/template
+++ b/srcpkgs/libmtp/template
@@ -1,12 +1,13 @@
# Template file for 'libmtp'
pkgname=libmtp
version=1.1.21
-revision=1
+revision=2
build_style=gnu-configure
configure_args="--disable-static --with-udev=/usr/lib/udev
--with-udev-group=plugdev"
hostmakedepends="pkg-config"
makedepends="libgcrypt-devel libusb-devel"
+depends="libmtp-udev"
short_desc="Library for Microsoft's Media Transfer Protocol (MTP)"
maintainer="Orphaned <orphan@voidlinux.org>"
license="LGPL-2.1-or-later"
@@ -17,7 +18,7 @@ checksum=c4ffa5ab8c8f48c91b0047f2e253c101c418d5696a5ed65c839922a4280872a7
if [ "$CROSS_BUILD" ]; then
# XXX needs host mtp-hotplug
- hostmakedepends+=" libmtp"
+ hostmakedepends+=" mtp-tools"
fi
pre_configure() {
@@ -35,3 +36,19 @@ libmtp-devel_package() {
vmove "usr/lib/*.so"
}
}
+
+libmtp-udev_package() {
+ short_desc+=" - udev rules"
+ pkg_install() {
+ vmove usr/lib/udev/hwdb.d/69-libmtp.hwdb
+ vmove usr/lib/udev/rules.d/69-libmtp.rules
+ }
+}
+
+mtp-tools_package() {
+ depends="${sourcepkg}>=${version}_${revision}"
+ short_desc+=" - example tools"
+ pkg_install() {
+ vmove "usr/bin/*"
+ }
+}
diff --git a/srcpkgs/mtp-tools b/srcpkgs/mtp-tools
new file mode 120000
index 0000000000000..e966e1f9db2e5
--- /dev/null
+++ b/srcpkgs/mtp-tools
@@ -0,0 +1 @@
+libmtp
\ No newline at end of file
From c0e6db586cd90d5ffa9b3aa195312f59b56db612 Mon Sep 17 00:00:00 2001
From: dkwo <nicolopiazzalunga@gmail.com>
Date: Fri, 24 Nov 2023 16:55:28 -0500
Subject: [PATCH 2/2] android-file-transfer-linux: add libmtp-udev to depends,
update to 4.3
it ships libmtp-ng but no udev rules
---
srcpkgs/android-file-transfer-linux/template | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/srcpkgs/android-file-transfer-linux/template b/srcpkgs/android-file-transfer-linux/template
index 4480fb0ab6692..430deb820282f 100644
--- a/srcpkgs/android-file-transfer-linux/template
+++ b/srcpkgs/android-file-transfer-linux/template
@@ -1,15 +1,16 @@
# Template file for 'android-file-transfer-linux'
pkgname=android-file-transfer-linux
-version=4.2
-revision=3
+version=4.3
+revision=1
build_style=cmake
configure_args="-DBUILD_SHARED_LIB=1"
hostmakedepends="qt5-qmake qt5-host-tools ninja pkg-config"
makedepends="file-devel fuse-devel qt5-devel readline-devel
qt5-tools-devel"
+depends="libmtp-udev"
short_desc="Android File Transfer for Linux"
maintainer="Toyam Cox <Vaelatern@voidlinux.org>"
license="LGPL-2.1-or-later"
homepage="https://github.com/whoozle/android-file-transfer-linux"
distfiles="https://github.com/whoozle/android-file-transfer-linux/archive/v${version}.tar.gz"
-checksum=cc607d68e8a18273c9b56975a70a0e68fbdf9d5b903b2727a345a605ff48a19f
+checksum=8ff658630fc820a7ca0b70025aa47d235b7fb64f5cb6a72ca76a7acbf3435128
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PR PATCH] [Updated] android-file-transfer-linux: depend on libmtp-udev (newly split)
2023-11-24 21:57 [PR PATCH] android-file-transfer-linux: add libmtp to depends dkwo
` (10 preceding siblings ...)
2023-12-23 19:07 ` [PR PATCH] [Updated] android-file-transfer-linux: depend on libmtp-udev (newly split) dkwo
@ 2023-12-24 8:30 ` dkwo
2023-12-24 20:15 ` dkwo
` (11 subsequent siblings)
23 siblings, 0 replies; 25+ messages in thread
From: dkwo @ 2023-12-24 8:30 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 409 bytes --]
There is an updated pull request by dkwo against master on the void-packages repository
https://github.com/dkwo/void-packages aft
https://github.com/void-linux/void-packages/pull/47378
android-file-transfer-linux: depend on libmtp-udev (newly split)
it's missing udev rules
- I tested the changes in this PR: yes
A patch file from https://github.com/void-linux/void-packages/pull/47378.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-aft-47378.patch --]
[-- Type: text/x-diff, Size: 3661 bytes --]
From ab83f9798300a2853c669f324ba3c1f232d02d60 Mon Sep 17 00:00:00 2001
From: dkwo <nicolopiazzalunga@gmail.com>
Date: Tue, 12 Dec 2023 16:13:31 -0500
Subject: [PATCH 1/2] libmtp: split tools/examples, udev rules
---
srcpkgs/libmtp-udev | 1 +
srcpkgs/libmtp/template | 23 +++++++++++++++++++++--
srcpkgs/mtp-tools | 1 +
3 files changed, 23 insertions(+), 2 deletions(-)
create mode 120000 srcpkgs/libmtp-udev
create mode 120000 srcpkgs/mtp-tools
diff --git a/srcpkgs/libmtp-udev b/srcpkgs/libmtp-udev
new file mode 120000
index 0000000000000..e966e1f9db2e5
--- /dev/null
+++ b/srcpkgs/libmtp-udev
@@ -0,0 +1 @@
+libmtp
\ No newline at end of file
diff --git a/srcpkgs/libmtp/template b/srcpkgs/libmtp/template
index 8f87793b08e4d..ad03a6bd5dfee 100644
--- a/srcpkgs/libmtp/template
+++ b/srcpkgs/libmtp/template
@@ -1,12 +1,13 @@
# Template file for 'libmtp'
pkgname=libmtp
version=1.1.21
-revision=1
+revision=2
build_style=gnu-configure
configure_args="--disable-static --with-udev=/usr/lib/udev
--with-udev-group=plugdev"
hostmakedepends="pkg-config"
makedepends="libgcrypt-devel libusb-devel"
+depends="libmtp-udev"
short_desc="Library for Microsoft's Media Transfer Protocol (MTP)"
maintainer="Orphaned <orphan@voidlinux.org>"
license="LGPL-2.1-or-later"
@@ -17,7 +18,7 @@ checksum=c4ffa5ab8c8f48c91b0047f2e253c101c418d5696a5ed65c839922a4280872a7
if [ "$CROSS_BUILD" ]; then
# XXX needs host mtp-hotplug
- hostmakedepends+=" libmtp"
+ hostmakedepends+=" mtp-tools"
fi
pre_configure() {
@@ -35,3 +36,21 @@ libmtp-devel_package() {
vmove "usr/lib/*.so"
}
}
+
+libmtp-udev_package() {
+ short_desc+=" - udev rules"
+ pkg_install() {
+ vmove usr/lib/udev/hwdb.d/69-libmtp.hwdb
+ vmove usr/lib/udev/rules.d/69-libmtp.rules
+ # this is hardcoded within the above rule
+ vmove usr/lib/udev/mtp-probe
+ }
+}
+
+mtp-tools_package() {
+ depends="${sourcepkg}>=${version}_${revision}"
+ short_desc+=" - example tools"
+ pkg_install() {
+ vmove "usr/bin/*"
+ }
+}
diff --git a/srcpkgs/mtp-tools b/srcpkgs/mtp-tools
new file mode 120000
index 0000000000000..e966e1f9db2e5
--- /dev/null
+++ b/srcpkgs/mtp-tools
@@ -0,0 +1 @@
+libmtp
\ No newline at end of file
From b07f40abf7b4c8df07f17f21301812ed42c84b23 Mon Sep 17 00:00:00 2001
From: dkwo <nicolopiazzalunga@gmail.com>
Date: Fri, 24 Nov 2023 16:55:28 -0500
Subject: [PATCH 2/2] android-file-transfer-linux: add libmtp-udev to depends,
update to 4.3
it ships libmtp-ng but no udev rules
---
srcpkgs/android-file-transfer-linux/template | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/srcpkgs/android-file-transfer-linux/template b/srcpkgs/android-file-transfer-linux/template
index 4480fb0ab6692..430deb820282f 100644
--- a/srcpkgs/android-file-transfer-linux/template
+++ b/srcpkgs/android-file-transfer-linux/template
@@ -1,15 +1,16 @@
# Template file for 'android-file-transfer-linux'
pkgname=android-file-transfer-linux
-version=4.2
-revision=3
+version=4.3
+revision=1
build_style=cmake
configure_args="-DBUILD_SHARED_LIB=1"
hostmakedepends="qt5-qmake qt5-host-tools ninja pkg-config"
makedepends="file-devel fuse-devel qt5-devel readline-devel
qt5-tools-devel"
+depends="libmtp-udev"
short_desc="Android File Transfer for Linux"
maintainer="Toyam Cox <Vaelatern@voidlinux.org>"
license="LGPL-2.1-or-later"
homepage="https://github.com/whoozle/android-file-transfer-linux"
distfiles="https://github.com/whoozle/android-file-transfer-linux/archive/v${version}.tar.gz"
-checksum=cc607d68e8a18273c9b56975a70a0e68fbdf9d5b903b2727a345a605ff48a19f
+checksum=8ff658630fc820a7ca0b70025aa47d235b7fb64f5cb6a72ca76a7acbf3435128
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PR PATCH] [Updated] android-file-transfer-linux: depend on libmtp-udev (newly split)
2023-11-24 21:57 [PR PATCH] android-file-transfer-linux: add libmtp to depends dkwo
` (11 preceding siblings ...)
2023-12-24 8:30 ` dkwo
@ 2023-12-24 20:15 ` dkwo
2023-12-26 18:00 ` dkwo
` (10 subsequent siblings)
23 siblings, 0 replies; 25+ messages in thread
From: dkwo @ 2023-12-24 20:15 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 409 bytes --]
There is an updated pull request by dkwo against master on the void-packages repository
https://github.com/dkwo/void-packages aft
https://github.com/void-linux/void-packages/pull/47378
android-file-transfer-linux: depend on libmtp-udev (newly split)
it's missing udev rules
- I tested the changes in this PR: yes
A patch file from https://github.com/void-linux/void-packages/pull/47378.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-aft-47378.patch --]
[-- Type: text/x-diff, Size: 2976 bytes --]
From 0802e946a3594d63ec18f97dee36812da5fb634a Mon Sep 17 00:00:00 2001
From: dkwo <nicolopiazzalunga@gmail.com>
Date: Tue, 12 Dec 2023 16:13:31 -0500
Subject: [PATCH 1/2] libmtp: split udev rules
---
srcpkgs/libmtp-udev | 1 +
srcpkgs/libmtp/template | 13 ++++++++++++-
2 files changed, 13 insertions(+), 1 deletion(-)
create mode 120000 srcpkgs/libmtp-udev
diff --git a/srcpkgs/libmtp-udev b/srcpkgs/libmtp-udev
new file mode 120000
index 0000000000000..e966e1f9db2e5
--- /dev/null
+++ b/srcpkgs/libmtp-udev
@@ -0,0 +1 @@
+libmtp
\ No newline at end of file
diff --git a/srcpkgs/libmtp/template b/srcpkgs/libmtp/template
index 8f87793b08e4d..f240a0ab3cc43 100644
--- a/srcpkgs/libmtp/template
+++ b/srcpkgs/libmtp/template
@@ -1,12 +1,13 @@
# Template file for 'libmtp'
pkgname=libmtp
version=1.1.21
-revision=1
+revision=2
build_style=gnu-configure
configure_args="--disable-static --with-udev=/usr/lib/udev
--with-udev-group=plugdev"
hostmakedepends="pkg-config"
makedepends="libgcrypt-devel libusb-devel"
+depends="libmtp-udev"
short_desc="Library for Microsoft's Media Transfer Protocol (MTP)"
maintainer="Orphaned <orphan@voidlinux.org>"
license="LGPL-2.1-or-later"
@@ -35,3 +36,13 @@ libmtp-devel_package() {
vmove "usr/lib/*.so"
}
}
+
+libmtp-udev_package() {
+ short_desc+=" - udev rules"
+ pkg_install() {
+ vmove usr/lib/udev/hwdb.d/69-libmtp.hwdb
+ vmove usr/lib/udev/rules.d/69-libmtp.rules
+ # this is hardcoded within the above rule
+ vmove usr/lib/udev/mtp-probe
+ }
+}
From df755d060e9db7c03787296d903a69e78b462c2a Mon Sep 17 00:00:00 2001
From: dkwo <nicolopiazzalunga@gmail.com>
Date: Fri, 24 Nov 2023 16:55:28 -0500
Subject: [PATCH 2/2] android-file-transfer-linux: add libmtp-udev to depends,
update to 4.3
it ships libmtp-ng but no udev rules
---
srcpkgs/android-file-transfer-linux/template | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/srcpkgs/android-file-transfer-linux/template b/srcpkgs/android-file-transfer-linux/template
index 4480fb0ab6692..430deb820282f 100644
--- a/srcpkgs/android-file-transfer-linux/template
+++ b/srcpkgs/android-file-transfer-linux/template
@@ -1,15 +1,16 @@
# Template file for 'android-file-transfer-linux'
pkgname=android-file-transfer-linux
-version=4.2
-revision=3
+version=4.3
+revision=1
build_style=cmake
configure_args="-DBUILD_SHARED_LIB=1"
hostmakedepends="qt5-qmake qt5-host-tools ninja pkg-config"
makedepends="file-devel fuse-devel qt5-devel readline-devel
qt5-tools-devel"
+depends="libmtp-udev"
short_desc="Android File Transfer for Linux"
maintainer="Toyam Cox <Vaelatern@voidlinux.org>"
license="LGPL-2.1-or-later"
homepage="https://github.com/whoozle/android-file-transfer-linux"
distfiles="https://github.com/whoozle/android-file-transfer-linux/archive/v${version}.tar.gz"
-checksum=cc607d68e8a18273c9b56975a70a0e68fbdf9d5b903b2727a345a605ff48a19f
+checksum=8ff658630fc820a7ca0b70025aa47d235b7fb64f5cb6a72ca76a7acbf3435128
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PR PATCH] [Updated] android-file-transfer-linux: depend on libmtp-udev (newly split)
2023-11-24 21:57 [PR PATCH] android-file-transfer-linux: add libmtp to depends dkwo
` (12 preceding siblings ...)
2023-12-24 20:15 ` dkwo
@ 2023-12-26 18:00 ` dkwo
2023-12-27 16:22 ` dkwo
` (9 subsequent siblings)
23 siblings, 0 replies; 25+ messages in thread
From: dkwo @ 2023-12-26 18:00 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 409 bytes --]
There is an updated pull request by dkwo against master on the void-packages repository
https://github.com/dkwo/void-packages aft
https://github.com/void-linux/void-packages/pull/47378
android-file-transfer-linux: depend on libmtp-udev (newly split)
it's missing udev rules
- I tested the changes in this PR: yes
A patch file from https://github.com/void-linux/void-packages/pull/47378.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-aft-47378.patch --]
[-- Type: text/x-diff, Size: 3004 bytes --]
From b51857995f5232256182e6cd2582678d4efdfdc2 Mon Sep 17 00:00:00 2001
From: dkwo <nicolopiazzalunga@gmail.com>
Date: Tue, 12 Dec 2023 16:13:31 -0500
Subject: [PATCH 1/2] libmtp: split udev rules
---
srcpkgs/libmtp-udev | 1 +
srcpkgs/libmtp/template | 13 ++++++++++++-
2 files changed, 13 insertions(+), 1 deletion(-)
create mode 120000 srcpkgs/libmtp-udev
diff --git a/srcpkgs/libmtp-udev b/srcpkgs/libmtp-udev
new file mode 120000
index 0000000000000..e966e1f9db2e5
--- /dev/null
+++ b/srcpkgs/libmtp-udev
@@ -0,0 +1 @@
+libmtp
\ No newline at end of file
diff --git a/srcpkgs/libmtp/template b/srcpkgs/libmtp/template
index 8f87793b08e4d..f240a0ab3cc43 100644
--- a/srcpkgs/libmtp/template
+++ b/srcpkgs/libmtp/template
@@ -1,12 +1,13 @@
# Template file for 'libmtp'
pkgname=libmtp
version=1.1.21
-revision=1
+revision=2
build_style=gnu-configure
configure_args="--disable-static --with-udev=/usr/lib/udev
--with-udev-group=plugdev"
hostmakedepends="pkg-config"
makedepends="libgcrypt-devel libusb-devel"
+depends="libmtp-udev"
short_desc="Library for Microsoft's Media Transfer Protocol (MTP)"
maintainer="Orphaned <orphan@voidlinux.org>"
license="LGPL-2.1-or-later"
@@ -35,3 +36,13 @@ libmtp-devel_package() {
vmove "usr/lib/*.so"
}
}
+
+libmtp-udev_package() {
+ short_desc+=" - udev rules"
+ pkg_install() {
+ vmove usr/lib/udev/hwdb.d/69-libmtp.hwdb
+ vmove usr/lib/udev/rules.d/69-libmtp.rules
+ # this is hardcoded within the above rule
+ vmove usr/lib/udev/mtp-probe
+ }
+}
From c73e3ea6772ad520c9418f1a3918b0f6c0072432 Mon Sep 17 00:00:00 2001
From: dkwo <nicolopiazzalunga@gmail.com>
Date: Fri, 24 Nov 2023 16:55:28 -0500
Subject: [PATCH 2/2] android-file-transfer-linux: add libmtp-udev to depends,
update to 4.3
it ships libmtp-ng but no udev rules
---
srcpkgs/android-file-transfer-linux/template | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/srcpkgs/android-file-transfer-linux/template b/srcpkgs/android-file-transfer-linux/template
index d223ff0ee2aab..e245dbd02b178 100644
--- a/srcpkgs/android-file-transfer-linux/template
+++ b/srcpkgs/android-file-transfer-linux/template
@@ -1,16 +1,16 @@
# Template file for 'android-file-transfer-linux'
pkgname=android-file-transfer-linux
-version=4.2
-revision=4
+version=4.3
+revision=1
build_style=cmake
configure_args="-DBUILD_SHARED_LIB=1"
hostmakedepends="qt5-qmake qt5-host-tools ninja pkg-config"
makedepends="file-devel fuse-devel qt5-devel readline-devel
qt5-tools-devel"
-depends="qt5-svg"
+depends="libmtp-udev qt5-svg"
short_desc="Android File Transfer for Linux"
maintainer="Toyam Cox <Vaelatern@voidlinux.org>"
license="LGPL-2.1-or-later"
homepage="https://github.com/whoozle/android-file-transfer-linux"
distfiles="https://github.com/whoozle/android-file-transfer-linux/archive/v${version}.tar.gz"
-checksum=cc607d68e8a18273c9b56975a70a0e68fbdf9d5b903b2727a345a605ff48a19f
+checksum=8ff658630fc820a7ca0b70025aa47d235b7fb64f5cb6a72ca76a7acbf3435128
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PR PATCH] [Updated] android-file-transfer-linux: depend on libmtp-udev (newly split)
2023-11-24 21:57 [PR PATCH] android-file-transfer-linux: add libmtp to depends dkwo
` (13 preceding siblings ...)
2023-12-26 18:00 ` dkwo
@ 2023-12-27 16:22 ` dkwo
2024-01-16 22:46 ` dkwo
` (8 subsequent siblings)
23 siblings, 0 replies; 25+ messages in thread
From: dkwo @ 2023-12-27 16:22 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 409 bytes --]
There is an updated pull request by dkwo against master on the void-packages repository
https://github.com/dkwo/void-packages aft
https://github.com/void-linux/void-packages/pull/47378
android-file-transfer-linux: depend on libmtp-udev (newly split)
it's missing udev rules
- I tested the changes in this PR: yes
A patch file from https://github.com/void-linux/void-packages/pull/47378.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-aft-47378.patch --]
[-- Type: text/x-diff, Size: 3004 bytes --]
From a711957c4b03e40e04ea01195528700bcc5467de Mon Sep 17 00:00:00 2001
From: dkwo <nicolopiazzalunga@gmail.com>
Date: Tue, 12 Dec 2023 16:13:31 -0500
Subject: [PATCH 1/2] libmtp: split udev rules
---
srcpkgs/libmtp-udev | 1 +
srcpkgs/libmtp/template | 13 ++++++++++++-
2 files changed, 13 insertions(+), 1 deletion(-)
create mode 120000 srcpkgs/libmtp-udev
diff --git a/srcpkgs/libmtp-udev b/srcpkgs/libmtp-udev
new file mode 120000
index 0000000000000..e966e1f9db2e5
--- /dev/null
+++ b/srcpkgs/libmtp-udev
@@ -0,0 +1 @@
+libmtp
\ No newline at end of file
diff --git a/srcpkgs/libmtp/template b/srcpkgs/libmtp/template
index 8f87793b08e4d..f240a0ab3cc43 100644
--- a/srcpkgs/libmtp/template
+++ b/srcpkgs/libmtp/template
@@ -1,12 +1,13 @@
# Template file for 'libmtp'
pkgname=libmtp
version=1.1.21
-revision=1
+revision=2
build_style=gnu-configure
configure_args="--disable-static --with-udev=/usr/lib/udev
--with-udev-group=plugdev"
hostmakedepends="pkg-config"
makedepends="libgcrypt-devel libusb-devel"
+depends="libmtp-udev"
short_desc="Library for Microsoft's Media Transfer Protocol (MTP)"
maintainer="Orphaned <orphan@voidlinux.org>"
license="LGPL-2.1-or-later"
@@ -35,3 +36,13 @@ libmtp-devel_package() {
vmove "usr/lib/*.so"
}
}
+
+libmtp-udev_package() {
+ short_desc+=" - udev rules"
+ pkg_install() {
+ vmove usr/lib/udev/hwdb.d/69-libmtp.hwdb
+ vmove usr/lib/udev/rules.d/69-libmtp.rules
+ # this is hardcoded within the above rule
+ vmove usr/lib/udev/mtp-probe
+ }
+}
From 33b5f4f1b6699533797c43499d7ff984dc38babd Mon Sep 17 00:00:00 2001
From: dkwo <nicolopiazzalunga@gmail.com>
Date: Fri, 24 Nov 2023 16:55:28 -0500
Subject: [PATCH 2/2] android-file-transfer-linux: add libmtp-udev to depends,
update to 4.3
it ships libmtp-ng but no udev rules
---
srcpkgs/android-file-transfer-linux/template | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/srcpkgs/android-file-transfer-linux/template b/srcpkgs/android-file-transfer-linux/template
index d223ff0ee2aab..e245dbd02b178 100644
--- a/srcpkgs/android-file-transfer-linux/template
+++ b/srcpkgs/android-file-transfer-linux/template
@@ -1,16 +1,16 @@
# Template file for 'android-file-transfer-linux'
pkgname=android-file-transfer-linux
-version=4.2
-revision=4
+version=4.3
+revision=1
build_style=cmake
configure_args="-DBUILD_SHARED_LIB=1"
hostmakedepends="qt5-qmake qt5-host-tools ninja pkg-config"
makedepends="file-devel fuse-devel qt5-devel readline-devel
qt5-tools-devel"
-depends="qt5-svg"
+depends="libmtp-udev qt5-svg"
short_desc="Android File Transfer for Linux"
maintainer="Toyam Cox <Vaelatern@voidlinux.org>"
license="LGPL-2.1-or-later"
homepage="https://github.com/whoozle/android-file-transfer-linux"
distfiles="https://github.com/whoozle/android-file-transfer-linux/archive/v${version}.tar.gz"
-checksum=cc607d68e8a18273c9b56975a70a0e68fbdf9d5b903b2727a345a605ff48a19f
+checksum=8ff658630fc820a7ca0b70025aa47d235b7fb64f5cb6a72ca76a7acbf3435128
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: android-file-transfer-linux: depend on libmtp-udev (newly split)
2023-11-24 21:57 [PR PATCH] android-file-transfer-linux: add libmtp to depends dkwo
` (14 preceding siblings ...)
2023-12-27 16:22 ` dkwo
@ 2024-01-16 22:46 ` dkwo
2024-01-16 23:33 ` tornaria
` (7 subsequent siblings)
23 siblings, 0 replies; 25+ messages in thread
From: dkwo @ 2024-01-16 22:46 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 175 bytes --]
New comment by dkwo on void-packages repository
https://github.com/void-linux/void-packages/pull/47378#issuecomment-1894642402
Comment:
@tornaria does it make sense to you?
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: android-file-transfer-linux: depend on libmtp-udev (newly split)
2023-11-24 21:57 [PR PATCH] android-file-transfer-linux: add libmtp to depends dkwo
` (15 preceding siblings ...)
2024-01-16 22:46 ` dkwo
@ 2024-01-16 23:33 ` tornaria
2024-01-16 23:55 ` dkwo
` (6 subsequent siblings)
23 siblings, 0 replies; 25+ messages in thread
From: tornaria @ 2024-01-16 23:33 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 174 bytes --]
New comment by tornaria on void-packages repository
https://github.com/void-linux/void-packages/pull/47378#issuecomment-1894687103
Comment:
What is this supposed to solve?
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: android-file-transfer-linux: depend on libmtp-udev (newly split)
2023-11-24 21:57 [PR PATCH] android-file-transfer-linux: add libmtp to depends dkwo
` (16 preceding siblings ...)
2024-01-16 23:33 ` tornaria
@ 2024-01-16 23:55 ` dkwo
2024-01-17 0:31 ` tornaria
` (5 subsequent siblings)
23 siblings, 0 replies; 25+ messages in thread
From: dkwo @ 2024-01-16 23:55 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 460 bytes --]
New comment by dkwo on void-packages repository
https://github.com/void-linux/void-packages/pull/47378#issuecomment-1894704509
Comment:
libmtp also ships some udev rules that are useful to other packages using MTP, e.g. android-file-transfer.
we split those in a subpackage, and make aft depend on it.
without this, one cannot use e.g. aft-mtp-mount (not even after installing android-udev-rules).
with this, it is enough to be a member of plugdev group.
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: android-file-transfer-linux: depend on libmtp-udev (newly split)
2023-11-24 21:57 [PR PATCH] android-file-transfer-linux: add libmtp to depends dkwo
` (17 preceding siblings ...)
2024-01-16 23:55 ` dkwo
@ 2024-01-17 0:31 ` tornaria
2024-01-31 21:20 ` dkwo
` (4 subsequent siblings)
23 siblings, 0 replies; 25+ messages in thread
From: tornaria @ 2024-01-17 0:31 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 258 bytes --]
New comment by tornaria on void-packages repository
https://github.com/void-linux/void-packages/pull/47378#issuecomment-1894737507
Comment:
I see. Your solution seems reasonable.
A simple workaround meanwhile is to install `libmtp` when one needs this.
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: android-file-transfer-linux: depend on libmtp-udev (newly split)
2023-11-24 21:57 [PR PATCH] android-file-transfer-linux: add libmtp to depends dkwo
` (18 preceding siblings ...)
2024-01-17 0:31 ` tornaria
@ 2024-01-31 21:20 ` dkwo
2024-02-01 0:36 ` Duncaen
` (3 subsequent siblings)
23 siblings, 0 replies; 25+ messages in thread
From: dkwo @ 2024-01-31 21:20 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 188 bytes --]
New comment by dkwo on void-packages repository
https://github.com/void-linux/void-packages/pull/47378#issuecomment-1919988764
Comment:
@leahneukirchen Can you look at this one as well?
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: android-file-transfer-linux: depend on libmtp-udev (newly split)
2023-11-24 21:57 [PR PATCH] android-file-transfer-linux: add libmtp to depends dkwo
` (19 preceding siblings ...)
2024-01-31 21:20 ` dkwo
@ 2024-02-01 0:36 ` Duncaen
2024-02-01 0:37 ` Duncaen
` (2 subsequent siblings)
23 siblings, 0 replies; 25+ messages in thread
From: Duncaen @ 2024-02-01 0:36 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 224 bytes --]
New comment by Duncaen on void-packages repository
https://github.com/void-linux/void-packages/pull/47378#issuecomment-1920255777
Comment:
The split doesn't make sense when the split out package depends on libmtp anyways.
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: android-file-transfer-linux: depend on libmtp-udev (newly split)
2023-11-24 21:57 [PR PATCH] android-file-transfer-linux: add libmtp to depends dkwo
` (20 preceding siblings ...)
2024-02-01 0:36 ` Duncaen
@ 2024-02-01 0:37 ` Duncaen
2024-02-01 16:03 ` [PR PATCH] [Closed]: " dkwo
2024-02-01 16:03 ` dkwo
23 siblings, 0 replies; 25+ messages in thread
From: Duncaen @ 2024-02-01 0:37 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 271 bytes --]
New comment by Duncaen on void-packages repository
https://github.com/void-linux/void-packages/pull/47378#issuecomment-1920255777
Comment:
The split doesn't make sense when the split out package depends on libmtp anyways (`usr/lib/udev/mtp-probe` links `libmtp.so.9`).
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PR PATCH] [Closed]: android-file-transfer-linux: depend on libmtp-udev (newly split)
2023-11-24 21:57 [PR PATCH] android-file-transfer-linux: add libmtp to depends dkwo
` (21 preceding siblings ...)
2024-02-01 0:37 ` Duncaen
@ 2024-02-01 16:03 ` dkwo
2024-02-01 16:03 ` dkwo
23 siblings, 0 replies; 25+ messages in thread
From: dkwo @ 2024-02-01 16:03 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 263 bytes --]
There's a closed pull request on the void-packages repository
android-file-transfer-linux: depend on libmtp-udev (newly split)
https://github.com/void-linux/void-packages/pull/47378
Description:
it's missing udev rules
- I tested the changes in this PR: yes
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: android-file-transfer-linux: depend on libmtp-udev (newly split)
2023-11-24 21:57 [PR PATCH] android-file-transfer-linux: add libmtp to depends dkwo
` (22 preceding siblings ...)
2024-02-01 16:03 ` [PR PATCH] [Closed]: " dkwo
@ 2024-02-01 16:03 ` dkwo
23 siblings, 0 replies; 25+ messages in thread
From: dkwo @ 2024-02-01 16:03 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 159 bytes --]
New comment by dkwo on void-packages repository
https://github.com/void-linux/void-packages/pull/47378#issuecomment-1921662281
Comment:
I see, you're right.
^ permalink raw reply [flat|nested] 25+ messages in thread
end of thread, other threads:[~2024-02-01 16:03 UTC | newest]
Thread overview: 25+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-24 21:57 [PR PATCH] android-file-transfer-linux: add libmtp to depends dkwo
2023-11-25 16:37 ` biopsin
2023-12-12 20:12 ` [PR PATCH] [Closed]: " dkwo
2023-12-12 20:12 ` dkwo
2023-12-12 21:15 ` dkwo
2023-12-12 21:15 ` [PR PATCH] [Updated] " dkwo
2023-12-12 21:25 ` dkwo
2023-12-13 17:15 ` dkwo
2023-12-14 15:43 ` dkwo
2023-12-14 15:44 ` dkwo
2023-12-14 15:44 ` dkwo
2023-12-23 19:07 ` [PR PATCH] [Updated] android-file-transfer-linux: depend on libmtp-udev (newly split) dkwo
2023-12-24 8:30 ` dkwo
2023-12-24 20:15 ` dkwo
2023-12-26 18:00 ` dkwo
2023-12-27 16:22 ` dkwo
2024-01-16 22:46 ` dkwo
2024-01-16 23:33 ` tornaria
2024-01-16 23:55 ` dkwo
2024-01-17 0:31 ` tornaria
2024-01-31 21:20 ` dkwo
2024-02-01 0:36 ` Duncaen
2024-02-01 0:37 ` Duncaen
2024-02-01 16:03 ` [PR PATCH] [Closed]: " dkwo
2024-02-01 16:03 ` dkwo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).