[PR PATCH] chromium: fix build with gcc13

[PR PATCH] chromium: fix build with gcc13

[Calandracas606]

[-- Attachment #1: Type: text/plain, Size: 1127 bytes --]

There is a new pull request by Calandracas606 against master on the void-packages repository

https://github.com/Calandracas606/void-packages chromium-gcc13-fix
https://github.com/void-linux/void-packages/pull/48474

chromium: fix build with gcc13
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **NO**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, x86_64-musl



A patch file from https://github.com/void-linux/void-packages/pull/48474.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-chromium-gcc13-fix-48474.patch --]
[-- Type: text/x-diff, Size: 1870 bytes --]

From 824ff080ec1c700cbd3595e700b033b5e04a78da Mon Sep 17 00:00:00 2001
From: Daniel Martinez <danielmartinez@cock.li>
Date: Wed, 31 Jan 2024 23:27:34 -0500
Subject: [PATCH] chromium: fix build with gcc13

---
 srcpkgs/chromium/patches/gcc13-wnoerror.patch | 21 +++++++++++++++++++
 srcpkgs/chromium/template                     |  2 +-
 2 files changed, 22 insertions(+), 1 deletion(-)
 create mode 100644 srcpkgs/chromium/patches/gcc13-wnoerror.patch

diff --git a/srcpkgs/chromium/patches/gcc13-wnoerror.patch b/srcpkgs/chromium/patches/gcc13-wnoerror.patch
new file mode 100644
index 0000000000000..611c3f9b8977a
--- /dev/null
+++ b/srcpkgs/chromium/patches/gcc13-wnoerror.patch
@@ -0,0 +1,21 @@
+https://gn.googlesource.com/gn/+/c7b223bfb225ce87a72a244d016ffdfcf227fa5e%5E%21/
+Ignore build warning -Werror=redundant-move
+
+gcc-13 complains with:
+error: redundant move in return statement [-Werror=redundant-move]
+
+We cannot fix the code, because both old versions of gcc and the windows
+toolchain fails to build.
+index adb622a..232e536 100755
+--- a/build/gen.py
++++ b/build/gen.py
+
+@@ -472,6 +472,8 @@
+     # flags not supported by gcc/g++.
+     if cxx == 'clang++':
+       cflags.extend(['-Wrange-loop-analysis', '-Wextra-semi-stmt'])
++    else:
++      cflags.append('-Wno-redundant-move')
+ 
+     if platform.is_linux() or platform.is_mingw() or platform.is_msys():
+       ldflags.append('-Wl,--as-needed')
diff --git a/srcpkgs/chromium/template b/srcpkgs/chromium/template
index 5613fa3813822..cd386c8a84ae6 100644
--- a/srcpkgs/chromium/template
+++ b/srcpkgs/chromium/template
@@ -2,7 +2,7 @@
 pkgname=chromium
 # See https://chromiumdash.appspot.com/releases?platform=Linux for the latest version
 version=120.0.6099.129
-revision=1
+revision=2
 archs="i686* x86_64* aarch64* armv7l*"
 hostmakedepends="
  $(vopt_if clang "clang lld llvm15")

Re: [PR PATCH] [Updated] chromium: fix build with gcc13

[Calandracas606]

[-- Attachment #1: Type: text/plain, Size: 1132 bytes --]

There is an updated pull request by Calandracas606 against master on the void-packages repository

https://github.com/Calandracas606/void-packages chromium-gcc13-fix
https://github.com/void-linux/void-packages/pull/48474

chromium: fix build with gcc13
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **NO**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, x86_64-musl



A patch file from https://github.com/void-linux/void-packages/pull/48474.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-chromium-gcc13-fix-48474.patch --]
[-- Type: text/x-diff, Size: 1888 bytes --]

From fc8c0a336065b6f8f3c3fc8da8fa72cfbfe22212 Mon Sep 17 00:00:00 2001
From: Daniel Martinez <danielmartinez@cock.li>
Date: Wed, 31 Jan 2024 23:27:34 -0500
Subject: [PATCH] chromium: fix build with gcc13

---
 srcpkgs/chromium/patches/gcc13-wnoerror.patch | 21 +++++++++++++++++++
 srcpkgs/chromium/template                     |  2 +-
 2 files changed, 22 insertions(+), 1 deletion(-)
 create mode 100644 srcpkgs/chromium/patches/gcc13-wnoerror.patch

diff --git a/srcpkgs/chromium/patches/gcc13-wnoerror.patch b/srcpkgs/chromium/patches/gcc13-wnoerror.patch
new file mode 100644
index 0000000000000..c069aa41b2d09
--- /dev/null
+++ b/srcpkgs/chromium/patches/gcc13-wnoerror.patch
@@ -0,0 +1,21 @@
+https://gn.googlesource.com/gn/+/c7b223bfb225ce87a72a244d016ffdfcf227fa5e%5E%21/
+Ignore build warning -Werror=redundant-move
+
+gcc-13 complains with:
+error: redundant move in return statement [-Werror=redundant-move]
+
+We cannot fix the code, because both old versions of gcc and the windows
+toolchain fails to build.
+index adb622a..232e536 100755
+--- a/tools/gn/build/gen.py
++++ b/tools/gn/build/gen.py
+
+@@ -472,6 +472,8 @@
+     # flags not supported by gcc/g++.
+     if cxx == 'clang++':
+       cflags.extend(['-Wrange-loop-analysis', '-Wextra-semi-stmt'])
++    else:
++      cflags.append('-Wno-redundant-move')
+ 
+     if platform.is_linux() or platform.is_mingw() or platform.is_msys():
+       ldflags.append('-Wl,--as-needed')
diff --git a/srcpkgs/chromium/template b/srcpkgs/chromium/template
index 5613fa3813822..cd386c8a84ae6 100644
--- a/srcpkgs/chromium/template
+++ b/srcpkgs/chromium/template
@@ -2,7 +2,7 @@
 pkgname=chromium
 # See https://chromiumdash.appspot.com/releases?platform=Linux for the latest version
 version=120.0.6099.129
-revision=1
+revision=2
 archs="i686* x86_64* aarch64* armv7l*"
 hostmakedepends="
  $(vopt_if clang "clang lld llvm15")

Re: chromium: fix build with gcc13

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 244 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/48474#issuecomment-1921416171

Comment:
This shouldn't require a revbump, and use `[ci skip]` since there is no way the CI can build chromium.

Re: [PR PATCH] [Updated] chromium: fix build with gcc13

[Calandracas606]

[-- Attachment #1: Type: text/plain, Size: 1143 bytes --]

There is an updated pull request by Calandracas606 against master on the void-packages repository

https://github.com/Calandracas606/void-packages chromium-gcc13-fix
https://github.com/void-linux/void-packages/pull/48474

chromium: fix build with gcc13
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **NO**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, x86_64-musl

[ci skip]


A patch file from https://github.com/void-linux/void-packages/pull/48474.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-chromium-gcc13-fix-48474.patch --]
[-- Type: text/x-diff, Size: 1378 bytes --]

From 8195c7dcda73d9ff5fda7eb89f797253bb654fde Mon Sep 17 00:00:00 2001
From: Daniel Martinez <danielmartinez@cock.li>
Date: Wed, 31 Jan 2024 23:27:34 -0500
Subject: [PATCH] chromium: fix build with gcc13

---
 srcpkgs/chromium/patches/gcc13-wnoerror.patch | 21 +++++++++++++++++++
 1 file changed, 21 insertions(+)
 create mode 100644 srcpkgs/chromium/patches/gcc13-wnoerror.patch

diff --git a/srcpkgs/chromium/patches/gcc13-wnoerror.patch b/srcpkgs/chromium/patches/gcc13-wnoerror.patch
new file mode 100644
index 0000000000000..c069aa41b2d09
--- /dev/null
+++ b/srcpkgs/chromium/patches/gcc13-wnoerror.patch
@@ -0,0 +1,21 @@
+https://gn.googlesource.com/gn/+/c7b223bfb225ce87a72a244d016ffdfcf227fa5e%5E%21/
+Ignore build warning -Werror=redundant-move
+
+gcc-13 complains with:
+error: redundant move in return statement [-Werror=redundant-move]
+
+We cannot fix the code, because both old versions of gcc and the windows
+toolchain fails to build.
+index adb622a..232e536 100755
+--- a/tools/gn/build/gen.py
++++ b/tools/gn/build/gen.py
+
+@@ -472,6 +472,8 @@
+     # flags not supported by gcc/g++.
+     if cxx == 'clang++':
+       cflags.extend(['-Wrange-loop-analysis', '-Wextra-semi-stmt'])
++    else:
++      cflags.append('-Wno-redundant-move')
+ 
+     if platform.is_linux() or platform.is_mingw() or platform.is_msys():
+       ldflags.append('-Wl,--as-needed')

Re: chromium: fix build with gcc13

[Calandracas606]

[-- Attachment #1: Type: text/plain, Size: 153 bytes --]

New comment by Calandracas606 on void-packages repository

https://github.com/void-linux/void-packages/pull/48474#issuecomment-1921502519

Comment:
done

Re: [PR PATCH] [Merged]: chromium: fix build with gcc13

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 962 bytes --]

There's a merged pull request on the void-packages repository

chromium: fix build with gcc13
https://github.com/void-linux/void-packages/pull/48474

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **NO**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, x86_64-musl

[ci skip]