[PR PATCH] kwave: fix icons

[PR PATCH] kwave: fix icons

[Luciogi]

[-- Attachment #1: Type: text/plain, Size: 491 bytes --]

There is a new pull request by Luciogi against master on the void-packages repository

https://github.com/Luciogi/void-packages kwav
https://github.com/void-linux/void-packages/pull/48482

kwave: fix icons
#### Testing the changes
- I tested the changes in this PR: **briefly**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-GLIBC)

#### Fixes
#47668 

A patch file from https://github.com/void-linux/void-packages/pull/48482.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-kwav-48482.patch --]
[-- Type: text/x-diff, Size: 1560 bytes --]

From a53d35abc6445ecc5fadf47911871a1823881122 Mon Sep 17 00:00:00 2001
From: Luciogi <lucigithubcommit@skiff.com>
Date: Fri, 2 Feb 2024 00:53:27 +0500
Subject: [PATCH] kwave: fix icons

---
 srcpkgs/kwave/template | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/kwave/template b/srcpkgs/kwave/template
index 7d4735c3815c3..d20527c392fcf 100644
--- a/srcpkgs/kwave/template
+++ b/srcpkgs/kwave/template
@@ -1,7 +1,7 @@
 # Template file for 'kwave'
 pkgname=kwave
 version=23.08.4
-revision=1
+revision=2
 build_style=cmake
 hostmakedepends="extra-cmake-modules gettext kconfig kcoreaddons kdoctools
  librsvg-utils pkg-config python3 qt5-host-tools qt5-qmake"
@@ -11,7 +11,7 @@ makedepends="alsa-lib-devel appstream-glib-devel audiofile-devel doxygen
  kdbusaddons-devel kdoctools-devel ki18n-devel kiconthemes-devel kio-devel
  kservice-devel ktexteditor-devel ktextwidgets-devel kxmlgui-devel libmad-devel
  libogg-devel librsvg-devel libsamplerate-devel libvorbis-devel opus-devel
- pulseaudio-devel qt5-multimedia-devel samurai"
+ pulseaudio-devel qt5-multimedia-devel samurai inkscape"
 depends="audiofile fftw hicolor-icon-theme id3lib lame libmad libsamplerate
  opus twolame"
 checkdepends="xvfb-run"
@@ -28,3 +28,10 @@ post_patch() {
 		-e '/${KDOCTOOLS_MEINPROC_EXECUTABLE}/d' \
 		-e 's/${MEINPROC_EXECUTABLE}/meinproc5/'
 }
+
+post_install() {
+	# svgz files are not loading as icons, svg files works
+	cd ${DESTDIR}/usr/share/icons/hicolor/scalable/actions
+	inkscape --export-type=svg *.svgz
+	rm *.svgz
+}

Re: kwave: fix icons

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 382 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/48482#issuecomment-1923018834

Comment:
svgz is just gzip-compressed svg, so there's no need to use inkscape:

```bash
post_install() {
	for f in "${DESTDIR}"/usr/share/icons/hicolor/scalable/actions/*.svgz; do
		mv "$f" "${f%z}.gz"
		gzip -d "${f%z}.gz"
	done
}
```

Re: kwave: fix icons

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 442 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/48482#issuecomment-1923018834

Comment:
svgz is just gzip-compressed svg, so there's no need to use inkscape:

```bash
post_install() {
	for f in "${DESTDIR}"/usr/share/icons/hicolor/scalable/actions/*.svgz; do
		mv "$f" "${f%z}.gz"
		gzip -d "${f%z}.gz"
	done
}
```

(also, inkscape should have been in **host**makedepends)

Re: kwave: fix icons

[Luciogi]

[-- Attachment #1: Type: text/plain, Size: 485 bytes --]

New comment by Luciogi on void-packages repository

https://github.com/void-linux/void-packages/pull/48482#issuecomment-1923792083

Comment:
> svgz is just gzip-compressed svg, so there's no need to use inkscape:
> 
> ```shell
> post_install() {
> 	for f in "${DESTDIR}"/usr/share/icons/hicolor/scalable/actions/*.svgz; do
> 		mv "$f" "${f%z}.gz"
> 		gzip -d "${f%z}.gz"
> 	done
> }
> ```
> 
> (also, inkscape should have been in **host**makedepends)

Thank you
it works

Re: [PR PATCH] [Updated] kwave: fix icons

[Luciogi]

[-- Attachment #1: Type: text/plain, Size: 490 bytes --]

There is an updated pull request by Luciogi against master on the void-packages repository

https://github.com/Luciogi/void-packages kwav
https://github.com/void-linux/void-packages/pull/48482

kwave: fix icons
#### Testing the changes
- I tested the changes in this PR: **briefly**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-GLIBC)

Fixes #47668 

A patch file from https://github.com/void-linux/void-packages/pull/48482.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-kwav-48482.patch --]
[-- Type: text/x-diff, Size: 1033 bytes --]

From 0f11b932be2b8351c2d4e6438665535e9167edcb Mon Sep 17 00:00:00 2001
From: Luciogi <lucigithubcommit@skiff.com>
Date: Fri, 2 Feb 2024 00:53:27 +0500
Subject: [PATCH] kwave: fix icons

---
 srcpkgs/kwave/template | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/kwave/template b/srcpkgs/kwave/template
index 7d4735c3815c3..b311292ff9002 100644
--- a/srcpkgs/kwave/template
+++ b/srcpkgs/kwave/template
@@ -1,7 +1,7 @@
 # Template file for 'kwave'
 pkgname=kwave
 version=23.08.4
-revision=1
+revision=2
 build_style=cmake
 hostmakedepends="extra-cmake-modules gettext kconfig kcoreaddons kdoctools
  librsvg-utils pkg-config python3 qt5-host-tools qt5-qmake"
@@ -28,3 +28,11 @@ post_patch() {
 		-e '/${KDOCTOOLS_MEINPROC_EXECUTABLE}/d' \
 		-e 's/${MEINPROC_EXECUTABLE}/meinproc5/'
 }
+
+post_install() {
+	# svgz files are not loading as icons, svg files works
+	for f in "${DESTDIR}"/usr/share/icons/hicolor/scalable/actions/*.svgz; do
+		mv "$f" "${f%z}.gz"
+		gzip -d "${f%z}.gz"
+	done
+}

Re: [PR PATCH] [Merged]: kwave: fix icons

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 337 bytes --]

There's a merged pull request on the void-packages repository

kwave: fix icons
https://github.com/void-linux/void-packages/pull/48482

Description:
#### Testing the changes
- I tested the changes in this PR: **briefly**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-GLIBC)

Fixes #47668