[PR PATCH] New package: xnotify-0.9.3

[PR PATCH] New package: xnotify-0.9.3

[loosefish-scapegrace]

[-- Attachment #1: Type: text/plain, Size: 789 bytes --]

There is a new pull request by loosefish-scapegrace against master on the void-packages repository

https://github.com/loosefish-scapegrace/void-packages xnotify
https://github.com/void-linux/void-packages/pull/47018

New package: xnotify-0.9.3
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - x86_64-musl
  - i686

A patch file from https://github.com/void-linux/void-packages/pull/47018.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-xnotify-47018.patch --]
[-- Type: text/x-diff, Size: 1381 bytes --]

From d7568e23a0cc709d35a23072d841386f160eced0 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?n=C3=A9p=C3=A9ta?= <nepeta@canaglie.net>
Date: Thu, 2 Nov 2023 20:13:27 +1100
Subject: [PATCH] New package: xnotify-0.9.3

---
 srcpkgs/xnotify/template | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)
 create mode 100644 srcpkgs/xnotify/template

diff --git a/srcpkgs/xnotify/template b/srcpkgs/xnotify/template
new file mode 100644
index 0000000000000..c2cfab1cd46c3
--- /dev/null
+++ b/srcpkgs/xnotify/template
@@ -0,0 +1,24 @@
+# Template file for 'xnotify'
+pkgname=xnotify
+version=0.9.3
+revision=1
+build_style=gnu-makefile
+makedepends="imlib2-devel libXft-devel libX11-devel libXinerama-devel"
+short_desc="Read notifications from stdin and pop them up on the screen"
+maintainer="népéta <nepeta@canaglie.net>"
+license="MIT"
+homepage="https://github.com/phillbush/xnotify"
+distfiles="https://github.com/phillbush/xnotify/archive/refs/tags/v0.9.3.tar.gz"
+checksum=9fa7505ad16c8d5e2305a56d0d88ca3a7e324816b4df7845b920db088482eb24
+
+do_build() {
+	[ -e ${FILESDIR}/config.h ] && cp ${FILESDIR}/config.h config.h
+	make INCS="-I${XBPS_CROSS_BASE}/usr/include -I${XBPS_CROSS_BASE}/usr/include/freetype2" \
+		LIBS="-lfontconfig -lXft -lX11 -lXinerama -lImlib2"
+}
+
+do_install() {
+	make PREFIX=/usr DESTDIR=${DESTDIR} install
+	vdoc README.md
+	vlicense LICENSE
+}

Re: [PR REVIEW] New package: xnotify-0.9.3

[Luciogi]

[-- Attachment #1: Type: text/plain, Size: 228 bytes --]

New review comment by Luciogi on void-packages repository

https://github.com/void-linux/void-packages/pull/47018#discussion_r1382451275

Comment:
```suggestion
distfiles="${homepage}/archive/refs/tags/v${version}.tar.gz"
```

Re: [PR REVIEW] New package: xnotify-0.9.3

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 188 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/47018#discussion_r1382467515

Comment:
no, don't use homepage in distfiles

Re: [PR REVIEW] New package: xnotify-0.9.3

[sh1r4s3]

[-- Attachment #1: Type: text/plain, Size: 202 bytes --]

New review comment by sh1r4s3 on void-packages repository

https://github.com/void-linux/void-packages/pull/47018#discussion_r1382479706

Comment:
```suggestion
	vlicense LICENSE
	vman xnotify.1
```

Re: [PR REVIEW] New package: xnotify-0.9.3

[sh1r4s3]

[-- Attachment #1: Type: text/plain, Size: 198 bytes --]

New review comment by sh1r4s3 on void-packages repository

https://github.com/void-linux/void-packages/pull/47018#discussion_r1382480595

Comment:
Oh, I missed that `Makefile` installs it. Sorry :)

Re: [PR REVIEW] New package: xnotify-0.9.3

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 215 bytes --]

New review comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/47018#discussion_r1382481607

Comment:
I don't see anywhere where this is respected by the build process.

Re: [PR REVIEW] New package: xnotify-0.9.3

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 209 bytes --]

New review comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/47018#discussion_r1382481607

Comment:
I don't see anywhere this is respected by the build process.

Re: [PR REVIEW] New package: xnotify-0.9.3

[loosefish-scapegrace]

[-- Attachment #1: Type: text/plain, Size: 295 bytes --]

New review comment by loosefish-scapegrace on void-packages repository

https://github.com/void-linux/void-packages/pull/47018#discussion_r1382482258

Comment:
isn't it? the xnotify makefile brings in `config.h`. (the upstream xnotify no longer has that file, but the latest release still does)

Re: [PR REVIEW] New package: xnotify-0.9.3

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 356 bytes --]

New review comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/47018#discussion_r1382612828

Comment:
That's even more of an argument against adding this capability. Some future release will drop it entirely and we'll be left with vestigial logic that only existed to support custom builds in the first place.

Re: New package: xnotify-0.9.3

[loosefish-scapegrace]

[-- Attachment #1: Type: text/plain, Size: 1248 bytes --]

New comment by loosefish-scapegrace on void-packages repository

https://github.com/void-linux/void-packages/pull/47018#issuecomment-1794069322

Comment:
"Andrew J. Hesford" ***@***.***> wrote:
> @ahesford commented on this pull request.
> 
> 
> 
> > @@ -0,0 +1,24 @@
> +# Template file for 'xnotify'
> +pkgname=xnotify
> +version=0.9.3
> +revision=1
> +build_style=gnu-makefile
> +makedepends="imlib2-devel libXft-devel libX11-devel libXinerama-devel"
> +short_desc="Read notifications from stdin and pop them up on the screen"
> +maintainer="népéta ***@***.***>"
> +license="MIT"
> +homepage="https://github.com/phillbush/xnotify"
> +distfiles="https://github.com/phillbush/xnotify/archive/refs/tags/v0.9.3.tar.gz"
> +checksum=9fa7505ad16c8d5e2305a56d0d88ca3a7e324816b4df7845b920db088482eb24
> +
> +do_build() {
> +	[ -e ${FILESDIR}/config.h ] && cp ${FILESDIR}/config.h config.h
> 
> That's even more of an argument against adding this capability. Some future release will drop it entirely and we'll be left with vestigial logic that only existed to support custom builds in the first place.

That's fair, I think. `xnotify` supports Xresources anyway, so I
think it's not as useful as for something like `dmenu`...

Re: New package: xnotify-0.9.3

[loosefish-scapegrace]

[-- Attachment #1: Type: text/plain, Size: 1248 bytes --]

New comment by loosefish-scapegrace on void-packages repository

https://github.com/void-linux/void-packages/pull/47018#issuecomment-1794069322

Comment:
"Andrew J. Hesford" ***@***.***> wrote:
> @ahesford commented on this pull request.
> 
> 
> 
> > @@ -0,0 +1,24 @@
> +# Template file for 'xnotify'
> +pkgname=xnotify
> +version=0.9.3
> +revision=1
> +build_style=gnu-makefile
> +makedepends="imlib2-devel libXft-devel libX11-devel libXinerama-devel"
> +short_desc="Read notifications from stdin and pop them up on the screen"
> +maintainer="népéta ***@***.***>"
> +license="MIT"
> +homepage="https://github.com/phillbush/xnotify"
> +distfiles="https://github.com/phillbush/xnotify/archive/refs/tags/v0.9.3.tar.gz"
> +checksum=9fa7505ad16c8d5e2305a56d0d88ca3a7e324816b4df7845b920db088482eb24
> +
> +do_build() {
> +	[ -e ${FILESDIR}/config.h ] && cp ${FILESDIR}/config.h config.h
> 
> That's even more of an argument against adding this capability. Some future release will drop it entirely and we'll be left with vestigial logic that only existed to support custom builds in the first place.

That's fair, I think. `xnotify` supports Xresources anyway, so I
think it's not as useful as for something like `dmenu`...

Re: [PR REVIEW] New package: xnotify-0.9.3

[loosefish-scapegrace]

[-- Attachment #1: Type: text/plain, Size: 497 bytes --]

New review comment by loosefish-scapegrace on void-packages repository

https://github.com/void-linux/void-packages/pull/47018#discussion_r1382771738

Comment:
> That's even more of an argument against adding this capability. Some future release will drop it entirely and we'll be left with vestigial logic that only existed to support custom builds in the first place.

That's fair, I think. `xnotify` supports Xresources anyway, so I
think it's not as useful as for something like `dmenu`...

Re: [PR PATCH] [Updated] New package: xnotify-0.9.3

[loosefish-scapegrace]

[-- Attachment #1: Type: text/plain, Size: 794 bytes --]

There is an updated pull request by loosefish-scapegrace against master on the void-packages repository

https://github.com/loosefish-scapegrace/void-packages xnotify
https://github.com/void-linux/void-packages/pull/47018

New package: xnotify-0.9.3
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - x86_64-musl
  - i686

A patch file from https://github.com/void-linux/void-packages/pull/47018.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-xnotify-47018.patch --]
[-- Type: text/x-diff, Size: 1268 bytes --]

From 7202945b2dd328cd8c7c9860a8edf259438c46d7 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?n=C3=A9p=C3=A9ta?= <nepeta@canaglie.net>
Date: Thu, 2 Nov 2023 20:13:27 +1100
Subject: [PATCH] New package: xnotify-0.9.3

---
 srcpkgs/xnotify/template | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)
 create mode 100644 srcpkgs/xnotify/template

diff --git a/srcpkgs/xnotify/template b/srcpkgs/xnotify/template
new file mode 100644
index 0000000000000..43f6a2f051f9b
--- /dev/null
+++ b/srcpkgs/xnotify/template
@@ -0,0 +1,20 @@
+# Template file for 'xnotify'
+pkgname=xnotify
+version=0.9.3
+revision=1
+build_style=gnu-makefile
+make_build_args="INCS=-I${XBPS_CROSS_BASE}/usr/include
+ INCS+=-I${XBPS_CROSS_BASE}/usr/include/freetype2"
+makedepends="imlib2-devel libXft-devel libX11-devel libXinerama-devel freetype-devel"
+short_desc="Read notifications from stdin and pop them up on the screen"
+maintainer="népéta <nepeta@canaglie.net>"
+license="MIT"
+homepage="https://github.com/phillbush/xnotify"
+distfiles="https://github.com/phillbush/xnotify/archive/refs/tags/v0.9.3.tar.gz"
+checksum=9fa7505ad16c8d5e2305a56d0d88ca3a7e324816b4df7845b920db088482eb24
+
+do_install() {
+	make PREFIX=/usr DESTDIR=${DESTDIR} install
+	vdoc README.md
+	vlicense LICENSE
+}

Re: New package: xnotify-0.9.3

[loosefish-scapegrace]

[-- Attachment #1: Type: text/plain, Size: 232 bytes --]

New comment by loosefish-scapegrace on void-packages repository

https://github.com/void-linux/void-packages/pull/47018#issuecomment-1794088727

Comment:
modified the template to use `make_build_args` and remove the `config.h` line

Re: New package: xnotify-0.9.3

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/47018#issuecomment-1926074196

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

Re: [PR PATCH] [Closed]: New package: xnotify-0.9.3

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 612 bytes --]

There's a closed pull request on the void-packages repository

New package: xnotify-0.9.3
https://github.com/void-linux/void-packages/pull/47018

Description:
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - x86_64-musl
  - i686