Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] llvm17: fix $version variables, trim trailing ws.
@ 2024-02-09  1:00 atweiden
  2024-02-09  1:09 ` Calandracas606
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: atweiden @ 2024-02-09  1:00 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 424 bytes --]

There is a new pull request by atweiden against master on the void-packages repository

https://github.com/atweiden/void-packages llvm17-fix
https://github.com/void-linux/void-packages/pull/48616

llvm17: fix $version variables, trim trailing ws.
[ci skip]

#### Testing the changes
- I tested the changes in this PR: **briefly**

A patch file from https://github.com/void-linux/void-packages/pull/48616.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-llvm17-fix-48616.patch --]
[-- Type: text/x-diff, Size: 1279 bytes --]

From e07717dcfabdc4386ce5ce50d7ba4c5799532fdb Mon Sep 17 00:00:00 2001
From: Andy Weidenbaum <atweiden@ioiojo.com>
Date: Fri, 9 Feb 2024 00:55:57 +0000
Subject: [PATCH] llvm17: fix $version variables, trim trailing ws.

---
 srcpkgs/llvm17/template | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/llvm17/template b/srcpkgs/llvm17/template
index 7bc22ec50272e..f7b3998b34d6a 100644
--- a/srcpkgs/llvm17/template
+++ b/srcpkgs/llvm17/template
@@ -637,7 +637,7 @@ libllvm17_package() {
 }
 
 llvm17-doc_package() {
-	short_desc+=" - documentation "
+	short_desc+=" - documentation"
 	pkg_install() {
 		vmove usr/share/doc
 	}
@@ -647,13 +647,13 @@ llvm17-devel_package() {
 	short_desc+=" - development files"
 	depends="llvm17>=${version}_${revision}"
 	if [ "$build_option_openmp" ]; then
-		depends+=" libomp-devel>={$version}_${revision} "
+		depends+=" libomp-devel>=${version}_${revision} "
 	fi
 	if [ "$build_option_mlir" ]; then
-		depends+=" mlir17-devel>={$version}_${revision} "
+		depends+=" mlir17-devel>=${version}_${revision} "
 	fi
 	if [ "$build_option_clang" ]; then
-		depends+=" clang17-devel>={$version}_${revision} "
+		depends+=" clang17-devel>=${version}_${revision} "
 	fi
 	pkg_install() {
 		vmove usr/lib/libLLVM.so

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: llvm17: fix $version variables, trim trailing ws.
  2024-02-09  1:00 [PR PATCH] llvm17: fix $version variables, trim trailing ws atweiden
@ 2024-02-09  1:09 ` Calandracas606
  2024-02-09 15:00 ` Calandracas606
  2024-02-10 21:30 ` [PR PATCH] [Closed]: " Duncaen
  2 siblings, 0 replies; 4+ messages in thread
From: Calandracas606 @ 2024-02-09  1:09 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 336 bytes --]

New comment by Calandracas606 on void-packages repository

https://github.com/void-linux/void-packages/pull/48616#issuecomment-1935176866

Comment:
Good catch.

There's a few other changes I want to make to the template. It appears to be working in its current state though, not sure if another needless 9+ hour build is a good idea.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: llvm17: fix $version variables, trim trailing ws.
  2024-02-09  1:00 [PR PATCH] llvm17: fix $version variables, trim trailing ws atweiden
  2024-02-09  1:09 ` Calandracas606
@ 2024-02-09 15:00 ` Calandracas606
  2024-02-10 21:30 ` [PR PATCH] [Closed]: " Duncaen
  2 siblings, 0 replies; 4+ messages in thread
From: Calandracas606 @ 2024-02-09 15:00 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 187 bytes --]

New comment by Calandracas606 on void-packages repository

https://github.com/void-linux/void-packages/pull/48616#issuecomment-1936084394

Comment:
changes incorporated as part of #48625

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PR PATCH] [Closed]: llvm17: fix $version variables, trim trailing ws.
  2024-02-09  1:00 [PR PATCH] llvm17: fix $version variables, trim trailing ws atweiden
  2024-02-09  1:09 ` Calandracas606
  2024-02-09 15:00 ` Calandracas606
@ 2024-02-10 21:30 ` Duncaen
  2 siblings, 0 replies; 4+ messages in thread
From: Duncaen @ 2024-02-10 21:30 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 268 bytes --]

There's a closed pull request on the void-packages repository

llvm17: fix $version variables, trim trailing ws.
https://github.com/void-linux/void-packages/pull/48616

Description:
[ci skip]

#### Testing the changes
- I tested the changes in this PR: **briefly**

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-02-10 21:30 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-09  1:00 [PR PATCH] llvm17: fix $version variables, trim trailing ws atweiden
2024-02-09  1:09 ` Calandracas606
2024-02-09 15:00 ` Calandracas606
2024-02-10 21:30 ` [PR PATCH] [Closed]: " Duncaen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).