[PR PATCH] New package: winegui-2.3.5

[PR PATCH] New package: winegui-2.3.5

[melroy89]

[-- Attachment #1: Type: text/plain, Size: 1687 bytes --]

There is a new pull request by melroy89 against master on the void-packages repository

https://github.com/melroy89/void-packages add_winegui
https://github.com/void-linux/void-packages/pull/48642

New package: winegui-2.3.5
Introducing WineGUI package. At last, a user-friendly Wine graphical interface.

I'm the developer of [WineGUI](https://gitlab.melroy.org/melroy/winegui).

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

The x86_64 build went fine. I also tested the WineGUI application itself, running on Void Linux. I did notice that wine-32bit was missing as well. But multilib can't be added as depends too bad! 

Hence I added a `README.voidlinux`, just like the Steam package. However, I hope there will be a **better solution** in the neat future. 

I also tried `armv6l` and `armv7l` cross-builds, but this seems to fail on wine? That is too bad.

```sh
=> wine-9.1_1: the following build options are set:
   mingw: Use the MinGW cross compiler to build WinPE DLLs (ON)
   xshm: Enable support for the X Shared Memory Extension (ON)
   staging: Apply the wine-staging patchset (OFF)
=> ERROR: wine-9.1_1: this package cannot be built for armv6l.
```

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc) -> OK

- I tried to build this PR locally for these architectures, but failed...:
  - armv7l
  - armv6l


A patch file from https://github.com/void-linux/void-packages/pull/48642.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-add_winegui-48642.patch --]
[-- Type: text/x-diff, Size: 3192 bytes --]

From 5e4e74004979d896c3977dfcc161f75a9892c678 Mon Sep 17 00:00:00 2001
From: Melroy van den Berg <melroy@melroy.org>
Date: Sat, 10 Feb 2024 21:56:47 +0100
Subject: [PATCH] New package: winegui-2.3.5

---
 srcpkgs/winegui/files/README.voidlinux | 36 ++++++++++++++++++++++++++
 srcpkgs/winegui/template               | 22 ++++++++++++++++
 2 files changed, 58 insertions(+)
 create mode 100644 srcpkgs/winegui/files/README.voidlinux
 create mode 100644 srcpkgs/winegui/template

diff --git a/srcpkgs/winegui/files/README.voidlinux b/srcpkgs/winegui/files/README.voidlinux
new file mode 100644
index 0000000000000..4e42a25e6c263
--- /dev/null
+++ b/srcpkgs/winegui/files/README.voidlinux
@@ -0,0 +1,36 @@
+WineGUI on i686 should work without needing to install any extra packages.
+
+WineGUI on x86_64 requires support for Wine in 32bits mode and OpenGL/Vulkan in 32bits mode,
+the 32bit packages are available in the multilib repository.
+
+Install the multilib repository to your system:
+
+	# xbps-install -S void-repo-multilib{,-nonfree}
+
+Generic (for all systems):
+
+	# xbps-install -S wine-32bit libgcc-32bit libstdc++-32bit libdrm-32bit libglvnd-32bit
+
+For users of the open source drivers (eg. AMD):
+
+	# xbps-install -S mesa-dri-32bit
+
+For users of the proprietary NVIDIA driver, install the appropriate 32-bit
+libraries for the version of nvidia you have installed:
+
+	# xbps-install -S nvidia-libs-32bit (for the latest nvidia package)
+	# xbps-install -S nvidia470-libs-32bit (for the latest previous package)
+	# xbps-install -S nvidia390-libs-32bit (for the legacy previous package)
+
+For mesa users this would result in:
+
+	# xbps-install -S wine-32bit libgcc-32bit libstdc++-32bit libdrm-32bit libglvnd-32bit mesa-dri-32bit
+
+The dbus service must be enabled, and the mono package will need to be
+installed for some apps/games to function.
+
+If games are running slowly or not at all, or there are issues with network
+streaming, verify that your user belongs to the video group.
+
+If your audio is not working, try installing pulseaudio,
+alsa-plugins-pulseaudio, and their "<package>-32bit" equivalents.
diff --git a/srcpkgs/winegui/template b/srcpkgs/winegui/template
new file mode 100644
index 0000000000000..81d474b68ab54
--- /dev/null
+++ b/srcpkgs/winegui/template
@@ -0,0 +1,22 @@
+# Template file for 'winegui'
+pkgname=winegui
+version=2.3.5
+revision=1
+build_style=cmake
+configure_args="-DCMAKE_INSTALL_PREFIX:PATH=/usr -DCMAKE_BUILD_TYPE=Release"
+hostmakedepends="pkg-config cmake gobject-introspection gdk-pixbuf-devel"
+makedepends="gtk+3-devel gtkmm-devel libglib-devel gdk-pixbuf pango-devel cairo-devel atk-devel"
+depends="wine wget unzip p7zip cabextract zenity"
+short_desc="User-friendly WINE manager"
+maintainer="Melroy van den Berg <melroy@melroy.org>"
+license="AGPL-3.0-only"
+homepage="https://gitlab.melroy.org/melroy/winegui"
+distfiles="https://gitlab.melroy.org/melroy/winegui/-/archive/v${version}/winegui-v${version}.tar.gz"
+checksum=be28e8cfbc847887a38ef9067fab9acf318de7800b795c4167832cdef34aee84
+
+export CUSTOM_PROJECT_VERSION="${version}"
+
+post_install() {
+	vlicense LICENSE
+	vdoc "${FILESDIR}/README.voidlinux"
+}

Re: [PR PATCH] [Updated] New package: winegui-2.3.5

[melroy89]

[-- Attachment #1: Type: text/plain, Size: 1692 bytes --]

There is an updated pull request by melroy89 against master on the void-packages repository

https://github.com/melroy89/void-packages add_winegui
https://github.com/void-linux/void-packages/pull/48642

New package: winegui-2.3.5
Introducing WineGUI package. At last, a user-friendly Wine graphical interface.

I'm the developer of [WineGUI](https://gitlab.melroy.org/melroy/winegui).

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

The x86_64 build went fine. I also tested the WineGUI application itself, running on Void Linux. I did notice that wine-32bit was missing as well. But multilib can't be added as depends too bad! 

Hence I added a `README.voidlinux`, just like the Steam package. However, I hope there will be a **better solution** in the neat future. 

I also tried `armv6l` and `armv7l` cross-builds, but this seems to fail on wine? That is too bad.

```sh
=> wine-9.1_1: the following build options are set:
   mingw: Use the MinGW cross compiler to build WinPE DLLs (ON)
   xshm: Enable support for the X Shared Memory Extension (ON)
   staging: Apply the wine-staging patchset (OFF)
=> ERROR: wine-9.1_1: this package cannot be built for armv6l.
```

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc) -> OK

- I tried to build this PR locally for these architectures, but failed...:
  - armv7l
  - armv6l


A patch file from https://github.com/void-linux/void-packages/pull/48642.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-add_winegui-48642.patch --]
[-- Type: text/x-diff, Size: 3113 bytes --]

From 842c00eef9ed36846201054e64b9d38560d94209 Mon Sep 17 00:00:00 2001
From: Melroy van den Berg <melroy@melroy.org>
Date: Sat, 10 Feb 2024 23:42:19 +0100
Subject: [PATCH] New package: winegui-2.3.5

---
 srcpkgs/winegui/files/README.voidlinux | 36 ++++++++++++++++++++++++++
 srcpkgs/winegui/template               | 21 +++++++++++++++
 2 files changed, 57 insertions(+)
 create mode 100644 srcpkgs/winegui/files/README.voidlinux
 create mode 100644 srcpkgs/winegui/template

diff --git a/srcpkgs/winegui/files/README.voidlinux b/srcpkgs/winegui/files/README.voidlinux
new file mode 100644
index 0000000000000..4e42a25e6c263
--- /dev/null
+++ b/srcpkgs/winegui/files/README.voidlinux
@@ -0,0 +1,36 @@
+WineGUI on i686 should work without needing to install any extra packages.
+
+WineGUI on x86_64 requires support for Wine in 32bits mode and OpenGL/Vulkan in 32bits mode,
+the 32bit packages are available in the multilib repository.
+
+Install the multilib repository to your system:
+
+	# xbps-install -S void-repo-multilib{,-nonfree}
+
+Generic (for all systems):
+
+	# xbps-install -S wine-32bit libgcc-32bit libstdc++-32bit libdrm-32bit libglvnd-32bit
+
+For users of the open source drivers (eg. AMD):
+
+	# xbps-install -S mesa-dri-32bit
+
+For users of the proprietary NVIDIA driver, install the appropriate 32-bit
+libraries for the version of nvidia you have installed:
+
+	# xbps-install -S nvidia-libs-32bit (for the latest nvidia package)
+	# xbps-install -S nvidia470-libs-32bit (for the latest previous package)
+	# xbps-install -S nvidia390-libs-32bit (for the legacy previous package)
+
+For mesa users this would result in:
+
+	# xbps-install -S wine-32bit libgcc-32bit libstdc++-32bit libdrm-32bit libglvnd-32bit mesa-dri-32bit
+
+The dbus service must be enabled, and the mono package will need to be
+installed for some apps/games to function.
+
+If games are running slowly or not at all, or there are issues with network
+streaming, verify that your user belongs to the video group.
+
+If your audio is not working, try installing pulseaudio,
+alsa-plugins-pulseaudio, and their "<package>-32bit" equivalents.
diff --git a/srcpkgs/winegui/template b/srcpkgs/winegui/template
new file mode 100644
index 0000000000000..bb76874744498
--- /dev/null
+++ b/srcpkgs/winegui/template
@@ -0,0 +1,21 @@
+# Template file for 'winegui'
+pkgname=winegui
+version=2.3.5
+revision=1
+build_style=cmake
+hostmakedepends="pkg-config cmake gobject-introspection gdk-pixbuf-devel"
+makedepends="gtk+3-devel gtkmm-devel libglib-devel gdk-pixbuf pango-devel cairo-devel atk-devel"
+depends="wine wget unzip p7zip cabextract zenity"
+short_desc="User-friendly WINE manager"
+maintainer="Melroy van den Berg <melroy@melroy.org>"
+license="AGPL-3.0-only"
+homepage="https://gitlab.melroy.org/melroy/winegui"
+distfiles="https://gitlab.melroy.org/melroy/winegui/-/archive/v${version}/winegui-v${version}.tar.gz"
+checksum=be28e8cfbc847887a38ef9067fab9acf318de7800b795c4167832cdef34aee84
+
+export CUSTOM_PROJECT_VERSION="${version}"
+
+post_install() {
+	vlicense LICENSE
+	vdoc "${FILESDIR}/README.voidlinux"
+}

Re: New package: winegui-2.3.5

[melroy89]

[-- Attachment #1: Type: text/plain, Size: 215 bytes --]

New comment by melroy89 on void-packages repository

https://github.com/void-linux/void-packages/pull/48642#issuecomment-1937334369

Comment:
Ps. I removed `configure_args` completely as it was deemed unnecessary. 

Re: [PR PATCH] [Updated] New package: winegui-2.3.5

[melroy89]

[-- Attachment #1: Type: text/plain, Size: 1692 bytes --]

There is an updated pull request by melroy89 against master on the void-packages repository

https://github.com/melroy89/void-packages add_winegui
https://github.com/void-linux/void-packages/pull/48642

New package: winegui-2.3.5
Introducing WineGUI package. At last, a user-friendly Wine graphical interface.

I'm the developer of [WineGUI](https://gitlab.melroy.org/melroy/winegui).

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

The x86_64 build went fine. I also tested the WineGUI application itself, running on Void Linux. I did notice that wine-32bit was missing as well. But multilib can't be added as depends too bad! 

Hence I added a `README.voidlinux`, just like the Steam package. However, I hope there will be a **better solution** in the neat future. 

I also tried `armv6l` and `armv7l` cross-builds, but this seems to fail on wine? That is too bad.

```sh
=> wine-9.1_1: the following build options are set:
   mingw: Use the MinGW cross compiler to build WinPE DLLs (ON)
   xshm: Enable support for the X Shared Memory Extension (ON)
   staging: Apply the wine-staging patchset (OFF)
=> ERROR: wine-9.1_1: this package cannot be built for armv6l.
```

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc) -> OK

- I tried to build this PR locally for these architectures, but failed...:
  - armv7l
  - armv6l


A patch file from https://github.com/void-linux/void-packages/pull/48642.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-add_winegui-48642.patch --]
[-- Type: text/x-diff, Size: 3127 bytes --]

From 2d2f5f416a643059751b0f28ebfee1149a450780 Mon Sep 17 00:00:00 2001
From: Melroy van den Berg <melroy@melroy.org>
Date: Sun, 11 Feb 2024 01:10:10 +0100
Subject: [PATCH] New package: winegui-2.3.5

---
 srcpkgs/winegui/files/README.voidlinux | 36 ++++++++++++++++++++++++++
 srcpkgs/winegui/template               | 20 ++++++++++++++
 2 files changed, 56 insertions(+)
 create mode 100644 srcpkgs/winegui/files/README.voidlinux
 create mode 100644 srcpkgs/winegui/template

diff --git a/srcpkgs/winegui/files/README.voidlinux b/srcpkgs/winegui/files/README.voidlinux
new file mode 100644
index 0000000000000..4e42a25e6c263
--- /dev/null
+++ b/srcpkgs/winegui/files/README.voidlinux
@@ -0,0 +1,36 @@
+WineGUI on i686 should work without needing to install any extra packages.
+
+WineGUI on x86_64 requires support for Wine in 32bits mode and OpenGL/Vulkan in 32bits mode,
+the 32bit packages are available in the multilib repository.
+
+Install the multilib repository to your system:
+
+	# xbps-install -S void-repo-multilib{,-nonfree}
+
+Generic (for all systems):
+
+	# xbps-install -S wine-32bit libgcc-32bit libstdc++-32bit libdrm-32bit libglvnd-32bit
+
+For users of the open source drivers (eg. AMD):
+
+	# xbps-install -S mesa-dri-32bit
+
+For users of the proprietary NVIDIA driver, install the appropriate 32-bit
+libraries for the version of nvidia you have installed:
+
+	# xbps-install -S nvidia-libs-32bit (for the latest nvidia package)
+	# xbps-install -S nvidia470-libs-32bit (for the latest previous package)
+	# xbps-install -S nvidia390-libs-32bit (for the legacy previous package)
+
+For mesa users this would result in:
+
+	# xbps-install -S wine-32bit libgcc-32bit libstdc++-32bit libdrm-32bit libglvnd-32bit mesa-dri-32bit
+
+The dbus service must be enabled, and the mono package will need to be
+installed for some apps/games to function.
+
+If games are running slowly or not at all, or there are issues with network
+streaming, verify that your user belongs to the video group.
+
+If your audio is not working, try installing pulseaudio,
+alsa-plugins-pulseaudio, and their "<package>-32bit" equivalents.
diff --git a/srcpkgs/winegui/template b/srcpkgs/winegui/template
new file mode 100644
index 0000000000000..3f8771c17fc20
--- /dev/null
+++ b/srcpkgs/winegui/template
@@ -0,0 +1,20 @@
+# Template file for 'winegui'
+pkgname=winegui
+version=2.3.5
+revision=1
+build_style=cmake
+configure_args="-DCUSTOM_PROJECT_VERSION:STRING=${version}"
+hostmakedepends="pkg-config cmake gobject-introspection gdk-pixbuf-devel"
+makedepends="gtk+3-devel gtkmm-devel libglib-devel gdk-pixbuf pango-devel cairo-devel atk-devel"
+depends="wine wget unzip p7zip cabextract zenity"
+short_desc="User-friendly WINE manager"
+maintainer="Melroy van den Berg <melroy@melroy.org>"
+license="AGPL-3.0-only"
+homepage="https://gitlab.melroy.org/melroy/winegui"
+distfiles="https://gitlab.melroy.org/melroy/winegui/-/archive/v${version}/winegui-v${version}.tar.gz"
+checksum=49eb2cf881bca4e3174ec08e34b270badd6a8275ad9a1a48ff6df621df1a9a24
+
+post_install() {
+	vlicense LICENSE
+	vdoc "${FILESDIR}/README.voidlinux"
+}

Re: New package: winegui-2.3.5

[melroy89]

[-- Attachment #1: Type: text/plain, Size: 190 bytes --]

New comment by melroy89 on void-packages repository

https://github.com/void-linux/void-packages/pull/48642#issuecomment-1937334369

Comment:
Ps. I switched to Cmake option instead for now.

Re: New package: winegui-2.3.5

[melroy89]

[-- Attachment #1: Type: text/plain, Size: 206 bytes --]

New comment by melroy89 on void-packages repository

https://github.com/void-linux/void-packages/pull/48642#issuecomment-1937334369

Comment:
Ps. I switched to Cmake option instead of env variable for now.

Re: New package: winegui-2.3.5

[chrysos349]

[-- Attachment #1: Type: text/plain, Size: 982 bytes --]

New comment by chrysos349 on void-packages repository

https://github.com/void-linux/void-packages/pull/48642#issuecomment-1937393840

Comment:
here is a cleaner template. the package compiles fine for `archs` wine supports.

p.s. why did you need `zenity`?

```
# Template file for 'winegui'
pkgname=winegui
version=2.3.5
revision=1
archs="i686* x86_64*"
build_style=cmake
configure_args="-DCUSTOM_PROJECT_VERSION:STRING=${version}"
hostmakedepends="pkg-config"
makedepends="gtkmm-devel"
depends="cabextract p7zip unzip wget wine"
short_desc="User-friendly WINE manager"
maintainer="Melroy van den Berg <melroy@melroy.org>"
license="AGPL-3.0-only"
homepage="https://gitlab.melroy.org/melroy/winegui"
distfiles="https://gitlab.melroy.org/melroy/winegui/-/archive/v${version}/winegui-v${version}.tar.gz"
checksum=49eb2cf881bca4e3174ec08e34b270badd6a8275ad9a1a48ff6df621df1a9a24

post_install() {
	vlicense LICENSE
	vdoc "${FILESDIR}/README.voidlinux"
}
```

Re: [PR PATCH] [Updated] New package: winegui-2.3.5

[melroy89]

[-- Attachment #1: Type: text/plain, Size: 1692 bytes --]

There is an updated pull request by melroy89 against master on the void-packages repository

https://github.com/melroy89/void-packages add_winegui
https://github.com/void-linux/void-packages/pull/48642

New package: winegui-2.3.5
Introducing WineGUI package. At last, a user-friendly Wine graphical interface.

I'm the developer of [WineGUI](https://gitlab.melroy.org/melroy/winegui).

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

The x86_64 build went fine. I also tested the WineGUI application itself, running on Void Linux. I did notice that wine-32bit was missing as well. But multilib can't be added as depends too bad! 

Hence I added a `README.voidlinux`, just like the Steam package. However, I hope there will be a **better solution** in the neat future. 

I also tried `armv6l` and `armv7l` cross-builds, but this seems to fail on wine? That is too bad.

```sh
=> wine-9.1_1: the following build options are set:
   mingw: Use the MinGW cross compiler to build WinPE DLLs (ON)
   xshm: Enable support for the X Shared Memory Extension (ON)
   staging: Apply the wine-staging patchset (OFF)
=> ERROR: wine-9.1_1: this package cannot be built for armv6l.
```

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc) -> OK

- I tried to build this PR locally for these architectures, but failed...:
  - armv7l
  - armv6l


A patch file from https://github.com/void-linux/void-packages/pull/48642.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-add_winegui-48642.patch --]
[-- Type: text/x-diff, Size: 3035 bytes --]

From c1253a277d5f8430115f535c082d01c6e4f0cb2f Mon Sep 17 00:00:00 2001
From: Melroy van den Berg <melroy@melroy.org>
Date: Sun, 11 Feb 2024 04:18:21 +0100
Subject: [PATCH] New package: winegui-2.3.5

---
 srcpkgs/winegui/files/README.voidlinux | 36 ++++++++++++++++++++++++++
 srcpkgs/winegui/template               | 21 +++++++++++++++
 2 files changed, 57 insertions(+)
 create mode 100644 srcpkgs/winegui/files/README.voidlinux
 create mode 100644 srcpkgs/winegui/template

diff --git a/srcpkgs/winegui/files/README.voidlinux b/srcpkgs/winegui/files/README.voidlinux
new file mode 100644
index 0000000000000..4e42a25e6c263
--- /dev/null
+++ b/srcpkgs/winegui/files/README.voidlinux
@@ -0,0 +1,36 @@
+WineGUI on i686 should work without needing to install any extra packages.
+
+WineGUI on x86_64 requires support for Wine in 32bits mode and OpenGL/Vulkan in 32bits mode,
+the 32bit packages are available in the multilib repository.
+
+Install the multilib repository to your system:
+
+	# xbps-install -S void-repo-multilib{,-nonfree}
+
+Generic (for all systems):
+
+	# xbps-install -S wine-32bit libgcc-32bit libstdc++-32bit libdrm-32bit libglvnd-32bit
+
+For users of the open source drivers (eg. AMD):
+
+	# xbps-install -S mesa-dri-32bit
+
+For users of the proprietary NVIDIA driver, install the appropriate 32-bit
+libraries for the version of nvidia you have installed:
+
+	# xbps-install -S nvidia-libs-32bit (for the latest nvidia package)
+	# xbps-install -S nvidia470-libs-32bit (for the latest previous package)
+	# xbps-install -S nvidia390-libs-32bit (for the legacy previous package)
+
+For mesa users this would result in:
+
+	# xbps-install -S wine-32bit libgcc-32bit libstdc++-32bit libdrm-32bit libglvnd-32bit mesa-dri-32bit
+
+The dbus service must be enabled, and the mono package will need to be
+installed for some apps/games to function.
+
+If games are running slowly or not at all, or there are issues with network
+streaming, verify that your user belongs to the video group.
+
+If your audio is not working, try installing pulseaudio,
+alsa-plugins-pulseaudio, and their "<package>-32bit" equivalents.
diff --git a/srcpkgs/winegui/template b/srcpkgs/winegui/template
new file mode 100644
index 0000000000000..8e1bf61e69643
--- /dev/null
+++ b/srcpkgs/winegui/template
@@ -0,0 +1,21 @@
+# Template file for 'winegui'
+pkgname=winegui
+version=2.3.5
+revision=1
+archs="i686* x86_64*"
+build_style=cmake
+configure_args="-DCUSTOM_PROJECT_VERSION:STRING=${version}"
+hostmakedepends="pkg-config"
+makedepends="gtkmm-devel"
+depends="wine wget unzip p7zip cabextract zenity"
+short_desc="User-friendly WINE manager"
+maintainer="Melroy van den Berg <melroy@melroy.org>"
+license="AGPL-3.0-only"
+homepage="https://gitlab.melroy.org/melroy/winegui"
+distfiles="https://gitlab.melroy.org/melroy/winegui/-/archive/v${version}/winegui-v${version}.tar.gz"
+checksum=49eb2cf881bca4e3174ec08e34b270badd6a8275ad9a1a48ff6df621df1a9a24
+
+post_install() {
+	vlicense LICENSE
+	vdoc "${FILESDIR}/README.voidlinux"
+}

Re: New package: winegui-2.3.5

[melroy89]

[-- Attachment #1: Type: text/plain, Size: 468 bytes --]

New comment by melroy89 on void-packages repository

https://github.com/void-linux/void-packages/pull/48642#issuecomment-1937407833

Comment:
Thanks. I cleaned it up.

> p.s. why did you need `zenity`?

unzip, wget, p7zip, cabextract and zenity are used by winetricks, which is downloaded independently.  If users want to interact with the Winetricks GUI they need to have zenity installed. Hence I add it as a depends for better usability of WineGUI as a whole. 

Re: New package: winegui-2.3.5

[melroy89]

[-- Attachment #1: Type: text/plain, Size: 578 bytes --]

New comment by melroy89 on void-packages repository

https://github.com/void-linux/void-packages/pull/48642#issuecomment-1937407833

Comment:
Thanks. I cleaned it up.

> p.s. why did you need `zenity`?

unzip, wget, p7zip, cabextract and zenity are used by winetricks, which is downloaded independently.  If users want to interact with the Winetricks GUI they need to have zenity installed. Hence I add it as a depends for better usability of WineGUI as a whole. This will give users the best experience when using WineGUI as well (but WineGUI itself only depends on GTK3).

Re: New package: winegui-2.3.5

[melroy89]

[-- Attachment #1: Type: text/plain, Size: 836 bytes --]

New comment by melroy89 on void-packages repository

https://github.com/void-linux/void-packages/pull/48642#issuecomment-1937407833

Comment:
Thanks. I cleaned it up.

> p.s. why did you need `zenity`?

unzip, wget, p7zip, cabextract and zenity are used by winetricks, which is downloaded independently.  If users want to interact with the Winetricks GUI they need to have zenity installed. Hence I add it as a depends for better usability of WineGUI as a whole. This will give users the best experience when using WineGUI as well (but WineGUI itself only depends on GTK3).

Ps. WineGUI will also use winetricks under the hood in some cases, eg. installing packages under the 'Configure' window using the one-button click installs. But you won't notice it's using winetricks, WineGUI is aimed to be as user-friendly as possible. 

Re: [PR REVIEW] New package: winegui-2.3.5

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 403 bytes --]

New review comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/48642#discussion_r1485603607

Comment:
As I noted on IRC, you should amend your distribution procress so this argument is unnecessary. Relying on the build process to tell you the version number for your own package is bad practice and, as the upstream author, you are in a position to fix it.

Re: [PR REVIEW] New package: winegui-2.3.5

[melroy89]

[-- Attachment #1: Type: text/plain, Size: 655 bytes --]

New review comment by melroy89 on void-packages repository

https://github.com/void-linux/void-packages/pull/48642#discussion_r1485611772

Comment:
I try my best. I don't want a version number checked in the source code. I like the way of dynamically setting the version (based on a git tags or a variable).

However, it seems like GitLab doesn't allow me to have any control of the published source archives. Meaning there is no easy way to prepare those generated source archives. And as I mentioned on IRC I don't like to check in generated code. The version is based on git tags, which work very well when doing package releasing via gitlab ci/cd. 

Re: [PR REVIEW] New package: winegui-2.3.5

[melroy89]

[-- Attachment #1: Type: text/plain, Size: 655 bytes --]

New review comment by melroy89 on void-packages repository

https://github.com/void-linux/void-packages/pull/48642#discussion_r1485611772

Comment:
I try my best. I don't want a version number checked in the source code. I like the way of dynamically setting the version (based on a git tags or a variable).

However, it seems like GitLab doesn't allow me to have any control of the published source archives. Meaning there is no easy way to prepare those generated source archives. And as I mentioned on IRC I don't like to check-in generated code. The version is based on git tags, which work very well when doing package releasing via gitlab ci/cd. 

Re: [PR REVIEW] New package: winegui-2.3.5

[melroy89]

[-- Attachment #1: Type: text/plain, Size: 721 bytes --]

New review comment by melroy89 on void-packages repository

https://github.com/void-linux/void-packages/pull/48642#discussion_r1485611772

Comment:
I try my best. I don't want a version number checked in the source code. I like the way of dynamically setting the version (based on a git tags or a variable).

However, it seems like GitLab doesn't allow me to have any control of the published source archives. Meaning there is no easy way to prepare those generated source archives. And as I mentioned on IRC I don't like to check-in generated code. The version is based on git tags, which work very well when doing package releasing via gitlab ci/cd. 

EDIT: I did add support for reading `version.txt` as well now.

Re: New package: winegui-2.3.5

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 1209 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/48642#issuecomment-1937805832

Comment:
-- Andrew J. ***@***.***[Mobile communication](585) 203-4284On Feb 11, 2024, at 10:07 AM, Melroy van den Berg ***@***.***> wrote:
@melroy89 commented on this pull request.



In srcpkgs/winegui/template:
> @@ -0,0 +1,21 @@
+# Template file for 'winegui'
+pkgname=winegui
+version=2.3.5
+revision=1
+archs="i686* x86_64*"
+build_style=cmake
+configure_args="-DCUSTOM_PROJECT_VERSION:STRING=${version}"

I try my best. I don't want a version number checked in the source code. I like the way of dynamically setting the version (based on a git tags or a variable).
However, it seems like GitLab doesn't allow me to have any control of the published source archives. Meaning there is no easy way to prepare those generated source archives. And as I mentioned on IRC I don't like to check in generated code. The version is based on git tags, which work very well when doing package releasing via gitlab ci/cd.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: ***@***.***>

Re: New package: winegui-2.3.5

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 1209 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/48642#issuecomment-1937805832

Comment:
-- Andrew J. ***@***.***[Mobile communication](585) 203-4284On Feb 11, 2024, at 10:07 AM, Melroy van den Berg ***@***.***> wrote:
@melroy89 commented on this pull request.



In srcpkgs/winegui/template:
> @@ -0,0 +1,21 @@
+# Template file for 'winegui'
+pkgname=winegui
+version=2.3.5
+revision=1
+archs="i686* x86_64*"
+build_style=cmake
+configure_args="-DCUSTOM_PROJECT_VERSION:STRING=${version}"

I try my best. I don't want a version number checked in the source code. I like the way of dynamically setting the version (based on a git tags or a variable).
However, it seems like GitLab doesn't allow me to have any control of the published source archives. Meaning there is no easy way to prepare those generated source archives. And as I mentioned on IRC I don't like to check in generated code. The version is based on git tags, which work very well when doing package releasing via gitlab ci/cd.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: ***@***.***>

Re: [PR PATCH] [Closed]: New package: winegui-2.3.5

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 1530 bytes --]

There's a closed pull request on the void-packages repository

New package: winegui-2.3.5
https://github.com/void-linux/void-packages/pull/48642

Description:
Introducing WineGUI package. At last, a user-friendly Wine graphical interface.

I'm the developer of [WineGUI](https://gitlab.melroy.org/melroy/winegui).

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

The x86_64 build went fine. I also tested the WineGUI application itself, running on Void Linux. I did notice that wine-32bit was missing as well. But multilib can't be added as depends too bad! 

Hence I added a `README.voidlinux`, just like the Steam package. However, I hope there will be a **better solution** in the neat future. 

I also tried `armv6l` and `armv7l` cross-builds, but this seems to fail on wine? That is too bad.

```sh
=> wine-9.1_1: the following build options are set:
   mingw: Use the MinGW cross compiler to build WinPE DLLs (ON)
   xshm: Enable support for the X Shared Memory Extension (ON)
   staging: Apply the wine-staging patchset (OFF)
=> ERROR: wine-9.1_1: this package cannot be built for armv6l.
```

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc) -> OK

- I tried to build this PR locally for these architectures, but failed...:
  - armv7l
  - armv6l

Re: New package: winegui-2.3.5

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 293 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/48642#issuecomment-1937829061

Comment:
When you figure out a way to manage your versioning that does not require us to tell you the version of your own software, feel free to resubmit this.

Re: New package: winegui-2.3.5

[melroy89]

[-- Attachment #1: Type: text/plain, Size: 364 bytes --]

New comment by melroy89 on void-packages repository

https://github.com/void-linux/void-packages/pull/48642#issuecomment-1937846591

Comment:
> When you figure out a way to manage your versioning that does not require us to tell you the version of your own software, feel free to resubmit this.

Follow-up: https://github.com/void-linux/void-packages/pull/48658

Re: [PR REVIEW] New package: winegui-2.3.5

[melroy89]

[-- Attachment #1: Type: text/plain, Size: 158 bytes --]

New review comment by melroy89 on void-packages repository

https://github.com/void-linux/void-packages/pull/48642#discussion_r1485657774

Comment:
Resolved.