Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] qsynth: update to 0.9.13
@ 2024-01-29 20:21 kaey
  2024-02-13 17:26 ` [PR REVIEW] " cinerea0
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: kaey @ 2024-01-29 20:21 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 573 bytes --]

There is a new pull request by kaey against master on the void-packages repository

https://github.com/kaey/void-packages qsynth-0.9.13
https://github.com/void-linux/void-packages/pull/48428

qsynth: update to 0.9.13
#### Testing the changes
- I tested the changes in this PR: **YES**



#### Local build testing
- I built this PR locally for my native architecture, x86_64
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64



A patch file from https://github.com/void-linux/void-packages/pull/48428.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-qsynth-0.9.13-48428.patch --]
[-- Type: text/x-diff, Size: 1488 bytes --]

From 611bfa0d836f894d7441cc7a1b9c83d85bfa25ee Mon Sep 17 00:00:00 2001
From: Konstantin Kulikov <k.kulikov2@gmail.com>
Date: Mon, 29 Jan 2024 23:19:32 +0300
Subject: [PATCH] qsynth: update to 0.9.13

---
 srcpkgs/qsynth/template | 20 +++++++-------------
 1 file changed, 7 insertions(+), 13 deletions(-)

diff --git a/srcpkgs/qsynth/template b/srcpkgs/qsynth/template
index 19f39132fc380..ddacd45f2f6d5 100644
--- a/srcpkgs/qsynth/template
+++ b/srcpkgs/qsynth/template
@@ -1,20 +1,14 @@
 # Template file for 'qsynth'
 pkgname=qsynth
-version=0.9.2
-revision=2
-build_style=gnu-configure
-build_helper=qmake
-hostmakedepends="pkg-config qt5-tools"
-makedepends="qt5-x11extras-devel jack-devel fluidsynth-devel"
-depends="fluidsynth jack desktop-file-utils hicolor-icon-theme"
+version=0.9.13
+revision=1
+build_style=cmake
+hostmakedepends="pkg-config qt6-tools qt6-base"
+makedepends="qt6-base-devel qt6-svg-devel fluidsynth-devel"
+depends="fluidsynth"
 short_desc="Qt GUI Interface for FluidSynth"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="GPL-2.0-or-later"
 homepage="http://qsynth.sourceforge.io"
 distfiles="${SOURCEFORGE_SITE}/${pkgname}/${pkgname}-${version}.tar.gz"
-checksum=ee9202178a6453c84d8016e61fd9a364e3dbbd306b4f3658baaa05be29927c3e
-
-if [ "${CROSS_BUILD}" ]; then
-	hostmakedepends+=" qt5-x11extras-devel"
-	configure_args+=" ac_cv_path_ac_cv_qmake=${XBPS_WRAPPERDIR}/qmake"
-fi
+checksum=4af819add4ba0705a13606e8bdc7e1a5029572ed22c2be1d0ea788724ba8d5f9

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PR REVIEW] qsynth: update to 0.9.13
  2024-01-29 20:21 [PR PATCH] qsynth: update to 0.9.13 kaey
@ 2024-02-13 17:26 ` cinerea0
  2024-02-13 18:56 ` kaey
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: cinerea0 @ 2024-02-13 17:26 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 253 bytes --]

New review comment by cinerea0 on void-packages repository

https://github.com/void-linux/void-packages/pull/48428#discussion_r1488297964

Comment:
```suggestion
depends="fluidsynth jack"
```

This still depends on JACK at runtime when I tested it.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PR REVIEW] qsynth: update to 0.9.13
  2024-01-29 20:21 [PR PATCH] qsynth: update to 0.9.13 kaey
  2024-02-13 17:26 ` [PR REVIEW] " cinerea0
@ 2024-02-13 18:56 ` kaey
  2024-02-13 19:00 ` kaey
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: kaey @ 2024-02-13 18:56 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 193 bytes --]

New review comment by kaey on void-packages repository

https://github.com/void-linux/void-packages/pull/48428#discussion_r1488428216

Comment:
ye, but jack server is also provided by pipewire

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PR REVIEW] qsynth: update to 0.9.13
  2024-01-29 20:21 [PR PATCH] qsynth: update to 0.9.13 kaey
  2024-02-13 17:26 ` [PR REVIEW] " cinerea0
  2024-02-13 18:56 ` kaey
@ 2024-02-13 19:00 ` kaey
  2024-02-13 20:36 ` cinerea0
  2024-02-13 20:37 ` [PR PATCH] [Merged]: " cinerea0
  4 siblings, 0 replies; 6+ messages in thread
From: kaey @ 2024-02-13 19:00 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 327 bytes --]

New review comment by kaey on void-packages repository

https://github.com/void-linux/void-packages/pull/48428#discussion_r1488428216

Comment:
ye, but jack server is also provided by pipewire. and also you can switch midi driver to alsa/pipewire/sdl2/other.

if anything qsynth doesn't depend on any output, fluidsynth does

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PR REVIEW] qsynth: update to 0.9.13
  2024-01-29 20:21 [PR PATCH] qsynth: update to 0.9.13 kaey
                   ` (2 preceding siblings ...)
  2024-02-13 19:00 ` kaey
@ 2024-02-13 20:36 ` cinerea0
  2024-02-13 20:37 ` [PR PATCH] [Merged]: " cinerea0
  4 siblings, 0 replies; 6+ messages in thread
From: cinerea0 @ 2024-02-13 20:36 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 167 bytes --]

New review comment by cinerea0 on void-packages repository

https://github.com/void-linux/void-packages/pull/48428#discussion_r1488542775

Comment:
Yeah, fair enough.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PR PATCH] [Merged]: qsynth: update to 0.9.13
  2024-01-29 20:21 [PR PATCH] qsynth: update to 0.9.13 kaey
                   ` (3 preceding siblings ...)
  2024-02-13 20:36 ` cinerea0
@ 2024-02-13 20:37 ` cinerea0
  4 siblings, 0 replies; 6+ messages in thread
From: cinerea0 @ 2024-02-13 20:37 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 422 bytes --]

There's a merged pull request on the void-packages repository

qsynth: update to 0.9.13
https://github.com/void-linux/void-packages/pull/48428

Description:
#### Testing the changes
- I tested the changes in this PR: **YES**



#### Local build testing
- I built this PR locally for my native architecture, x86_64
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64



^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2024-02-13 20:37 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-29 20:21 [PR PATCH] qsynth: update to 0.9.13 kaey
2024-02-13 17:26 ` [PR REVIEW] " cinerea0
2024-02-13 18:56 ` kaey
2024-02-13 19:00 ` kaey
2024-02-13 20:36 ` cinerea0
2024-02-13 20:37 ` [PR PATCH] [Merged]: " cinerea0

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).