Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] adwaita-qt: enable Qt 6 support
@ 2024-02-13 21:45 dsemy
  2024-02-13 22:31 ` dsemy
                   ` (6 more replies)
  0 siblings, 7 replies; 8+ messages in thread
From: dsemy @ 2024-02-13 21:45 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1100 bytes --]

There is a new pull request by dsemy against master on the void-packages repository

https://github.com/dsemy/void-packages master
https://github.com/void-linux/void-packages/pull/48707

adwaita-qt: enable Qt 6 support
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, x86-64-glibc


A patch file from https://github.com/void-linux/void-packages/pull/48707.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-48707.patch --]
[-- Type: text/x-diff, Size: 947 bytes --]

From 6cdc7d927fbb4586dd4af49ac15125f1d6387049 Mon Sep 17 00:00:00 2001
From: Daniel Semyonov <daniel@dsemy.com>
Date: Tue, 13 Feb 2024 23:29:39 +0200
Subject: [PATCH] adwaita-qt: enable Qt 6 support

---
 srcpkgs/adwaita-qt/template | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/adwaita-qt/template b/srcpkgs/adwaita-qt/template
index 83dec4a991a111..8d7843b2631fcd 100644
--- a/srcpkgs/adwaita-qt/template
+++ b/srcpkgs/adwaita-qt/template
@@ -1,10 +1,11 @@
 # Template file for 'adwaita-qt'
 pkgname=adwaita-qt
 version=1.4.2
-revision=1
+revision=2
 build_style=cmake
+configure_args="-DUSE_QT6=1"
 hostmakedepends="qt5-host-tools qt5-qmake"
-makedepends="qt5-devel qt5-x11extras-devel"
+makedepends="qt5-devel qt5-x11extras-devel qt6-base-devel"
 short_desc="Style to bend Qt applications to look like they belong into GNOME Shell"
 maintainer="Piotr Wójcik <chocimier@tlen.pl>"
 license="GPL-2.0-or-later"

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: adwaita-qt: enable Qt 6 support
  2024-02-13 21:45 [PR PATCH] adwaita-qt: enable Qt 6 support dsemy
@ 2024-02-13 22:31 ` dsemy
  2024-02-13 22:42 ` classabbyamp
                   ` (5 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: dsemy @ 2024-02-13 22:31 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 435 bytes --]

New comment by dsemy on void-packages repository

https://github.com/void-linux/void-packages/pull/48707#issuecomment-1942748018

Comment:
Cross compile is failing because QT_HOST_PATH isn't set (required when cross compiling with Qt 6 as it turns out).
Not sure how to make this work, the best information I found about this variable are two messages sent to a Debian mailing list by someone who also didn't seem to figure this out.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: adwaita-qt: enable Qt 6 support
  2024-02-13 21:45 [PR PATCH] adwaita-qt: enable Qt 6 support dsemy
  2024-02-13 22:31 ` dsemy
@ 2024-02-13 22:42 ` classabbyamp
  2024-02-13 22:43 ` classabbyamp
                   ` (4 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: classabbyamp @ 2024-02-13 22:42 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 173 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/48707#issuecomment-1942759494

Comment:
hostmakedepends+=qt6-tools

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: adwaita-qt: enable Qt 6 support
  2024-02-13 21:45 [PR PATCH] adwaita-qt: enable Qt 6 support dsemy
  2024-02-13 22:31 ` dsemy
  2024-02-13 22:42 ` classabbyamp
@ 2024-02-13 22:43 ` classabbyamp
  2024-02-14  0:19 ` dsemy
                   ` (3 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: classabbyamp @ 2024-02-13 22:43 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 267 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/48707#issuecomment-1942760734

Comment:
also this seems to *remove* the qt5 version. it's probably going to have to be built twice, once with each version of qt

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: adwaita-qt: enable Qt 6 support
  2024-02-13 21:45 [PR PATCH] adwaita-qt: enable Qt 6 support dsemy
                   ` (2 preceding siblings ...)
  2024-02-13 22:43 ` classabbyamp
@ 2024-02-14  0:19 ` dsemy
  2024-02-14  0:27 ` classabbyamp
                   ` (2 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: dsemy @ 2024-02-14  0:19 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 323 bytes --]

New comment by dsemy on void-packages repository

https://github.com/void-linux/void-packages/pull/48707#issuecomment-1942892888

Comment:
Yeah you're right I didn't realize that (I was using a local Qt 6 build alongside the current package so I had both versions installed).
Maybe this should be split into two packages?

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: adwaita-qt: enable Qt 6 support
  2024-02-13 21:45 [PR PATCH] adwaita-qt: enable Qt 6 support dsemy
                   ` (3 preceding siblings ...)
  2024-02-14  0:19 ` dsemy
@ 2024-02-14  0:27 ` classabbyamp
  2024-02-15  2:33 ` [PR PATCH] [Closed]: " sgn
  2024-02-15  2:33 ` sgn
  6 siblings, 0 replies; 8+ messages in thread
From: classabbyamp @ 2024-02-14  0:27 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 238 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/48707#issuecomment-1942900243

Comment:
i'm not sure this needs separate packages, maybe something like what qwt does could be done

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR PATCH] [Closed]: adwaita-qt: enable Qt 6 support
  2024-02-13 21:45 [PR PATCH] adwaita-qt: enable Qt 6 support dsemy
                   ` (4 preceding siblings ...)
  2024-02-14  0:27 ` classabbyamp
@ 2024-02-15  2:33 ` sgn
  2024-02-15  2:33 ` sgn
  6 siblings, 0 replies; 8+ messages in thread
From: sgn @ 2024-02-15  2:33 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 954 bytes --]

There's a closed pull request on the void-packages repository

adwaita-qt: enable Qt 6 support
https://github.com/void-linux/void-packages/pull/48707

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, x86-64-glibc


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: adwaita-qt: enable Qt 6 support
  2024-02-13 21:45 [PR PATCH] adwaita-qt: enable Qt 6 support dsemy
                   ` (5 preceding siblings ...)
  2024-02-15  2:33 ` [PR PATCH] [Closed]: " sgn
@ 2024-02-15  2:33 ` sgn
  6 siblings, 0 replies; 8+ messages in thread
From: sgn @ 2024-02-15  2:33 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 178 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/48707#issuecomment-1945270501

Comment:
d2ade215f130d0c134cd4810fde8ce25fd45341d

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2024-02-15  2:33 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-13 21:45 [PR PATCH] adwaita-qt: enable Qt 6 support dsemy
2024-02-13 22:31 ` dsemy
2024-02-13 22:42 ` classabbyamp
2024-02-13 22:43 ` classabbyamp
2024-02-14  0:19 ` dsemy
2024-02-14  0:27 ` classabbyamp
2024-02-15  2:33 ` [PR PATCH] [Closed]: " sgn
2024-02-15  2:33 ` sgn

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).