[PR PATCH] python3-websocket-client: fix alternatives, update to 1.7.0

[PR PATCH] python3-websocket-client: fix alternatives, update to 1.7.0

[dkwo]

[-- Attachment #1: Type: text/plain, Size: 473 bytes --]

There is a new pull request by dkwo against master on the void-packages repository

https://github.com/dkwo/void-packages wsdump
https://github.com/void-linux/void-packages/pull/48607

python3-websocket-client: fix alternatives, update to 1.7.0
discoverd this with `xbps-pkgdb -a`, and while at it also updated.
cc @tornaria @ahesford 
`/usr/bin/wsdump` was broken, now it works.

A patch file from https://github.com/void-linux/void-packages/pull/48607.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-wsdump-48607.patch --]
[-- Type: text/x-diff, Size: 1675 bytes --]

From e0e19c76621c5b773a834cf49731c3fe9f91a01e Mon Sep 17 00:00:00 2001
From: dkwo <nicolopiazzalunga@gmail.com>
Date: Thu, 8 Feb 2024 11:44:55 -0500
Subject: [PATCH] python3-websocket-client: fix alternatives, update to 1.7.0

---
 srcpkgs/python3-websocket-client/template | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/srcpkgs/python3-websocket-client/template b/srcpkgs/python3-websocket-client/template
index 2af5a45ed25f5..71a5a67e1b5d6 100644
--- a/srcpkgs/python3-websocket-client/template
+++ b/srcpkgs/python3-websocket-client/template
@@ -1,17 +1,17 @@
 # Template file for 'python3-websocket-client'
 pkgname=python3-websocket-client
-version=1.6.3
-revision=2
-build_style=python3-module
+version=1.7.0
+revision=1
+build_style=python3-pep517
 make_check_target="websocket/tests"
-hostmakedepends="python3-setuptools"
+hostmakedepends="python3-setuptools python3-wheel"
 depends="python3 ca-certificates"
-checkdepends="python3-pytest"
+checkdepends="python3-pytest python3-socks"
 short_desc="WebSocket client for Python3"
 maintainer="Sergi Alvarez <pancake@nopcode.org>"
 license="Apache-2.0"
 homepage="https://github.com/websocket-client/websocket-client"
 changelog="https://raw.githubusercontent.com/websocket-client/websocket-client/master/ChangeLog"
 distfiles="https://github.com/websocket-client/websocket-client/archive/refs/tags/v${version}.tar.gz"
-checksum=65e9e02843ef02b8f9503d6b284a3605d92c201170b5b234afcaf1c5a01c64e0
-alternatives="websocket-client:wsdump:/usr/bin/wsdump.py"
+checksum=923c3b7d0cecfdc449eec5e95c90ae6b0ea24e8782d42f23c05d2bb43bfabd39
+alternatives="websocket-client:wsdump:/usr/bin/wsdump"

Re: python3-websocket-client: fix alternatives, update to 1.7.0

[tornaria]

[-- Attachment #1: Type: text/plain, Size: 405 bytes --]

New comment by tornaria on void-packages repository

https://github.com/void-linux/void-packages/pull/48607#issuecomment-1934969393

Comment:
I couldn't find any alternative `/usr/bin/wsdump`, is there any? If not, just remove the `alternatives=` line.

Besides, I don't understand `alternatives="websocket-client:wsdump:/usr/bin/wsdump"`, wouldn't that make a symlink from `/usr/bin/wsdump` to itself?

Re: python3-websocket-client: fix alternatives, update to 1.7.0

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 370 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/48607#issuecomment-1934982075

Comment:
The `wsdump` script would have to be renamed `wsdump3` to make the alternative work. It's a holdover from when we had a Py2 version of the package, but lately we've been replacing altneratives like this with a conflict instead.

Re: python3-websocket-client: fix alternatives, update to 1.7.0

[dkwo]

[-- Attachment #1: Type: text/plain, Size: 217 bytes --]

New comment by dkwo on void-packages repository

https://github.com/void-linux/void-packages/pull/48607#issuecomment-1935005688

Comment:
I see. Should I remove the alternative? or make it conflict with what exactly?

Re: python3-websocket-client: fix alternatives, update to 1.7.0

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 279 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/48607#issuecomment-1935223262

Comment:
The alternative can be removed, and the package should conflict with `python-websocket-client` in case anybody still has that installed.

Re: [PR PATCH] [Updated] python3-websocket-client: fix alternatives, update to 1.7.0

[dkwo]

[-- Attachment #1: Type: text/plain, Size: 478 bytes --]

There is an updated pull request by dkwo against master on the void-packages repository

https://github.com/dkwo/void-packages wsdump
https://github.com/void-linux/void-packages/pull/48607

python3-websocket-client: fix alternatives, update to 1.7.0
discoverd this with `xbps-pkgdb -a`, and while at it also updated.
cc @tornaria @ahesford 
`/usr/bin/wsdump` was broken, now it works.

A patch file from https://github.com/void-linux/void-packages/pull/48607.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-wsdump-48607.patch --]
[-- Type: text/x-diff, Size: 1657 bytes --]

From 5055339f0e9ad38a3622b2c3768c6eb17a9ec38c Mon Sep 17 00:00:00 2001
From: dkwo <nicolopiazzalunga@gmail.com>
Date: Thu, 8 Feb 2024 11:44:55 -0500
Subject: [PATCH] python3-websocket-client: drop alternatives, update to 1.7.0

---
 srcpkgs/python3-websocket-client/template | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/srcpkgs/python3-websocket-client/template b/srcpkgs/python3-websocket-client/template
index 2af5a45ed25f5..b176022f61600 100644
--- a/srcpkgs/python3-websocket-client/template
+++ b/srcpkgs/python3-websocket-client/template
@@ -1,17 +1,17 @@
 # Template file for 'python3-websocket-client'
 pkgname=python3-websocket-client
-version=1.6.3
-revision=2
-build_style=python3-module
+version=1.7.0
+revision=1
+build_style=python3-pep517
 make_check_target="websocket/tests"
-hostmakedepends="python3-setuptools"
+hostmakedepends="python3-setuptools python3-wheel"
 depends="python3 ca-certificates"
-checkdepends="python3-pytest"
+checkdepends="python3-pytest python3-socks"
 short_desc="WebSocket client for Python3"
 maintainer="Sergi Alvarez <pancake@nopcode.org>"
 license="Apache-2.0"
 homepage="https://github.com/websocket-client/websocket-client"
 changelog="https://raw.githubusercontent.com/websocket-client/websocket-client/master/ChangeLog"
 distfiles="https://github.com/websocket-client/websocket-client/archive/refs/tags/v${version}.tar.gz"
-checksum=65e9e02843ef02b8f9503d6b284a3605d92c201170b5b234afcaf1c5a01c64e0
-alternatives="websocket-client:wsdump:/usr/bin/wsdump.py"
+checksum=923c3b7d0cecfdc449eec5e95c90ae6b0ea24e8782d42f23c05d2bb43bfabd39
+conflicts="python-websocket-client"

Re: python3-websocket-client: fix alternatives, update to 1.7.0

[dkwo]

[-- Attachment #1: Type: text/plain, Size: 152 bytes --]

New comment by dkwo on void-packages repository

https://github.com/void-linux/void-packages/pull/48607#issuecomment-1936123000

Comment:
Done, thanks.

Re: python3-websocket-client: fix alternatives, update to 1.7.0

[dkwo]

[-- Attachment #1: Type: text/plain, Size: 158 bytes --]

New comment by dkwo on void-packages repository

https://github.com/void-linux/void-packages/pull/48607#issuecomment-1944572412

Comment:
can this be merged?

Re: [PR PATCH] [Merged]: python3-websocket-client: fix alternatives, update to 1.7.0

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 329 bytes --]

There's a merged pull request on the void-packages repository

python3-websocket-client: fix alternatives, update to 1.7.0
https://github.com/void-linux/void-packages/pull/48607

Description:
discoverd this with `xbps-pkgdb -a`, and while at it also updated.
cc @tornaria @ahesford 
`/usr/bin/wsdump` was broken, now it works.