From: yoshiyoshyosh <yoshiyoshyosh@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] LuaJIT: update to 2.1.1706708390, cleanup.
Date: Mon, 19 Feb 2024 06:00:44 +0100 [thread overview]
Message-ID: <20240219050045.0330C23D5A@inbox.vuxu.org> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-48453@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 620 bytes --]
New review comment by yoshiyoshyosh on void-packages repository
https://github.com/void-linux/void-packages/pull/48453#discussion_r1494011424
Comment:
I don't believe that we should set the version to simply "2.1" and revbump for updates.
For one, it obscures when this is actually updated or when something simply needs to change in the template/shared libs/etc.
For another, when liajit builds and installs, the shared lib has this version, the makefile echoes this as the "minor" version, all the like. By all means, the `git show` *is* the canonical minor version, and it should be reflected in the template
next prev parent reply other threads:[~2024-02-19 5:00 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-31 8:15 [PR PATCH] LuaJIT: update to 2.1.1692580715, cleanup yoshiyoshyosh
2024-01-31 8:17 ` [PR PATCH] [Updated] " yoshiyoshyosh
2024-01-31 17:41 ` [PR REVIEW] " Chocimier
2024-01-31 17:49 ` yoshiyoshyosh
2024-01-31 17:53 ` yoshiyoshyosh
2024-01-31 17:53 ` yoshiyoshyosh
2024-01-31 18:14 ` Chocimier
2024-01-31 18:18 ` yoshiyoshyosh
2024-01-31 18:29 ` [PR PATCH] [Updated] " yoshiyoshyosh
2024-02-15 13:38 ` [PR REVIEW] LuaJIT: update to 2.1.1706708390, cleanup Calandracas606
2024-02-16 16:25 ` Calandracas606
2024-02-16 16:55 ` [PR REVIEW] " Calandracas606
2024-02-16 17:01 ` Calandracas606
2024-02-16 17:18 ` Calandracas606
2024-02-16 17:24 ` Calandracas606
2024-02-16 18:21 ` Calandracas606
2024-02-16 18:29 ` Calandracas606
2024-02-19 5:00 ` yoshiyoshyosh [this message]
2024-02-19 5:06 ` yoshiyoshyosh
2024-02-19 5:06 ` yoshiyoshyosh
2024-02-19 5:20 ` yoshiyoshyosh
2024-02-19 5:24 ` yoshiyoshyosh
2024-02-19 5:35 ` [PR PATCH] [Updated] " yoshiyoshyosh
2024-02-19 12:21 ` Calandracas606
2024-02-24 2:07 ` yoshiyoshyosh
2024-02-24 18:15 ` Calandracas606
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240219050045.0330C23D5A@inbox.vuxu.org \
--to=yoshiyoshyosh@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).