Re: LuaJIT: update to 2.1.1706708390, cleanup.

[Calandracas606 <Calandracas606@users.noreply.github.com>]

[-- Attachment #1: Type: text/plain, Size: 1520 bytes --]

New comment by Calandracas606 on void-packages repository

https://github.com/void-linux/void-packages/pull/48453#issuecomment-1962452705

Comment:
> > I think the remaining patch for luajit_rolling.h can be dropped too: [LuaJIT/LuaJIT@14987af](https://github.com/LuaJIT/LuaJIT/commit/14987af80ab583514f19ef36d1023655324fc757)
> 
> I'm not sure? I look at all the other distros and they seem to keep this patch even after updating past this commit

- Alpine
  - Not updated past this commit
- Chimera
  - LuaJIT not packaged
- Fedora
  - still has LUAJIT_VERSION_SYM patch
  - patch was added in 2015, well before LuaJIT moved to rolling

Fedora patch says that they patched out LUAJIT_VERSION_SYM since it caused ABI breaks on updates, which is the whole point of the macro.

My understanding is that the patch exists because historically, it "artificially" caused an ABI break, even when there were no ABI breaking changes.

Since the move to rolling, the macro has not changed, its value has remained "luaJIT_version_2_1_ROLLING", this suggests that there has been no breaking changes. As long as the macro stays the same, the patch doesn't actually accomplish anything.

If the macro does change, presumably due to a real breaking change, patching this out could make it hard to detect.

The way I see it, this patch doesn't actually accomplish anything meaningful, and I don't think keeping a pointless patch around is a good idea.

Again, it would be helpful to have another opinion on this.