[PR PATCH] openvpn: update to 2.6.9.

[PR PATCH] openvpn: update to 2.6.9.

[Bnyro]

[-- Attachment #1: Type: text/plain, Size: 473 bytes --]

There is a new pull request by Bnyro against master on the void-packages repository

https://github.com/Bnyro/void-packages openvpn
https://github.com/void-linux/void-packages/pull/48693

openvpn: update to 2.6.9.

#### Testing the changes
- I tested the changes in this PR: **briefly**

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc



A patch file from https://github.com/void-linux/void-packages/pull/48693.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-openvpn-48693.patch --]
[-- Type: text/x-diff, Size: 1220 bytes --]

From 2628efa45d01e3955fd65e162c2b423e2f81d3a2 Mon Sep 17 00:00:00 2001
From: Bnyro <bnyro@tutanota.com>
Date: Tue, 13 Feb 2024 12:32:55 +0100
Subject: [PATCH] openvpn: update to 2.6.9.

---
 srcpkgs/openvpn/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/openvpn/template b/srcpkgs/openvpn/template
index 41a8d837e87b1..538459d534476 100644
--- a/srcpkgs/openvpn/template
+++ b/srcpkgs/openvpn/template
@@ -1,6 +1,6 @@
 # Template file for 'openvpn'
 pkgname=openvpn
-version=2.6.8
+version=2.6.9
 revision=1
 build_style=gnu-configure
 configure_args="$(vopt_enable pkcs11) --disable-systemd
@@ -15,8 +15,8 @@ maintainer="Orphaned <orphan@voidlinux.org>"
 license="GPL-2.0-only"
 homepage="https://www.openvpn.net"
 changelog="https://raw.githubusercontent.com/OpenVPN/openvpn/release/${version%.*}/Changes.rst"
-distfiles="http://build.openvpn.net/downloads/releases/openvpn-${version}.tar.gz"
-checksum=5ede1565c8a6d880100f7f235317a7ee9eea83d5052db5547f13a9e76af7805d
+distfiles="https://build.openvpn.net/downloads/releases/openvpn-${version}.tar.gz"
+checksum=e08d147e15b4508dfcd1d6618a1f21f1495f9817a8dadc1eddf0532fa116d7e3
 # t_net.sh fails on CI.
 make_check=ci-skip
 

Re: openvpn: update to 2.6.9.

[slymattz]

[-- Attachment #1: Type: text/plain, Size: 390 bytes --]

New comment by slymattz on void-packages repository

https://github.com/void-linux/void-packages/pull/48693#issuecomment-1951427247

Comment:
Cool!

Would you consider adding a runit service? 

files/openvpn/run
```
#!/bin/sh
exec 2>&1
[ -r conf ] && . ./conf
exec openvpn --config ${CONF_FILE:=/etc/openvpn/openvpn.conf}
```

template
```
post_install() {
	vsv openvpn
```

Re: openvpn: update to 2.6.9.

[Bnyro]

[-- Attachment #1: Type: text/plain, Size: 541 bytes --]

New comment by Bnyro on void-packages repository

https://github.com/void-linux/void-packages/pull/48693#issuecomment-1951451569

Comment:
> Would you consider adding a runit service?
>
I personally think that's a good idea, but I just saw https://github.com/void-linux/void-packages/pull/17906#issuecomment-569937899 where adding a service has been rejected (for unknown reasons). I think we should better do this in a other PR to allow further discussions about it there, so that it won't block this update. Feel free to create one :+1:

Re: openvpn: update to 2.6.9.

[slymattz]

[-- Attachment #1: Type: text/plain, Size: 913 bytes --]

New comment by slymattz on void-packages repository

https://github.com/void-linux/void-packages/pull/48693#issuecomment-1951457118

Comment:
https://github.com/void-linux/void-packages/pull/17906#issuecomment-569937899 is really intriguing and I wonder what the rationale for such a decision was.

Anyhow, I see things two-fold here: 
1) running OpenVPN as a server - you must have a runit service here to start it on boot
2) running OpenVPN as a client - you don't have to have a runit server here unless you want to run it on boot

So three scenarios pop-up: two where having a runit service is highly essential and one where it is redundant (like when you run openvpn /etc/openvpn/client/1.conf &

As a personal note, I've run the runit service in a server instance successfully today, so it works.

These are the technicalities but I'm wondering on what your opinions are. I propose a discussion. 

Re: openvpn: update to 2.6.9.

[slymattz]

[-- Attachment #1: Type: text/plain, Size: 914 bytes --]

New comment by slymattz on void-packages repository

https://github.com/void-linux/void-packages/pull/48693#issuecomment-1951457118

Comment:
https://github.com/void-linux/void-packages/pull/17906#issuecomment-569937899 is really intriguing and I wonder what the rationale for such a decision was.

Anyhow, I see things two-fold here: 
1) running OpenVPN as a server - you must have a runit service here to start it on boot
2) running OpenVPN as a client - you don't have to have a runit service here unless you want to run it on boot

So three scenarios pop-up: two where having a runit service is highly essential and one where it is redundant (like when you run openvpn /etc/openvpn/client/1.conf &

As a personal note, I've run the runit service in a server instance successfully today, so it works.

These are the technicalities but I'm wondering on what your opinions are. I propose a discussion. 

Re: openvpn: update to 2.6.9.

[Bnyro]

[-- Attachment #1: Type: text/plain, Size: 374 bytes --]

New comment by Bnyro on void-packages repository

https://github.com/void-linux/void-packages/pull/48693#issuecomment-1951468626

Comment:
I personally agree that it makes sense to add a service for both options, one for running as openvpn server and one for running as client.
But we probably get more opinions in a GitHub discussion, so that's probably a good idea 👍 

Re: openvpn: update to 2.6.9.

[slymattz]

[-- Attachment #1: Type: text/plain, Size: 683 bytes --]

New comment by slymattz on void-packages repository

https://github.com/void-linux/void-packages/pull/48693#issuecomment-1952943319

Comment:
> > Would you consider adding a runit service?
> 
> I personally think that's a good idea, but I just saw [#17906 (comment)](https://github.com/void-linux/void-packages/pull/17906#issuecomment-569937899) where adding a service has been rejected (for unknown reasons). I think we should better do this in a other PR to allow further discussions about it there, so that it won't block this update. Feel free to create one 👍

I hope this is the right place for such a discussion: https://github.com/void-linux/void-packages/issues/48834

Re: openvpn: update to 2.6.9.

[slymattz]

[-- Attachment #1: Type: text/plain, Size: 1081 bytes --]

New comment by slymattz on void-packages repository

https://github.com/void-linux/void-packages/pull/48693#issuecomment-1959656887

Comment:
> (...) I think we should better do this in a other PR to allow further discussions about it there, so that it won't block this update. Feel free to create one 👍

Whoever reviews this PR, please bear in mind that I had no intention of hindering this OpenVPN update by opening up a discussion here - https://github.com/void-linux/void-packages/issues/48834

I believe keeping OpenVPN up-to-date is important regardless of the conclusions drawn in the aforementioned discussion. That being said, it would be nice to have a runit service installed in /usr/share/examples/sv/openvpn in one of the future updates (see https://github.com/void-linux/void-packages/issues/48834#issuecomment-1953063448). One argument for doing so is that the service would be easily accessible to users who want to have it enabled on boot. And on top of that the proposed solution would be safe for those who run OpenVPN manually or use NetworkManager etc.

Re: openvpn: update to 2.6.9.

[slymattz]

[-- Attachment #1: Type: text/plain, Size: 1297 bytes --]

New comment by slymattz on void-packages repository

https://github.com/void-linux/void-packages/pull/48693#issuecomment-1959656887

Comment:
> (...) I think we should better do this in a other PR to allow further discussions about it there, so that it won't block this update. Feel free to create one 👍

Whoever reviews this PR, please bear in mind that I had no intention of hindering this OpenVPN update by opening up a discussion here - https://github.com/void-linux/void-packages/issues/48834

I believe keeping OpenVPN up-to-date is important regardless of the conclusions drawn in the aforementioned discussion. That being said, it would be nice to have runit services for openvpn-server and openvpn-client installed in /usr/share/examples/sv (see https://github.com/void-linux/void-packages/issues/48834#issuecomment-1953063448). One argument for doing so is that the service would be easily accessible to users who want to have it enabled on boot. And on top of that the proposed solution would be safe for those who run OpenVPN manually or use NetworkManager etc.

Another argument for including runit services for OpenVPN is that similar software like https://github.com/void-linux/void-packages/tree/master/srcpkgs/wireguard-tools does come with a runit service preinstalled.