Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] mdbook-toc: Fix mdbook warning
@ 2024-02-22 20:21 meator
  2024-02-22 20:25 ` [PR PATCH] [Closed]: " meator
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: meator @ 2024-02-22 20:21 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1672 bytes --]

There is a new pull request by meator against master on the void-packages repository

https://github.com/meator/void-packages mdbook-toc
https://github.com/void-linux/void-packages/pull/48882

mdbook-toc: Fix mdbook warning
mdbook complains that mdbook-toc was built against mdbook version 0.4.36 which is outdated now:

```
Warning: The mdbook-toc preprocessor was built against version 0.4.36 of mdbook, but we're being called from version 0.4.37
```

There are probably more elegant and future proof ways to solve this (one of which is just ignoring the warning because it's a warning and not an error), but bumping mdbook-toc fixes it too.

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/48882.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-mdbook-toc-48882.patch --]
[-- Type: text/x-diff, Size: 800 bytes --]

From 15778ab81946a325800eec2143f2740b2b905204 Mon Sep 17 00:00:00 2001
From: meator <meator.dev@gmail.com>
Date: Thu, 22 Feb 2024 21:17:19 +0100
Subject: [PATCH] mdbook-toc: Fix mdbook warning

mdbook complains that mdbook-toc was built against mdbook version 0.4.36
which is outdated now.
---
 srcpkgs/mdbook-toc/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/mdbook-toc/template b/srcpkgs/mdbook-toc/template
index fa8e3e7885742e..bebc57233028b3 100644
--- a/srcpkgs/mdbook-toc/template
+++ b/srcpkgs/mdbook-toc/template
@@ -1,7 +1,7 @@
 # Template file for 'mdbook-toc'
 pkgname=mdbook-toc
 version=0.14.2
-revision=1
+revision=2
 build_style=cargo
 short_desc="Preprocessor for mdbook to add inline TOC support"
 maintainer="Orphaned <orphan@voidlinux.org>"

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PR PATCH] [Closed]: mdbook-toc: Fix mdbook warning
  2024-02-22 20:21 [PR PATCH] mdbook-toc: Fix mdbook warning meator
@ 2024-02-22 20:25 ` meator
  2024-02-22 20:25 ` meator
  2024-02-22 20:29 ` classabbyamp
  2 siblings, 0 replies; 4+ messages in thread
From: meator @ 2024-02-22 20:25 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1520 bytes --]

There's a closed pull request on the void-packages repository

mdbook-toc: Fix mdbook warning
https://github.com/void-linux/void-packages/pull/48882

Description:
mdbook complains that mdbook-toc was built against mdbook version 0.4.36 which is outdated now:

```
Warning: The mdbook-toc preprocessor was built against version 0.4.36 of mdbook, but we're being called from version 0.4.37
```

There are probably more elegant and future proof ways to solve this (one of which is just ignoring the warning because it's a warning and not an error), but bumping mdbook-toc fixes it too.

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: mdbook-toc: Fix mdbook warning
  2024-02-22 20:21 [PR PATCH] mdbook-toc: Fix mdbook warning meator
  2024-02-22 20:25 ` [PR PATCH] [Closed]: " meator
@ 2024-02-22 20:25 ` meator
  2024-02-22 20:29 ` classabbyamp
  2 siblings, 0 replies; 4+ messages in thread
From: meator @ 2024-02-22 20:25 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 203 bytes --]

New comment by meator on void-packages repository

https://github.com/void-linux/void-packages/pull/48882#issuecomment-1960251708

Comment:
Sorry, this looks like it can't be solved by a simple rebuild.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: mdbook-toc: Fix mdbook warning
  2024-02-22 20:21 [PR PATCH] mdbook-toc: Fix mdbook warning meator
  2024-02-22 20:25 ` [PR PATCH] [Closed]: " meator
  2024-02-22 20:25 ` meator
@ 2024-02-22 20:29 ` classabbyamp
  2 siblings, 0 replies; 4+ messages in thread
From: classabbyamp @ 2024-02-22 20:29 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 205 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/48882#issuecomment-1960260848

Comment:
probably needs a `cargo update` in pre_patch or post_patch

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-02-22 20:29 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-22 20:21 [PR PATCH] mdbook-toc: Fix mdbook warning meator
2024-02-22 20:25 ` [PR PATCH] [Closed]: " meator
2024-02-22 20:25 ` meator
2024-02-22 20:29 ` classabbyamp

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).