Github messages for voidlinux
 help / color / mirror / Atom feed
* Re: [PR PATCH] [Updated] New package: sayonara-player-1.7.0-stable3
  2023-08-29 16:31 [PR PATCH] New package: sayonara-player-1.7.0-stable3 fanyx
@ 2023-08-29 16:29 ` fanyx
  2023-08-29 16:33 ` fanyx
                   ` (34 subsequent siblings)
  35 siblings, 0 replies; 37+ messages in thread
From: fanyx @ 2023-08-29 16:29 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 838 bytes --]

There is an updated pull request by fanyx against master on the void-packages repository

https://github.com/fanyx/void-packages sayonara-player
https://github.com/void-linux/void-packages/pull/45816

New package: sayonara-player-1.7.0-stable3
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

<!--#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)

`xbps-query` shows weird dependencies
if there is anything redundant from `makedepends` to `depends`, let me know and i'll remove stuff as needed

A patch file from https://github.com/void-linux/void-packages/pull/45816.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-sayonara-player-45816.patch --]
[-- Type: text/x-diff, Size: 1318 bytes --]

From 678aa11f483413a6c833744f4bada23ddae45bb6 Mon Sep 17 00:00:00 2001
From: fanyx <fanyx@posteo.net>
Date: Tue, 29 Aug 2023 18:21:26 +0200
Subject: [PATCH] New package: sayonara-player-1.7.0-stable3

---
 srcpkgs/sayonara-player/template | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
 create mode 100644 srcpkgs/sayonara-player/template

diff --git a/srcpkgs/sayonara-player/template b/srcpkgs/sayonara-player/template
new file mode 100644
index 0000000000000..af63a1f78466f
--- /dev/null
+++ b/srcpkgs/sayonara-player/template
@@ -0,0 +1,16 @@
+# Template file for 'sayonara-player'
+pkgname=sayonara-player
+version=1.7.0
+revision=1
+build_style=cmake
+makedepends="pkg-config gst-plugins-bad1-devel qt5-devel qt5-tools-devel
+ qt5-plugin-mysql qt5-plugin-odbc qt5-plugin-pgsql qt5-plugin-sqlite
+ qt5-plugin-tds qt5-svg-devel taglib-devel"
+depends="qt5-core taglib gst-plugins-base1 gst-plugins-good1 gst-plugins-bad1
+ gst-plugins-ugly1 gst-libav"
+short_desc="Sayonara is a small, clear and fast audio player written in C++, Qt"
+maintainer="fanyx <fanyx@posteo.net>"
+license="GPL-3.0-or-later"
+homepage="https://sayonara-player.com"
+distfiles="https://sayonara-player.com/files/sayonara-player-${version}-stable3.tar.gz"
+checksum=21c7ebe42a98e0bce324224236f5665eb19263a1f005c0e20be69d1ca8ef44a1

^ permalink raw reply	[flat|nested] 37+ messages in thread

* [PR PATCH] New package: sayonara-player-1.7.0-stable3
@ 2023-08-29 16:31 fanyx
  2023-08-29 16:29 ` [PR PATCH] [Updated] " fanyx
                   ` (35 more replies)
  0 siblings, 36 replies; 37+ messages in thread
From: fanyx @ 2023-08-29 16:31 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 833 bytes --]

There is a new pull request by fanyx against master on the void-packages repository

https://github.com/fanyx/void-packages sayonara-player
https://github.com/void-linux/void-packages/pull/45816

New package: sayonara-player-1.7.0-stable3
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

<!--#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)

`xbps-query` shows weird dependencies
if there is anything redundant from `makedepends` to `depends`, let me know and i'll remove stuff as needed

A patch file from https://github.com/void-linux/void-packages/pull/45816.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-sayonara-player-45816.patch --]
[-- Type: text/x-diff, Size: 1318 bytes --]

From 678aa11f483413a6c833744f4bada23ddae45bb6 Mon Sep 17 00:00:00 2001
From: fanyx <fanyx@posteo.net>
Date: Tue, 29 Aug 2023 18:21:26 +0200
Subject: [PATCH] New package: sayonara-player-1.7.0-stable3

---
 srcpkgs/sayonara-player/template | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
 create mode 100644 srcpkgs/sayonara-player/template

diff --git a/srcpkgs/sayonara-player/template b/srcpkgs/sayonara-player/template
new file mode 100644
index 0000000000000..af63a1f78466f
--- /dev/null
+++ b/srcpkgs/sayonara-player/template
@@ -0,0 +1,16 @@
+# Template file for 'sayonara-player'
+pkgname=sayonara-player
+version=1.7.0
+revision=1
+build_style=cmake
+makedepends="pkg-config gst-plugins-bad1-devel qt5-devel qt5-tools-devel
+ qt5-plugin-mysql qt5-plugin-odbc qt5-plugin-pgsql qt5-plugin-sqlite
+ qt5-plugin-tds qt5-svg-devel taglib-devel"
+depends="qt5-core taglib gst-plugins-base1 gst-plugins-good1 gst-plugins-bad1
+ gst-plugins-ugly1 gst-libav"
+short_desc="Sayonara is a small, clear and fast audio player written in C++, Qt"
+maintainer="fanyx <fanyx@posteo.net>"
+license="GPL-3.0-or-later"
+homepage="https://sayonara-player.com"
+distfiles="https://sayonara-player.com/files/sayonara-player-${version}-stable3.tar.gz"
+checksum=21c7ebe42a98e0bce324224236f5665eb19263a1f005c0e20be69d1ca8ef44a1

^ permalink raw reply	[flat|nested] 37+ messages in thread

* Re: [PR PATCH] [Updated] New package: sayonara-player-1.7.0-stable3
  2023-08-29 16:31 [PR PATCH] New package: sayonara-player-1.7.0-stable3 fanyx
  2023-08-29 16:29 ` [PR PATCH] [Updated] " fanyx
@ 2023-08-29 16:33 ` fanyx
  2023-08-29 16:47 ` [PR REVIEW] " ahesford
                   ` (33 subsequent siblings)
  35 siblings, 0 replies; 37+ messages in thread
From: fanyx @ 2023-08-29 16:33 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 838 bytes --]

There is an updated pull request by fanyx against master on the void-packages repository

https://github.com/fanyx/void-packages sayonara-player
https://github.com/void-linux/void-packages/pull/45816

New package: sayonara-player-1.7.0-stable3
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

<!--#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)

`xbps-query` shows weird dependencies
if there is anything redundant from `makedepends` to `depends`, let me know and i'll remove stuff as needed

A patch file from https://github.com/void-linux/void-packages/pull/45816.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-sayonara-player-45816.patch --]
[-- Type: text/x-diff, Size: 1318 bytes --]

From 678aa11f483413a6c833744f4bada23ddae45bb6 Mon Sep 17 00:00:00 2001
From: fanyx <fanyx@posteo.net>
Date: Tue, 29 Aug 2023 18:21:26 +0200
Subject: [PATCH] New package: sayonara-player-1.7.0-stable3

---
 srcpkgs/sayonara-player/template | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
 create mode 100644 srcpkgs/sayonara-player/template

diff --git a/srcpkgs/sayonara-player/template b/srcpkgs/sayonara-player/template
new file mode 100644
index 0000000000000..af63a1f78466f
--- /dev/null
+++ b/srcpkgs/sayonara-player/template
@@ -0,0 +1,16 @@
+# Template file for 'sayonara-player'
+pkgname=sayonara-player
+version=1.7.0
+revision=1
+build_style=cmake
+makedepends="pkg-config gst-plugins-bad1-devel qt5-devel qt5-tools-devel
+ qt5-plugin-mysql qt5-plugin-odbc qt5-plugin-pgsql qt5-plugin-sqlite
+ qt5-plugin-tds qt5-svg-devel taglib-devel"
+depends="qt5-core taglib gst-plugins-base1 gst-plugins-good1 gst-plugins-bad1
+ gst-plugins-ugly1 gst-libav"
+short_desc="Sayonara is a small, clear and fast audio player written in C++, Qt"
+maintainer="fanyx <fanyx@posteo.net>"
+license="GPL-3.0-or-later"
+homepage="https://sayonara-player.com"
+distfiles="https://sayonara-player.com/files/sayonara-player-${version}-stable3.tar.gz"
+checksum=21c7ebe42a98e0bce324224236f5665eb19263a1f005c0e20be69d1ca8ef44a1

^ permalink raw reply	[flat|nested] 37+ messages in thread

* Re: [PR REVIEW] New package: sayonara-player-1.7.0-stable3
  2023-08-29 16:31 [PR PATCH] New package: sayonara-player-1.7.0-stable3 fanyx
                   ` (2 preceding siblings ...)
  2023-08-29 16:47 ` [PR REVIEW] " ahesford
@ 2023-08-29 16:47 ` ahesford
  2023-08-29 16:48 ` fanyx
                   ` (31 subsequent siblings)
  35 siblings, 0 replies; 37+ messages in thread
From: ahesford @ 2023-08-29 16:47 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 200 bytes --]

New review comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/45816#discussion_r1309094253

Comment:
The version should include the "stable3" component.

^ permalink raw reply	[flat|nested] 37+ messages in thread

* Re: [PR REVIEW] New package: sayonara-player-1.7.0-stable3
  2023-08-29 16:31 [PR PATCH] New package: sayonara-player-1.7.0-stable3 fanyx
  2023-08-29 16:29 ` [PR PATCH] [Updated] " fanyx
  2023-08-29 16:33 ` fanyx
@ 2023-08-29 16:47 ` ahesford
  2023-08-29 16:47 ` ahesford
                   ` (32 subsequent siblings)
  35 siblings, 0 replies; 37+ messages in thread
From: ahesford @ 2023-08-29 16:47 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 235 bytes --]

New review comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/45816#discussion_r1309094527

Comment:
```suggestion
short_desc="Small, clear and fast audio player written in C++, Qt"
```

^ permalink raw reply	[flat|nested] 37+ messages in thread

* Re: [PR REVIEW] New package: sayonara-player-1.7.0-stable3
  2023-08-29 16:31 [PR PATCH] New package: sayonara-player-1.7.0-stable3 fanyx
                   ` (3 preceding siblings ...)
  2023-08-29 16:47 ` ahesford
@ 2023-08-29 16:48 ` fanyx
  2023-08-29 16:50 ` [PR PATCH] [Updated] " fanyx
                   ` (30 subsequent siblings)
  35 siblings, 0 replies; 37+ messages in thread
From: fanyx @ 2023-08-29 16:48 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 225 bytes --]

New review comment by fanyx on void-packages repository

https://github.com/void-linux/void-packages/pull/45816#discussion_r1309097972

Comment:
xlint does not allow me to add `-stable3`
so should i just do `1.7.0stable3` ?

^ permalink raw reply	[flat|nested] 37+ messages in thread

* Re: [PR PATCH] [Updated] New package: sayonara-player-1.7.0-stable3
  2023-08-29 16:31 [PR PATCH] New package: sayonara-player-1.7.0-stable3 fanyx
                   ` (4 preceding siblings ...)
  2023-08-29 16:48 ` fanyx
@ 2023-08-29 16:50 ` fanyx
  2023-08-29 16:58 ` fanyx
                   ` (29 subsequent siblings)
  35 siblings, 0 replies; 37+ messages in thread
From: fanyx @ 2023-08-29 16:50 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 838 bytes --]

There is an updated pull request by fanyx against master on the void-packages repository

https://github.com/fanyx/void-packages sayonara-player
https://github.com/void-linux/void-packages/pull/45816

New package: sayonara-player-1.7.0-stable3
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

<!--#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)

`xbps-query` shows weird dependencies
if there is anything redundant from `makedepends` to `depends`, let me know and i'll remove stuff as needed

A patch file from https://github.com/void-linux/void-packages/pull/45816.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-sayonara-player-45816.patch --]
[-- Type: text/x-diff, Size: 1385 bytes --]

From 840b020e58176e79ec59ecc39b1157a1f4426fa0 Mon Sep 17 00:00:00 2001
From: fanyx <fanyx@posteo.net>
Date: Tue, 29 Aug 2023 18:21:26 +0200
Subject: [PATCH] New package: sayonara-player-1.7.0-stable3

---
 srcpkgs/sayonara-player/template | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
 create mode 100644 srcpkgs/sayonara-player/template

diff --git a/srcpkgs/sayonara-player/template b/srcpkgs/sayonara-player/template
new file mode 100644
index 0000000000000..92f99d8661287
--- /dev/null
+++ b/srcpkgs/sayonara-player/template
@@ -0,0 +1,18 @@
+# Template file for 'sayonara-player'
+pkgname=sayonara-player
+_version=1.7.0
+_version_suffix=stable3
+version="${_version}${_version_suffix}"
+revision=1
+build_style=cmake
+makedepends="pkg-config gst-plugins-bad1-devel qt5-devel qt5-tools-devel
+ qt5-plugin-mysql qt5-plugin-odbc qt5-plugin-pgsql qt5-plugin-sqlite
+ qt5-plugin-tds qt5-svg-devel taglib-devel"
+depends="qt5-core taglib gst-plugins-base1 gst-plugins-good1 gst-plugins-bad1
+ gst-plugins-ugly1 gst-libav"
+short_desc="Small, clear and fast audio player written in C++, Qt"
+maintainer="fanyx <fanyx@posteo.net>"
+license="GPL-3.0-or-later"
+homepage="https://sayonara-player.com"
+distfiles="https://sayonara-player.com/files/sayonara-player-${_version}-${_version_suffix}.tar.gz"
+checksum=21c7ebe42a98e0bce324224236f5665eb19263a1f005c0e20be69d1ca8ef44a1

^ permalink raw reply	[flat|nested] 37+ messages in thread

* Re: New package: sayonara-player-1.7.0-stable3
  2023-08-29 16:31 [PR PATCH] New package: sayonara-player-1.7.0-stable3 fanyx
                   ` (5 preceding siblings ...)
  2023-08-29 16:50 ` [PR PATCH] [Updated] " fanyx
@ 2023-08-29 16:58 ` fanyx
  2023-08-29 18:05 ` [PR PATCH] [Updated] " fanyx
                   ` (28 subsequent siblings)
  35 siblings, 0 replies; 37+ messages in thread
From: fanyx @ 2023-08-29 16:58 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 315 bytes --]

New comment by fanyx on void-packages repository

https://github.com/void-linux/void-packages/pull/45816#issuecomment-1697821700

Comment:
custom variables are supposed to be prefixed with `_`

`sayonara-player:5: version must not contain the characters - or : or _`
xlint cannot deal with that unfortunately...

^ permalink raw reply	[flat|nested] 37+ messages in thread

* Re: [PR PATCH] [Updated] New package: sayonara-player-1.7.0-stable3
  2023-08-29 16:31 [PR PATCH] New package: sayonara-player-1.7.0-stable3 fanyx
                   ` (6 preceding siblings ...)
  2023-08-29 16:58 ` fanyx
@ 2023-08-29 18:05 ` fanyx
  2023-08-29 18:06 ` ahesford
                   ` (27 subsequent siblings)
  35 siblings, 0 replies; 37+ messages in thread
From: fanyx @ 2023-08-29 18:05 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 838 bytes --]

There is an updated pull request by fanyx against master on the void-packages repository

https://github.com/fanyx/void-packages sayonara-player
https://github.com/void-linux/void-packages/pull/45816

New package: sayonara-player-1.7.0-stable3
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

<!--#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)

`xbps-query` shows weird dependencies
if there is anything redundant from `makedepends` to `depends`, let me know and i'll remove stuff as needed

A patch file from https://github.com/void-linux/void-packages/pull/45816.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-sayonara-player-45816.patch --]
[-- Type: text/x-diff, Size: 1320 bytes --]

From 4a486070f38788fa15a597021bccb3a1eeca0835 Mon Sep 17 00:00:00 2001
From: fanyx <fanyx@posteo.net>
Date: Tue, 29 Aug 2023 18:21:26 +0200
Subject: [PATCH] New package: sayonara-player-1.7.0-stable3

---
 srcpkgs/sayonara-player/template | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
 create mode 100644 srcpkgs/sayonara-player/template

diff --git a/srcpkgs/sayonara-player/template b/srcpkgs/sayonara-player/template
new file mode 100644
index 0000000000000..7244e89325cc7
--- /dev/null
+++ b/srcpkgs/sayonara-player/template
@@ -0,0 +1,16 @@
+# Template file for 'sayonara-player'
+pkgname=sayonara-player
+version=1.7.0.stable3
+revision=1
+build_style=cmake
+makedepends="pkg-config gst-plugins-bad1-devel qt5-devel qt5-tools-devel
+ qt5-plugin-mysql qt5-plugin-odbc qt5-plugin-pgsql qt5-plugin-sqlite
+ qt5-plugin-tds qt5-svg-devel taglib-devel"
+depends="qt5-core taglib gst-plugins-base1 gst-plugins-good1 gst-plugins-bad1
+ gst-plugins-ugly1 gst-libav"
+short_desc="Small, clear and fast audio player written in C++, Qt"
+maintainer="fanyx <fanyx@posteo.net>"
+license="GPL-3.0-or-later"
+homepage="https://sayonara-player.com"
+distfiles="https://sayonara-player.com/files/sayonara-player-${version/.stable/-stable}.tar.gz"
+checksum=21c7ebe42a98e0bce324224236f5665eb19263a1f005c0e20be69d1ca8ef44a1

^ permalink raw reply	[flat|nested] 37+ messages in thread

* Re: New package: sayonara-player-1.7.0-stable3
  2023-08-29 16:31 [PR PATCH] New package: sayonara-player-1.7.0-stable3 fanyx
                   ` (7 preceding siblings ...)
  2023-08-29 18:05 ` [PR PATCH] [Updated] " fanyx
@ 2023-08-29 18:06 ` ahesford
  2023-08-29 18:08 ` fanyx
                   ` (26 subsequent siblings)
  35 siblings, 0 replies; 37+ messages in thread
From: ahesford @ 2023-08-29 18:06 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 339 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/45816#issuecomment-1697890493

Comment:
The `version` variable should never contain variables to expand; literal strings only. You can use something like `version=1.7.0.stable3` and, in the `distfiles`, use `${version/.stable/-stable}`.

^ permalink raw reply	[flat|nested] 37+ messages in thread

* Re: New package: sayonara-player-1.7.0-stable3
  2023-08-29 16:31 [PR PATCH] New package: sayonara-player-1.7.0-stable3 fanyx
                   ` (8 preceding siblings ...)
  2023-08-29 18:06 ` ahesford
@ 2023-08-29 18:08 ` fanyx
  2023-08-29 18:31 ` fanyx
                   ` (25 subsequent siblings)
  35 siblings, 0 replies; 37+ messages in thread
From: fanyx @ 2023-08-29 18:08 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 161 bytes --]

New comment by fanyx on void-packages repository

https://github.com/void-linux/void-packages/pull/45816#issuecomment-1697898044

Comment:
thanks, sounds good


^ permalink raw reply	[flat|nested] 37+ messages in thread

* Re: New package: sayonara-player-1.7.0-stable3
  2023-08-29 16:31 [PR PATCH] New package: sayonara-player-1.7.0-stable3 fanyx
                   ` (9 preceding siblings ...)
  2023-08-29 18:08 ` fanyx
@ 2023-08-29 18:31 ` fanyx
  2023-08-29 18:44 ` [PR REVIEW] " ahesford
                   ` (24 subsequent siblings)
  35 siblings, 0 replies; 37+ messages in thread
From: fanyx @ 2023-08-29 18:31 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 284 bytes --]

New comment by fanyx on void-packages repository

https://github.com/void-linux/void-packages/pull/45816#issuecomment-1697899007

Comment:
the build has been building openssl and other stuff alongside the actual program
any idea why that is?
the branch is rebased on current master

^ permalink raw reply	[flat|nested] 37+ messages in thread

* Re: [PR REVIEW] New package: sayonara-player-1.7.0-stable3
  2023-08-29 16:31 [PR PATCH] New package: sayonara-player-1.7.0-stable3 fanyx
                   ` (10 preceding siblings ...)
  2023-08-29 18:31 ` fanyx
@ 2023-08-29 18:44 ` ahesford
  2023-08-29 18:56 ` [PR PATCH] [Updated] " fanyx
                   ` (23 subsequent siblings)
  35 siblings, 0 replies; 37+ messages in thread
From: ahesford @ 2023-08-29 18:44 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 352 bytes --]

New review comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/45816#discussion_r1309195646

Comment:
The fact that `xbps-src` automatically detects a `gst-plugins-base1` dependency suggests that `gst-plugins-bad1-devel` is never actually being used, and should be replaced with `gst-plugins-base1-devel`.

^ permalink raw reply	[flat|nested] 37+ messages in thread

* Re: [PR PATCH] [Updated] New package: sayonara-player-1.7.0-stable3
  2023-08-29 16:31 [PR PATCH] New package: sayonara-player-1.7.0-stable3 fanyx
                   ` (11 preceding siblings ...)
  2023-08-29 18:44 ` [PR REVIEW] " ahesford
@ 2023-08-29 18:56 ` fanyx
  2023-08-29 19:08 ` [PR REVIEW] " ahesford
                   ` (22 subsequent siblings)
  35 siblings, 0 replies; 37+ messages in thread
From: fanyx @ 2023-08-29 18:56 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 838 bytes --]

There is an updated pull request by fanyx against master on the void-packages repository

https://github.com/fanyx/void-packages sayonara-player
https://github.com/void-linux/void-packages/pull/45816

New package: sayonara-player-1.7.0-stable3
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

<!--#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)

`xbps-query` shows weird dependencies
if there is anything redundant from `makedepends` to `depends`, let me know and i'll remove stuff as needed

A patch file from https://github.com/void-linux/void-packages/pull/45816.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-sayonara-player-45816.patch --]
[-- Type: text/x-diff, Size: 1239 bytes --]

From d0889d4994acf10ee6585cd52de7e7a4d9168c0c Mon Sep 17 00:00:00 2001
From: fanyx <fanyx@posteo.net>
Date: Tue, 29 Aug 2023 18:21:26 +0200
Subject: [PATCH] New package: sayonara-player-1.7.0.stable3

---
 srcpkgs/sayonara-player/template | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
 create mode 100644 srcpkgs/sayonara-player/template

diff --git a/srcpkgs/sayonara-player/template b/srcpkgs/sayonara-player/template
new file mode 100644
index 0000000000000..3cd7456c5256e
--- /dev/null
+++ b/srcpkgs/sayonara-player/template
@@ -0,0 +1,15 @@
+# Template file for 'sayonara-player'
+pkgname=sayonara-player
+version=1.7.0.stable3
+revision=1
+build_style=cmake
+makedepends="pkg-config gst-plugins-base1-devel qt5-devel qt5-tools-devel
+ qt5-plugin-mysql qt5-plugin-odbc qt5-plugin-pgsql qt5-plugin-sqlite
+ qt5-plugin-tds qt5-svg-devel taglib-devel"
+depends="gst-plugins-good1"
+short_desc="Small, clear and fast audio player written in C++, Qt"
+maintainer="fanyx <fanyx@posteo.net>"
+license="GPL-3.0-or-later"
+homepage="https://sayonara-player.com"
+distfiles="https://sayonara-player.com/files/sayonara-player-${version/.stable/-stable}.tar.gz"
+checksum=21c7ebe42a98e0bce324224236f5665eb19263a1f005c0e20be69d1ca8ef44a1

^ permalink raw reply	[flat|nested] 37+ messages in thread

* Re: [PR REVIEW] New package: sayonara-player-1.7.0-stable3
  2023-08-29 16:31 [PR PATCH] New package: sayonara-player-1.7.0-stable3 fanyx
                   ` (12 preceding siblings ...)
  2023-08-29 18:56 ` [PR PATCH] [Updated] " fanyx
@ 2023-08-29 19:08 ` ahesford
  2023-08-29 19:24 ` fanyx
                   ` (21 subsequent siblings)
  35 siblings, 0 replies; 37+ messages in thread
From: ahesford @ 2023-08-29 19:08 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 611 bytes --]

New review comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/45816#discussion_r1309191101

Comment:
The `qt5-core`, `taglib`, `gst-plugins-base1` dependencies are automatically detected and shouldn't be in this list. Are `gst-plugins-bad1`, `gst-plugins-ugly1` and `gst-libav` strictly required for major functionality? [This FAQ](https://sayonara-player.com/faq/#i-cannot-play-ape-encoded-tracks-streams) suggests that `gst-libav` might enable optional support for particular encodings, and the gstreamer plugins probably don't matter from a program standpoint.

^ permalink raw reply	[flat|nested] 37+ messages in thread

* Re: [PR REVIEW] New package: sayonara-player-1.7.0-stable3
  2023-08-29 16:31 [PR PATCH] New package: sayonara-player-1.7.0-stable3 fanyx
                   ` (13 preceding siblings ...)
  2023-08-29 19:08 ` [PR REVIEW] " ahesford
@ 2023-08-29 19:24 ` fanyx
  2023-08-29 21:14 ` [PR REVIEW] New package: sayonara-player-1.7.0.stable3 classabbyamp
                   ` (20 subsequent siblings)
  35 siblings, 0 replies; 37+ messages in thread
From: fanyx @ 2023-08-29 19:24 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 273 bytes --]

New review comment by fanyx on void-packages repository

https://github.com/void-linux/void-packages/pull/45816#discussion_r1309226393

Comment:
thanks, will remove those 3 from depends

looking at the dev's provided pkgbuild file, they're probably optional dependencies

^ permalink raw reply	[flat|nested] 37+ messages in thread

* Re: [PR REVIEW] New package: sayonara-player-1.7.0.stable3
  2023-08-29 16:31 [PR PATCH] New package: sayonara-player-1.7.0-stable3 fanyx
                   ` (14 preceding siblings ...)
  2023-08-29 19:24 ` fanyx
@ 2023-08-29 21:14 ` classabbyamp
  2023-08-30 11:52 ` [PR PATCH] [Updated] " fanyx
                   ` (19 subsequent siblings)
  35 siblings, 0 replies; 37+ messages in thread
From: classabbyamp @ 2023-08-29 21:14 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 220 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/45816#discussion_r1309361905

Comment:
```suggestion
short_desc="Small, clear and fast audio player"
```

^ permalink raw reply	[flat|nested] 37+ messages in thread

* Re: [PR PATCH] [Updated] New package: sayonara-player-1.7.0.stable3
  2023-08-29 16:31 [PR PATCH] New package: sayonara-player-1.7.0-stable3 fanyx
                   ` (15 preceding siblings ...)
  2023-08-29 21:14 ` [PR REVIEW] New package: sayonara-player-1.7.0.stable3 classabbyamp
@ 2023-08-30 11:52 ` fanyx
  2023-08-31 10:22 ` fanyx
                   ` (18 subsequent siblings)
  35 siblings, 0 replies; 37+ messages in thread
From: fanyx @ 2023-08-30 11:52 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 838 bytes --]

There is an updated pull request by fanyx against master on the void-packages repository

https://github.com/fanyx/void-packages sayonara-player
https://github.com/void-linux/void-packages/pull/45816

New package: sayonara-player-1.7.0.stable3
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

<!--#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)

`xbps-query` shows weird dependencies
if there is anything redundant from `makedepends` to `depends`, let me know and i'll remove stuff as needed

A patch file from https://github.com/void-linux/void-packages/pull/45816.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-sayonara-player-45816.patch --]
[-- Type: text/x-diff, Size: 1220 bytes --]

From 51dd6617c125ae2abae34720693537daac3463fd Mon Sep 17 00:00:00 2001
From: fanyx <fanyx@posteo.net>
Date: Tue, 29 Aug 2023 18:21:26 +0200
Subject: [PATCH] New package: sayonara-player-1.7.0.stable3

---
 srcpkgs/sayonara-player/template | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
 create mode 100644 srcpkgs/sayonara-player/template

diff --git a/srcpkgs/sayonara-player/template b/srcpkgs/sayonara-player/template
new file mode 100644
index 0000000000000..61c32b24d6225
--- /dev/null
+++ b/srcpkgs/sayonara-player/template
@@ -0,0 +1,15 @@
+# Template file for 'sayonara-player'
+pkgname=sayonara-player
+version=1.7.0.stable3
+revision=1
+build_style=cmake
+makedepends="pkg-config gst-plugins-base1-devel qt5-devel qt5-tools-devel
+ qt5-plugin-mysql qt5-plugin-odbc qt5-plugin-pgsql qt5-plugin-sqlite
+ qt5-plugin-tds qt5-svg-devel taglib-devel"
+depends="gst-plugins-good1"
+short_desc="Small, clear and fast audio player"
+maintainer="fanyx <fanyx@posteo.net>"
+license="GPL-3.0-or-later"
+homepage="https://sayonara-player.com"
+distfiles="https://sayonara-player.com/files/sayonara-player-${version/.stable/-stable}.tar.gz"
+checksum=21c7ebe42a98e0bce324224236f5665eb19263a1f005c0e20be69d1ca8ef44a1

^ permalink raw reply	[flat|nested] 37+ messages in thread

* Re: [PR PATCH] [Updated] New package: sayonara-player-1.7.0.stable3
  2023-08-29 16:31 [PR PATCH] New package: sayonara-player-1.7.0-stable3 fanyx
                   ` (16 preceding siblings ...)
  2023-08-30 11:52 ` [PR PATCH] [Updated] " fanyx
@ 2023-08-31 10:22 ` fanyx
  2023-08-31 10:22 ` fanyx
                   ` (17 subsequent siblings)
  35 siblings, 0 replies; 37+ messages in thread
From: fanyx @ 2023-08-31 10:22 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 838 bytes --]

There is an updated pull request by fanyx against master on the void-packages repository

https://github.com/fanyx/void-packages sayonara-player
https://github.com/void-linux/void-packages/pull/45816

New package: sayonara-player-1.7.0.stable3
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

<!--#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)

`xbps-query` shows weird dependencies
if there is anything redundant from `makedepends` to `depends`, let me know and i'll remove stuff as needed

A patch file from https://github.com/void-linux/void-packages/pull/45816.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-sayonara-player-45816.patch --]
[-- Type: text/x-diff, Size: 1220 bytes --]

From b314a9da99faf24ff5971ae2cb4c5676957016ae Mon Sep 17 00:00:00 2001
From: fanyx <fanyx@posteo.net>
Date: Thu, 31 Aug 2023 12:20:48 +0200
Subject: [PATCH] New package: sayonara-player-1.7.0.stable3

---
 srcpkgs/sayonara-player/template | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
 create mode 100644 srcpkgs/sayonara-player/template

diff --git a/srcpkgs/sayonara-player/template b/srcpkgs/sayonara-player/template
new file mode 100644
index 0000000000000..61c32b24d6225
--- /dev/null
+++ b/srcpkgs/sayonara-player/template
@@ -0,0 +1,15 @@
+# Template file for 'sayonara-player'
+pkgname=sayonara-player
+version=1.7.0.stable3
+revision=1
+build_style=cmake
+makedepends="pkg-config gst-plugins-base1-devel qt5-devel qt5-tools-devel
+ qt5-plugin-mysql qt5-plugin-odbc qt5-plugin-pgsql qt5-plugin-sqlite
+ qt5-plugin-tds qt5-svg-devel taglib-devel"
+depends="gst-plugins-good1"
+short_desc="Small, clear and fast audio player"
+maintainer="fanyx <fanyx@posteo.net>"
+license="GPL-3.0-or-later"
+homepage="https://sayonara-player.com"
+distfiles="https://sayonara-player.com/files/sayonara-player-${version/.stable/-stable}.tar.gz"
+checksum=21c7ebe42a98e0bce324224236f5665eb19263a1f005c0e20be69d1ca8ef44a1

^ permalink raw reply	[flat|nested] 37+ messages in thread

* Re: New package: sayonara-player-1.7.0.stable3
  2023-08-29 16:31 [PR PATCH] New package: sayonara-player-1.7.0-stable3 fanyx
                   ` (17 preceding siblings ...)
  2023-08-31 10:22 ` fanyx
@ 2023-08-31 10:22 ` fanyx
  2023-08-31 10:37 ` [PR PATCH] [Updated] " fanyx
                   ` (16 subsequent siblings)
  35 siblings, 0 replies; 37+ messages in thread
From: fanyx @ 2023-08-31 10:22 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 162 bytes --]

New comment by fanyx on void-packages repository

https://github.com/void-linux/void-packages/pull/45816#issuecomment-1700771310

Comment:
Bumped to rerun checks

^ permalink raw reply	[flat|nested] 37+ messages in thread

* Re: [PR PATCH] [Updated] New package: sayonara-player-1.7.0.stable3
  2023-08-29 16:31 [PR PATCH] New package: sayonara-player-1.7.0-stable3 fanyx
                   ` (18 preceding siblings ...)
  2023-08-31 10:22 ` fanyx
@ 2023-08-31 10:37 ` fanyx
  2023-08-31 10:46 ` fanyx
                   ` (15 subsequent siblings)
  35 siblings, 0 replies; 37+ messages in thread
From: fanyx @ 2023-08-31 10:37 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 838 bytes --]

There is an updated pull request by fanyx against master on the void-packages repository

https://github.com/fanyx/void-packages sayonara-player
https://github.com/void-linux/void-packages/pull/45816

New package: sayonara-player-1.7.0.stable3
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

<!--#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)

`xbps-query` shows weird dependencies
if there is anything redundant from `makedepends` to `depends`, let me know and i'll remove stuff as needed

A patch file from https://github.com/void-linux/void-packages/pull/45816.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-sayonara-player-45816.patch --]
[-- Type: text/x-diff, Size: 1240 bytes --]

From 7335c7a95b2fa1e2629c3acc03ba0f171b271642 Mon Sep 17 00:00:00 2001
From: fanyx <fanyx@posteo.net>
Date: Thu, 31 Aug 2023 12:20:48 +0200
Subject: [PATCH] New package: sayonara-player-1.7.0.stable3

---
 srcpkgs/sayonara-player/template | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
 create mode 100644 srcpkgs/sayonara-player/template

diff --git a/srcpkgs/sayonara-player/template b/srcpkgs/sayonara-player/template
new file mode 100644
index 0000000000000..f14abf75a947e
--- /dev/null
+++ b/srcpkgs/sayonara-player/template
@@ -0,0 +1,16 @@
+# Template file for 'sayonara-player'
+pkgname=sayonara-player
+version=1.7.0.stable3
+revision=1
+build_style=cmake
+hostmakedepends="pkg-config"
+makedepends="gst-plugins-base1-devel qt5-devel qt5-tools-devel
+ qt5-plugin-mysql qt5-plugin-odbc qt5-plugin-pgsql qt5-plugin-sqlite
+ qt5-plugin-tds qt5-svg-devel taglib-devel"
+depends="gst-plugins-good1"
+short_desc="Small, clear and fast audio player"
+maintainer="fanyx <fanyx@posteo.net>"
+license="GPL-3.0-or-later"
+homepage="https://sayonara-player.com"
+distfiles="https://sayonara-player.com/files/sayonara-player-${version/.stable/-stable}.tar.gz"
+checksum=21c7ebe42a98e0bce324224236f5665eb19263a1f005c0e20be69d1ca8ef44a1

^ permalink raw reply	[flat|nested] 37+ messages in thread

* Re: [PR PATCH] [Updated] New package: sayonara-player-1.7.0.stable3
  2023-08-29 16:31 [PR PATCH] New package: sayonara-player-1.7.0-stable3 fanyx
                   ` (19 preceding siblings ...)
  2023-08-31 10:37 ` [PR PATCH] [Updated] " fanyx
@ 2023-08-31 10:46 ` fanyx
  2023-08-31 10:47 ` fanyx
                   ` (14 subsequent siblings)
  35 siblings, 0 replies; 37+ messages in thread
From: fanyx @ 2023-08-31 10:46 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 838 bytes --]

There is an updated pull request by fanyx against master on the void-packages repository

https://github.com/fanyx/void-packages sayonara-player
https://github.com/void-linux/void-packages/pull/45816

New package: sayonara-player-1.7.0.stable3
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

<!--#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)

`xbps-query` shows weird dependencies
if there is anything redundant from `makedepends` to `depends`, let me know and i'll remove stuff as needed

A patch file from https://github.com/void-linux/void-packages/pull/45816.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-sayonara-player-45816.patch --]
[-- Type: text/x-diff, Size: 2054 bytes --]

From 7335c7a95b2fa1e2629c3acc03ba0f171b271642 Mon Sep 17 00:00:00 2001
From: fanyx <fanyx@posteo.net>
Date: Thu, 31 Aug 2023 12:20:48 +0200
Subject: [PATCH 1/2] New package: sayonara-player-1.7.0.stable3

---
 srcpkgs/sayonara-player/template | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
 create mode 100644 srcpkgs/sayonara-player/template

diff --git a/srcpkgs/sayonara-player/template b/srcpkgs/sayonara-player/template
new file mode 100644
index 0000000000000..f14abf75a947e
--- /dev/null
+++ b/srcpkgs/sayonara-player/template
@@ -0,0 +1,16 @@
+# Template file for 'sayonara-player'
+pkgname=sayonara-player
+version=1.7.0.stable3
+revision=1
+build_style=cmake
+hostmakedepends="pkg-config"
+makedepends="gst-plugins-base1-devel qt5-devel qt5-tools-devel
+ qt5-plugin-mysql qt5-plugin-odbc qt5-plugin-pgsql qt5-plugin-sqlite
+ qt5-plugin-tds qt5-svg-devel taglib-devel"
+depends="gst-plugins-good1"
+short_desc="Small, clear and fast audio player"
+maintainer="fanyx <fanyx@posteo.net>"
+license="GPL-3.0-or-later"
+homepage="https://sayonara-player.com"
+distfiles="https://sayonara-player.com/files/sayonara-player-${version/.stable/-stable}.tar.gz"
+checksum=21c7ebe42a98e0bce324224236f5665eb19263a1f005c0e20be69d1ca8ef44a1

From 68c0a0a9d5bd4fde23b21f377d79b80cdebd285d Mon Sep 17 00:00:00 2001
From: fanyx <fanyx@posteo.net>
Date: Thu, 31 Aug 2023 12:45:26 +0200
Subject: [PATCH 2/2] add qmake

---
 srcpkgs/sayonara-player/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/sayonara-player/template b/srcpkgs/sayonara-player/template
index f14abf75a947e..163e2c203b395 100644
--- a/srcpkgs/sayonara-player/template
+++ b/srcpkgs/sayonara-player/template
@@ -3,7 +3,7 @@ pkgname=sayonara-player
 version=1.7.0.stable3
 revision=1
 build_style=cmake
-hostmakedepends="pkg-config"
+hostmakedepends="pkg-config qt5-qmake"
 makedepends="gst-plugins-base1-devel qt5-devel qt5-tools-devel
  qt5-plugin-mysql qt5-plugin-odbc qt5-plugin-pgsql qt5-plugin-sqlite
  qt5-plugin-tds qt5-svg-devel taglib-devel"

^ permalink raw reply	[flat|nested] 37+ messages in thread

* Re: [PR PATCH] [Updated] New package: sayonara-player-1.7.0.stable3
  2023-08-29 16:31 [PR PATCH] New package: sayonara-player-1.7.0-stable3 fanyx
                   ` (20 preceding siblings ...)
  2023-08-31 10:46 ` fanyx
@ 2023-08-31 10:47 ` fanyx
  2023-08-31 10:52 ` fanyx
                   ` (13 subsequent siblings)
  35 siblings, 0 replies; 37+ messages in thread
From: fanyx @ 2023-08-31 10:47 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 838 bytes --]

There is an updated pull request by fanyx against master on the void-packages repository

https://github.com/fanyx/void-packages sayonara-player
https://github.com/void-linux/void-packages/pull/45816

New package: sayonara-player-1.7.0.stable3
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

<!--#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)

`xbps-query` shows weird dependencies
if there is anything redundant from `makedepends` to `depends`, let me know and i'll remove stuff as needed

A patch file from https://github.com/void-linux/void-packages/pull/45816.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-sayonara-player-45816.patch --]
[-- Type: text/x-diff, Size: 1250 bytes --]

From e84673ce3de0133ad50fde2041fffad77d7c41ad Mon Sep 17 00:00:00 2001
From: fanyx <fanyx@posteo.net>
Date: Thu, 31 Aug 2023 12:20:48 +0200
Subject: [PATCH] New package: sayonara-player-1.7.0.stable3

---
 srcpkgs/sayonara-player/template | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
 create mode 100644 srcpkgs/sayonara-player/template

diff --git a/srcpkgs/sayonara-player/template b/srcpkgs/sayonara-player/template
new file mode 100644
index 0000000000000..163e2c203b395
--- /dev/null
+++ b/srcpkgs/sayonara-player/template
@@ -0,0 +1,16 @@
+# Template file for 'sayonara-player'
+pkgname=sayonara-player
+version=1.7.0.stable3
+revision=1
+build_style=cmake
+hostmakedepends="pkg-config qt5-qmake"
+makedepends="gst-plugins-base1-devel qt5-devel qt5-tools-devel
+ qt5-plugin-mysql qt5-plugin-odbc qt5-plugin-pgsql qt5-plugin-sqlite
+ qt5-plugin-tds qt5-svg-devel taglib-devel"
+depends="gst-plugins-good1"
+short_desc="Small, clear and fast audio player"
+maintainer="fanyx <fanyx@posteo.net>"
+license="GPL-3.0-or-later"
+homepage="https://sayonara-player.com"
+distfiles="https://sayonara-player.com/files/sayonara-player-${version/.stable/-stable}.tar.gz"
+checksum=21c7ebe42a98e0bce324224236f5665eb19263a1f005c0e20be69d1ca8ef44a1

^ permalink raw reply	[flat|nested] 37+ messages in thread

* Re: New package: sayonara-player-1.7.0.stable3
  2023-08-29 16:31 [PR PATCH] New package: sayonara-player-1.7.0-stable3 fanyx
                   ` (21 preceding siblings ...)
  2023-08-31 10:47 ` fanyx
@ 2023-08-31 10:52 ` fanyx
  2023-08-31 10:56 ` fanyx
                   ` (12 subsequent siblings)
  35 siblings, 0 replies; 37+ messages in thread
From: fanyx @ 2023-08-31 10:52 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 245 bytes --]

New comment by fanyx on void-packages repository

https://github.com/void-linux/void-packages/pull/45816#issuecomment-1700814081

Comment:
@ahesford should i move the qt5- packages to hostmakedepends?
non-x64 builds seem to be failing to this 

^ permalink raw reply	[flat|nested] 37+ messages in thread

* Re: New package: sayonara-player-1.7.0.stable3
  2023-08-29 16:31 [PR PATCH] New package: sayonara-player-1.7.0-stable3 fanyx
                   ` (22 preceding siblings ...)
  2023-08-31 10:52 ` fanyx
@ 2023-08-31 10:56 ` fanyx
  2023-08-31 14:19 ` ahesford
                   ` (11 subsequent siblings)
  35 siblings, 0 replies; 37+ messages in thread
From: fanyx @ 2023-08-31 10:56 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 250 bytes --]

New comment by fanyx on void-packages repository

https://github.com/void-linux/void-packages/pull/45816#issuecomment-1700814081

Comment:
@ahesford should i move the qt5- packages to hostmakedepends?
non-x86(_64) builds seem to be failing to this 

^ permalink raw reply	[flat|nested] 37+ messages in thread

* Re: New package: sayonara-player-1.7.0.stable3
  2023-08-29 16:31 [PR PATCH] New package: sayonara-player-1.7.0-stable3 fanyx
                   ` (23 preceding siblings ...)
  2023-08-31 10:56 ` fanyx
@ 2023-08-31 14:19 ` ahesford
  2023-08-31 14:27 ` [PR PATCH] [Updated] " fanyx
                   ` (10 subsequent siblings)
  35 siblings, 0 replies; 37+ messages in thread
From: ahesford @ 2023-08-31 14:19 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 450 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/45816#issuecomment-1701145859

Comment:
> @ahesford should i move the qt5- packages to hostmakedepends? non-x86(_64) builds seem to be failing to this

No, you need `qt5-host-tools` in `hostmakedepends` for cross-builds. See [the VLC template](https://github.com/void-linux/void-packages/blob/master/srcpkgs/vlc/template#L72-L74) for an example.

^ permalink raw reply	[flat|nested] 37+ messages in thread

* Re: [PR PATCH] [Updated] New package: sayonara-player-1.7.0.stable3
  2023-08-29 16:31 [PR PATCH] New package: sayonara-player-1.7.0-stable3 fanyx
                   ` (24 preceding siblings ...)
  2023-08-31 14:19 ` ahesford
@ 2023-08-31 14:27 ` fanyx
  2023-08-31 14:53 ` fanyx
                   ` (9 subsequent siblings)
  35 siblings, 0 replies; 37+ messages in thread
From: fanyx @ 2023-08-31 14:27 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 838 bytes --]

There is an updated pull request by fanyx against master on the void-packages repository

https://github.com/fanyx/void-packages sayonara-player
https://github.com/void-linux/void-packages/pull/45816

New package: sayonara-player-1.7.0.stable3
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

<!--#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)

`xbps-query` shows weird dependencies
if there is anything redundant from `makedepends` to `depends`, let me know and i'll remove stuff as needed

A patch file from https://github.com/void-linux/void-packages/pull/45816.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-sayonara-player-45816.patch --]
[-- Type: text/x-diff, Size: 1329 bytes --]

From 263d91366fae88b0078a8b02fdf659f2baaa7b34 Mon Sep 17 00:00:00 2001
From: fanyx <fanyx@posteo.net>
Date: Thu, 31 Aug 2023 12:20:48 +0200
Subject: [PATCH] New package: sayonara-player-1.7.0.stable3

---
 srcpkgs/sayonara-player/template | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
 create mode 100644 srcpkgs/sayonara-player/template

diff --git a/srcpkgs/sayonara-player/template b/srcpkgs/sayonara-player/template
new file mode 100644
index 0000000000000..2a1a232c2e1c4
--- /dev/null
+++ b/srcpkgs/sayonara-player/template
@@ -0,0 +1,21 @@
+# Template file for 'sayonara-player'
+pkgname=sayonara-player
+version=1.7.0.stable3
+revision=1
+build_style=cmake
+hostmakedepends="pkg-config qt5-qmake"
+makedepends="gst-plugins-base1-devel qt5-devel qt5-tools-devel
+ qt5-plugin-mysql qt5-plugin-odbc qt5-plugin-pgsql qt5-plugin-sqlite
+ qt5-plugin-tds qt5-svg-devel taglib-devel"
+depends="gst-plugins-good1"
+short_desc="Small, clear and fast audio player"
+maintainer="fanyx <fanyx@posteo.net>"
+license="GPL-3.0-or-later"
+homepage="https://sayonara-player.com"
+distfiles="https://sayonara-player.com/files/sayonara-player-${version/.stable/-stable}.tar.gz"
+checksum=21c7ebe42a98e0bce324224236f5665eb19263a1f005c0e20be69d1ca8ef44a1
+
+if [ "$CROSS_BUILD" ]; then
+	hostmakedepends+=" qt5-host-tools"
+fi
+

^ permalink raw reply	[flat|nested] 37+ messages in thread

* Re: New package: sayonara-player-1.7.0.stable3
  2023-08-29 16:31 [PR PATCH] New package: sayonara-player-1.7.0-stable3 fanyx
                   ` (25 preceding siblings ...)
  2023-08-31 14:27 ` [PR PATCH] [Updated] " fanyx
@ 2023-08-31 14:53 ` fanyx
  2023-08-31 15:01 ` [PR PATCH] [Updated] " fanyx
                   ` (8 subsequent siblings)
  35 siblings, 0 replies; 37+ messages in thread
From: fanyx @ 2023-08-31 14:53 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 258 bytes --]

New comment by fanyx on void-packages repository

https://github.com/void-linux/void-packages/pull/45816#issuecomment-1701202502

Comment:
do i add 
```
if [ "$XBPS_TARGET_LIBC" -eq "musl"]; then
    makedepends+=" libexecinfo"
fi
```
for musl builds?

^ permalink raw reply	[flat|nested] 37+ messages in thread

* Re: [PR PATCH] [Updated] New package: sayonara-player-1.7.0.stable3
  2023-08-29 16:31 [PR PATCH] New package: sayonara-player-1.7.0-stable3 fanyx
                   ` (26 preceding siblings ...)
  2023-08-31 14:53 ` fanyx
@ 2023-08-31 15:01 ` fanyx
  2023-08-31 15:02 ` fanyx
                   ` (7 subsequent siblings)
  35 siblings, 0 replies; 37+ messages in thread
From: fanyx @ 2023-08-31 15:01 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 838 bytes --]

There is an updated pull request by fanyx against master on the void-packages repository

https://github.com/fanyx/void-packages sayonara-player
https://github.com/void-linux/void-packages/pull/45816

New package: sayonara-player-1.7.0.stable3
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

<!--#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)

`xbps-query` shows weird dependencies
if there is anything redundant from `makedepends` to `depends`, let me know and i'll remove stuff as needed

A patch file from https://github.com/void-linux/void-packages/pull/45816.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-sayonara-player-45816.patch --]
[-- Type: text/x-diff, Size: 1409 bytes --]

From e5ced025fbf9e86293c44da36e54543d109eb856 Mon Sep 17 00:00:00 2001
From: fanyx <fanyx@posteo.net>
Date: Thu, 31 Aug 2023 12:20:48 +0200
Subject: [PATCH] New package: sayonara-player-1.7.0.stable3

---
 srcpkgs/sayonara-player/template | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)
 create mode 100644 srcpkgs/sayonara-player/template

diff --git a/srcpkgs/sayonara-player/template b/srcpkgs/sayonara-player/template
new file mode 100644
index 0000000000000..12cec6156ea46
--- /dev/null
+++ b/srcpkgs/sayonara-player/template
@@ -0,0 +1,25 @@
+# Template file for 'sayonara-player'
+pkgname=sayonara-player
+version=1.7.0.stable3
+revision=1
+build_style=cmake
+hostmakedepends="pkg-config qt5-qmake"
+makedepends="gst-plugins-base1-devel qt5-devel qt5-tools-devel
+ qt5-plugin-mysql qt5-plugin-odbc qt5-plugin-pgsql qt5-plugin-sqlite
+ qt5-plugin-tds qt5-svg-devel taglib-devel"
+depends="gst-plugins-good1"
+short_desc="Small, clear and fast audio player"
+maintainer="fanyx <fanyx@posteo.net>"
+license="GPL-3.0-or-later"
+homepage="https://sayonara-player.com"
+distfiles="https://sayonara-player.com/files/sayonara-player-${version/.stable/-stable}.tar.gz"
+checksum=21c7ebe42a98e0bce324224236f5665eb19263a1f005c0e20be69d1ca8ef44a1
+
+if [ "$CROSS_BUILD" ]; then
+	hostmakedepends+=" qt5-host-tools"
+fi
+
+if [ "$XBPS_TARGET_LIBC" -eq "musl" ];
+	makedepends+=" libexecinfo"
+fi
+

^ permalink raw reply	[flat|nested] 37+ messages in thread

* Re: [PR PATCH] [Updated] New package: sayonara-player-1.7.0.stable3
  2023-08-29 16:31 [PR PATCH] New package: sayonara-player-1.7.0-stable3 fanyx
                   ` (27 preceding siblings ...)
  2023-08-31 15:01 ` [PR PATCH] [Updated] " fanyx
@ 2023-08-31 15:02 ` fanyx
  2023-08-31 15:05 ` fanyx
                   ` (6 subsequent siblings)
  35 siblings, 0 replies; 37+ messages in thread
From: fanyx @ 2023-08-31 15:02 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 838 bytes --]

There is an updated pull request by fanyx against master on the void-packages repository

https://github.com/fanyx/void-packages sayonara-player
https://github.com/void-linux/void-packages/pull/45816

New package: sayonara-player-1.7.0.stable3
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

<!--#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)

`xbps-query` shows weird dependencies
if there is anything redundant from `makedepends` to `depends`, let me know and i'll remove stuff as needed

A patch file from https://github.com/void-linux/void-packages/pull/45816.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-sayonara-player-45816.patch --]
[-- Type: text/x-diff, Size: 1406 bytes --]

From cfe4a6815ea4c2e3b738d2e7ce43e4ed38d8e925 Mon Sep 17 00:00:00 2001
From: fanyx <fanyx@posteo.net>
Date: Thu, 31 Aug 2023 12:20:48 +0200
Subject: [PATCH] New package: sayonara-player-1.7.0.stable3

---
 srcpkgs/sayonara-player/template | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)
 create mode 100644 srcpkgs/sayonara-player/template

diff --git a/srcpkgs/sayonara-player/template b/srcpkgs/sayonara-player/template
new file mode 100644
index 0000000000000..4080e4083cac6
--- /dev/null
+++ b/srcpkgs/sayonara-player/template
@@ -0,0 +1,24 @@
+# Template file for 'sayonara-player'
+pkgname=sayonara-player
+version=1.7.0.stable3
+revision=1
+build_style=cmake
+hostmakedepends="pkg-config qt5-qmake"
+makedepends="gst-plugins-base1-devel qt5-devel qt5-tools-devel
+ qt5-plugin-mysql qt5-plugin-odbc qt5-plugin-pgsql qt5-plugin-sqlite
+ qt5-plugin-tds qt5-svg-devel taglib-devel"
+depends="gst-plugins-good1"
+short_desc="Small, clear and fast audio player"
+maintainer="fanyx <fanyx@posteo.net>"
+license="GPL-3.0-or-later"
+homepage="https://sayonara-player.com"
+distfiles="https://sayonara-player.com/files/sayonara-player-${version/.stable/-stable}.tar.gz"
+checksum=21c7ebe42a98e0bce324224236f5665eb19263a1f005c0e20be69d1ca8ef44a1
+
+if [ "$CROSS_BUILD" ]; then
+	hostmakedepends+=" qt5-host-tools"
+fi
+
+if [ "$XBPS_TARGET_LIBC" -eq "musl" ];
+	makedepends+=" libexecinfo"
+fi

^ permalink raw reply	[flat|nested] 37+ messages in thread

* Re: [PR PATCH] [Updated] New package: sayonara-player-1.7.0.stable3
  2023-08-29 16:31 [PR PATCH] New package: sayonara-player-1.7.0-stable3 fanyx
                   ` (28 preceding siblings ...)
  2023-08-31 15:02 ` fanyx
@ 2023-08-31 15:05 ` fanyx
  2023-08-31 22:25 ` ahesford
                   ` (5 subsequent siblings)
  35 siblings, 0 replies; 37+ messages in thread
From: fanyx @ 2023-08-31 15:05 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 838 bytes --]

There is an updated pull request by fanyx against master on the void-packages repository

https://github.com/fanyx/void-packages sayonara-player
https://github.com/void-linux/void-packages/pull/45816

New package: sayonara-player-1.7.0.stable3
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

<!--#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)

`xbps-query` shows weird dependencies
if there is anything redundant from `makedepends` to `depends`, let me know and i'll remove stuff as needed

A patch file from https://github.com/void-linux/void-packages/pull/45816.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-sayonara-player-45816.patch --]
[-- Type: text/x-diff, Size: 1411 bytes --]

From 88a0d9661d0d65c8f05069e212d04ade086991c4 Mon Sep 17 00:00:00 2001
From: fanyx <fanyx@posteo.net>
Date: Thu, 31 Aug 2023 12:20:48 +0200
Subject: [PATCH] New package: sayonara-player-1.7.0.stable3

---
 srcpkgs/sayonara-player/template | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)
 create mode 100644 srcpkgs/sayonara-player/template

diff --git a/srcpkgs/sayonara-player/template b/srcpkgs/sayonara-player/template
new file mode 100644
index 0000000000000..5054d7a2e2375
--- /dev/null
+++ b/srcpkgs/sayonara-player/template
@@ -0,0 +1,24 @@
+# Template file for 'sayonara-player'
+pkgname=sayonara-player
+version=1.7.0.stable3
+revision=1
+build_style=cmake
+hostmakedepends="pkg-config qt5-qmake"
+makedepends="gst-plugins-base1-devel qt5-devel qt5-tools-devel
+ qt5-plugin-mysql qt5-plugin-odbc qt5-plugin-pgsql qt5-plugin-sqlite
+ qt5-plugin-tds qt5-svg-devel taglib-devel"
+depends="gst-plugins-good1"
+short_desc="Small, clear and fast audio player"
+maintainer="fanyx <fanyx@posteo.net>"
+license="GPL-3.0-or-later"
+homepage="https://sayonara-player.com"
+distfiles="https://sayonara-player.com/files/sayonara-player-${version/.stable/-stable}.tar.gz"
+checksum=21c7ebe42a98e0bce324224236f5665eb19263a1f005c0e20be69d1ca8ef44a1
+
+if [ "$CROSS_BUILD" ]; then
+	hostmakedepends+=" qt5-host-tools"
+fi
+
+if [ "$XBPS_TARGET_LIBC" -eq "musl" ]; then
+	makedepends+=" libexecinfo"
+fi

^ permalink raw reply	[flat|nested] 37+ messages in thread

* Re: New package: sayonara-player-1.7.0.stable3
  2023-08-29 16:31 [PR PATCH] New package: sayonara-player-1.7.0-stable3 fanyx
                   ` (29 preceding siblings ...)
  2023-08-31 15:05 ` fanyx
@ 2023-08-31 22:25 ` ahesford
  2023-09-01  6:57 ` fanyx
                   ` (4 subsequent siblings)
  35 siblings, 0 replies; 37+ messages in thread
From: ahesford @ 2023-08-31 22:25 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 468 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/45816#issuecomment-1701861438

Comment:
> do i add
> 
> ```
> if [ "$XBPS_TARGET_LIBC" -eq "musl"]; then
>     makedepends+=" libexecinfo"
> fi
> ```
> 
> for musl builds?

It would be `if [ "$XBPS_TARGET_LIBC" = "musl"];` (not `-eq`, which will attempt an integer comparison), but you're right that `libexecinfo` should be made available for musl builds.

^ permalink raw reply	[flat|nested] 37+ messages in thread

* Re: New package: sayonara-player-1.7.0.stable3
  2023-08-29 16:31 [PR PATCH] New package: sayonara-player-1.7.0-stable3 fanyx
                   ` (30 preceding siblings ...)
  2023-08-31 22:25 ` ahesford
@ 2023-09-01  6:57 ` fanyx
  2023-09-01  7:03 ` [PR PATCH] [Updated] " fanyx
                   ` (3 subsequent siblings)
  35 siblings, 0 replies; 37+ messages in thread
From: fanyx @ 2023-09-01  6:57 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 202 bytes --]

New comment by fanyx on void-packages repository

https://github.com/void-linux/void-packages/pull/45816#issuecomment-1702263341

Comment:
oh, i thought `-eq` and `=` were equal.
well, today i learned

^ permalink raw reply	[flat|nested] 37+ messages in thread

* Re: [PR PATCH] [Updated] New package: sayonara-player-1.7.0.stable3
  2023-08-29 16:31 [PR PATCH] New package: sayonara-player-1.7.0-stable3 fanyx
                   ` (31 preceding siblings ...)
  2023-09-01  6:57 ` fanyx
@ 2023-09-01  7:03 ` fanyx
  2023-09-01  7:07 ` fanyx
                   ` (2 subsequent siblings)
  35 siblings, 0 replies; 37+ messages in thread
From: fanyx @ 2023-09-01  7:03 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 838 bytes --]

There is an updated pull request by fanyx against master on the void-packages repository

https://github.com/fanyx/void-packages sayonara-player
https://github.com/void-linux/void-packages/pull/45816

New package: sayonara-player-1.7.0.stable3
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

<!--#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)

`xbps-query` shows weird dependencies
if there is anything redundant from `makedepends` to `depends`, let me know and i'll remove stuff as needed

A patch file from https://github.com/void-linux/void-packages/pull/45816.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-sayonara-player-45816.patch --]
[-- Type: text/x-diff, Size: 1413 bytes --]

From 55fc97510d5f0dd32aba27d544cc065dc973d320 Mon Sep 17 00:00:00 2001
From: fanyx <fanyx@posteo.net>
Date: Thu, 31 Aug 2023 12:20:48 +0200
Subject: [PATCH] New package: sayonara-player-1.7.0.stable3

---
 srcpkgs/sayonara-player/template | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)
 create mode 100644 srcpkgs/sayonara-player/template

diff --git a/srcpkgs/sayonara-player/template b/srcpkgs/sayonara-player/template
new file mode 100644
index 0000000000000..8414b898c51ee
--- /dev/null
+++ b/srcpkgs/sayonara-player/template
@@ -0,0 +1,24 @@
+# Template file for 'sayonara-player'
+pkgname=sayonara-player
+version=1.7.0.stable3
+revision=1
+build_style=cmake
+hostmakedepends="pkg-config qt5-qmake"
+makedepends="gst-plugins-base1-devel qt5-devel qt5-tools-devel
+ qt5-plugin-mysql qt5-plugin-odbc qt5-plugin-pgsql qt5-plugin-sqlite
+ qt5-plugin-tds qt5-svg-devel taglib-devel"
+depends="gst-plugins-good1"
+short_desc="Small, clear and fast audio player"
+maintainer="fanyx <fanyx@posteo.net>"
+license="GPL-3.0-or-later"
+homepage="https://sayonara-player.com"
+distfiles="https://sayonara-player.com/files/sayonara-player-${version/.stable/-stable}.tar.gz"
+checksum=21c7ebe42a98e0bce324224236f5665eb19263a1f005c0e20be69d1ca8ef44a1
+
+if [ "$CROSS_BUILD" ]; then
+	hostmakedepends+=" qt5-host-tools"
+fi
+
+if [ "$XBPS_TARGET_LIBC" = "musl" ]; then
+	hostmakedepends+=" libexecinfo"
+fi

^ permalink raw reply	[flat|nested] 37+ messages in thread

* Re: [PR PATCH] [Updated] New package: sayonara-player-1.7.0.stable3
  2023-08-29 16:31 [PR PATCH] New package: sayonara-player-1.7.0-stable3 fanyx
                   ` (32 preceding siblings ...)
  2023-09-01  7:03 ` [PR PATCH] [Updated] " fanyx
@ 2023-09-01  7:07 ` fanyx
  2023-12-01  1:50 ` github-actions
  2024-02-23 14:41 ` [PR PATCH] [Closed]: " fanyx
  35 siblings, 0 replies; 37+ messages in thread
From: fanyx @ 2023-09-01  7:07 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 838 bytes --]

There is an updated pull request by fanyx against master on the void-packages repository

https://github.com/fanyx/void-packages sayonara-player
https://github.com/void-linux/void-packages/pull/45816

New package: sayonara-player-1.7.0.stable3
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

<!--#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)

`xbps-query` shows weird dependencies
if there is anything redundant from `makedepends` to `depends`, let me know and i'll remove stuff as needed

A patch file from https://github.com/void-linux/void-packages/pull/45816.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-sayonara-player-45816.patch --]
[-- Type: text/x-diff, Size: 1415 bytes --]

From 129896138182a5d36d31b7e8f8343fcf913ec71b Mon Sep 17 00:00:00 2001
From: fanyx <fanyx@posteo.net>
Date: Thu, 31 Aug 2023 12:20:48 +0200
Subject: [PATCH] New package: sayonara-player-1.7.0.stable3

---
 srcpkgs/sayonara-player/template | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)
 create mode 100644 srcpkgs/sayonara-player/template

diff --git a/srcpkgs/sayonara-player/template b/srcpkgs/sayonara-player/template
new file mode 100644
index 0000000000000..10e81a503144f
--- /dev/null
+++ b/srcpkgs/sayonara-player/template
@@ -0,0 +1,24 @@
+# Template file for 'sayonara-player'
+pkgname=sayonara-player
+version=1.7.0.stable3
+revision=1
+build_style=cmake
+hostmakedepends="pkg-config qt5-qmake"
+makedepends="gst-plugins-base1-devel qt5-devel qt5-tools-devel
+ qt5-plugin-mysql qt5-plugin-odbc qt5-plugin-pgsql qt5-plugin-sqlite
+ qt5-plugin-tds qt5-svg-devel taglib-devel"
+depends="gst-plugins-good1"
+short_desc="Small, clear and fast audio player"
+maintainer="fanyx <fanyx@posteo.net>"
+license="GPL-3.0-or-later"
+homepage="https://sayonara-player.com"
+distfiles="https://sayonara-player.com/files/sayonara-player-${version/.stable/-stable}.tar.gz"
+checksum=21c7ebe42a98e0bce324224236f5665eb19263a1f005c0e20be69d1ca8ef44a1
+
+if [ "$CROSS_BUILD" ]; then
+	hostmakedepends+=" qt5-host-tools"
+fi
+
+if [ "$XBPS_TARGET_LIBC" = "musl" ]; then
+	makedepends+=" libexecinfo-devel"
+fi

^ permalink raw reply	[flat|nested] 37+ messages in thread

* Re: New package: sayonara-player-1.7.0.stable3
  2023-08-29 16:31 [PR PATCH] New package: sayonara-player-1.7.0-stable3 fanyx
                   ` (33 preceding siblings ...)
  2023-09-01  7:07 ` fanyx
@ 2023-12-01  1:50 ` github-actions
  2024-02-23 14:41 ` [PR PATCH] [Closed]: " fanyx
  35 siblings, 0 replies; 37+ messages in thread
From: github-actions @ 2023-12-01  1:50 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/45816#issuecomment-1835281998

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

^ permalink raw reply	[flat|nested] 37+ messages in thread

* Re: [PR PATCH] [Closed]: New package: sayonara-player-1.7.0.stable3
  2023-08-29 16:31 [PR PATCH] New package: sayonara-player-1.7.0-stable3 fanyx
                   ` (34 preceding siblings ...)
  2023-12-01  1:50 ` github-actions
@ 2024-02-23 14:41 ` fanyx
  35 siblings, 0 replies; 37+ messages in thread
From: fanyx @ 2024-02-23 14:41 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 678 bytes --]

There's a closed pull request on the void-packages repository

New package: sayonara-player-1.7.0.stable3
https://github.com/void-linux/void-packages/pull/45816

Description:
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

<!--#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)

`xbps-query` shows weird dependencies
if there is anything redundant from `makedepends` to `depends`, let me know and i'll remove stuff as needed

^ permalink raw reply	[flat|nested] 37+ messages in thread

end of thread, other threads:[~2024-02-23 14:41 UTC | newest]

Thread overview: 37+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-29 16:31 [PR PATCH] New package: sayonara-player-1.7.0-stable3 fanyx
2023-08-29 16:29 ` [PR PATCH] [Updated] " fanyx
2023-08-29 16:33 ` fanyx
2023-08-29 16:47 ` [PR REVIEW] " ahesford
2023-08-29 16:47 ` ahesford
2023-08-29 16:48 ` fanyx
2023-08-29 16:50 ` [PR PATCH] [Updated] " fanyx
2023-08-29 16:58 ` fanyx
2023-08-29 18:05 ` [PR PATCH] [Updated] " fanyx
2023-08-29 18:06 ` ahesford
2023-08-29 18:08 ` fanyx
2023-08-29 18:31 ` fanyx
2023-08-29 18:44 ` [PR REVIEW] " ahesford
2023-08-29 18:56 ` [PR PATCH] [Updated] " fanyx
2023-08-29 19:08 ` [PR REVIEW] " ahesford
2023-08-29 19:24 ` fanyx
2023-08-29 21:14 ` [PR REVIEW] New package: sayonara-player-1.7.0.stable3 classabbyamp
2023-08-30 11:52 ` [PR PATCH] [Updated] " fanyx
2023-08-31 10:22 ` fanyx
2023-08-31 10:22 ` fanyx
2023-08-31 10:37 ` [PR PATCH] [Updated] " fanyx
2023-08-31 10:46 ` fanyx
2023-08-31 10:47 ` fanyx
2023-08-31 10:52 ` fanyx
2023-08-31 10:56 ` fanyx
2023-08-31 14:19 ` ahesford
2023-08-31 14:27 ` [PR PATCH] [Updated] " fanyx
2023-08-31 14:53 ` fanyx
2023-08-31 15:01 ` [PR PATCH] [Updated] " fanyx
2023-08-31 15:02 ` fanyx
2023-08-31 15:05 ` fanyx
2023-08-31 22:25 ` ahesford
2023-09-01  6:57 ` fanyx
2023-09-01  7:03 ` [PR PATCH] [Updated] " fanyx
2023-09-01  7:07 ` fanyx
2023-12-01  1:50 ` github-actions
2024-02-23 14:41 ` [PR PATCH] [Closed]: " fanyx

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).