* [PR PATCH] New package: freetube-0.19.2
@ 2024-03-07 0:37 budrz55
2024-03-07 3:08 ` [PR REVIEW] " abenson
` (7 more replies)
0 siblings, 8 replies; 9+ messages in thread
From: budrz55 @ 2024-03-07 0:37 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 661 bytes --]
There is a new pull request by budrz55 against master on the void-packages repository
https://github.com/budrz55/void-packages freetube-branch
https://github.com/void-linux/void-packages/pull/49161
New package: freetube-0.19.2
#### Testing the changes
- I tested the changes in this PR: YES
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): YES
#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
A patch file from https://github.com/void-linux/void-packages/pull/49161.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-freetube-branch-49161.patch --]
[-- Type: text/x-diff, Size: 2786 bytes --]
From 215650cb0c655e5f5835d149867a7d9f882739d1 Mon Sep 17 00:00:00 2001
From: budrz55 <budroz135@tutanota.com>
Date: Wed, 6 Mar 2024 18:54:01 -0500
Subject: [PATCH] New package: freetube-0.19.2
---
srcpkgs/freetube/files/freetube.desktop | 11 ++++++++
srcpkgs/freetube/files/freetube.sh | 3 +++
srcpkgs/freetube/template | 35 +++++++++++++++++++++++++
3 files changed, 49 insertions(+)
create mode 100644 srcpkgs/freetube/files/freetube.desktop
create mode 100644 srcpkgs/freetube/files/freetube.sh
create mode 100644 srcpkgs/freetube/template
diff --git a/srcpkgs/freetube/files/freetube.desktop b/srcpkgs/freetube/files/freetube.desktop
new file mode 100644
index 00000000000000..f19a51a83c022c
--- /dev/null
+++ b/srcpkgs/freetube/files/freetube.desktop
@@ -0,0 +1,11 @@
+[Desktop Entry]
+Name=FreeTube
+GenericName=YouTube Player
+Comment=An open source desktop YouTube player built with privacy in mind.
+Exec=freetube %U
+Terminal=false
+Type=Application
+Icon=freetube
+MimeType=x-scheme-handler/freetube;
+Categories=Network;
+StartupWMClass=FreeTube
diff --git a/srcpkgs/freetube/files/freetube.sh b/srcpkgs/freetube/files/freetube.sh
new file mode 100644
index 00000000000000..63ca1b1cc46ac3
--- /dev/null
+++ b/srcpkgs/freetube/files/freetube.sh
@@ -0,0 +1,3 @@
+#!/bin/sh
+
+electron24 /usr/lib/freetube/app.asar "$@"
diff --git a/srcpkgs/freetube/template b/srcpkgs/freetube/template
new file mode 100644
index 00000000000000..7ab7c1fa2760b3
--- /dev/null
+++ b/srcpkgs/freetube/template
@@ -0,0 +1,35 @@
+# Template file for 'freetube'
+
+pkgname=freetube
+_pkgname=FreeTube
+version=0.19.2
+revision=1
+archs="x86_64"
+short_desc='Open source desktop YouTube player built with privacy in mind'
+license='AGPL-3.0-or-later'
+hostmakedepends="gcc"
+depends='electron24'
+makedepends='yarn'
+maintainer="budrz55 <budroz135@tutanota.com>"
+homepage=https://freetubeapp.io
+distfiles=(https://github.com/FreeTubeApp/FreeTube/archive/v$version-beta.tar.gz
+ freetube.desktop
+ freetube.sh)
+checksum=(21c4c05eb1e2e8a95d7d1b94a150a6535616c82a17a6f0ad60a974ec03e3c3b0
+ ada2b4b8f6a1e8896acbce4f4d311228d2c86026c273ffa00afa3247294f8b1e
+ 3f4951c6cdb33cc1c4df05606760197efe45321519c259e47656077d6df2af18)
+
+do_build() {
+ yarn --cache-folder "yarn-cache" install
+ yarn --cache-folder "yarn-cache" run build
+}
+
+do_install() {
+ vlicense LICENSE
+ install -d "${DESTDIR}"/usr/lib/${pkgname}
+ cp -R "build/linux-unpacked/resources/app.asar" "${DESTDIR}/usr/lib/$pkgname"
+ install -Dm755 "${FILESDIR}/freetube.sh" "${DESTDIR}/usr/bin/$pkgname"
+ install -Dm644 "./_icons/icon.svg" "${DESTDIR}/usr/share/pixmaps/$pkgname.svg"
+ cd ..
+ install -Dm644 "${FILESDIR}/freetube.desktop" "${DESTDIR}/usr/share/applications/$pkgname.desktop"
+}
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PR REVIEW] New package: freetube-0.19.2
2024-03-07 0:37 [PR PATCH] New package: freetube-0.19.2 budrz55
@ 2024-03-07 3:08 ` abenson
2024-03-07 3:08 ` abenson
` (6 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: abenson @ 2024-03-07 3:08 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 167 bytes --]
New review comment by abenson on void-packages repository
https://github.com/void-linux/void-packages/pull/49161#discussion_r1515425159
Comment:
Why is this limited
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PR REVIEW] New package: freetube-0.19.2
2024-03-07 0:37 [PR PATCH] New package: freetube-0.19.2 budrz55
2024-03-07 3:08 ` [PR REVIEW] " abenson
@ 2024-03-07 3:08 ` abenson
2024-03-07 3:09 ` abenson
` (5 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: abenson @ 2024-03-07 3:08 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 184 bytes --]
New review comment by abenson on void-packages repository
https://github.com/void-linux/void-packages/pull/49161#discussion_r1515425535
Comment:
Why not just have `pkgname=FreeTube`
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PR REVIEW] New package: freetube-0.19.2
2024-03-07 0:37 [PR PATCH] New package: freetube-0.19.2 budrz55
2024-03-07 3:08 ` [PR REVIEW] " abenson
2024-03-07 3:08 ` abenson
@ 2024-03-07 3:09 ` abenson
2024-03-07 3:09 ` abenson
` (4 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: abenson @ 2024-03-07 3:09 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 162 bytes --]
New review comment by abenson on void-packages repository
https://github.com/void-linux/void-packages/pull/49161#discussion_r1515425871
Comment:
Not necessary.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PR REVIEW] New package: freetube-0.19.2
2024-03-07 0:37 [PR PATCH] New package: freetube-0.19.2 budrz55
` (2 preceding siblings ...)
2024-03-07 3:09 ` abenson
@ 2024-03-07 3:09 ` abenson
2024-03-07 3:11 ` abenson
` (3 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: abenson @ 2024-03-07 3:09 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 199 bytes --]
New review comment by abenson on void-packages repository
https://github.com/void-linux/void-packages/pull/49161#discussion_r1515426783
Comment:
Why is this `makedepends` and not `hostmakedepends`
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PR REVIEW] New package: freetube-0.19.2
2024-03-07 0:37 [PR PATCH] New package: freetube-0.19.2 budrz55
` (3 preceding siblings ...)
2024-03-07 3:09 ` abenson
@ 2024-03-07 3:11 ` abenson
2024-03-07 3:11 ` abenson
` (2 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: abenson @ 2024-03-07 3:11 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 335 bytes --]
New review comment by abenson on void-packages repository
https://github.com/void-linux/void-packages/pull/49161#discussion_r1515427982
Comment:
`xbps-src` at the moment doesn't support arrays, so it only takes the first argument. It doesn't matter, since with `xbps-src` you don't need to list assets in `$FILESDIR` in `distfiles`.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PR REVIEW] New package: freetube-0.19.2
2024-03-07 0:37 [PR PATCH] New package: freetube-0.19.2 budrz55
` (4 preceding siblings ...)
2024-03-07 3:11 ` abenson
@ 2024-03-07 3:11 ` abenson
2024-03-07 3:44 ` budrz55
2024-03-07 4:19 ` [PR PATCH] [Updated] " budrz55
7 siblings, 0 replies; 9+ messages in thread
From: abenson @ 2024-03-07 3:11 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 158 bytes --]
New review comment by abenson on void-packages repository
https://github.com/void-linux/void-packages/pull/49161#discussion_r1515428102
Comment:
Same here.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: New package: freetube-0.19.2
2024-03-07 0:37 [PR PATCH] New package: freetube-0.19.2 budrz55
` (5 preceding siblings ...)
2024-03-07 3:11 ` abenson
@ 2024-03-07 3:44 ` budrz55
2024-03-07 4:19 ` [PR PATCH] [Updated] " budrz55
7 siblings, 0 replies; 9+ messages in thread
From: budrz55 @ 2024-03-07 3:44 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1871 bytes --]
New comment by budrz55 on void-packages repository
https://github.com/void-linux/void-packages/pull/49161#issuecomment-1982295837
Comment:
Sorry. This is my first package and clearly have no idea what I am doing. Just trying to get it to build and work, which it appears to.
I wanted to learn how to build a package, particularly one that I wanted. Freetube wasn't available so I thought that maybe it would be a doable package that I could add, contributing to Voidlinux.
I appreciate your input though and will make note of it.
--
Sent with Tuta; enjoy secure & ad-free emails:
https://tuta.com
Mar 6, 2024, 22:11 by ***@***.***:
>
>
>
>
> @abenson> commented on this pull request.
>
>
>
>
> In > srcpkgs/freetube/template <https://github.com/void-linux/void-packages/pull/49161#discussion_r1515428102>> :
>
> > +pkgname=freetube+_pkgname=FreeTube+version=0.19.2+revision=1+archs="x86_64"+short_desc='Open source desktop YouTube player built with privacy in mind'+license='AGPL-3.0-or-later'+hostmakedepends="gcc"+depends='electron24'+makedepends='yarn'+maintainer="budrz55 ***@***.***>"+homepage=https://freetubeapp.io+distfiles=(https://github.com/FreeTubeApp/FreeTube/archive/v$version-beta.tar.gz+ freetube.desktop+ freetube.sh)+checksum=(21c4c05eb1e2e8a95d7d1b94a150a6535616c82a17a6f0ad60a974ec03e3c3b0
>
> Same here.
>
>
>
> —
> Reply to this email directly, > view it on GitHub <https://github.com/void-linux/void-packages/pull/49161#pullrequestreview-1921359405>> , or > unsubscribe <https://github.com/notifications/unsubscribe-auth/A6PSEEH7SXZFLFGCSTE66V3YW7LGHAVCNFSM6AAAAABEKBHYH2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSMRRGM2TSNBQGU>> .
> You are receiving this because you authored the thread.> Message ID: > <void-linux/void-packages/pull/49161/review/1921359405> @> github> .> com>
>
>
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PR PATCH] [Updated] New package: freetube-0.19.2
2024-03-07 0:37 [PR PATCH] New package: freetube-0.19.2 budrz55
` (6 preceding siblings ...)
2024-03-07 3:44 ` budrz55
@ 2024-03-07 4:19 ` budrz55
7 siblings, 0 replies; 9+ messages in thread
From: budrz55 @ 2024-03-07 4:19 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 666 bytes --]
There is an updated pull request by budrz55 against master on the void-packages repository
https://github.com/budrz55/void-packages freetube-branch
https://github.com/void-linux/void-packages/pull/49161
New package: freetube-0.19.2
#### Testing the changes
- I tested the changes in this PR: YES
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): YES
#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
A patch file from https://github.com/void-linux/void-packages/pull/49161.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-freetube-branch-49161.patch --]
[-- Type: text/x-diff, Size: 7015 bytes --]
From 8fbd4e9cd09b67e29a4d2470dd46487c76b62fb6 Mon Sep 17 00:00:00 2001
From: budrz55 <budroz135@tutanota.com>
Date: Wed, 6 Mar 2024 18:54:01 -0500
Subject: [PATCH] New package: freetube-0.19.2
new file: srcpkgs/FreeTube/files/freetube.desktop
new file: srcpkgs/FreeTube/files/freetube.sh
new file: srcpkgs/FreeTube/template
new file: srcpkgs/FreeTube/template.old
new file: srcpkgs/freetube/files/freetube.desktop
new file: srcpkgs/freetube/files/freetube.sh
new file: srcpkgs/freetube/template
deleted: srcpkgs/freetube/files/freetube.desktop
deleted: srcpkgs/freetube/files/freetube.sh
deleted: srcpkgs/freetube/template
---
srcpkgs/FreeTube/files/freetube.desktop | 11 ++++++++
srcpkgs/FreeTube/files/freetube.sh | 3 +++
srcpkgs/FreeTube/template | 27 +++++++++++++++++++
srcpkgs/FreeTube/template.old | 35 +++++++++++++++++++++++++
srcpkgs/freetube/files/freetube.desktop | 11 ++++++++
srcpkgs/freetube/files/freetube.sh | 3 +++
srcpkgs/freetube/template | 35 +++++++++++++++++++++++++
7 files changed, 125 insertions(+)
create mode 100644 srcpkgs/FreeTube/files/freetube.desktop
create mode 100644 srcpkgs/FreeTube/files/freetube.sh
create mode 100644 srcpkgs/FreeTube/template
create mode 100644 srcpkgs/FreeTube/template.old
create mode 100644 srcpkgs/freetube/files/freetube.desktop
create mode 100644 srcpkgs/freetube/files/freetube.sh
create mode 100644 srcpkgs/freetube/template
diff --git a/srcpkgs/FreeTube/files/freetube.desktop b/srcpkgs/FreeTube/files/freetube.desktop
new file mode 100644
index 00000000000000..c47d7bee7b1934
--- /dev/null
+++ b/srcpkgs/FreeTube/files/freetube.desktop
@@ -0,0 +1,11 @@
+[Desktop Entry]
+Name=FreeTube
+GenericName=YouTube Player
+Comment=Open source desktop YouTube player built with privacy in mind.
+Exec=FreeTube %U
+Terminal=false
+Type=Application
+Icon=FreeTube
+MimeType=x-scheme-handler/FreeTube;
+Categories=Network;
+StartupWMClass=FreeTube
diff --git a/srcpkgs/FreeTube/files/freetube.sh b/srcpkgs/FreeTube/files/freetube.sh
new file mode 100644
index 00000000000000..23b15f8b91f7aa
--- /dev/null
+++ b/srcpkgs/FreeTube/files/freetube.sh
@@ -0,0 +1,3 @@
+#!/bin/sh
+
+electron24 /usr/lib/FreeTube/app.asar "$@"
diff --git a/srcpkgs/FreeTube/template b/srcpkgs/FreeTube/template
new file mode 100644
index 00000000000000..c6a1904bf25fe3
--- /dev/null
+++ b/srcpkgs/FreeTube/template
@@ -0,0 +1,27 @@
+# Template file for 'FreeTube'
+
+pkgname=FreeTube
+version=0.19.2
+revision=1
+short_desc='Open source desktop YouTube player built with privacy in mind'
+license='AGPL-3.0-or-later'
+depends='electron24'
+hostmakedepends='yarn'
+maintainer="budrz55 <budroz135@tutanota.com>"
+homepage=https://freetubeapp.io
+distfiles="https://github.com/FreeTubeApp/FreeTube/archive/v$version-beta.tar.gz"
+checksum="21c4c05eb1e2e8a95d7d1b94a150a6535616c82a17a6f0ad60a974ec03e3c3b0"
+
+do_build() {
+ yarn --cache-folder "yarn-cache" install
+ yarn --cache-folder "yarn-cache" run build
+}
+
+do_install() {
+ vlicense LICENSE
+ vmkdir usr/lib/${pkgname}
+ vcopy build/linux-unpacked/resources/app.asar usr/lib/$pkgname
+ vbin ${FILESDIR}/freetube.sh $pkgname
+ vinstall ./_icons/icon.svg 644 usr/share/pixmaps/$pkgname.svg
+ vinstall ${FILESDIR}/freetube.desktop 644 usr/share/applications/$pkgname.desktop
+}
diff --git a/srcpkgs/FreeTube/template.old b/srcpkgs/FreeTube/template.old
new file mode 100644
index 00000000000000..7ab7c1fa2760b3
--- /dev/null
+++ b/srcpkgs/FreeTube/template.old
@@ -0,0 +1,35 @@
+# Template file for 'freetube'
+
+pkgname=freetube
+_pkgname=FreeTube
+version=0.19.2
+revision=1
+archs="x86_64"
+short_desc='Open source desktop YouTube player built with privacy in mind'
+license='AGPL-3.0-or-later'
+hostmakedepends="gcc"
+depends='electron24'
+makedepends='yarn'
+maintainer="budrz55 <budroz135@tutanota.com>"
+homepage=https://freetubeapp.io
+distfiles=(https://github.com/FreeTubeApp/FreeTube/archive/v$version-beta.tar.gz
+ freetube.desktop
+ freetube.sh)
+checksum=(21c4c05eb1e2e8a95d7d1b94a150a6535616c82a17a6f0ad60a974ec03e3c3b0
+ ada2b4b8f6a1e8896acbce4f4d311228d2c86026c273ffa00afa3247294f8b1e
+ 3f4951c6cdb33cc1c4df05606760197efe45321519c259e47656077d6df2af18)
+
+do_build() {
+ yarn --cache-folder "yarn-cache" install
+ yarn --cache-folder "yarn-cache" run build
+}
+
+do_install() {
+ vlicense LICENSE
+ install -d "${DESTDIR}"/usr/lib/${pkgname}
+ cp -R "build/linux-unpacked/resources/app.asar" "${DESTDIR}/usr/lib/$pkgname"
+ install -Dm755 "${FILESDIR}/freetube.sh" "${DESTDIR}/usr/bin/$pkgname"
+ install -Dm644 "./_icons/icon.svg" "${DESTDIR}/usr/share/pixmaps/$pkgname.svg"
+ cd ..
+ install -Dm644 "${FILESDIR}/freetube.desktop" "${DESTDIR}/usr/share/applications/$pkgname.desktop"
+}
diff --git a/srcpkgs/freetube/files/freetube.desktop b/srcpkgs/freetube/files/freetube.desktop
new file mode 100644
index 00000000000000..f19a51a83c022c
--- /dev/null
+++ b/srcpkgs/freetube/files/freetube.desktop
@@ -0,0 +1,11 @@
+[Desktop Entry]
+Name=FreeTube
+GenericName=YouTube Player
+Comment=An open source desktop YouTube player built with privacy in mind.
+Exec=freetube %U
+Terminal=false
+Type=Application
+Icon=freetube
+MimeType=x-scheme-handler/freetube;
+Categories=Network;
+StartupWMClass=FreeTube
diff --git a/srcpkgs/freetube/files/freetube.sh b/srcpkgs/freetube/files/freetube.sh
new file mode 100644
index 00000000000000..63ca1b1cc46ac3
--- /dev/null
+++ b/srcpkgs/freetube/files/freetube.sh
@@ -0,0 +1,3 @@
+#!/bin/sh
+
+electron24 /usr/lib/freetube/app.asar "$@"
diff --git a/srcpkgs/freetube/template b/srcpkgs/freetube/template
new file mode 100644
index 00000000000000..7ab7c1fa2760b3
--- /dev/null
+++ b/srcpkgs/freetube/template
@@ -0,0 +1,35 @@
+# Template file for 'freetube'
+
+pkgname=freetube
+_pkgname=FreeTube
+version=0.19.2
+revision=1
+archs="x86_64"
+short_desc='Open source desktop YouTube player built with privacy in mind'
+license='AGPL-3.0-or-later'
+hostmakedepends="gcc"
+depends='electron24'
+makedepends='yarn'
+maintainer="budrz55 <budroz135@tutanota.com>"
+homepage=https://freetubeapp.io
+distfiles=(https://github.com/FreeTubeApp/FreeTube/archive/v$version-beta.tar.gz
+ freetube.desktop
+ freetube.sh)
+checksum=(21c4c05eb1e2e8a95d7d1b94a150a6535616c82a17a6f0ad60a974ec03e3c3b0
+ ada2b4b8f6a1e8896acbce4f4d311228d2c86026c273ffa00afa3247294f8b1e
+ 3f4951c6cdb33cc1c4df05606760197efe45321519c259e47656077d6df2af18)
+
+do_build() {
+ yarn --cache-folder "yarn-cache" install
+ yarn --cache-folder "yarn-cache" run build
+}
+
+do_install() {
+ vlicense LICENSE
+ install -d "${DESTDIR}"/usr/lib/${pkgname}
+ cp -R "build/linux-unpacked/resources/app.asar" "${DESTDIR}/usr/lib/$pkgname"
+ install -Dm755 "${FILESDIR}/freetube.sh" "${DESTDIR}/usr/bin/$pkgname"
+ install -Dm644 "./_icons/icon.svg" "${DESTDIR}/usr/share/pixmaps/$pkgname.svg"
+ cd ..
+ install -Dm644 "${FILESDIR}/freetube.desktop" "${DESTDIR}/usr/share/applications/$pkgname.desktop"
+}
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2024-03-07 4:19 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-07 0:37 [PR PATCH] New package: freetube-0.19.2 budrz55
2024-03-07 3:08 ` [PR REVIEW] " abenson
2024-03-07 3:08 ` abenson
2024-03-07 3:09 ` abenson
2024-03-07 3:09 ` abenson
2024-03-07 3:11 ` abenson
2024-03-07 3:11 ` abenson
2024-03-07 3:44 ` budrz55
2024-03-07 4:19 ` [PR PATCH] [Updated] " budrz55
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).