* [PR PATCH] n: update to 9.2.1
@ 2024-02-26 19:13 akierig
2024-02-27 1:06 ` [PR REVIEW] " sgn
` (10 more replies)
0 siblings, 11 replies; 12+ messages in thread
From: akierig @ 2024-02-26 19:13 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 463 bytes --]
There is a new pull request by akierig against master on the void-packages repository
https://github.com/akierig/void-packages n-9.2.1
https://github.com/void-linux/void-packages/pull/48954
n: update to 9.2.1
#### Testing the changes
- I tested the changes in this PR: **YES**
#### Local build testing
- I built this PR locally for my native architecture, x86_64
A patch file from https://github.com/void-linux/void-packages/pull/48954.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-n-9.2.1-48954.patch --]
[-- Type: text/x-diff, Size: 942 bytes --]
From f66fa39f4be6adf559c0a836135143f4484665e5 Mon Sep 17 00:00:00 2001
From: anelki <akierig@fastmail.de>
Date: Mon, 26 Feb 2024 13:11:41 -0600
Subject: [PATCH] n: update to 9.2.1
---
srcpkgs/n/template | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/n/template b/srcpkgs/n/template
index ad3eab31a29c0..12081dc8c0175 100644
--- a/srcpkgs/n/template
+++ b/srcpkgs/n/template
@@ -1,6 +1,6 @@
# Template file for 'n'
pkgname=n
-version=9.2.0
+version=9.2.1
revision=1
build_style=gnu-makefile
depends="curl"
@@ -10,7 +10,7 @@ license="MIT"
homepage="https://github.com/tj/n"
changelog="https://raw.githubusercontent.com/tj/n/master/CHANGELOG.md"
distfiles="https://github.com/tj/n/archive/refs/tags/v${version}.tar.gz"
-checksum=5ed8a416014abd115e7174aa32ccba29826eebab2188420404f46931f6388eb1
+checksum=f112c291a1f441a14971ce5ee5dfb5f0a5d4251bd5f3ec556ef1c5a0687e3ee6
do_install() {
vbin bin/n n
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PR REVIEW] n: update to 9.2.1
2024-02-26 19:13 [PR PATCH] n: update to 9.2.1 akierig
@ 2024-02-27 1:06 ` sgn
2024-03-01 2:03 ` [PR PATCH] [Updated] " akierig
` (9 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: sgn @ 2024-02-27 1:06 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 439 bytes --]
New review comment by sgn on void-packages repository
https://github.com/void-linux/void-packages/pull/48954#discussion_r1503505649
Comment:
This is a simple `bash` script, that uses `curl` or `wget` to fetch `glibc`-only nodejs binaries distribution, then uses `tar` and `gzip` or `xz` to unpack it out.
So:
- **Personally**, I will not merge this update
- Its dependency needs to be updated
- It should be limited to glibc only.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PR PATCH] [Updated] n: update to 9.2.1
2024-02-26 19:13 [PR PATCH] n: update to 9.2.1 akierig
2024-02-27 1:06 ` [PR REVIEW] " sgn
@ 2024-03-01 2:03 ` akierig
2024-03-01 2:03 ` [PR REVIEW] " akierig
` (8 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: akierig @ 2024-03-01 2:03 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 468 bytes --]
There is an updated pull request by akierig against master on the void-packages repository
https://github.com/akierig/void-packages n-9.2.1
https://github.com/void-linux/void-packages/pull/48954
n: update to 9.2.1
#### Testing the changes
- I tested the changes in this PR: **YES**
#### Local build testing
- I built this PR locally for my native architecture, x86_64
A patch file from https://github.com/void-linux/void-packages/pull/48954.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-n-9.2.1-48954.patch --]
[-- Type: text/x-diff, Size: 1077 bytes --]
From da5fd718d9e843089048281a52e6a9f5a96a4745 Mon Sep 17 00:00:00 2001
From: anelki <akierig@fastmail.de>
Date: Mon, 26 Feb 2024 13:11:41 -0600
Subject: [PATCH] n: update to 9.2.1
---
srcpkgs/n/template | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/srcpkgs/n/template b/srcpkgs/n/template
index ad3eab31a29c08..9edf1f19b1e338 100644
--- a/srcpkgs/n/template
+++ b/srcpkgs/n/template
@@ -1,16 +1,17 @@
# Template file for 'n'
pkgname=n
-version=9.2.0
+version=9.2.1
revision=1
+archs="~*-musl"
build_style=gnu-makefile
-depends="curl"
+depends="curl gzip tar"
short_desc="Simple command line NodeJS version management"
maintainer="anelki <akierig@fastmail.de>"
license="MIT"
homepage="https://github.com/tj/n"
changelog="https://raw.githubusercontent.com/tj/n/master/CHANGELOG.md"
distfiles="https://github.com/tj/n/archive/refs/tags/v${version}.tar.gz"
-checksum=5ed8a416014abd115e7174aa32ccba29826eebab2188420404f46931f6388eb1
+checksum=f112c291a1f441a14971ce5ee5dfb5f0a5d4251bd5f3ec556ef1c5a0687e3ee6
do_install() {
vbin bin/n n
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PR REVIEW] n: update to 9.2.1
2024-02-26 19:13 [PR PATCH] n: update to 9.2.1 akierig
2024-02-27 1:06 ` [PR REVIEW] " sgn
2024-03-01 2:03 ` [PR PATCH] [Updated] " akierig
@ 2024-03-01 2:03 ` akierig
2024-03-15 18:02 ` classabbyamp
` (7 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: akierig @ 2024-03-01 2:03 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 205 bytes --]
New review comment by akierig on void-packages repository
https://github.com/void-linux/void-packages/pull/48954#discussion_r1508399496
Comment:
I think the most recent revision should cover everything
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PR REVIEW] n: update to 9.2.1
2024-02-26 19:13 [PR PATCH] n: update to 9.2.1 akierig
` (3 preceding siblings ...)
2024-03-15 18:02 ` classabbyamp
@ 2024-03-15 18:02 ` classabbyamp
2024-03-15 18:03 ` classabbyamp
` (5 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: classabbyamp @ 2024-03-15 18:02 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 545 bytes --]
New review comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/48954#discussion_r1526650430
Comment:
```suggestion
```
in `srcpkgs/n/files/README.voidlinux`, add something like:
```
On musl, armv6l, and other platforms that nodejs does not provide official releases,
n can be used by setting the environment variable N_NODE_DOWNLOAD_MIRROR:
N_NODE_DOWNLOAD_MIRROR=https://unofficial-builds.nodejs.org/download/release
```
https://github.com/tj/n/issues/648#issuecomment-763056046
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PR REVIEW] n: update to 9.2.1
2024-02-26 19:13 [PR PATCH] n: update to 9.2.1 akierig
` (2 preceding siblings ...)
2024-03-01 2:03 ` [PR REVIEW] " akierig
@ 2024-03-15 18:02 ` classabbyamp
2024-03-15 18:02 ` classabbyamp
` (6 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: classabbyamp @ 2024-03-15 18:02 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 226 bytes --]
New review comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/48954#discussion_r1526651203
Comment:
```suggestion
vbin bin/n
```
I think the 2nd argument isn't necessary
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PR REVIEW] n: update to 9.2.1
2024-02-26 19:13 [PR PATCH] n: update to 9.2.1 akierig
` (4 preceding siblings ...)
2024-03-15 18:02 ` classabbyamp
@ 2024-03-15 18:03 ` classabbyamp
2024-03-15 20:19 ` [PR PATCH] [Updated] " akierig
` (4 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: classabbyamp @ 2024-03-15 18:03 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 587 bytes --]
New review comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/48954#discussion_r1526650430
Comment:
```suggestion
```
in `srcpkgs/n/files/README.voidlinux`, add something like:
```
On musl, armv6l, and other platforms that nodejs does not provide official releases,
n can be used by setting the environment variable N_NODE_DOWNLOAD_MIRROR:
N_NODE_DOWNLOAD_MIRROR=https://unofficial-builds.nodejs.org/download/release
```
(please check that the env var is right)
https://github.com/tj/n/issues/648#issuecomment-763056046
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PR PATCH] [Updated] n: update to 9.2.1
2024-02-26 19:13 [PR PATCH] n: update to 9.2.1 akierig
` (5 preceding siblings ...)
2024-03-15 18:03 ` classabbyamp
@ 2024-03-15 20:19 ` akierig
2024-03-15 20:24 ` akierig
` (3 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: akierig @ 2024-03-15 20:19 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 468 bytes --]
There is an updated pull request by akierig against master on the void-packages repository
https://github.com/akierig/void-packages n-9.2.1
https://github.com/void-linux/void-packages/pull/48954
n: update to 9.2.1
#### Testing the changes
- I tested the changes in this PR: **YES**
#### Local build testing
- I built this PR locally for my native architecture, x86_64
A patch file from https://github.com/void-linux/void-packages/pull/48954.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-n-9.2.1-48954.patch --]
[-- Type: text/x-diff, Size: 1829 bytes --]
From aec017f18d0d19340ed42c31af46e39998e7b3f0 Mon Sep 17 00:00:00 2001
From: anelki <akierig@fastmail.de>
Date: Mon, 26 Feb 2024 13:11:41 -0600
Subject: [PATCH] n: update to 9.2.1 and amend readme.voidlinux for
musl/non-x86
---
srcpkgs/n/files/README.voidlinux | 6 +++++-
srcpkgs/n/template | 8 ++++----
2 files changed, 9 insertions(+), 5 deletions(-)
diff --git a/srcpkgs/n/files/README.voidlinux b/srcpkgs/n/files/README.voidlinux
index faefa91351e5ef..277d7be6875b2a 100644
--- a/srcpkgs/n/files/README.voidlinux
+++ b/srcpkgs/n/files/README.voidlinux
@@ -1,3 +1,7 @@
It is strongly recommended to set the environment variable N_PREFIX to install to a user-writable area. For example:
-export N_PREFIX=$HOME/local/n
+N_PREFIX=$HOME/local/n
+
+By default, nodejs only provides official builds for glibc. For musl and other unofficial supported builds, set the variable like so:
+
+N_NODE_DOWNLOAD_MIRROR=https://unofficial-builds.nodejs.org/download/release
diff --git a/srcpkgs/n/template b/srcpkgs/n/template
index ad3eab31a29c08..4897850676cf99 100644
--- a/srcpkgs/n/template
+++ b/srcpkgs/n/template
@@ -1,19 +1,19 @@
# Template file for 'n'
pkgname=n
-version=9.2.0
+version=9.2.1
revision=1
build_style=gnu-makefile
-depends="curl"
+depends="curl tar xz"
short_desc="Simple command line NodeJS version management"
maintainer="anelki <akierig@fastmail.de>"
license="MIT"
homepage="https://github.com/tj/n"
changelog="https://raw.githubusercontent.com/tj/n/master/CHANGELOG.md"
distfiles="https://github.com/tj/n/archive/refs/tags/v${version}.tar.gz"
-checksum=5ed8a416014abd115e7174aa32ccba29826eebab2188420404f46931f6388eb1
+checksum=f112c291a1f441a14971ce5ee5dfb5f0a5d4251bd5f3ec556ef1c5a0687e3ee6
do_install() {
- vbin bin/n n
+ vbin bin/n
vdoc ${FILESDIR}/README.voidlinux
}
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: n: update to 9.2.1
2024-02-26 19:13 [PR PATCH] n: update to 9.2.1 akierig
` (6 preceding siblings ...)
2024-03-15 20:19 ` [PR PATCH] [Updated] " akierig
@ 2024-03-15 20:24 ` akierig
2024-03-15 20:35 ` [PR REVIEW] " classabbyamp
` (2 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: akierig @ 2024-03-15 20:24 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 187 bytes --]
New comment by akierig on void-packages repository
https://github.com/void-linux/void-packages/pull/48954#issuecomment-2000392623
Comment:
thanks @classabbyamp, should all be resolved.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PR REVIEW] n: update to 9.2.1
2024-02-26 19:13 [PR PATCH] n: update to 9.2.1 akierig
` (7 preceding siblings ...)
2024-03-15 20:24 ` akierig
@ 2024-03-15 20:35 ` classabbyamp
2024-03-15 20:41 ` [PR PATCH] [Updated] " akierig
2024-03-15 20:46 ` [PR PATCH] [Merged]: " classabbyamp
10 siblings, 0 replies; 12+ messages in thread
From: classabbyamp @ 2024-03-15 20:35 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 308 bytes --]
New review comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/48954#discussion_r1526806705
Comment:
```suggestion
By default, nodejs only provides official builds for glibc. For musl and other unofficially supported builds, set the variable like so:
```
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PR PATCH] [Updated] n: update to 9.2.1
2024-02-26 19:13 [PR PATCH] n: update to 9.2.1 akierig
` (8 preceding siblings ...)
2024-03-15 20:35 ` [PR REVIEW] " classabbyamp
@ 2024-03-15 20:41 ` akierig
2024-03-15 20:46 ` [PR PATCH] [Merged]: " classabbyamp
10 siblings, 0 replies; 12+ messages in thread
From: akierig @ 2024-03-15 20:41 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 468 bytes --]
There is an updated pull request by akierig against master on the void-packages repository
https://github.com/akierig/void-packages n-9.2.1
https://github.com/void-linux/void-packages/pull/48954
n: update to 9.2.1
#### Testing the changes
- I tested the changes in this PR: **YES**
#### Local build testing
- I built this PR locally for my native architecture, x86_64
A patch file from https://github.com/void-linux/void-packages/pull/48954.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-n-9.2.1-48954.patch --]
[-- Type: text/x-diff, Size: 1838 bytes --]
From 1df23ddb3fff0073dd61194d580bcb9fcad89963 Mon Sep 17 00:00:00 2001
From: anelki <akierig@fastmail.de>
Date: Mon, 26 Feb 2024 13:11:41 -0600
Subject: [PATCH] n: update to 9.2.1 and amend readme.voidlinux for
musl/non-x86
---
srcpkgs/n/files/README.voidlinux | 6 +++++-
srcpkgs/n/template | 8 ++++----
2 files changed, 9 insertions(+), 5 deletions(-)
diff --git a/srcpkgs/n/files/README.voidlinux b/srcpkgs/n/files/README.voidlinux
index faefa91351e5ef..90ad5de920e543 100644
--- a/srcpkgs/n/files/README.voidlinux
+++ b/srcpkgs/n/files/README.voidlinux
@@ -1,3 +1,7 @@
It is strongly recommended to set the environment variable N_PREFIX to install to a user-writable area. For example:
-export N_PREFIX=$HOME/local/n
+N_PREFIX=$HOME/local/n
+
+By default, nodejs only provides official builds for glibc. For musl and other unofficially supported architectures, set the variable like so:
+
+N_NODE_DOWNLOAD_MIRROR=https://unofficial-builds.nodejs.org/download/release
diff --git a/srcpkgs/n/template b/srcpkgs/n/template
index ad3eab31a29c08..4897850676cf99 100644
--- a/srcpkgs/n/template
+++ b/srcpkgs/n/template
@@ -1,19 +1,19 @@
# Template file for 'n'
pkgname=n
-version=9.2.0
+version=9.2.1
revision=1
build_style=gnu-makefile
-depends="curl"
+depends="curl tar xz"
short_desc="Simple command line NodeJS version management"
maintainer="anelki <akierig@fastmail.de>"
license="MIT"
homepage="https://github.com/tj/n"
changelog="https://raw.githubusercontent.com/tj/n/master/CHANGELOG.md"
distfiles="https://github.com/tj/n/archive/refs/tags/v${version}.tar.gz"
-checksum=5ed8a416014abd115e7174aa32ccba29826eebab2188420404f46931f6388eb1
+checksum=f112c291a1f441a14971ce5ee5dfb5f0a5d4251bd5f3ec556ef1c5a0687e3ee6
do_install() {
- vbin bin/n n
+ vbin bin/n
vdoc ${FILESDIR}/README.voidlinux
}
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PR PATCH] [Merged]: n: update to 9.2.1
2024-02-26 19:13 [PR PATCH] n: update to 9.2.1 akierig
` (9 preceding siblings ...)
2024-03-15 20:41 ` [PR PATCH] [Updated] " akierig
@ 2024-03-15 20:46 ` classabbyamp
10 siblings, 0 replies; 12+ messages in thread
From: classabbyamp @ 2024-03-15 20:46 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 312 bytes --]
There's a merged pull request on the void-packages repository
n: update to 9.2.1
https://github.com/void-linux/void-packages/pull/48954
Description:
#### Testing the changes
- I tested the changes in this PR: **YES**
#### Local build testing
- I built this PR locally for my native architecture, x86_64
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2024-03-15 20:46 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-26 19:13 [PR PATCH] n: update to 9.2.1 akierig
2024-02-27 1:06 ` [PR REVIEW] " sgn
2024-03-01 2:03 ` [PR PATCH] [Updated] " akierig
2024-03-01 2:03 ` [PR REVIEW] " akierig
2024-03-15 18:02 ` classabbyamp
2024-03-15 18:02 ` classabbyamp
2024-03-15 18:03 ` classabbyamp
2024-03-15 20:19 ` [PR PATCH] [Updated] " akierig
2024-03-15 20:24 ` akierig
2024-03-15 20:35 ` [PR REVIEW] " classabbyamp
2024-03-15 20:41 ` [PR PATCH] [Updated] " akierig
2024-03-15 20:46 ` [PR PATCH] [Merged]: " classabbyamp
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).