[PR PATCH] slack-desktop: allow the use of WebRTCPipeWireCapturer flag

[PR PATCH] slack-desktop: allow the use of WebRTCPipeWireCapturer flag

[mdkcore0]

[-- Attachment #1: Type: text/plain, Size: 1037 bytes --]

There is a new pull request by mdkcore0 against master on the void-packages repository

https://github.com/mdkcore0/void-packages update-slack-desktop
https://github.com/void-linux/void-packages/pull/49298

slack-desktop: allow the use of WebRTCPipeWireCapturer flag
Slack seems to [disable screen sharing on Wayland](https://forums.slackcommunity.com/s/question/0D53a00009BSEGACA5/when-will-slack-support-wayland-screen-sharing-does-anyone-have-workarounds-or-hacks-to-make-it-work), this commit allow the use of WebRTCPipeWireCapturer.
Final user still needs to add the flag on the command line to make use of it:
`--enable-features=WebRTCPipeWireCapturer --ozone-platform-hint=auto`.

Note: just tested on Wayland, it would be great if someone tested it on x11 too.

#### Testing the changes
- I tested the changes in this PR: **briefly**

#### Local build testing
- I built this PR locally for my native architecture: x86_64-libc


A patch file from https://github.com/void-linux/void-packages/pull/49298.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-update-slack-desktop-49298.patch --]
[-- Type: text/x-diff, Size: 1523 bytes --]

From 4d719a772431a399d087881deb4e3b3b20d58c5d Mon Sep 17 00:00:00 2001
From: Rodrigo Oliveira <mdkcore@qtrnn.io>
Date: Thu, 14 Mar 2024 17:18:19 -0300
Subject: [PATCH] slack-desktop: allow the use of WebRTCPipeWireCapturer flag

Slack seems to disable screen sharing on Wayland [1], so this commit
allow the use of WebRTCPipeWireCapturer.
Note that the user still need to add the flag on the command line to
enable it: --enable-features=WebRTCPipeWireCapturer
--ozone-platform-hint=auto.

[1] https://forums.slackcommunity.com/s/question/0D53a00009BSEGACA5/when-will-slack-support-wayland-screen-sharing-does-anyone-have-workarounds-or-hacks-to-make-it-work
---
 srcpkgs/slack-desktop/template | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/slack-desktop/template b/srcpkgs/slack-desktop/template
index 4ed60d25375222..6368b1790c9039 100644
--- a/srcpkgs/slack-desktop/template
+++ b/srcpkgs/slack-desktop/template
@@ -1,7 +1,7 @@
 # Template file for 'slack-desktop'
 pkgname=slack-desktop
 version=4.36.140
-revision=1
+revision=2
 archs="x86_64"
 depends="xdg-utils"
 short_desc="Messaging app for teams"
@@ -19,6 +19,7 @@ do_install() {
 	vinstall usr/share/applications/slack.desktop 644 usr/share/applications
 	vinstall usr/share/pixmaps/slack.png 644 usr/share/pixmaps
 	mkdir ${DESTDIR}/usr/bin
+	vsed -i -e 's/,"WebRTCPipeWireCapturer"/,"LebRTCPipeWireCapturer"/' usr/lib/slack/resources/app.asar
 	vcopy usr/lib/slack usr/lib
 	ln -s ../lib/slack/slack ${DESTDIR}/usr/bin/slack
 }

Re: slack-desktop: allow the use of WebRTCPipeWireCapturer flag

[mdkcore0]

[-- Attachment #1: Type: text/plain, Size: 156 bytes --]

New comment by mdkcore0 on void-packages repository

https://github.com/void-linux/void-packages/pull/49298#issuecomment-1998450090

Comment:
@dataCobra :)

Re: [PR PATCH] [Updated] slack-desktop: allow the use of WebRTCPipeWireCapturer flag

[mdkcore0]

[-- Attachment #1: Type: text/plain, Size: 1042 bytes --]

There is an updated pull request by mdkcore0 against master on the void-packages repository

https://github.com/mdkcore0/void-packages update-slack-desktop
https://github.com/void-linux/void-packages/pull/49298

slack-desktop: allow the use of WebRTCPipeWireCapturer flag
Slack seems to [disable screen sharing on Wayland](https://forums.slackcommunity.com/s/question/0D53a00009BSEGACA5/when-will-slack-support-wayland-screen-sharing-does-anyone-have-workarounds-or-hacks-to-make-it-work), this commit allow the use of WebRTCPipeWireCapturer.
Final user still needs to add the flag on the command line to make use of it:
`--enable-features=WebRTCPipeWireCapturer --ozone-platform-hint=auto`.

Note: just tested on Wayland, it would be great if someone tested it on x11 too.

#### Testing the changes
- I tested the changes in this PR: **briefly**

#### Local build testing
- I built this PR locally for my native architecture: x86_64-libc


A patch file from https://github.com/void-linux/void-packages/pull/49298.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-update-slack-desktop-49298.patch --]
[-- Type: text/x-diff, Size: 1523 bytes --]

From 8d44fafdedf99c4ed2f258baa396f436a9771898 Mon Sep 17 00:00:00 2001
From: Rodrigo Oliveira <mdkcore@qtrnn.io>
Date: Thu, 14 Mar 2024 17:18:19 -0300
Subject: [PATCH] slack-desktop: allow the use of WebRTCPipeWireCapturer flag

Slack seems to disable screen sharing on Wayland [1], so this commit
allow the use of WebRTCPipeWireCapturer.
Note that the user still need to add the flag on the command line to
enable it: --enable-features=WebRTCPipeWireCapturer
--ozone-platform-hint=auto.

[1] https://forums.slackcommunity.com/s/question/0D53a00009BSEGACA5/when-will-slack-support-wayland-screen-sharing-does-anyone-have-workarounds-or-hacks-to-make-it-work
---
 srcpkgs/slack-desktop/template | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/slack-desktop/template b/srcpkgs/slack-desktop/template
index 4ed60d25375222..6368b1790c9039 100644
--- a/srcpkgs/slack-desktop/template
+++ b/srcpkgs/slack-desktop/template
@@ -1,7 +1,7 @@
 # Template file for 'slack-desktop'
 pkgname=slack-desktop
 version=4.36.140
-revision=1
+revision=2
 archs="x86_64"
 depends="xdg-utils"
 short_desc="Messaging app for teams"
@@ -19,6 +19,7 @@ do_install() {
 	vinstall usr/share/applications/slack.desktop 644 usr/share/applications
 	vinstall usr/share/pixmaps/slack.png 644 usr/share/pixmaps
 	mkdir ${DESTDIR}/usr/bin
+	vsed -i -e 's/,"WebRTCPipeWireCapturer"/,"LebRTCPipeWireCapturer"/' usr/lib/slack/resources/app.asar
 	vcopy usr/lib/slack usr/lib
 	ln -s ../lib/slack/slack ${DESTDIR}/usr/bin/slack
 }

Re: slack-desktop: allow the use of WebRTCPipeWireCapturer flag

[dataCobra]

[-- Attachment #1: Type: text/plain, Size: 202 bytes --]

New comment by dataCobra on void-packages repository

https://github.com/void-linux/void-packages/pull/49298#issuecomment-1999052554

Comment:
Thank you for the contribution.

I'll test it under X11.

Re: slack-desktop: allow the use of WebRTCPipeWireCapturer flag

[dataCobra]

[-- Attachment #1: Type: text/plain, Size: 456 bytes --]

New comment by dataCobra on void-packages repository

https://github.com/void-linux/void-packages/pull/49298#issuecomment-2008740845

Comment:
I've successfully tested the change and after the change everything still works under X11.

Since I'm currently not using the slack-desktop app with Void are you able to adopt the package and be the new maintainer?

Because at the moment I can't guaranty that I can update and test the package in the future.

Re: slack-desktop: allow the use of WebRTCPipeWireCapturer flag

[dataCobra]

[-- Attachment #1: Type: text/plain, Size: 436 bytes --]

New comment by dataCobra on void-packages repository

https://github.com/void-linux/void-packages/pull/49298#issuecomment-2008740845

Comment:
I've successfully tested this PR and everything still works under X11.

Since I'm currently not using the slack-desktop app with Void are you able to adopt the package and be the new maintainer?

Because at the moment I can't guaranty that I can update and test the package in the future.

Re: slack-desktop: allow the use of WebRTCPipeWireCapturer flag

[mdkcore0]

[-- Attachment #1: Type: text/plain, Size: 272 bytes --]

New comment by mdkcore0 on void-packages repository

https://github.com/void-linux/void-packages/pull/49298#issuecomment-2009974514

Comment:
hey, I can adopt, we use it for work, so I can keep it updated. Will update this PR to adopt it.
And many thanks for testing it!

Re: [PR PATCH] [Updated] slack-desktop: allow the use of WebRTCPipeWireCapturer flag

[mdkcore0]

[-- Attachment #1: Type: text/plain, Size: 1042 bytes --]

There is an updated pull request by mdkcore0 against master on the void-packages repository

https://github.com/mdkcore0/void-packages update-slack-desktop
https://github.com/void-linux/void-packages/pull/49298

slack-desktop: allow the use of WebRTCPipeWireCapturer flag
Slack seems to [disable screen sharing on Wayland](https://forums.slackcommunity.com/s/question/0D53a00009BSEGACA5/when-will-slack-support-wayland-screen-sharing-does-anyone-have-workarounds-or-hacks-to-make-it-work), this commit allow the use of WebRTCPipeWireCapturer.
Final user still needs to add the flag on the command line to make use of it:
`--enable-features=WebRTCPipeWireCapturer --ozone-platform-hint=auto`.

Note: just tested on Wayland, it would be great if someone tested it on x11 too.

#### Testing the changes
- I tested the changes in this PR: **briefly**

#### Local build testing
- I built this PR locally for my native architecture: x86_64-libc


A patch file from https://github.com/void-linux/void-packages/pull/49298.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-update-slack-desktop-49298.patch --]
[-- Type: text/x-diff, Size: 1808 bytes --]

From 0921641de239960abcaceacd04c14988e27bb7ef Mon Sep 17 00:00:00 2001
From: Rodrigo Oliveira <mdkcore@qtrnn.io>
Date: Thu, 14 Mar 2024 17:18:19 -0300
Subject: [PATCH] slack-desktop: allow the use of WebRTCPipeWireCapturer flag,
 adopt

Slack seems to disable screen sharing on Wayland [1], so this commit
allow the use of WebRTCPipeWireCapturer.
Note that the user still need to add the flag on the command line to
enable it: --enable-features=WebRTCPipeWireCapturer
--ozone-platform-hint=auto.

[1] https://forums.slackcommunity.com/s/question/0D53a00009BSEGACA5/when-will-slack-support-wayland-screen-sharing-does-anyone-have-workarounds-or-hacks-to-make-it-work
---
 srcpkgs/slack-desktop/template | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/slack-desktop/template b/srcpkgs/slack-desktop/template
index 4ed60d25375222..1a7288bd1a3460 100644
--- a/srcpkgs/slack-desktop/template
+++ b/srcpkgs/slack-desktop/template
@@ -1,11 +1,11 @@
 # Template file for 'slack-desktop'
 pkgname=slack-desktop
 version=4.36.140
-revision=1
+revision=2
 archs="x86_64"
 depends="xdg-utils"
 short_desc="Messaging app for teams"
-maintainer="dataCobra <datacobra@thinkbot.de>"
+maintainer="Rodrigo Oliveira <mdkcore@qtrnn.io>"
 license="custom:Proprietary"
 homepage="https://slack.com/"
 distfiles="https://downloads.slack-edge.com/releases/linux/${version}/prod/x64/${pkgname}-${version}-amd64.deb"
@@ -19,6 +19,7 @@ do_install() {
 	vinstall usr/share/applications/slack.desktop 644 usr/share/applications
 	vinstall usr/share/pixmaps/slack.png 644 usr/share/pixmaps
 	mkdir ${DESTDIR}/usr/bin
+	vsed -i -e 's/,"WebRTCPipeWireCapturer"/,"LebRTCPipeWireCapturer"/' usr/lib/slack/resources/app.asar
 	vcopy usr/lib/slack usr/lib
 	ln -s ../lib/slack/slack ${DESTDIR}/usr/bin/slack
 }

Re: [PR PATCH] [Updated] slack-desktop: allow the use of WebRTCPipeWireCapturer flag, adopt

[mdkcore0]

[-- Attachment #1: Type: text/plain, Size: 1116 bytes --]

There is an updated pull request by mdkcore0 against master on the void-packages repository

https://github.com/mdkcore0/void-packages update-slack-desktop
https://github.com/void-linux/void-packages/pull/49298

slack-desktop: allow the use of WebRTCPipeWireCapturer flag, adopt
Slack seems to [disable screen sharing on Wayland](https://forums.slackcommunity.com/s/question/0D53a00009BSEGACA5/when-will-slack-support-wayland-screen-sharing-does-anyone-have-workarounds-or-hacks-to-make-it-work), this commit allow the use of WebRTCPipeWireCapturer.
Final user still needs to add the flag on the command line to make use of it:
`--enable-features=WebRTCPipeWireCapturer --ozone-platform-hint=auto`.

Note: just tested on Wayland, it would be great if someone tested it on x11 too.
Note2: As discussed below with @dataCobra, I'm adopting this package.

#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture: x86_64-libc


A patch file from https://github.com/void-linux/void-packages/pull/49298.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-update-slack-desktop-49298.patch --]
[-- Type: text/x-diff, Size: 1808 bytes --]

From 1096492183d8f840e4b1029710e95888ef8ba094 Mon Sep 17 00:00:00 2001
From: Rodrigo Oliveira <mdkcore@qtrnn.io>
Date: Thu, 14 Mar 2024 17:18:19 -0300
Subject: [PATCH] slack-desktop: allow the use of WebRTCPipeWireCapturer flag,
 adopt

Slack seems to disable screen sharing on Wayland [1], so this commit
allow the use of WebRTCPipeWireCapturer.
Note that the user still need to add the flag on the command line to
enable it: --enable-features=WebRTCPipeWireCapturer
--ozone-platform-hint=auto.

[1] https://forums.slackcommunity.com/s/question/0D53a00009BSEGACA5/when-will-slack-support-wayland-screen-sharing-does-anyone-have-workarounds-or-hacks-to-make-it-work
---
 srcpkgs/slack-desktop/template | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/slack-desktop/template b/srcpkgs/slack-desktop/template
index 4ed60d25375222..1a7288bd1a3460 100644
--- a/srcpkgs/slack-desktop/template
+++ b/srcpkgs/slack-desktop/template
@@ -1,11 +1,11 @@
 # Template file for 'slack-desktop'
 pkgname=slack-desktop
 version=4.36.140
-revision=1
+revision=2
 archs="x86_64"
 depends="xdg-utils"
 short_desc="Messaging app for teams"
-maintainer="dataCobra <datacobra@thinkbot.de>"
+maintainer="Rodrigo Oliveira <mdkcore@qtrnn.io>"
 license="custom:Proprietary"
 homepage="https://slack.com/"
 distfiles="https://downloads.slack-edge.com/releases/linux/${version}/prod/x64/${pkgname}-${version}-amd64.deb"
@@ -19,6 +19,7 @@ do_install() {
 	vinstall usr/share/applications/slack.desktop 644 usr/share/applications
 	vinstall usr/share/pixmaps/slack.png 644 usr/share/pixmaps
 	mkdir ${DESTDIR}/usr/bin
+	vsed -i -e 's/,"WebRTCPipeWireCapturer"/,"LebRTCPipeWireCapturer"/' usr/lib/slack/resources/app.asar
 	vcopy usr/lib/slack usr/lib
 	ln -s ../lib/slack/slack ${DESTDIR}/usr/bin/slack
 }

Re: [PR PATCH] [Merged]: slack-desktop: allow the use of WebRTCPipeWireCapturer flag, adopt

[cinerea0]

[-- Attachment #1: Type: text/plain, Size: 945 bytes --]

There's a merged pull request on the void-packages repository

slack-desktop: allow the use of WebRTCPipeWireCapturer flag, adopt
https://github.com/void-linux/void-packages/pull/49298

Description:
Slack seems to [disable screen sharing on Wayland](https://forums.slackcommunity.com/s/question/0D53a00009BSEGACA5/when-will-slack-support-wayland-screen-sharing-does-anyone-have-workarounds-or-hacks-to-make-it-work), this commit allow the use of WebRTCPipeWireCapturer.
Final user still needs to add the flag on the command line to make use of it:
`--enable-features=WebRTCPipeWireCapturer --ozone-platform-hint=auto`.

Note: just tested on Wayland, it would be great if someone tested it on x11 too.
Note2: As discussed below with @dataCobra, I'm adopting this package.

#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture: x86_64-libc