[PR PATCH] spotify fix

[PR PATCH] spotify fix

[Baturax]

[-- Attachment #1: Type: text/plain, Size: 575 bytes --]

There is a new pull request by Baturax against master on the void-packages repository

https://github.com/Baturax/void-packages master
https://github.com/void-linux/void-packages/pull/49514

spotify fix

- I tested the changes in this PR: YES


- This new package conforms to the package-requirements: YES

- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - x86_64 glibc


A patch file from https://github.com/void-linux/void-packages/pull/49514.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-49514.patch --]
[-- Type: text/x-diff, Size: 1890 bytes --]

From 4352911b5b9b1d911126eeca099f5269aa812400 Mon Sep 17 00:00:00 2001
From: Bai <batuhanakkurt000@gmail.com>
Date: Sun, 24 Mar 2024 23:39:55 +0300
Subject: [PATCH 1/2] Update spotify

---
 srcpkgs/spotify/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/spotify/template b/srcpkgs/spotify/template
index 91a924b935a71a..bb0843f658727d 100644
--- a/srcpkgs/spotify/template
+++ b/srcpkgs/spotify/template
@@ -11,7 +11,7 @@ short_desc="Proprietary music streaming client"
 maintainer="Stefan Mühlinghaus <jazzman@alphabreed.com>"
 license="custom:Proprietary"
 homepage="https://www.spotify.com"
-distfiles="http://repository.spotify.com/pool/non-free/s/spotify-client/spotify-client_${version}.${_subver}_amd64.deb"
+distfiles="http://repository.spotify.com/pool/non-free/s/spotify-client/spotify-client_1.2.31.1205.g4d59ad7c_amd64.deb"
 checksum=83abdf8bd65348353110b6d858cb7adb53ef9d751d5f348af3fb8868f9eb1151
 repository=nonfree
 restricted=yes

From 7dbb73b7b3d64abdcc55bfb4281a7f2fb5699fe3 Mon Sep 17 00:00:00 2001
From: Bai <batuhanakkurt000@gmail.com>
Date: Mon, 25 Mar 2024 00:21:26 +0300
Subject: [PATCH 2/2] Update checksum

---
 srcpkgs/spotify/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/spotify/template b/srcpkgs/spotify/template
index bb0843f658727d..4bf2f3f2645cdf 100644
--- a/srcpkgs/spotify/template
+++ b/srcpkgs/spotify/template
@@ -12,7 +12,7 @@ maintainer="Stefan Mühlinghaus <jazzman@alphabreed.com>"
 license="custom:Proprietary"
 homepage="https://www.spotify.com"
 distfiles="http://repository.spotify.com/pool/non-free/s/spotify-client/spotify-client_1.2.31.1205.g4d59ad7c_amd64.deb"
-checksum=83abdf8bd65348353110b6d858cb7adb53ef9d751d5f348af3fb8868f9eb1151
+checksum=71b724bd9ec37ccc37b340606bc37f46d47320b5fa429a4c9dce5bd24e07adb8
 repository=nonfree
 restricted=yes
 nostrip=yes

Re: [PR REVIEW] spotify fix

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 193 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/49514#discussion_r1536916427

Comment:
don't hardcode, use the variables above 

Re: [PR REVIEW] spotify fix

[Baturax]

[-- Attachment #1: Type: text/plain, Size: 380 bytes --]

New review comment by Baturax on void-packages repository

https://github.com/void-linux/void-packages/pull/49514#discussion_r1536917193

Comment:
it gives error 
http://repository.spotify.com/pool/non-free/s/spotify-client/spotify-client_1.2.26.1187.g36b715a1_amd64.deb: Not Found
=> ERROR: spotify-1.2.26_1: failed to fetch 'spotify-client_1.2.26.1187.g36b715a1_amd64.deb'.

Re: [PR REVIEW] spotify fix

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 234 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/49514#discussion_r1536917406

Comment:
update the variables instead of removing them and replacing them with new values.

Re: [PR PATCH] [Updated] spotify fix

[Baturax]

[-- Attachment #1: Type: text/plain, Size: 580 bytes --]

There is an updated pull request by Baturax against master on the void-packages repository

https://github.com/Baturax/void-packages master
https://github.com/void-linux/void-packages/pull/49514

spotify fix

- I tested the changes in this PR: YES


- This new package conforms to the package-requirements: YES

- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - x86_64 glibc


A patch file from https://github.com/void-linux/void-packages/pull/49514.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-49514.patch --]
[-- Type: text/x-diff, Size: 3101 bytes --]

From 4352911b5b9b1d911126eeca099f5269aa812400 Mon Sep 17 00:00:00 2001
From: Bai <batuhanakkurt000@gmail.com>
Date: Sun, 24 Mar 2024 23:39:55 +0300
Subject: [PATCH 1/3] Update spotify

---
 srcpkgs/spotify/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/spotify/template b/srcpkgs/spotify/template
index 91a924b935a71a..bb0843f658727d 100644
--- a/srcpkgs/spotify/template
+++ b/srcpkgs/spotify/template
@@ -11,7 +11,7 @@ short_desc="Proprietary music streaming client"
 maintainer="Stefan Mühlinghaus <jazzman@alphabreed.com>"
 license="custom:Proprietary"
 homepage="https://www.spotify.com"
-distfiles="http://repository.spotify.com/pool/non-free/s/spotify-client/spotify-client_${version}.${_subver}_amd64.deb"
+distfiles="http://repository.spotify.com/pool/non-free/s/spotify-client/spotify-client_1.2.31.1205.g4d59ad7c_amd64.deb"
 checksum=83abdf8bd65348353110b6d858cb7adb53ef9d751d5f348af3fb8868f9eb1151
 repository=nonfree
 restricted=yes

From 7dbb73b7b3d64abdcc55bfb4281a7f2fb5699fe3 Mon Sep 17 00:00:00 2001
From: Bai <batuhanakkurt000@gmail.com>
Date: Mon, 25 Mar 2024 00:21:26 +0300
Subject: [PATCH 2/3] Update checksum

---
 srcpkgs/spotify/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/spotify/template b/srcpkgs/spotify/template
index bb0843f658727d..4bf2f3f2645cdf 100644
--- a/srcpkgs/spotify/template
+++ b/srcpkgs/spotify/template
@@ -12,7 +12,7 @@ maintainer="Stefan Mühlinghaus <jazzman@alphabreed.com>"
 license="custom:Proprietary"
 homepage="https://www.spotify.com"
 distfiles="http://repository.spotify.com/pool/non-free/s/spotify-client/spotify-client_1.2.31.1205.g4d59ad7c_amd64.deb"
-checksum=83abdf8bd65348353110b6d858cb7adb53ef9d751d5f348af3fb8868f9eb1151
+checksum=71b724bd9ec37ccc37b340606bc37f46d47320b5fa429a4c9dce5bd24e07adb8
 repository=nonfree
 restricted=yes
 nostrip=yes

From 4ebbee2017ca8aabde9833204cfc41dd2cbbcf67 Mon Sep 17 00:00:00 2001
From: Bai <batuhanakkurt000@gmail.com>
Date: Mon, 25 Mar 2024 00:47:52 +0300
Subject: [PATCH 3/3] use var

---
 srcpkgs/spotify/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/spotify/template b/srcpkgs/spotify/template
index 4bf2f3f2645cdf..fbd27656e2d33c 100644
--- a/srcpkgs/spotify/template
+++ b/srcpkgs/spotify/template
@@ -1,8 +1,8 @@
 # Template file for 'spotify'
 pkgname=spotify
-version=1.2.26
+version=1.2.31
 revision=1
-_subver=1187.g36b715a1
+_subver=1205.g4d59ad7c
 archs="x86_64"
 create_wrksrc=yes
 hostmakedepends="libcurl"
@@ -11,7 +11,7 @@ short_desc="Proprietary music streaming client"
 maintainer="Stefan Mühlinghaus <jazzman@alphabreed.com>"
 license="custom:Proprietary"
 homepage="https://www.spotify.com"
-distfiles="http://repository.spotify.com/pool/non-free/s/spotify-client/spotify-client_1.2.31.1205.g4d59ad7c_amd64.deb"
+distfiles="https://repository-origin.spotify.com/pool/non-free/s/spotify-client/spotify-client_${version}.${_subver}_amd64.deb"
 checksum=71b724bd9ec37ccc37b340606bc37f46d47320b5fa429a4c9dce5bd24e07adb8
 repository=nonfree
 restricted=yes

Re: [PR REVIEW] spotify fix

[Baturax]

[-- Attachment #1: Type: text/plain, Size: 160 bytes --]

New review comment by Baturax on void-packages repository

https://github.com/void-linux/void-packages/pull/49514#discussion_r1536918683

Comment:
fixed thanks

Re: spotify fix

[dataCobra]

[-- Attachment #1: Type: text/plain, Size: 334 bytes --]

New comment by dataCobra on void-packages repository

https://github.com/void-linux/void-packages/pull/49514#issuecomment-2017330728

Comment:
Hey, there is already a PR for an update to the newest version where we also discussed the no longer available version 1.2.26.

PR -> https://github.com/void-linux/void-packages/pull/48955

Re: spotify fix

[Baturax]

[-- Attachment #1: Type: text/plain, Size: 322 bytes --]

New comment by Baturax on void-packages repository

https://github.com/void-linux/void-packages/pull/49514#issuecomment-2017826105

Comment:
> Hey, there is already a PR for an update to the newest version where we also discussed the no longer available version 1.2.26.
> 
> PR -> #48955

oh okay. will you accept it?

Re: spotify fix

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 153 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/49514#issuecomment-2021982303

Comment:
#49559

Re: [PR PATCH] [Closed]: spotify fix

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 425 bytes --]

There's a closed pull request on the void-packages repository

spotify fix
https://github.com/void-linux/void-packages/pull/49514

Description:

- I tested the changes in this PR: YES


- This new package conforms to the package-requirements: YES

- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - x86_64 glibc