Github messages for voidlinux
 help / color / mirror / Atom feed
From: Akaricchi <Akaricchi@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: taisei: update to 1.4.1
Date: Wed, 27 Mar 2024 14:29:13 +0100	[thread overview]
Message-ID: <20240327132913.D75D421350@inbox.vuxu.org> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-49348@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1154 bytes --]

New comment by Akaricchi on void-packages repository

https://github.com/void-linux/void-packages/pull/49348#issuecomment-2022773504

Comment:
`-msse2` is ok, but the proper fix be to correct this check in CGLM: https://github.com/recp/cglm/blob/1de373a9bd453d1fff6846db3a01ade8270f12bb/include/cglm/simd/intrin.h#L27

It should only check for SSE2 there. I can try to submit that upstream a bit later, though I'll need to set up a 32-bit environment to test it first.

For what it's worth, openSUSE doesn't build Taisei for i686, because CGLM fails (or at least used to fail) some unit tests on that platform. It doesn't look like i686 support is well maintained there, and we neither test nor provide i686 Linux builds of Taisei either. I don't believe there's an x86 system around that can handle this game acceptably well while not supporting x86-64.

As for why we enforce `-msse`: what we really want is `-mfpmath=sse`, which prevents the compiler from using x87 FPU instructions for floating point math. It's to reduce the potential for replay compatibility problems between different builds, due to the extended used by those instructions.

  parent reply	other threads:[~2024-03-27 13:29 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-18 11:00 [PR PATCH] taisei 1.4.1 version bump aryalaadi
2024-03-25 16:35 ` [PR PATCH] [Updated] " aryalaadi
2024-03-25 16:51 ` aryalaadi
2024-03-25 16:55 ` [PR REVIEW] taisei: update to 1.4.1 tornaria
2024-03-25 16:56 ` tornaria
2024-03-25 17:00 ` [PR PATCH] [Updated] " aryalaadi
2024-03-25 17:04 ` aryalaadi
2024-03-25 17:16 ` aryalaadi
2024-03-26 14:07 ` [PR REVIEW] " tornaria
2024-03-26 16:17 ` [PR PATCH] [Updated] " aryalaadi
2024-03-26 16:29 ` tornaria
2024-03-26 23:54 ` ahesford
2024-03-27  3:38 ` tornaria
2024-03-27  3:54 ` [PR PATCH] [Updated] " aryalaadi
2024-03-27  3:56 ` aryalaadi
2024-03-27  3:57 ` [PR PATCH] [Updated] " aryalaadi
2024-03-27  4:27 ` aryalaadi
2024-03-27  4:32 ` aryalaadi
2024-03-27 11:01 ` [PR REVIEW] " tornaria
2024-03-27 11:10 ` tornaria
2024-03-27 11:24 ` ahesford
2024-03-27 11:24 ` ahesford
2024-03-27 11:30 ` ahesford
2024-03-27 13:05 ` [PR REVIEW] " Akaricchi
2024-03-27 13:29 ` Akaricchi [this message]
2024-03-27 13:29 ` Akaricchi
2024-03-27 13:30 ` Akaricchi
2024-03-27 14:24 ` tornaria
2024-03-27 14:49 ` [PR PATCH] [Updated] " aryalaadi
2024-03-27 14:51 ` aryalaadi
2024-03-27 14:57 ` aryalaadi
2024-03-27 16:01 ` Akaricchi
2024-03-27 16:07 ` Akaricchi
2024-03-27 16:07 ` Akaricchi
2024-03-27 17:01 ` ahesford
2024-03-27 20:10 ` tornaria
2024-03-28  9:30 ` [PR PATCH] [Updated] " aryalaadi
2024-03-28  9:38 ` aryalaadi
2024-03-28  9:40 ` aryalaadi
2024-03-28  9:42 ` aryalaadi
2024-03-29 16:19 ` [PR PATCH] [Updated] " aryalaadi
2024-03-29 23:11 ` tornaria
2024-03-30  0:21 ` tornaria
2024-03-30 13:28 ` unspecd
2024-03-31 20:49 ` recp
2024-04-01 15:14 ` recp
2024-04-02  6:00 ` aryalaadi
2024-04-02  6:35 ` [PR PATCH] [Updated] " aryalaadi
2024-04-02  6:41 ` aryalaadi
2024-04-02  6:49 ` aryalaadi
2024-04-02  6:52 ` aryalaadi
2024-04-02  7:07 ` aryalaadi
2024-04-02  7:53 ` aryalaadi
2024-04-02 11:44 ` [PR REVIEW] " ahesford
2024-04-02 13:02 ` [PR PATCH] [Updated] " aryalaadi
2024-04-02 13:03 ` [PR REVIEW] " aryalaadi
2024-04-03 21:24 ` tornaria

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240327132913.D75D421350@inbox.vuxu.org \
    --to=akaricchi@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).