Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] gnome-maps: update to 1.2.0.
@ 2024-03-27 13:19 fanyx
  2024-03-27 13:29 ` fanyx
                   ` (13 more replies)
  0 siblings, 14 replies; 15+ messages in thread
From: fanyx @ 2024-03-27 13:19 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 568 bytes --]

There is a new pull request by fanyx against master on the void-packages repository

https://github.com/fanyx/void-packages gnome-maps
https://github.com/void-linux/void-packages/pull/49564

gnome-maps: update to 1.2.0.
#### Testing the changes
- I tested the changes in this PR: **NO**

#### Local build testing
- [ ] I built this PR locally for my native architecture, (x86_64-glibc)
- I built this PR locally for these architectures (if supported. mark crossbuilds):


A patch file from https://github.com/void-linux/void-packages/pull/49564.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gnome-maps-49564.patch --]
[-- Type: text/x-diff, Size: 2977 bytes --]

From 9c888d6b46314dceb9e1632d75f457a6051d7faa Mon Sep 17 00:00:00 2001
From: fanyx <fanyx@posteo.net>
Date: Wed, 27 Mar 2024 14:16:31 +0100
Subject: [PATCH 1/2] gnome-maps: update to 46.0.

---
 srcpkgs/gnome-maps/template | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/gnome-maps/template b/srcpkgs/gnome-maps/template
index 90fcc9e2011846..0509fd3c245ee3 100644
--- a/srcpkgs/gnome-maps/template
+++ b/srcpkgs/gnome-maps/template
@@ -1,6 +1,6 @@
 # Template file for 'gnome-maps'
 pkgname=gnome-maps
-version=45.5
+version=46.0
 revision=1
 build_style=meson
 build_helper="gir"
@@ -13,6 +13,7 @@ short_desc="GNOME maps application"
 maintainer="Enno Boland <gottox@voidlinux.org>"
 license="GPL-2.0-or-later"
 homepage="https://wiki.gnome.org/Apps/Maps"
-changelog="https://gitlab.gnome.org/GNOME/gnome-maps/-/raw/gnome-45/NEWS"
+#changelog="https://gitlab.gnome.org/GNOME/gnome-maps/-/raw/main/NEWS"
+changelog="https://gitlab.gnome.org/GNOME/gnome-maps/-/raw/gnome-46/NEWS"
 distfiles="${GNOME_SITE}/gnome-maps/${version%.*}/gnome-maps-${version}.tar.xz"
-checksum=1c20f5e10dce684adefb2961526266a224e6c46c16fa03b954affa0b3a1bb740
+checksum=e70979b56075b9a3051f375ea7080ea481e7bd5229e6d8228f8de961cae2a9ae

From a01ccf0554573778b799b72589ab58ab59f9faae Mon Sep 17 00:00:00 2001
From: fanyx <fanyx@posteo.net>
Date: Wed, 27 Mar 2024 14:16:48 +0100
Subject: [PATCH 2/2] libshumate: update to 1.2.0.

---
 srcpkgs/libshumate/template | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/libshumate/template b/srcpkgs/libshumate/template
index 1b515ba782dce5..0d6f969371cff4 100644
--- a/srcpkgs/libshumate/template
+++ b/srcpkgs/libshumate/template
@@ -1,21 +1,22 @@
 # Template file for 'libshumate'
 pkgname=libshumate
-version=1.1.3
+version=1.2.0
 revision=1
 build_style=meson
 build_helper="gir"
 configure_args="$(vopt_bool gir vapi) $(vopt_bool gir gir) $(vopt_bool gir gtk_doc)"
 hostmakedepends="pkg-config $(vopt_if gir 'gi-docgen vala') glib-devel gettext"
-makedepends="libglib-devel sqlite-devel cairo-devel gtk4-devel libsoup3-devel"
+makedepends="libglib-devel sqlite-devel cairo-devel gtk4-devel libsoup3-devel
+ protobuf-c-devel gperf"
 checkdepends="dbus xvfb-run"
 short_desc="C library providing a GtkWidget to display maps"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="LGPL-2.1-or-later"
 homepage="https://wiki.gnome.org/Projects/libshumate"
 #changelog="https://gitlab.gnome.org/GNOME/libshumate/-/raw/main/NEWS"
-changelog="https://gitlab.gnome.org/GNOME/libshumate/-/raw/libshumate-1-1/NEWS"
+changelog="https://gitlab.gnome.org/GNOME/libshumate/-/raw/libshumate-1-2/NEWS"
 distfiles="${GNOME_SITE}/libshumate/${version%.*}/libshumate-${version}.tar.xz"
-checksum=6b8a159ed744fdd15992411662a05cb4187fb55e185111a366e0038d2f0b3543
+checksum=4f8413a707cd00f84cee39ca49f58c48fc436f008ea80d6532ac37dafd0ba96b
 make_check_pre="dbus-run-session xvfb-run"
 
 build_options="gir"

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: gnome-maps: update to 1.2.0.
  2024-03-27 13:19 [PR PATCH] gnome-maps: update to 1.2.0 fanyx
@ 2024-03-27 13:29 ` fanyx
  2024-03-27 14:48 ` [PR REVIEW] " chrysos349
                   ` (12 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: fanyx @ 2024-03-27 13:29 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 247 bytes --]

New comment by fanyx on void-packages repository

https://github.com/void-linux/void-packages/pull/49564#issuecomment-2022774169

Comment:
@oreo639 can you point me to how i disable `G_DISABLE_ASSERT`
feels like this would be disabled by default

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PR REVIEW] gnome-maps: update to 1.2.0.
  2024-03-27 13:19 [PR PATCH] gnome-maps: update to 1.2.0 fanyx
  2024-03-27 13:29 ` fanyx
@ 2024-03-27 14:48 ` chrysos349
  2024-03-27 14:48 ` chrysos349
                   ` (11 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: chrysos349 @ 2024-03-27 14:48 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 183 bytes --]

New review comment by chrysos349 on void-packages repository

https://github.com/void-linux/void-packages/pull/49564#discussion_r1541270841

Comment:
move `gperf` to `hostmakdepends`

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PR REVIEW] gnome-maps: update to 1.2.0.
  2024-03-27 13:19 [PR PATCH] gnome-maps: update to 1.2.0 fanyx
  2024-03-27 13:29 ` fanyx
  2024-03-27 14:48 ` [PR REVIEW] " chrysos349
@ 2024-03-27 14:48 ` chrysos349
  2024-03-27 14:54 ` fanyx
                   ` (10 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: chrysos349 @ 2024-03-27 14:48 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 217 bytes --]

New review comment by chrysos349 on void-packages repository

https://github.com/void-linux/void-packages/pull/49564#discussion_r1541271604

Comment:
add `--buildtype debugoptimized` to `configure_args` to fix tests.

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PR REVIEW] gnome-maps: update to 1.2.0.
  2024-03-27 13:19 [PR PATCH] gnome-maps: update to 1.2.0 fanyx
                   ` (2 preceding siblings ...)
  2024-03-27 14:48 ` chrysos349
@ 2024-03-27 14:54 ` fanyx
  2024-03-27 15:23 ` [PR PATCH] [Updated] " fanyx
                   ` (9 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: fanyx @ 2024-03-27 14:54 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 159 bytes --]

New review comment by fanyx on void-packages repository

https://github.com/void-linux/void-packages/pull/49564#discussion_r1541282749

Comment:
ty great call

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PR PATCH] [Updated] gnome-maps: update to 1.2.0.
  2024-03-27 13:19 [PR PATCH] gnome-maps: update to 1.2.0 fanyx
                   ` (3 preceding siblings ...)
  2024-03-27 14:54 ` fanyx
@ 2024-03-27 15:23 ` fanyx
  2024-03-27 15:30 ` fanyx
                   ` (8 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: fanyx @ 2024-03-27 15:23 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 573 bytes --]

There is an updated pull request by fanyx against master on the void-packages repository

https://github.com/fanyx/void-packages gnome-maps
https://github.com/void-linux/void-packages/pull/49564

gnome-maps: update to 1.2.0.
#### Testing the changes
- I tested the changes in this PR: **NO**

#### Local build testing
- [ ] I built this PR locally for my native architecture, (x86_64-glibc)
- I built this PR locally for these architectures (if supported. mark crossbuilds):


A patch file from https://github.com/void-linux/void-packages/pull/49564.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gnome-maps-49564.patch --]
[-- Type: text/x-diff, Size: 3589 bytes --]

From 7a80d3069a695f6ff590c55087fa31352d70e894 Mon Sep 17 00:00:00 2001
From: fanyx <fanyx@posteo.net>
Date: Wed, 27 Mar 2024 14:16:31 +0100
Subject: [PATCH 1/2] gnome-maps: update to 46.0.

---
 srcpkgs/gnome-maps/template | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/gnome-maps/template b/srcpkgs/gnome-maps/template
index 90fcc9e2011846..60f64551ed4409 100644
--- a/srcpkgs/gnome-maps/template
+++ b/srcpkgs/gnome-maps/template
@@ -1,18 +1,20 @@
 # Template file for 'gnome-maps'
 pkgname=gnome-maps
-version=45.5
+version=46.0
 revision=1
 build_style=meson
 build_helper="gir"
 hostmakedepends="glib-devel gettext pkg-config AppStream gjs desktop-file-utils
  gtk-update-icon-cache"
 makedepends="geoclue2-devel gjs-devel geocode-glib-devel libgweather-devel
- gnome-desktop-devel libshumate-devel rest-devel libadwaita-devel libportal-devel"
+ gnome-desktop-devel libshumate-devel rest-devel libadwaita-devel libportal-devel
+ librsvg-devel"
 depends="geoclue2 gjs libadwaita libgweather rest"
 short_desc="GNOME maps application"
 maintainer="Enno Boland <gottox@voidlinux.org>"
 license="GPL-2.0-or-later"
 homepage="https://wiki.gnome.org/Apps/Maps"
-changelog="https://gitlab.gnome.org/GNOME/gnome-maps/-/raw/gnome-45/NEWS"
+#changelog="https://gitlab.gnome.org/GNOME/gnome-maps/-/raw/main/NEWS"
+changelog="https://gitlab.gnome.org/GNOME/gnome-maps/-/raw/gnome-46/NEWS"
 distfiles="${GNOME_SITE}/gnome-maps/${version%.*}/gnome-maps-${version}.tar.xz"
-checksum=1c20f5e10dce684adefb2961526266a224e6c46c16fa03b954affa0b3a1bb740
+checksum=e70979b56075b9a3051f375ea7080ea481e7bd5229e6d8228f8de961cae2a9ae

From 7f5802a4c306a2881dc53c6e49c8fedaa5b0a308 Mon Sep 17 00:00:00 2001
From: fanyx <fanyx@posteo.net>
Date: Wed, 27 Mar 2024 14:16:48 +0100
Subject: [PATCH 2/2] libshumate: update to 1.2.0.

---
 srcpkgs/libshumate/template | 15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)

diff --git a/srcpkgs/libshumate/template b/srcpkgs/libshumate/template
index 1b515ba782dce5..e988e4d9234a6b 100644
--- a/srcpkgs/libshumate/template
+++ b/srcpkgs/libshumate/template
@@ -1,21 +1,24 @@
 # Template file for 'libshumate'
 pkgname=libshumate
-version=1.1.3
+version=1.2.0
 revision=1
 build_style=meson
 build_helper="gir"
-configure_args="$(vopt_bool gir vapi) $(vopt_bool gir gir) $(vopt_bool gir gtk_doc)"
-hostmakedepends="pkg-config $(vopt_if gir 'gi-docgen vala') glib-devel gettext"
-makedepends="libglib-devel sqlite-devel cairo-devel gtk4-devel libsoup3-devel"
+configure_args="$(vopt_bool gir vapi) $(vopt_bool gir gir)
+ $(vopt_bool gir gtk_doc) --buildtype debugoptimized"
+hostmakedepends="pkg-config $(vopt_if gir 'gi-docgen vala') glib-devel gettext
+ gperf"
+makedepends="libglib-devel sqlite-devel cairo-devel gtk4-devel libsoup3-devel
+ protobuf-c-devel"
 checkdepends="dbus xvfb-run"
 short_desc="C library providing a GtkWidget to display maps"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="LGPL-2.1-or-later"
 homepage="https://wiki.gnome.org/Projects/libshumate"
 #changelog="https://gitlab.gnome.org/GNOME/libshumate/-/raw/main/NEWS"
-changelog="https://gitlab.gnome.org/GNOME/libshumate/-/raw/libshumate-1-1/NEWS"
+changelog="https://gitlab.gnome.org/GNOME/libshumate/-/raw/libshumate-1-2/NEWS"
 distfiles="${GNOME_SITE}/libshumate/${version%.*}/libshumate-${version}.tar.xz"
-checksum=6b8a159ed744fdd15992411662a05cb4187fb55e185111a366e0038d2f0b3543
+checksum=4f8413a707cd00f84cee39ca49f58c48fc436f008ea80d6532ac37dafd0ba96b
 make_check_pre="dbus-run-session xvfb-run"
 
 build_options="gir"

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PR PATCH] [Updated] gnome-maps: update to 1.2.0.
  2024-03-27 13:19 [PR PATCH] gnome-maps: update to 1.2.0 fanyx
                   ` (4 preceding siblings ...)
  2024-03-27 15:23 ` [PR PATCH] [Updated] " fanyx
@ 2024-03-27 15:30 ` fanyx
  2024-03-28  0:53 ` [PR REVIEW] " oreo639
                   ` (7 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: fanyx @ 2024-03-27 15:30 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 573 bytes --]

There is an updated pull request by fanyx against master on the void-packages repository

https://github.com/fanyx/void-packages gnome-maps
https://github.com/void-linux/void-packages/pull/49564

gnome-maps: update to 1.2.0.
#### Testing the changes
- I tested the changes in this PR: **NO**

#### Local build testing
- [ ] I built this PR locally for my native architecture, (x86_64-glibc)
- I built this PR locally for these architectures (if supported. mark crossbuilds):


A patch file from https://github.com/void-linux/void-packages/pull/49564.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gnome-maps-49564.patch --]
[-- Type: text/x-diff, Size: 3622 bytes --]

From 130498276b492720c33666a8283e3ed8bab87fbd Mon Sep 17 00:00:00 2001
From: fanyx <fanyx@posteo.net>
Date: Wed, 27 Mar 2024 14:16:31 +0100
Subject: [PATCH 1/2] gnome-maps: update to 46.0.

---
 srcpkgs/gnome-maps/template | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/gnome-maps/template b/srcpkgs/gnome-maps/template
index 90fcc9e2011846..cef881cc4545cf 100644
--- a/srcpkgs/gnome-maps/template
+++ b/srcpkgs/gnome-maps/template
@@ -1,18 +1,21 @@
 # Template file for 'gnome-maps'
 pkgname=gnome-maps
-version=45.5
+version=46.0
 revision=1
 build_style=meson
 build_helper="gir"
 hostmakedepends="glib-devel gettext pkg-config AppStream gjs desktop-file-utils
  gtk-update-icon-cache"
 makedepends="geoclue2-devel gjs-devel geocode-glib-devel libgweather-devel
- gnome-desktop-devel libshumate-devel rest-devel libadwaita-devel libportal-devel"
+ gnome-desktop-devel libshumate-devel rest-devel libadwaita-devel libportal-devel
+ librsvg-devel"
 depends="geoclue2 gjs libadwaita libgweather rest"
+checkdepends="libsecret-devel"
 short_desc="GNOME maps application"
 maintainer="Enno Boland <gottox@voidlinux.org>"
 license="GPL-2.0-or-later"
 homepage="https://wiki.gnome.org/Apps/Maps"
-changelog="https://gitlab.gnome.org/GNOME/gnome-maps/-/raw/gnome-45/NEWS"
+#changelog="https://gitlab.gnome.org/GNOME/gnome-maps/-/raw/main/NEWS"
+changelog="https://gitlab.gnome.org/GNOME/gnome-maps/-/raw/gnome-46/NEWS"
 distfiles="${GNOME_SITE}/gnome-maps/${version%.*}/gnome-maps-${version}.tar.xz"
-checksum=1c20f5e10dce684adefb2961526266a224e6c46c16fa03b954affa0b3a1bb740
+checksum=e70979b56075b9a3051f375ea7080ea481e7bd5229e6d8228f8de961cae2a9ae

From a4cb06981d70c61d5ddeb471f14d9db99fe1dc92 Mon Sep 17 00:00:00 2001
From: fanyx <fanyx@posteo.net>
Date: Wed, 27 Mar 2024 14:16:48 +0100
Subject: [PATCH 2/2] libshumate: update to 1.2.0.

---
 srcpkgs/libshumate/template | 15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)

diff --git a/srcpkgs/libshumate/template b/srcpkgs/libshumate/template
index 1b515ba782dce5..e988e4d9234a6b 100644
--- a/srcpkgs/libshumate/template
+++ b/srcpkgs/libshumate/template
@@ -1,21 +1,24 @@
 # Template file for 'libshumate'
 pkgname=libshumate
-version=1.1.3
+version=1.2.0
 revision=1
 build_style=meson
 build_helper="gir"
-configure_args="$(vopt_bool gir vapi) $(vopt_bool gir gir) $(vopt_bool gir gtk_doc)"
-hostmakedepends="pkg-config $(vopt_if gir 'gi-docgen vala') glib-devel gettext"
-makedepends="libglib-devel sqlite-devel cairo-devel gtk4-devel libsoup3-devel"
+configure_args="$(vopt_bool gir vapi) $(vopt_bool gir gir)
+ $(vopt_bool gir gtk_doc) --buildtype debugoptimized"
+hostmakedepends="pkg-config $(vopt_if gir 'gi-docgen vala') glib-devel gettext
+ gperf"
+makedepends="libglib-devel sqlite-devel cairo-devel gtk4-devel libsoup3-devel
+ protobuf-c-devel"
 checkdepends="dbus xvfb-run"
 short_desc="C library providing a GtkWidget to display maps"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="LGPL-2.1-or-later"
 homepage="https://wiki.gnome.org/Projects/libshumate"
 #changelog="https://gitlab.gnome.org/GNOME/libshumate/-/raw/main/NEWS"
-changelog="https://gitlab.gnome.org/GNOME/libshumate/-/raw/libshumate-1-1/NEWS"
+changelog="https://gitlab.gnome.org/GNOME/libshumate/-/raw/libshumate-1-2/NEWS"
 distfiles="${GNOME_SITE}/libshumate/${version%.*}/libshumate-${version}.tar.xz"
-checksum=6b8a159ed744fdd15992411662a05cb4187fb55e185111a366e0038d2f0b3543
+checksum=4f8413a707cd00f84cee39ca49f58c48fc436f008ea80d6532ac37dafd0ba96b
 make_check_pre="dbus-run-session xvfb-run"
 
 build_options="gir"

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PR REVIEW] gnome-maps: update to 1.2.0.
  2024-03-27 13:19 [PR PATCH] gnome-maps: update to 1.2.0 fanyx
                   ` (5 preceding siblings ...)
  2024-03-27 15:30 ` fanyx
@ 2024-03-28  0:53 ` oreo639
  2024-03-28  0:59 ` oreo639
                   ` (6 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: oreo639 @ 2024-03-28  0:53 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 318 bytes --]

New review comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/49564#discussion_r1542189806

Comment:
Don't use `--buildtype debugoptimized` we use `--buildtype plain` because we don't want extra junk to pollute the cflags.

Just use vsed to remove `-DG_DISABLE_ASSERT`.

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PR REVIEW] gnome-maps: update to 1.2.0.
  2024-03-27 13:19 [PR PATCH] gnome-maps: update to 1.2.0 fanyx
                   ` (6 preceding siblings ...)
  2024-03-28  0:53 ` [PR REVIEW] " oreo639
@ 2024-03-28  0:59 ` oreo639
  2024-03-28  1:01 ` oreo639
                   ` (5 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: oreo639 @ 2024-03-28  0:59 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 434 bytes --]

New review comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/49564#discussion_r1542189806

Comment:
Don't use `--buildtype debugoptimized` we use `--buildtype plain` because we don't want extra junk to pollute the cflags.

Just use vsed to remove `-DG_DISABLE_ASSERT`.

The real issue though is that they are also building the tests with `G_DISABLE_ASSERT` and not just the library.

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PR REVIEW] gnome-maps: update to 1.2.0.
  2024-03-27 13:19 [PR PATCH] gnome-maps: update to 1.2.0 fanyx
                   ` (7 preceding siblings ...)
  2024-03-28  0:59 ` oreo639
@ 2024-03-28  1:01 ` oreo639
  2024-03-28  4:48 ` oreo639
                   ` (4 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: oreo639 @ 2024-03-28  1:01 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 457 bytes --]

New review comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/49564#discussion_r1542189806

Comment:
Don't use `--buildtype debugoptimized` we use `--buildtype plain` because we don't want extra junk to pollute the cflags.

Just use vsed to remove `-DG_DISABLE_ASSERT`.

The real issue though is that they are also building the tests with `G_DISABLE_ASSERT` when that should only be applied to the library.

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PR REVIEW] gnome-maps: update to 1.2.0.
  2024-03-27 13:19 [PR PATCH] gnome-maps: update to 1.2.0 fanyx
                   ` (8 preceding siblings ...)
  2024-03-28  1:01 ` oreo639
@ 2024-03-28  4:48 ` oreo639
  2024-03-28  9:23 ` [PR REVIEW] gnome-maps: update to 46.0 chrysos349
                   ` (3 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: oreo639 @ 2024-03-28  4:48 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 467 bytes --]

New review comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/49564#discussion_r1542189806

Comment:
Don't use `--buildtype debugoptimized` we use `--buildtype plain` because we don't want extra automatic junk to pollute the cflags.

Just use vsed to remove `-DG_DISABLE_ASSERT`.

The real issue though is that they are also building the tests with `G_DISABLE_ASSERT` when that should only be applied to the library.

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PR REVIEW] gnome-maps: update to 46.0.
  2024-03-27 13:19 [PR PATCH] gnome-maps: update to 1.2.0 fanyx
                   ` (9 preceding siblings ...)
  2024-03-28  4:48 ` oreo639
@ 2024-03-28  9:23 ` chrysos349
  2024-03-28  9:55 ` [PR PATCH] [Updated] " fanyx
                   ` (2 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: chrysos349 @ 2024-03-28  9:23 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 331 bytes --]

New review comment by chrysos349 on void-packages repository

https://github.com/void-linux/void-packages/pull/49564#discussion_r1542576114

Comment:
thanks for a better fix.

add to the template

```sh
post_patch() {
	vsed -i shumate/meson.build -e '/DG_DISABLE_ASSERT/d'
}
```

 and remove `--buildtype debugoptimized`

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PR PATCH] [Updated] gnome-maps: update to 46.0.
  2024-03-27 13:19 [PR PATCH] gnome-maps: update to 1.2.0 fanyx
                   ` (10 preceding siblings ...)
  2024-03-28  9:23 ` [PR REVIEW] gnome-maps: update to 46.0 chrysos349
@ 2024-03-28  9:55 ` fanyx
  2024-03-28 10:02 ` [PR REVIEW] " fanyx
  2024-04-14  7:54 ` [PR PATCH] [Merged]: " oreo639
  13 siblings, 0 replies; 15+ messages in thread
From: fanyx @ 2024-03-28  9:55 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 572 bytes --]

There is an updated pull request by fanyx against master on the void-packages repository

https://github.com/fanyx/void-packages gnome-maps
https://github.com/void-linux/void-packages/pull/49564

gnome-maps: update to 46.0.
#### Testing the changes
- I tested the changes in this PR: **NO**

#### Local build testing
- [x] I built this PR locally for my native architecture, (x86_64-glibc)
- I built this PR locally for these architectures (if supported. mark crossbuilds):


A patch file from https://github.com/void-linux/void-packages/pull/49564.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gnome-maps-49564.patch --]
[-- Type: text/x-diff, Size: 3799 bytes --]

From 1dfe1f8a0f752b948267b6c7f5c85358f4b6e730 Mon Sep 17 00:00:00 2001
From: fanyx <fanyx@posteo.net>
Date: Wed, 27 Mar 2024 14:16:31 +0100
Subject: [PATCH 1/2] gnome-maps: update to 46.0.

---
 srcpkgs/gnome-maps/template | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/gnome-maps/template b/srcpkgs/gnome-maps/template
index 90fcc9e2011846..cef881cc4545cf 100644
--- a/srcpkgs/gnome-maps/template
+++ b/srcpkgs/gnome-maps/template
@@ -1,18 +1,21 @@
 # Template file for 'gnome-maps'
 pkgname=gnome-maps
-version=45.5
+version=46.0
 revision=1
 build_style=meson
 build_helper="gir"
 hostmakedepends="glib-devel gettext pkg-config AppStream gjs desktop-file-utils
  gtk-update-icon-cache"
 makedepends="geoclue2-devel gjs-devel geocode-glib-devel libgweather-devel
- gnome-desktop-devel libshumate-devel rest-devel libadwaita-devel libportal-devel"
+ gnome-desktop-devel libshumate-devel rest-devel libadwaita-devel libportal-devel
+ librsvg-devel"
 depends="geoclue2 gjs libadwaita libgweather rest"
+checkdepends="libsecret-devel"
 short_desc="GNOME maps application"
 maintainer="Enno Boland <gottox@voidlinux.org>"
 license="GPL-2.0-or-later"
 homepage="https://wiki.gnome.org/Apps/Maps"
-changelog="https://gitlab.gnome.org/GNOME/gnome-maps/-/raw/gnome-45/NEWS"
+#changelog="https://gitlab.gnome.org/GNOME/gnome-maps/-/raw/main/NEWS"
+changelog="https://gitlab.gnome.org/GNOME/gnome-maps/-/raw/gnome-46/NEWS"
 distfiles="${GNOME_SITE}/gnome-maps/${version%.*}/gnome-maps-${version}.tar.xz"
-checksum=1c20f5e10dce684adefb2961526266a224e6c46c16fa03b954affa0b3a1bb740
+checksum=e70979b56075b9a3051f375ea7080ea481e7bd5229e6d8228f8de961cae2a9ae

From 238ff0dab6b3252da7b66cb4ac7f98cac3e6bb90 Mon Sep 17 00:00:00 2001
From: fanyx <fanyx@posteo.net>
Date: Wed, 27 Mar 2024 14:16:48 +0100
Subject: [PATCH 2/2] libshumate: update to 1.2.0.

---
 srcpkgs/libshumate/template | 19 +++++++++++++------
 1 file changed, 13 insertions(+), 6 deletions(-)

diff --git a/srcpkgs/libshumate/template b/srcpkgs/libshumate/template
index 1b515ba782dce5..4cd5f31eac0fee 100644
--- a/srcpkgs/libshumate/template
+++ b/srcpkgs/libshumate/template
@@ -1,26 +1,33 @@
 # Template file for 'libshumate'
 pkgname=libshumate
-version=1.1.3
+version=1.2.0
 revision=1
 build_style=meson
 build_helper="gir"
-configure_args="$(vopt_bool gir vapi) $(vopt_bool gir gir) $(vopt_bool gir gtk_doc)"
-hostmakedepends="pkg-config $(vopt_if gir 'gi-docgen vala') glib-devel gettext"
-makedepends="libglib-devel sqlite-devel cairo-devel gtk4-devel libsoup3-devel"
+configure_args="$(vopt_bool gir vapi) $(vopt_bool gir gir)
+ $(vopt_bool gir gtk_doc)"
+hostmakedepends="pkg-config $(vopt_if gir 'gi-docgen vala') glib-devel gettext
+ gperf"
+makedepends="libglib-devel sqlite-devel cairo-devel gtk4-devel libsoup3-devel
+ protobuf-c-devel"
 checkdepends="dbus xvfb-run"
 short_desc="C library providing a GtkWidget to display maps"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="LGPL-2.1-or-later"
 homepage="https://wiki.gnome.org/Projects/libshumate"
 #changelog="https://gitlab.gnome.org/GNOME/libshumate/-/raw/main/NEWS"
-changelog="https://gitlab.gnome.org/GNOME/libshumate/-/raw/libshumate-1-1/NEWS"
+changelog="https://gitlab.gnome.org/GNOME/libshumate/-/raw/libshumate-1-2/NEWS"
 distfiles="${GNOME_SITE}/libshumate/${version%.*}/libshumate-${version}.tar.xz"
-checksum=6b8a159ed744fdd15992411662a05cb4187fb55e185111a366e0038d2f0b3543
+checksum=4f8413a707cd00f84cee39ca49f58c48fc436f008ea80d6532ac37dafd0ba96b
 make_check_pre="dbus-run-session xvfb-run"
 
 build_options="gir"
 build_options_default="gir"
 
+post_patch() {
+	vsed -i shumate/meson.build -e '/-DG_DISABLE_ASSERT/d'
+}
+
 pre_build() {
 	# help gi-docgen find gi files on cross
 	if [ -n "$CROSS_BUILD" ]; then

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PR REVIEW] gnome-maps: update to 46.0.
  2024-03-27 13:19 [PR PATCH] gnome-maps: update to 1.2.0 fanyx
                   ` (11 preceding siblings ...)
  2024-03-28  9:55 ` [PR PATCH] [Updated] " fanyx
@ 2024-03-28 10:02 ` fanyx
  2024-04-14  7:54 ` [PR PATCH] [Merged]: " oreo639
  13 siblings, 0 replies; 15+ messages in thread
From: fanyx @ 2024-03-28 10:02 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 240 bytes --]

New review comment by fanyx on void-packages repository

https://github.com/void-linux/void-packages/pull/49564#discussion_r1542633422

Comment:
honestly, i should've found that option myself
looked in the wrong subdir meson.build (tests)

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PR PATCH] [Merged]: gnome-maps: update to 46.0.
  2024-03-27 13:19 [PR PATCH] gnome-maps: update to 1.2.0 fanyx
                   ` (12 preceding siblings ...)
  2024-03-28 10:02 ` [PR REVIEW] " fanyx
@ 2024-04-14  7:54 ` oreo639
  13 siblings, 0 replies; 15+ messages in thread
From: oreo639 @ 2024-04-14  7:54 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 417 bytes --]

There's a merged pull request on the void-packages repository

gnome-maps: update to 46.0.
https://github.com/void-linux/void-packages/pull/49564

Description:
#### Testing the changes
- I tested the changes in this PR: **NO**

#### Local build testing
- [x] I built this PR locally for my native architecture, (x86_64-glibc)
- I built this PR locally for these architectures (if supported. mark crossbuilds):


^ permalink raw reply	[flat|nested] 15+ messages in thread

end of thread, other threads:[~2024-04-14  7:54 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-27 13:19 [PR PATCH] gnome-maps: update to 1.2.0 fanyx
2024-03-27 13:29 ` fanyx
2024-03-27 14:48 ` [PR REVIEW] " chrysos349
2024-03-27 14:48 ` chrysos349
2024-03-27 14:54 ` fanyx
2024-03-27 15:23 ` [PR PATCH] [Updated] " fanyx
2024-03-27 15:30 ` fanyx
2024-03-28  0:53 ` [PR REVIEW] " oreo639
2024-03-28  0:59 ` oreo639
2024-03-28  1:01 ` oreo639
2024-03-28  4:48 ` oreo639
2024-03-28  9:23 ` [PR REVIEW] gnome-maps: update to 46.0 chrysos349
2024-03-28  9:55 ` [PR PATCH] [Updated] " fanyx
2024-03-28 10:02 ` [PR REVIEW] " fanyx
2024-04-14  7:54 ` [PR PATCH] [Merged]: " oreo639

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).