* Re: python3-feedparser: update to 6.0.11, adopt.
2024-04-01 9:31 [PR PATCH] python3-feedparser: update to 6.0.11, adopt adigitoleo
@ 2024-04-01 12:12 ` adigitoleo
2024-04-01 13:31 ` [PR REVIEW] " ahesford
` (5 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: adigitoleo @ 2024-04-01 12:12 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 267 bytes --]
New comment by adigitoleo on void-packages repository
https://github.com/void-linux/void-packages/pull/49647#issuecomment-2029665042
Comment:
The pluggy dependency shouldn't be required. It is a transient dep for tox, which currently doesn't declare it. See #49512
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PR REVIEW] python3-feedparser: update to 6.0.11, adopt.
2024-04-01 9:31 [PR PATCH] python3-feedparser: update to 6.0.11, adopt adigitoleo
2024-04-01 12:12 ` adigitoleo
@ 2024-04-01 13:31 ` ahesford
2024-04-01 13:31 ` ahesford
` (4 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: ahesford @ 2024-04-01 13:31 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 270 bytes --]
New review comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/49647#discussion_r1546327574
Comment:
We like to see a longer history of contributions before people adopt packages. Please leave the package orphaned for now.
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PR REVIEW] python3-feedparser: update to 6.0.11, adopt.
2024-04-01 9:31 [PR PATCH] python3-feedparser: update to 6.0.11, adopt adigitoleo
2024-04-01 12:12 ` adigitoleo
2024-04-01 13:31 ` [PR REVIEW] " ahesford
@ 2024-04-01 13:31 ` ahesford
2024-04-01 13:31 ` ahesford
` (3 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: ahesford @ 2024-04-01 13:31 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 277 bytes --]
New review comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/49647#discussion_r1546333082
Comment:
Please update project homepage to reflect the site linked on the upstream source repository:
https://feedparser.readthedocs.io/
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PR REVIEW] python3-feedparser: update to 6.0.11, adopt.
2024-04-01 9:31 [PR PATCH] python3-feedparser: update to 6.0.11, adopt adigitoleo
` (2 preceding siblings ...)
2024-04-01 13:31 ` ahesford
@ 2024-04-01 13:31 ` ahesford
2024-04-01 13:31 ` ahesford
` (2 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: ahesford @ 2024-04-01 13:31 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 207 bytes --]
New review comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/49647#discussion_r1546333851
Comment:
Use upstream project description: "Parse feeds in Python".
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PR REVIEW] python3-feedparser: update to 6.0.11, adopt.
2024-04-01 9:31 [PR PATCH] python3-feedparser: update to 6.0.11, adopt adigitoleo
` (3 preceding siblings ...)
2024-04-01 13:31 ` ahesford
@ 2024-04-01 13:31 ` ahesford
2024-04-01 13:31 ` ahesford
2024-04-01 13:38 ` [PR PATCH] [Updated] " adigitoleo
6 siblings, 0 replies; 8+ messages in thread
From: ahesford @ 2024-04-01 13:31 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 183 bytes --]
New review comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/49647#discussion_r1546335255
Comment:
Unnecessary once `tox` is dropped.
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PR REVIEW] python3-feedparser: update to 6.0.11, adopt.
2024-04-01 9:31 [PR PATCH] python3-feedparser: update to 6.0.11, adopt adigitoleo
` (4 preceding siblings ...)
2024-04-01 13:31 ` ahesford
@ 2024-04-01 13:31 ` ahesford
2024-04-01 13:38 ` [PR PATCH] [Updated] " adigitoleo
6 siblings, 0 replies; 8+ messages in thread
From: ahesford @ 2024-04-01 13:31 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 457 bytes --]
New review comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/49647#discussion_r1546334971
Comment:
`tox` is not suitable for running checks with `xbps-src`, as it fetches wheels in virtual environments and isn't actually testing what we build. If this package should be tested, you should pull in `python3-pytest` here and fetch from the project's GitHub repository; the PyPI distribution contains no tests.
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PR PATCH] [Updated] python3-feedparser: update to 6.0.11, adopt.
2024-04-01 9:31 [PR PATCH] python3-feedparser: update to 6.0.11, adopt adigitoleo
` (5 preceding siblings ...)
2024-04-01 13:31 ` ahesford
@ 2024-04-01 13:38 ` adigitoleo
6 siblings, 0 replies; 8+ messages in thread
From: adigitoleo @ 2024-04-01 13:38 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 617 bytes --]
There is an updated pull request by adigitoleo against master on the void-packages repository
https://github.com/adigitoleo/void-packages python3-feedparser
https://github.com/void-linux/void-packages/pull/49647
python3-feedparser: update to 6.0.11, adopt.
#### Testing the changes
- I tested the changes in this PR: **briefly**
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
- I built this PR locally for these architectures (crossbuilds):
- aarch64-musl
- armv7l
A patch file from https://github.com/void-linux/void-packages/pull/49647.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-python3-feedparser-49647.patch --]
[-- Type: text/x-diff, Size: 1345 bytes --]
From 2dc0b8e28a623e5ef2f13ae77a3d52360b29fc1a Mon Sep 17 00:00:00 2001
From: adigitoleo <adigitoleo@posteo.net>
Date: Mon, 1 Apr 2024 20:26:31 +1100
Subject: [PATCH] python3-feedparser: update to 6.0.11.
---
srcpkgs/python3-feedparser/template | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/srcpkgs/python3-feedparser/template b/srcpkgs/python3-feedparser/template
index 34a0df9750a519..6295f90a0ab40a 100644
--- a/srcpkgs/python3-feedparser/template
+++ b/srcpkgs/python3-feedparser/template
@@ -1,17 +1,17 @@
# Template file for 'python3-feedparser'
pkgname=python3-feedparser
-version=6.0.8
-revision=4
+version=6.0.11
+revision=1
build_style=python3-module
hostmakedepends="python3-setuptools"
-depends="python3-sgmllib"
+depends="python3-sgmllib python3-requests"
checkdepends="${depends}"
-short_desc="Parse Atom and RSS feeds in Python3"
+short_desc="Parse feeds in Python"
maintainer="Orphaned <orphan@voidlinux.org>"
license="BSD-2-Clause"
-homepage="https://pypi.org/project/feedparser/"
+homepage="https://feedparser.readthedocs.io/"
distfiles="${PYPI_SITE}/f/feedparser/feedparser-${version}.tar.gz"
-checksum=5ce0410a05ab248c8c7cfca3a0ea2203968ee9ff4486067379af4827a59f9661
+checksum=c9d0407b64c6f2a065d0ebb292c2b35c01050cc0dc33757461aaabdc4c4184d5
post_install() {
vlicense LICENSE
^ permalink raw reply [flat|nested] 8+ messages in thread