Re: [PR PATCH] [Updated] Fix solaar udev rules

[im-apbecker <im-apbecker@users.noreply.github.com>]

[-- Attachment #1: Type: text/plain, Size: 1206 bytes --]

There is an updated pull request by im-apbecker against master on the void-packages repository

https://github.com/im-apbecker/void-packages solaar-udev-rules
https://github.com/void-linux/void-packages/pull/49674

Fix solaar udev rules
This PR adds back in a missing udev rules file that is required for solaar to function.

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)


A patch file from https://github.com/void-linux/void-packages/pull/49674.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-solaar-udev-rules-49674.patch --]
[-- Type: text/x-diff, Size: 2057 bytes --]

From 013f0e20576bacc5c2222f20fb5e514c89f1b192 Mon Sep 17 00:00:00 2001
From: apbecker <apbecker@protonmail.com>
Date: Tue, 2 Apr 2024 12:13:17 -0600
Subject: [PATCH 1/2] Fix solaar udev rules

---
 srcpkgs/Solaar/template | 1 +
 1 file changed, 1 insertion(+)

diff --git a/srcpkgs/Solaar/template b/srcpkgs/Solaar/template
index 922c658f3abe86..01bb9154bd176e 100644
--- a/srcpkgs/Solaar/template
+++ b/srcpkgs/Solaar/template
@@ -17,4 +17,5 @@ checksum=2b292da8923e19a4a7a459d6fcd1119ce157cb579fd00077f87633c0dedfbba5
 
 post_install() {
 	vdoc "${FILESDIR}/README.voidlinux"
+	vinstall "rules.d/42-logitech-unify-permissions.rules" 644 /usr/share/solaar/udev-rules.d
 }

From cbab68e59e9328d5f88970c275a75ae6dfbe5595 Mon Sep 17 00:00:00 2001
From: apbecker <apbecker@protonmail.com>
Date: Tue, 2 Apr 2024 15:31:06 -0600
Subject: [PATCH 2/2] Update solaar's README.voidlinux

---
 srcpkgs/Solaar/files/README.voidlinux | 5 +++--
 srcpkgs/Solaar/template               | 1 -
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/Solaar/files/README.voidlinux b/srcpkgs/Solaar/files/README.voidlinux
index 7596828f668ad4..87ac51ef863e74 100644
--- a/srcpkgs/Solaar/files/README.voidlinux
+++ b/srcpkgs/Solaar/files/README.voidlinux
@@ -1,3 +1,4 @@
-To use Solaar without root privileges, copy the file
-    /usr/share/solaar/udev-rules.d/42-logitech-unify-permissions.rules
+To use Solaar without root privileges, nothing special should be required.
+If issues are encountered, try copying the file at
+    /usr/lib/udev/rules.d/42-logitech-unify-permissions.rules
 into the directory /etc/udev/rules.d/ and reload udev rules.
diff --git a/srcpkgs/Solaar/template b/srcpkgs/Solaar/template
index 01bb9154bd176e..922c658f3abe86 100644
--- a/srcpkgs/Solaar/template
+++ b/srcpkgs/Solaar/template
@@ -17,5 +17,4 @@ checksum=2b292da8923e19a4a7a459d6fcd1119ce157cb579fd00077f87633c0dedfbba5
 
 post_install() {
 	vdoc "${FILESDIR}/README.voidlinux"
-	vinstall "rules.d/42-logitech-unify-permissions.rules" 644 /usr/share/solaar/udev-rules.d
 }