From: classabbyamp <classabbyamp@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] Fix solaar udev rules
Date: Tue, 02 Apr 2024 23:37:50 +0200 [thread overview]
Message-ID: <20240402213750.754B623F69@inbox.vuxu.org> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-49674@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 538 bytes --]
New review comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/49674#discussion_r1548639429
Comment:
actually, seeing what the readme says now, I would remove that, and add an [INSTALL.msg](https://github.com/void-linux/void-packages/blob/master/Manual.md#install_remove_files_msg) that says something like:
> Previous versions of solaar required copying or symlinking udev rules to /etc/udev/rules.d.
> If this was done previously, it is recommended to remove that file or symlink.
next prev parent reply other threads:[~2024-04-02 21:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-02 18:31 [PR PATCH] " im-apbecker
2024-04-02 21:13 ` [PR REVIEW] " classabbyamp
2024-04-02 21:16 ` im-apbecker
2024-04-02 21:17 ` im-apbecker
2024-04-02 21:24 ` im-apbecker
2024-04-02 21:26 ` classabbyamp
2024-04-02 21:31 ` [PR PATCH] [Updated] " im-apbecker
2024-04-02 21:37 ` classabbyamp [this message]
2024-04-02 22:22 ` im-apbecker
2024-04-02 22:22 ` [PR REVIEW] " im-apbecker
2024-04-06 2:46 ` [PR PATCH] [Closed]: " classabbyamp
2024-04-06 10:01 ` icp1994
2024-04-06 10:15 ` classabbyamp
2024-04-06 13:35 ` icp1994
2024-04-06 18:56 ` classabbyamp
2024-04-06 20:26 ` classabbyamp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240402213750.754B623F69@inbox.vuxu.org \
--to=classabbyamp@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).