* Re: libvncserver: add missing buildepends (fixes broken functionality of vnc apps using encryption)
2024-04-04 6:38 [PR PATCH] libvncserver: add missing buildepends (fixes broken functionality of vnc apps using encryption) Luciogi
@ 2024-04-04 6:39 ` Luciogi
2024-04-04 6:41 ` [PR PATCH] [Updated] " Luciogi
` (5 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Luciogi @ 2024-04-04 6:39 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 209 bytes --]
New comment by Luciogi on void-packages repository
https://github.com/void-linux/void-packages/pull/49699#issuecomment-2036307131
Comment:
fixes https://github.com/void-linux/void-packages/discussions/49698
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PR PATCH] [Updated] libvncserver: add missing buildepends (fixes broken functionality of vnc apps using encryption)
2024-04-04 6:38 [PR PATCH] libvncserver: add missing buildepends (fixes broken functionality of vnc apps using encryption) Luciogi
2024-04-04 6:39 ` Luciogi
@ 2024-04-04 6:41 ` Luciogi
2024-04-04 6:55 ` [PR REVIEW] " sgn
` (4 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Luciogi @ 2024-04-04 6:41 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 556 bytes --]
There is an updated pull request by Luciogi against master on the void-packages repository
https://github.com/Luciogi/void-packages libvncserver
https://github.com/void-linux/void-packages/pull/49699
libvncserver: add missing buildepends (fixes broken functionality of vnc apps using encryption)
#### Testing the changes
- I tested the changes in this PR: **YES**
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-GLIBC)
A patch file from https://github.com/void-linux/void-packages/pull/49699.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-libvncserver-49699.patch --]
[-- Type: text/x-diff, Size: 1390 bytes --]
From ad1c586967765792595ebb9bcaba23fa7e4fd646 Mon Sep 17 00:00:00 2001
From: Luciogi <lucigithubcommit@skiff.com>
Date: Thu, 4 Apr 2024 11:34:05 +0500
Subject: [PATCH] libvncserver: add missing buildepends
---
srcpkgs/libvncserver/template | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/srcpkgs/libvncserver/template b/srcpkgs/libvncserver/template
index a6b40790b6940f..89e69e515769e2 100644
--- a/srcpkgs/libvncserver/template
+++ b/srcpkgs/libvncserver/template
@@ -1,11 +1,12 @@
# Template file for 'libvncserver'
pkgname=libvncserver
version=0.9.14
-revision=2
+revision=3
build_style=cmake
-confiugre_args="-DWITH_OPENSSL=ON -DWITH_GNUTLS=OFF"
+configure_args="-DWITH_OPENSSL=ON -DWITH_GNUTLS=OFF -DWITH_SYSTEMD=OFF"
hostmakedepends="pkg-config"
-makedepends="zlib-devel libjpeg-turbo-devel libpng-devel openssl-devel"
+makedepends="zlib-devel libjpeg-turbo-devel libpng-devel openssl-devel
+ SDL2-devel lzo-devel libgcrypt-devel"
short_desc="C libraries to easily implement VNC server or client functionality"
maintainer="Orphaned <orphan@voidlinux.org>"
license="GPL-2.0-or-later"
@@ -17,6 +18,7 @@ libvncserver-devel_package() {
depends="${makedepends} ${sourcepkg}-${version}_${revision}"
short_desc+=" - development files"
pkg_install() {
+ vmove usr/lib/cmake
vmove usr/include
vmove "usr/lib/*.so"
vmove usr/lib/pkgconfig
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PR REVIEW] libvncserver: add missing buildepends (fixes broken functionality of vnc apps using encryption)
2024-04-04 6:38 [PR PATCH] libvncserver: add missing buildepends (fixes broken functionality of vnc apps using encryption) Luciogi
2024-04-04 6:39 ` Luciogi
2024-04-04 6:41 ` [PR PATCH] [Updated] " Luciogi
@ 2024-04-04 6:55 ` sgn
2024-04-04 7:08 ` Luciogi
` (3 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: sgn @ 2024-04-04 6:55 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 199 bytes --]
New review comment by sgn on void-packages repository
https://github.com/void-linux/void-packages/pull/49699#discussion_r1551029399
Comment:
Why `SDL2-devel` is needed? it's only for examples, no?
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PR REVIEW] libvncserver: add missing buildepends (fixes broken functionality of vnc apps using encryption)
2024-04-04 6:38 [PR PATCH] libvncserver: add missing buildepends (fixes broken functionality of vnc apps using encryption) Luciogi
` (2 preceding siblings ...)
2024-04-04 6:55 ` [PR REVIEW] " sgn
@ 2024-04-04 7:08 ` Luciogi
2024-04-04 7:11 ` [PR PATCH] [Updated] " Luciogi
` (2 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Luciogi @ 2024-04-04 7:08 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 192 bytes --]
New review comment by Luciogi on void-packages repository
https://github.com/void-linux/void-packages/pull/49699#discussion_r1551047870
Comment:
yes it is for examples, should I remove it ?
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PR PATCH] [Updated] libvncserver: add missing buildepends (fixes broken functionality of vnc apps using encryption)
2024-04-04 6:38 [PR PATCH] libvncserver: add missing buildepends (fixes broken functionality of vnc apps using encryption) Luciogi
` (3 preceding siblings ...)
2024-04-04 7:08 ` Luciogi
@ 2024-04-04 7:11 ` Luciogi
2024-04-04 7:12 ` [PR REVIEW] " Luciogi
2024-04-04 7:48 ` [PR PATCH] [Merged]: " sgn
6 siblings, 0 replies; 8+ messages in thread
From: Luciogi @ 2024-04-04 7:11 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 556 bytes --]
There is an updated pull request by Luciogi against master on the void-packages repository
https://github.com/Luciogi/void-packages libvncserver
https://github.com/void-linux/void-packages/pull/49699
libvncserver: add missing buildepends (fixes broken functionality of vnc apps using encryption)
#### Testing the changes
- I tested the changes in this PR: **YES**
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-GLIBC)
A patch file from https://github.com/void-linux/void-packages/pull/49699.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-libvncserver-49699.patch --]
[-- Type: text/x-diff, Size: 1379 bytes --]
From f18026876078782e9b8f8a6af31bd912d4621003 Mon Sep 17 00:00:00 2001
From: Luciogi <lucigithubcommit@skiff.com>
Date: Thu, 4 Apr 2024 11:34:05 +0500
Subject: [PATCH] libvncserver: add missing buildepends
---
srcpkgs/libvncserver/template | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/srcpkgs/libvncserver/template b/srcpkgs/libvncserver/template
index a6b40790b6940f..1c8d106f24702b 100644
--- a/srcpkgs/libvncserver/template
+++ b/srcpkgs/libvncserver/template
@@ -1,11 +1,12 @@
# Template file for 'libvncserver'
pkgname=libvncserver
version=0.9.14
-revision=2
+revision=3
build_style=cmake
-confiugre_args="-DWITH_OPENSSL=ON -DWITH_GNUTLS=OFF"
+configure_args="-DWITH_OPENSSL=ON -DWITH_GNUTLS=OFF -DWITH_SYSTEMD=OFF"
hostmakedepends="pkg-config"
-makedepends="zlib-devel libjpeg-turbo-devel libpng-devel openssl-devel"
+makedepends="zlib-devel libjpeg-turbo-devel libpng-devel openssl-devel
+ lzo-devel libgcrypt-devel"
short_desc="C libraries to easily implement VNC server or client functionality"
maintainer="Orphaned <orphan@voidlinux.org>"
license="GPL-2.0-or-later"
@@ -17,6 +18,7 @@ libvncserver-devel_package() {
depends="${makedepends} ${sourcepkg}-${version}_${revision}"
short_desc+=" - development files"
pkg_install() {
+ vmove usr/lib/cmake
vmove usr/include
vmove "usr/lib/*.so"
vmove usr/lib/pkgconfig
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PR REVIEW] libvncserver: add missing buildepends (fixes broken functionality of vnc apps using encryption)
2024-04-04 6:38 [PR PATCH] libvncserver: add missing buildepends (fixes broken functionality of vnc apps using encryption) Luciogi
` (4 preceding siblings ...)
2024-04-04 7:11 ` [PR PATCH] [Updated] " Luciogi
@ 2024-04-04 7:12 ` Luciogi
2024-04-04 7:48 ` [PR PATCH] [Merged]: " sgn
6 siblings, 0 replies; 8+ messages in thread
From: Luciogi @ 2024-04-04 7:12 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 155 bytes --]
New review comment by Luciogi on void-packages repository
https://github.com/void-linux/void-packages/pull/49699#discussion_r1551052886
Comment:
removed
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PR PATCH] [Merged]: libvncserver: add missing buildepends (fixes broken functionality of vnc apps using encryption)
2024-04-04 6:38 [PR PATCH] libvncserver: add missing buildepends (fixes broken functionality of vnc apps using encryption) Luciogi
` (5 preceding siblings ...)
2024-04-04 7:12 ` [PR REVIEW] " Luciogi
@ 2024-04-04 7:48 ` sgn
6 siblings, 0 replies; 8+ messages in thread
From: sgn @ 2024-04-04 7:48 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 395 bytes --]
There's a merged pull request on the void-packages repository
libvncserver: add missing buildepends (fixes broken functionality of vnc apps using encryption)
https://github.com/void-linux/void-packages/pull/49699
Description:
#### Testing the changes
- I tested the changes in this PR: **YES**
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-GLIBC)
^ permalink raw reply [flat|nested] 8+ messages in thread