[PR PATCH] Draft: New Package: squeezelite

[PR PATCH] Draft: New Package: squeezelite

[Simerax]

[-- Attachment #1: Type: text/plain, Size: 1313 bytes --]

There is a new pull request by Simerax against master on the void-packages repository

https://github.com/Simerax/void-packages new-pkg-squeezelite
https://github.com/void-linux/void-packages/pull/49654

Draft: New Package: squeezelite
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**


<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - i686
  - i686-musl
  - x86_64-musl
  - armv6l
  - armv6l-musl
  - armv7l
  - armv7l-musl
  - aarch64
  - aarch64-musl



A patch file from https://github.com/void-linux/void-packages/pull/49654.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-new-pkg-squeezelite-49654.patch --]
[-- Type: text/x-diff, Size: 2089 bytes --]

From 2618d298aa9865ea83dc806ee2c2291b5d36db10 Mon Sep 17 00:00:00 2001
From: Xaver Fischer <xaverfischer@mail.de>
Date: Mon, 1 Apr 2024 17:54:11 +0200
Subject: [PATCH 1/2] New Package: squeezelite

---
 srcpkgs/squeezelite/template | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)
 create mode 100644 srcpkgs/squeezelite/template

diff --git a/srcpkgs/squeezelite/template b/srcpkgs/squeezelite/template
new file mode 100644
index 00000000000000..3bf984ead5496a
--- /dev/null
+++ b/srcpkgs/squeezelite/template
@@ -0,0 +1,20 @@
+# Template file for 'squeezelite'
+pkgname=squeezelite
+version=2.0
+revision=1
+archs="i686 x86_64 armv6l armv7l aarch64"
+build_style=gnu-makefile
+hostmakedepends="pkg-config"
+makedepends="alsa-lib-devel libflac-devel faad2-devel mpg123-devel libmad-devel libvorbis-devel"
+depends="alsa-lib libflac faad2 mpg123 libmad libvorbis"
+short_desc="Squeezebox Client for Logitech Media Server"
+maintainer="Xaver Fischer <xaverfischer@mail.de>"
+license="GPL-3.0-or-later"
+homepage="https://github.com/ralph-irving/squeezelite"
+#changelog=""
+distfiles="${homepage}/archive/refs/heads/master.zip"
+checksum=53dd9162e03c3ee0655e39ce7f4ae4d0177a0e202a535ed64a4675e8b777bc1b
+
+do_install() {
+	vbin squeezelite
+}

From f1f62f22524ead802c605bd7ff90b4bd8b124d37 Mon Sep 17 00:00:00 2001
From: Xaver Fischer <xaverfischer@mail.de>
Date: Mon, 1 Apr 2024 18:07:48 +0200
Subject: [PATCH 2/2] added more architectures

---
 srcpkgs/squeezelite/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/squeezelite/template b/srcpkgs/squeezelite/template
index 3bf984ead5496a..f748e43e3acc17 100644
--- a/srcpkgs/squeezelite/template
+++ b/srcpkgs/squeezelite/template
@@ -2,7 +2,7 @@
 pkgname=squeezelite
 version=2.0
 revision=1
-archs="i686 x86_64 armv6l armv7l aarch64"
+archs="i686 i686-musl x86_64 x86_64-musl armv6l armv6l-musl armv7l armv7l-musl aarch64 aarch64-musl"
 build_style=gnu-makefile
 hostmakedepends="pkg-config"
 makedepends="alsa-lib-devel libflac-devel faad2-devel mpg123-devel libmad-devel libvorbis-devel"

Re: Draft: New Package: squeezelite

[Simerax]

[-- Attachment #1: Type: text/plain, Size: 384 bytes --]

New comment by Simerax on void-packages repository

https://github.com/void-linux/void-packages/pull/49654#issuecomment-2030070652

Comment:
TODO: Right now the template uses head in distfiles which is not acceptable

Maintainer does not plan on creating tags/releases

https://github.com/ralph-irving/squeezelite/issues/29
https://github.com/ralph-irving/squeezelite/issues/213

Re: [PR PATCH] [Updated] Draft: New Package: squeezelite

[Simerax]

[-- Attachment #1: Type: text/plain, Size: 1318 bytes --]

There is an updated pull request by Simerax against master on the void-packages repository

https://github.com/Simerax/void-packages new-pkg-squeezelite
https://github.com/void-linux/void-packages/pull/49654

Draft: New Package: squeezelite
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**


<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - i686
  - i686-musl
  - x86_64-musl
  - armv6l
  - armv6l-musl
  - armv7l
  - armv7l-musl
  - aarch64
  - aarch64-musl



A patch file from https://github.com/void-linux/void-packages/pull/49654.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-new-pkg-squeezelite-49654.patch --]
[-- Type: text/x-diff, Size: 3481 bytes --]

From 2618d298aa9865ea83dc806ee2c2291b5d36db10 Mon Sep 17 00:00:00 2001
From: Xaver Fischer <xaverfischer@mail.de>
Date: Mon, 1 Apr 2024 17:54:11 +0200
Subject: [PATCH 1/3] New Package: squeezelite

---
 srcpkgs/squeezelite/template | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)
 create mode 100644 srcpkgs/squeezelite/template

diff --git a/srcpkgs/squeezelite/template b/srcpkgs/squeezelite/template
new file mode 100644
index 00000000000000..3bf984ead5496a
--- /dev/null
+++ b/srcpkgs/squeezelite/template
@@ -0,0 +1,20 @@
+# Template file for 'squeezelite'
+pkgname=squeezelite
+version=2.0
+revision=1
+archs="i686 x86_64 armv6l armv7l aarch64"
+build_style=gnu-makefile
+hostmakedepends="pkg-config"
+makedepends="alsa-lib-devel libflac-devel faad2-devel mpg123-devel libmad-devel libvorbis-devel"
+depends="alsa-lib libflac faad2 mpg123 libmad libvorbis"
+short_desc="Squeezebox Client for Logitech Media Server"
+maintainer="Xaver Fischer <xaverfischer@mail.de>"
+license="GPL-3.0-or-later"
+homepage="https://github.com/ralph-irving/squeezelite"
+#changelog=""
+distfiles="${homepage}/archive/refs/heads/master.zip"
+checksum=53dd9162e03c3ee0655e39ce7f4ae4d0177a0e202a535ed64a4675e8b777bc1b
+
+do_install() {
+	vbin squeezelite
+}

From f1f62f22524ead802c605bd7ff90b4bd8b124d37 Mon Sep 17 00:00:00 2001
From: Xaver Fischer <xaverfischer@mail.de>
Date: Mon, 1 Apr 2024 18:07:48 +0200
Subject: [PATCH 2/3] added more architectures

---
 srcpkgs/squeezelite/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/squeezelite/template b/srcpkgs/squeezelite/template
index 3bf984ead5496a..f748e43e3acc17 100644
--- a/srcpkgs/squeezelite/template
+++ b/srcpkgs/squeezelite/template
@@ -2,7 +2,7 @@
 pkgname=squeezelite
 version=2.0
 revision=1
-archs="i686 x86_64 armv6l armv7l aarch64"
+archs="i686 i686-musl x86_64 x86_64-musl armv6l armv6l-musl armv7l armv7l-musl aarch64 aarch64-musl"
 build_style=gnu-makefile
 hostmakedepends="pkg-config"
 makedepends="alsa-lib-devel libflac-devel faad2-devel mpg123-devel libmad-devel libvorbis-devel"

From d19d29e4bf237dcc236e5a3e682f7c176299d5c8 Mon Sep 17 00:00:00 2001
From: Xaver Fischer <xaverfischer@mail.de>
Date: Mon, 1 Apr 2024 18:39:34 +0200
Subject: [PATCH 3/3] pin version 2.0.0.1477

---
 srcpkgs/squeezelite/template | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/squeezelite/template b/srcpkgs/squeezelite/template
index f748e43e3acc17..4d9d6585605995 100644
--- a/srcpkgs/squeezelite/template
+++ b/srcpkgs/squeezelite/template
@@ -1,6 +1,10 @@
 # Template file for 'squeezelite'
 pkgname=squeezelite
-version=2.0
+
+# current version is specified in squeezelite.h
+# upstream does not create git tags / github releases
+# see: https://github.com/ralph-irving/squeezelite/issues/29
+version=2.0.0.1477
 revision=1
 archs="i686 i686-musl x86_64 x86_64-musl armv6l armv6l-musl armv7l armv7l-musl aarch64 aarch64-musl"
 build_style=gnu-makefile
@@ -12,9 +16,10 @@ maintainer="Xaver Fischer <xaverfischer@mail.de>"
 license="GPL-3.0-or-later"
 homepage="https://github.com/ralph-irving/squeezelite"
 #changelog=""
-distfiles="${homepage}/archive/refs/heads/master.zip"
-checksum=53dd9162e03c3ee0655e39ce7f4ae4d0177a0e202a535ed64a4675e8b777bc1b
+distfiles="${homepage}/archive/3cbbc535f3431880b54c78f5f9489484e4187cf0.zip"
+checksum=cbe70bb0ad653eaef7cfc6aea67eec4e3341efaaa4a060df203d7814f42bf774
 
 do_install() {
 	vbin squeezelite
 }
+

Re: Draft: New Package: squeezelite

[Simerax]

[-- Attachment #1: Type: text/plain, Size: 340 bytes --]

New comment by Simerax on void-packages repository

https://github.com/void-linux/void-packages/pull/49654#issuecomment-2030131800

Comment:
version is now manually managed via git commit hash in distfiles. NixOS seems to be doing it the same way https://github.com/NixOS/nixpkgs/blob/master/pkgs/applications/audio/squeezelite/default.nix

Re: [PR REVIEW] New Package: squeezelite

[Bnyro]

[-- Attachment #1: Type: text/plain, Size: 214 bytes --]

New review comment by Bnyro on void-packages repository

https://github.com/void-linux/void-packages/pull/49654#discussion_r1554721730

Comment:
You can drop that line if all architectures are supported anyways...

Re: [PR REVIEW] New Package: squeezelite

[Bnyro]

[-- Attachment #1: Type: text/plain, Size: 164 bytes --]

New review comment by Bnyro on void-packages repository

https://github.com/void-linux/void-packages/pull/49654#discussion_r1554721738

Comment:
```suggestion
```

Re: [PR REVIEW] New Package: squeezelite

[Bnyro]

[-- Attachment #1: Type: text/plain, Size: 185 bytes --]

New review comment by Bnyro on void-packages repository

https://github.com/void-linux/void-packages/pull/49654#discussion_r1554721806

Comment:
please remove that unnecessary new line

Re: [PR PATCH] [Updated] New Package: squeezelite

[Simerax]

[-- Attachment #1: Type: text/plain, Size: 1311 bytes --]

There is an updated pull request by Simerax against master on the void-packages repository

https://github.com/Simerax/void-packages new-pkg-squeezelite
https://github.com/void-linux/void-packages/pull/49654

New Package: squeezelite
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**


<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - i686
  - i686-musl
  - x86_64-musl
  - armv6l
  - armv6l-musl
  - armv7l
  - armv7l-musl
  - aarch64
  - aarch64-musl



A patch file from https://github.com/void-linux/void-packages/pull/49654.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-new-pkg-squeezelite-49654.patch --]
[-- Type: text/x-diff, Size: 4759 bytes --]

From 2618d298aa9865ea83dc806ee2c2291b5d36db10 Mon Sep 17 00:00:00 2001
From: Xaver Fischer <xaverfischer@mail.de>
Date: Mon, 1 Apr 2024 17:54:11 +0200
Subject: [PATCH 1/4] New Package: squeezelite

---
 srcpkgs/squeezelite/template | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)
 create mode 100644 srcpkgs/squeezelite/template

diff --git a/srcpkgs/squeezelite/template b/srcpkgs/squeezelite/template
new file mode 100644
index 00000000000000..3bf984ead5496a
--- /dev/null
+++ b/srcpkgs/squeezelite/template
@@ -0,0 +1,20 @@
+# Template file for 'squeezelite'
+pkgname=squeezelite
+version=2.0
+revision=1
+archs="i686 x86_64 armv6l armv7l aarch64"
+build_style=gnu-makefile
+hostmakedepends="pkg-config"
+makedepends="alsa-lib-devel libflac-devel faad2-devel mpg123-devel libmad-devel libvorbis-devel"
+depends="alsa-lib libflac faad2 mpg123 libmad libvorbis"
+short_desc="Squeezebox Client for Logitech Media Server"
+maintainer="Xaver Fischer <xaverfischer@mail.de>"
+license="GPL-3.0-or-later"
+homepage="https://github.com/ralph-irving/squeezelite"
+#changelog=""
+distfiles="${homepage}/archive/refs/heads/master.zip"
+checksum=53dd9162e03c3ee0655e39ce7f4ae4d0177a0e202a535ed64a4675e8b777bc1b
+
+do_install() {
+	vbin squeezelite
+}

From f1f62f22524ead802c605bd7ff90b4bd8b124d37 Mon Sep 17 00:00:00 2001
From: Xaver Fischer <xaverfischer@mail.de>
Date: Mon, 1 Apr 2024 18:07:48 +0200
Subject: [PATCH 2/4] added more architectures

---
 srcpkgs/squeezelite/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/squeezelite/template b/srcpkgs/squeezelite/template
index 3bf984ead5496a..f748e43e3acc17 100644
--- a/srcpkgs/squeezelite/template
+++ b/srcpkgs/squeezelite/template
@@ -2,7 +2,7 @@
 pkgname=squeezelite
 version=2.0
 revision=1
-archs="i686 x86_64 armv6l armv7l aarch64"
+archs="i686 i686-musl x86_64 x86_64-musl armv6l armv6l-musl armv7l armv7l-musl aarch64 aarch64-musl"
 build_style=gnu-makefile
 hostmakedepends="pkg-config"
 makedepends="alsa-lib-devel libflac-devel faad2-devel mpg123-devel libmad-devel libvorbis-devel"

From d19d29e4bf237dcc236e5a3e682f7c176299d5c8 Mon Sep 17 00:00:00 2001
From: Xaver Fischer <xaverfischer@mail.de>
Date: Mon, 1 Apr 2024 18:39:34 +0200
Subject: [PATCH 3/4] pin version 2.0.0.1477

---
 srcpkgs/squeezelite/template | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/squeezelite/template b/srcpkgs/squeezelite/template
index f748e43e3acc17..4d9d6585605995 100644
--- a/srcpkgs/squeezelite/template
+++ b/srcpkgs/squeezelite/template
@@ -1,6 +1,10 @@
 # Template file for 'squeezelite'
 pkgname=squeezelite
-version=2.0
+
+# current version is specified in squeezelite.h
+# upstream does not create git tags / github releases
+# see: https://github.com/ralph-irving/squeezelite/issues/29
+version=2.0.0.1477
 revision=1
 archs="i686 i686-musl x86_64 x86_64-musl armv6l armv6l-musl armv7l armv7l-musl aarch64 aarch64-musl"
 build_style=gnu-makefile
@@ -12,9 +16,10 @@ maintainer="Xaver Fischer <xaverfischer@mail.de>"
 license="GPL-3.0-or-later"
 homepage="https://github.com/ralph-irving/squeezelite"
 #changelog=""
-distfiles="${homepage}/archive/refs/heads/master.zip"
-checksum=53dd9162e03c3ee0655e39ce7f4ae4d0177a0e202a535ed64a4675e8b777bc1b
+distfiles="${homepage}/archive/3cbbc535f3431880b54c78f5f9489484e4187cf0.zip"
+checksum=cbe70bb0ad653eaef7cfc6aea67eec4e3341efaaa4a060df203d7814f42bf774
 
 do_install() {
 	vbin squeezelite
 }
+

From 16d920a29beaca5d2ac062e3f433df116021b60f Mon Sep 17 00:00:00 2001
From: Xaver Fischer <xaverfischer@mail.de>
Date: Sun, 7 Apr 2024 15:58:29 +0200
Subject: [PATCH 4/4] fix formatting & drop archs string

---
 srcpkgs/squeezelite/template | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/srcpkgs/squeezelite/template b/srcpkgs/squeezelite/template
index 4d9d6585605995..9066e720d6c8d3 100644
--- a/srcpkgs/squeezelite/template
+++ b/srcpkgs/squeezelite/template
@@ -6,7 +6,6 @@ pkgname=squeezelite
 # see: https://github.com/ralph-irving/squeezelite/issues/29
 version=2.0.0.1477
 revision=1
-archs="i686 i686-musl x86_64 x86_64-musl armv6l armv6l-musl armv7l armv7l-musl aarch64 aarch64-musl"
 build_style=gnu-makefile
 hostmakedepends="pkg-config"
 makedepends="alsa-lib-devel libflac-devel faad2-devel mpg123-devel libmad-devel libvorbis-devel"
@@ -15,11 +14,9 @@ short_desc="Squeezebox Client for Logitech Media Server"
 maintainer="Xaver Fischer <xaverfischer@mail.de>"
 license="GPL-3.0-or-later"
 homepage="https://github.com/ralph-irving/squeezelite"
-#changelog=""
 distfiles="${homepage}/archive/3cbbc535f3431880b54c78f5f9489484e4187cf0.zip"
 checksum=cbe70bb0ad653eaef7cfc6aea67eec4e3341efaaa4a060df203d7814f42bf774
 
 do_install() {
 	vbin squeezelite
 }
-