[PR PATCH] quazip: update to 1.4

[PR PATCH] quazip: update to 1.4

[ElHereward]

[-- Attachment #1: Type: text/plain, Size: 470 bytes --]

There is a new pull request by ElHereward against master on the void-packages repository

https://github.com/ElHereward/void-packages quazip
https://github.com/void-linux/void-packages/pull/49782

quazip: update to 1.4
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture x86_64


A patch file from https://github.com/void-linux/void-packages/pull/49782.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-quazip-49782.patch --]
[-- Type: text/x-diff, Size: 1829 bytes --]

From 4d946de21642346943ad07fc7c8b785d4e0b3470 Mon Sep 17 00:00:00 2001
From: ElHereward <andrey.koltsov@proton.me>
Date: Wed, 10 Apr 2024 13:30:33 +0200
Subject: [PATCH 1/2] quazip: update to 1.4

---
 srcpkgs/quazip/template | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/srcpkgs/quazip/template b/srcpkgs/quazip/template
index b9faea57e49bf3..eefb5558b72797 100644
--- a/srcpkgs/quazip/template
+++ b/srcpkgs/quazip/template
@@ -1,6 +1,6 @@
 # Template file for 'quazip'
 pkgname=quazip
-version=0.8.1
+version=1.4
 revision=1
 build_style=cmake
 makedepends="qt5-devel zlib-devel"
@@ -16,14 +16,9 @@ if [ -n "$CROSS_BUILD" ]; then
 fi
 
 quazip-devel_package() {
+	build_style=meta
 	depends="${sourcepkg}>=${version}_${revision}"
 	short_desc+=" - development files"
-	pkg_install() {
-		vmove usr/include
-		vmove usr/share
-		vmove "usr/lib/*.a"
-		vmove "usr/lib/*.so"
-	}
 }
 
 quazip-qt5_package() {

From 4b48ce85d5bbf863e53fc3b3fd10f36f71b9f980 Mon Sep 17 00:00:00 2001
From: ElHereward <andrey.koltsov@proton.me>
Date: Wed, 10 Apr 2024 13:34:35 +0200
Subject: [PATCH 2/2] quazip: update to 1.4

---
 srcpkgs/quazip/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/quazip/template b/srcpkgs/quazip/template
index eefb5558b72797..a3e60c3b5f6858 100644
--- a/srcpkgs/quazip/template
+++ b/srcpkgs/quazip/template
@@ -9,7 +9,7 @@ maintainer="Duncaen <duncaen@voidlinux.org>"
 license="LGPL-2.1-only"
 homepage="https://github.com/stachenov/quazip"
 distfiles="https://github.com/stachenov/quazip/archive/v${version}.tar.gz"
-checksum=4fda4d4248e08015b5090d0369ef9e68bdc4475aa12494f7c0f6d79e43270d14
+checksum=79633fd3a18e2d11a7d5c40c4c79c1786ba0c74b59ad752e8429746fe1781dd6
 
 if [ -n "$CROSS_BUILD" ]; then
 	hostmakedepends+=" qt5-host-tools qt5-devel"

Re: [PR REVIEW] quazip: update to 1.4

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 614 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/49782#discussion_r1559882311

Comment:
this is incorrect, just some files were moved around and the -devel package should not be empty.

```diff
@@ -20,8 +20,8 @@ quazip-devel_package() {
        short_desc+=" - development files"
        pkg_install() {
                vmove usr/include
-               vmove usr/share
-               vmove "usr/lib/*.a"
+               vmove usr/lib/cmake
+               vmove usr/lib/pkgconfig
                vmove "usr/lib/*.so"
        }
 }
```

Re: [PR PATCH] [Updated] quazip: update to 1.4

[ElHereward]

[-- Attachment #1: Type: text/plain, Size: 479 bytes --]

There is an updated pull request by ElHereward against master on the void-packages repository

https://github.com/ElHereward/void-packages quazip
https://github.com/void-linux/void-packages/pull/49782

quazip: update to 1.4
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture **x86_64**


A patch file from https://github.com/void-linux/void-packages/pull/49782.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-quazip-49782.patch --]
[-- Type: text/x-diff, Size: 3127 bytes --]

From 4d946de21642346943ad07fc7c8b785d4e0b3470 Mon Sep 17 00:00:00 2001
From: ElHereward <andrey.koltsov@proton.me>
Date: Wed, 10 Apr 2024 13:30:33 +0200
Subject: [PATCH 1/3] quazip: update to 1.4

---
 srcpkgs/quazip/template | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/srcpkgs/quazip/template b/srcpkgs/quazip/template
index b9faea57e49bf3..eefb5558b72797 100644
--- a/srcpkgs/quazip/template
+++ b/srcpkgs/quazip/template
@@ -1,6 +1,6 @@
 # Template file for 'quazip'
 pkgname=quazip
-version=0.8.1
+version=1.4
 revision=1
 build_style=cmake
 makedepends="qt5-devel zlib-devel"
@@ -16,14 +16,9 @@ if [ -n "$CROSS_BUILD" ]; then
 fi
 
 quazip-devel_package() {
+	build_style=meta
 	depends="${sourcepkg}>=${version}_${revision}"
 	short_desc+=" - development files"
-	pkg_install() {
-		vmove usr/include
-		vmove usr/share
-		vmove "usr/lib/*.a"
-		vmove "usr/lib/*.so"
-	}
 }
 
 quazip-qt5_package() {

From 4b48ce85d5bbf863e53fc3b3fd10f36f71b9f980 Mon Sep 17 00:00:00 2001
From: ElHereward <andrey.koltsov@proton.me>
Date: Wed, 10 Apr 2024 13:34:35 +0200
Subject: [PATCH 2/3] quazip: update to 1.4

---
 srcpkgs/quazip/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/quazip/template b/srcpkgs/quazip/template
index eefb5558b72797..a3e60c3b5f6858 100644
--- a/srcpkgs/quazip/template
+++ b/srcpkgs/quazip/template
@@ -9,7 +9,7 @@ maintainer="Duncaen <duncaen@voidlinux.org>"
 license="LGPL-2.1-only"
 homepage="https://github.com/stachenov/quazip"
 distfiles="https://github.com/stachenov/quazip/archive/v${version}.tar.gz"
-checksum=4fda4d4248e08015b5090d0369ef9e68bdc4475aa12494f7c0f6d79e43270d14
+checksum=79633fd3a18e2d11a7d5c40c4c79c1786ba0c74b59ad752e8429746fe1781dd6
 
 if [ -n "$CROSS_BUILD" ]; then
 	hostmakedepends+=" qt5-host-tools qt5-devel"

From 2ed67f7e3adb18526d69c0b28e0e4f4ae73d39a7 Mon Sep 17 00:00:00 2001
From: ElHereward <andrey.koltsov@proton.me>
Date: Thu, 11 Apr 2024 09:45:38 +0200
Subject: [PATCH 3/3] quazip: update to 1.4

---
 common/shlibs           | 2 +-
 srcpkgs/quazip/template | 6 ++++++
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/common/shlibs b/common/shlibs
index 12238cd813cede..da7063ce0bb8f4 100644
--- a/common/shlibs
+++ b/common/shlibs
@@ -2246,7 +2246,7 @@ libtelepathy-qt5-farstream.so.0 telepathy-qt5-farstream-0.9.5_1
 libKF5Attica.so.5 attica-5.6.0_1
 liblastfm_fingerprint5.so.1 liblastfm-qt5-1.0.9_1
 liblastfm5.so.1 liblastfm-qt5-1.0.9_1
-libquazip5.so.1 quazip-0.7.3_2
+libquazip5.so.1 quazip-1.4_1
 libjreen-qt5.so.1 jreen-1.3.0_1
 libzen.so.0 libzen-0.4.31_1
 libmediainfo.so.0 libmediainfo-0.7.75_1
diff --git a/srcpkgs/quazip/template b/srcpkgs/quazip/template
index a3e60c3b5f6858..426fad771c39e4 100644
--- a/srcpkgs/quazip/template
+++ b/srcpkgs/quazip/template
@@ -19,6 +19,12 @@ quazip-devel_package() {
 	build_style=meta
 	depends="${sourcepkg}>=${version}_${revision}"
 	short_desc+=" - development files"
+	pkg_install() {
+		vmove usr/include
+		vmove usr/lib/cmake
+                vmove usr/lib/pkgconfig
+		vmove "usr/lib/*.so"
+	}
 }
 
 quazip-qt5_package() {

Re: quazip: update to 1.4

[ElHereward]

[-- Attachment #1: Type: text/plain, Size: 306 bytes --]

New comment by ElHereward on void-packages repository

https://github.com/void-linux/void-packages/pull/49782#issuecomment-2049124885

Comment:
@classabbyamp tx - the problem with vmove i could solve.
i changed the shlib template - but i dont understand what you mean by rebuild. Can i test it on my own?

Re: quazip: update to 1.4

[ElHereward]

[-- Attachment #1: Type: text/plain, Size: 440 bytes --]

New comment by ElHereward on void-packages repository

https://github.com/void-linux/void-packages/pull/49782#issuecomment-2049124885

Comment:
@classabbyamp tx - the problem with vmove i could solve.
i changed the shlib template - but i dont understand what you mean by rebuild. Can i test it on my own?
What i also didnt understand: why void packages quazip 0.8.1 but shlibs need 0.7.3? Is there any dependencies at the running system?

Re: quazip: update to 1.4

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 603 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/49782#issuecomment-2049509073

Comment:
> i dont understand what you mean by rebuild

when the version of a shared library changes, the packages that use that shared library need to be rebuilt for the new version

> Can i test it on my own?

sure, but those packages also need to be included in this PR with the `revision` incremented

> why void packages quazip 0.8.1 but shlibs need 0.7.3?

`common/shlibs` records the _minimum_ version of the package that provides the shared library

Re: quazip: update to 1.4

[ElHereward]

[-- Attachment #1: Type: text/plain, Size: 675 bytes --]

New comment by ElHereward on void-packages repository

https://github.com/void-linux/void-packages/pull/49782#issuecomment-2049517776

Comment:
> > i dont understand what you mean by rebuild
> 
> when the version of a shared library changes, the packages that use that shared library need to be rebuilt for the new version
> 
> > Can i test it on my own?
> 
> sure, but those packages also need to be included in this PR with the `revision` incremented
> 
> > why void packages quazip 0.8.1 but shlibs need 0.7.3?
> 
> `common/shlibs` records the _minimum_ version of the package that provides the shared library

okay tx - then i need to read the docs twice :D 

Re: [PR PATCH] [Updated] quazip: update to 1.4

[ElHereward]

[-- Attachment #1: Type: text/plain, Size: 479 bytes --]

There is an updated pull request by ElHereward against master on the void-packages repository

https://github.com/ElHereward/void-packages quazip
https://github.com/void-linux/void-packages/pull/49782

quazip: update to 1.4
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture **x86_64**


A patch file from https://github.com/void-linux/void-packages/pull/49782.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-quazip-49782.patch --]
[-- Type: text/x-diff, Size: 3127 bytes --]

From 4d946de21642346943ad07fc7c8b785d4e0b3470 Mon Sep 17 00:00:00 2001
From: ElHereward <andrey.koltsov@proton.me>
Date: Wed, 10 Apr 2024 13:30:33 +0200
Subject: [PATCH 1/3] quazip: update to 1.4

---
 srcpkgs/quazip/template | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/srcpkgs/quazip/template b/srcpkgs/quazip/template
index b9faea57e49bf3..eefb5558b72797 100644
--- a/srcpkgs/quazip/template
+++ b/srcpkgs/quazip/template
@@ -1,6 +1,6 @@
 # Template file for 'quazip'
 pkgname=quazip
-version=0.8.1
+version=1.4
 revision=1
 build_style=cmake
 makedepends="qt5-devel zlib-devel"
@@ -16,14 +16,9 @@ if [ -n "$CROSS_BUILD" ]; then
 fi
 
 quazip-devel_package() {
+	build_style=meta
 	depends="${sourcepkg}>=${version}_${revision}"
 	short_desc+=" - development files"
-	pkg_install() {
-		vmove usr/include
-		vmove usr/share
-		vmove "usr/lib/*.a"
-		vmove "usr/lib/*.so"
-	}
 }
 
 quazip-qt5_package() {

From 4b48ce85d5bbf863e53fc3b3fd10f36f71b9f980 Mon Sep 17 00:00:00 2001
From: ElHereward <andrey.koltsov@proton.me>
Date: Wed, 10 Apr 2024 13:34:35 +0200
Subject: [PATCH 2/3] quazip: update to 1.4

---
 srcpkgs/quazip/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/quazip/template b/srcpkgs/quazip/template
index eefb5558b72797..a3e60c3b5f6858 100644
--- a/srcpkgs/quazip/template
+++ b/srcpkgs/quazip/template
@@ -9,7 +9,7 @@ maintainer="Duncaen <duncaen@voidlinux.org>"
 license="LGPL-2.1-only"
 homepage="https://github.com/stachenov/quazip"
 distfiles="https://github.com/stachenov/quazip/archive/v${version}.tar.gz"
-checksum=4fda4d4248e08015b5090d0369ef9e68bdc4475aa12494f7c0f6d79e43270d14
+checksum=79633fd3a18e2d11a7d5c40c4c79c1786ba0c74b59ad752e8429746fe1781dd6
 
 if [ -n "$CROSS_BUILD" ]; then
 	hostmakedepends+=" qt5-host-tools qt5-devel"

From 2ed67f7e3adb18526d69c0b28e0e4f4ae73d39a7 Mon Sep 17 00:00:00 2001
From: ElHereward <andrey.koltsov@proton.me>
Date: Thu, 11 Apr 2024 09:45:38 +0200
Subject: [PATCH 3/3] quazip: update to 1.4

---
 common/shlibs           | 2 +-
 srcpkgs/quazip/template | 6 ++++++
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/common/shlibs b/common/shlibs
index 12238cd813cede..da7063ce0bb8f4 100644
--- a/common/shlibs
+++ b/common/shlibs
@@ -2246,7 +2246,7 @@ libtelepathy-qt5-farstream.so.0 telepathy-qt5-farstream-0.9.5_1
 libKF5Attica.so.5 attica-5.6.0_1
 liblastfm_fingerprint5.so.1 liblastfm-qt5-1.0.9_1
 liblastfm5.so.1 liblastfm-qt5-1.0.9_1
-libquazip5.so.1 quazip-0.7.3_2
+libquazip5.so.1 quazip-1.4_1
 libjreen-qt5.so.1 jreen-1.3.0_1
 libzen.so.0 libzen-0.4.31_1
 libmediainfo.so.0 libmediainfo-0.7.75_1
diff --git a/srcpkgs/quazip/template b/srcpkgs/quazip/template
index a3e60c3b5f6858..426fad771c39e4 100644
--- a/srcpkgs/quazip/template
+++ b/srcpkgs/quazip/template
@@ -19,6 +19,12 @@ quazip-devel_package() {
 	build_style=meta
 	depends="${sourcepkg}>=${version}_${revision}"
 	short_desc+=" - development files"
+	pkg_install() {
+		vmove usr/include
+		vmove usr/lib/cmake
+                vmove usr/lib/pkgconfig
+		vmove "usr/lib/*.so"
+	}
 }
 
 quazip-qt5_package() {

Re: [PR PATCH] [Closed]: quazip: update to 1.4

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 318 bytes --]

There's a closed pull request on the void-packages repository

quazip: update to 1.4
https://github.com/void-linux/void-packages/pull/49782

Description:
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture **x86_64**