Github messages for voidlinux
 help / color / mirror / Atom feed
From: MIvanchev <MIvanchev@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: TheForceEngine: remove optional dependency zenity
Date: Sat, 20 Apr 2024 10:02:14 +0200	[thread overview]
Message-ID: <20240420080214.8B6D923D73@inbox.vuxu.org> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-49933@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 635 bytes --]

New comment by MIvanchev on void-packages repository

https://github.com/void-linux/void-packages/pull/49933#issuecomment-2067596553

Comment:
zenity is not a required runtime dependency, it's an optional runtime dependency and one of 4 possible that allows file selection dialogs to be shown. This is clear in both the documentation and the source (https://github.com/luciusDXL/TheForceEngine/blob/master/TheForceEngine/TFE_Ui/portable-file-dialogs.h#L525).  It also reduces the package size from 120MB (and including weird stuff like webkit and AppStream) to 16MB. Without zenity or kdialog the user has to enter the paths manually.

      parent reply	other threads:[~2024-04-20  8:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-20  7:58 [PR PATCH] " MIvanchev
2024-04-20  8:01 ` MIvanchev
2024-04-20  8:02 ` MIvanchev [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240420080214.8B6D923D73@inbox.vuxu.org \
    --to=mivanchev@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).