[PR PATCH] TheForceEngine: remove optional dependency zenity

[PR PATCH] TheForceEngine: remove optional dependency zenity

[MIvanchev]

[-- Attachment #1: Type: text/plain, Size: 523 bytes --]

There is a new pull request by MIvanchev against master on the void-packages repository

https://github.com/MIvanchev/void-packages theforceengine-no-zenity
https://github.com/void-linux/void-packages/pull/49933

TheForceEngine: remove optional dependency zenity
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-GLIBC)


A patch file from https://github.com/void-linux/void-packages/pull/49933.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-theforceengine-no-zenity-49933.patch --]
[-- Type: text/x-diff, Size: 1007 bytes --]

From 456fa289b78acbabf2ea9765e45bb3395f9cb846 Mon Sep 17 00:00:00 2001
From: Mihail Ivanchev <contact@ivanchev.net>
Date: Sat, 20 Apr 2024 09:56:57 +0200
Subject: [PATCH] TheForceEngine: remove optional dependency zenity

---
 srcpkgs/TheForceEngine/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/TheForceEngine/template b/srcpkgs/TheForceEngine/template
index 6805db0ff5194e..cf7b1d1114dc7a 100644
--- a/srcpkgs/TheForceEngine/template
+++ b/srcpkgs/TheForceEngine/template
@@ -1,11 +1,11 @@
 # Template file for 'TheForceEngine'
 pkgname=TheForceEngine
 version=1.09.540
-revision=1
+revision=2
 build_style=cmake
 hostmakedepends="pkg-config"
 makedepends="SDL2-devel SDL2_image-devel rtmidi-devel jack-devel glew-devel MesaLib-devel"
-depends="zenity"
+depends="desktop-file-utils hicolor-icon-theme"
 short_desc="Modern \"Jedi Engine\" replacement supporting Dark Forces and mods"
 maintainer="Kenneth Dodrill <hello@kennydodrill.com>"
 license="GPL-2.0-only"

Re: TheForceEngine: remove optional dependency zenity

[MIvanchev]

[-- Attachment #1: Type: text/plain, Size: 567 bytes --]

New comment by MIvanchev on void-packages repository

https://github.com/void-linux/void-packages/pull/49933#issuecomment-2067596553

Comment:
zenity is not a required runtime dependency, it's an optional runtime dependency and one of 4 possible that allows file selection dialogs to be shown. This is clear in both the documentation and the source (https://github.com/luciusDXL/TheForceEngine/blob/master/TheForceEngine/TFE_Ui/portable-file-dialogs.h#L525).  It also reduces the package size from 120MB (and including weird stuff like webkit and AppStream) to 16MB.

Re: TheForceEngine: remove optional dependency zenity

[MIvanchev]

[-- Attachment #1: Type: text/plain, Size: 635 bytes --]

New comment by MIvanchev on void-packages repository

https://github.com/void-linux/void-packages/pull/49933#issuecomment-2067596553

Comment:
zenity is not a required runtime dependency, it's an optional runtime dependency and one of 4 possible that allows file selection dialogs to be shown. This is clear in both the documentation and the source (https://github.com/luciusDXL/TheForceEngine/blob/master/TheForceEngine/TFE_Ui/portable-file-dialogs.h#L525).  It also reduces the package size from 120MB (and including weird stuff like webkit and AppStream) to 16MB. Without zenity or kdialog the user has to enter the paths manually.