[PR PATCH] singular: update to 4.4.0.

[PR PATCH] singular: update to 4.4.0.

[tornaria]

[-- Attachment #1: Type: text/plain, Size: 1513 bytes --]

There is a new pull request by tornaria against master on the void-packages repository

https://github.com/tornaria/void-packages singular
https://github.com/void-linux/void-packages/pull/49966

singular: update to 4.4.0.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

This needed bumping sagemath, so its testsuite is fully run here for a good test that singular works fine for us. One test fails due to the update of scipy to 1.13, so I added an easy fix (backported, already merged upstream).

@dkwo may want to test on aarch64.

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/49966.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-singular-49966.patch --]
[-- Type: text/x-diff, Size: 4332 bytes --]

From ebfa6fdb77a648a95cc029302fe0bbd856d636e0 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Gonzalo=20Tornar=C3=ADa?= <tornaria@cmat.edu.uy>
Date: Sun, 21 Apr 2024 14:50:37 -0300
Subject: [PATCH 1/2] singular: update to 4.4.0.

---
 common/shlibs             | 8 ++++----
 srcpkgs/singular/template | 4 ++--
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/common/shlibs b/common/shlibs
index c4a876216d6397..d3c889a0783a69 100644
--- a/common/shlibs
+++ b/common/shlibs
@@ -4038,10 +4038,10 @@ libecl.so.23.9 ecl-23.9.9_1
 libecm.so.1 ecm-7.0.4_3
 libcliquer.so.1 cliquer-1.22_1
 libomalloc-0.9.6.so singular-4.2.1_1
-libSingular-4.3.2.so singular-4.3.2_1
-libfactory-4.3.2.so singular-4.3.2_1
-libpolys-4.3.2.so singular-4.3.2_1
-libsingular_resources-4.3.2.so singular-4.3.2_1
+libSingular-4.4.0.so singular-4.4.0_1
+libfactory-4.4.0.so singular-4.4.0_1
+libpolys-4.4.0.so singular-4.4.0_1
+libsingular_resources-4.4.0.so singular-4.4.0_1
 libbrial.so.3 brial-1.2.10_1
 libbrial_groebner.so.3 brial-1.2.10_1
 libm4ri-0.0.20200125.so m4ri-20200125_1
diff --git a/srcpkgs/singular/template b/srcpkgs/singular/template
index 819ee81cb82801..aa4899c7bdaab9 100644
--- a/srcpkgs/singular/template
+++ b/srcpkgs/singular/template
@@ -1,6 +1,6 @@
 # Template file for 'singular'
 pkgname=singular
-version=4.3.2p16
+version=4.4.0
 revision=1
 _majver=${version%p*}
 build_style=gnu-configure
@@ -20,7 +20,7 @@ maintainer="dkwo <npiazza@disroot.org>, Gonzalo Tornaría <tornaria@cmat.edu.uy>
 license="GPL-2.0-or-later"
 homepage="https://www.singular.uni-kl.de"
 distfiles="https://www.singular.uni-kl.de/ftp/pub/Math/Singular/SOURCES/${_majver//./-}/singular-${version}.tar.gz"
-checksum=675733ba13a6ec67c564e753139f7c0c4b0d3e29bdb995de5341b616f1472a16
+checksum=c269abbd24c84fe33edc0af1e78b8fec53d8e94338410ac06c2666cfd40d43f2
 
 if [ -z "$CROSS_BUILD" ]; then
 	makedepends+=" ntl-devel"

From e678ec4e1865f9e4958b180865f20ec01661bdfe Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Gonzalo=20Tornar=C3=ADa?= <tornaria@cmat.edu.uy>
Date: Sun, 21 Apr 2024 14:51:04 -0300
Subject: [PATCH 2/2] sagemath: revbump for singular

---
 srcpkgs/sagemath/patches/37763-scipy_1.13.patch | 13 +++++++++++++
 srcpkgs/sagemath/patches/get_patches            |  1 +
 srcpkgs/sagemath/template                       |  2 +-
 3 files changed, 15 insertions(+), 1 deletion(-)
 create mode 100644 srcpkgs/sagemath/patches/37763-scipy_1.13.patch

diff --git a/srcpkgs/sagemath/patches/37763-scipy_1.13.patch b/srcpkgs/sagemath/patches/37763-scipy_1.13.patch
new file mode 100644
index 00000000000000..219c6bdc323f7e
--- /dev/null
+++ b/srcpkgs/sagemath/patches/37763-scipy_1.13.patch
@@ -0,0 +1,13 @@
+diff --git a/src/sage/matrix/matrix_double_dense.pyx b/src/sage/matrix/matrix_double_dense.pyx
+index 6877a924de2..a01defad999 100644
+--- a/src/sage/matrix/matrix_double_dense.pyx
++++ b/src/sage/matrix/matrix_double_dense.pyx
+@@ -3683,7 +3683,7 @@ cdef class Matrix_double_dense(Matrix_numpy_dense):
+             sage: A = matrix(CDF, 2, [1,2+I,3*I,4]); A                                  # needs sage.symbolic
+             [        1.0 2.0 + 1.0*I]
+             [      3.0*I         4.0]
+-            sage: A.exp()  # tol 1.1e-14                                                # needs sage.symbolic
++            sage: A.exp()  # tol 3e-14                                                  # needs sage.symbolic
+             [-19.614602953804912 + 12.517743846762578*I   3.7949636449582176 + 28.88379930658099*I]
+             [ -32.383580980922254 + 21.88423595789845*I   2.269633004093535 + 44.901324827684824*I]
+ 
diff --git a/srcpkgs/sagemath/patches/get_patches b/srcpkgs/sagemath/patches/get_patches
index 77afead3fc913d..56057bbd4a397b 100755
--- a/srcpkgs/sagemath/patches/get_patches
+++ b/srcpkgs/sagemath/patches/get_patches
@@ -22,3 +22,4 @@ cd $(dirname "$0")
 
 # needs review
 get_pr 37492 "singular 4.3.2p16"
+get_pr 37763 "scipy 1.13"
diff --git a/srcpkgs/sagemath/template b/srcpkgs/sagemath/template
index 22faf78921c5f4..8b4bf7dfa441bb 100644
--- a/srcpkgs/sagemath/template
+++ b/srcpkgs/sagemath/template
@@ -1,7 +1,7 @@
 # Template file for 'sagemath'
 pkgname=sagemath
 version=10.3
-revision=1
+revision=2
 build_wrksrc=pkgs/sagemath-standard
 build_style=python3-pep517
 make_build_args="--skip-dependency-check"

Re: singular: update to 4.4.0.

[dkwo]

[-- Attachment #1: Type: text/plain, Size: 174 bytes --]

New comment by dkwo on void-packages repository

https://github.com/void-linux/void-packages/pull/49966#issuecomment-2072438997

Comment:
Thanks!  Give me a couple of days.

Re: singular: update to 4.4.0.

[tornaria]

[-- Attachment #1: Type: text/plain, Size: 212 bytes --]

New comment by tornaria on void-packages repository

https://github.com/void-linux/void-packages/pull/49966#issuecomment-2072497542

Comment:
> Thanks! Give me a couple of days.

Sure, there's no hurry at all.

Re: singular: update to 4.4.0.

[dkwo]

[-- Attachment #1: Type: text/plain, Size: 402 bytes --]

New comment by dkwo on void-packages repository

https://github.com/void-linux/void-packages/pull/49966#issuecomment-2075731380

Comment:
On aarch64, with check=yes, I get one slow doctest
`sage/homology/moment_angle_complex.py Warning, slow doctest: Z.homology()`
and one failure
`sage/algebras/quatalg/quaternion_algebra.py # 1 doctest failed`

I'll try again to see if it was a random failure.

Re: singular: update to 4.4.0.

[tornaria]

[-- Attachment #1: Type: text/plain, Size: 864 bytes --]

New comment by tornaria on void-packages repository

https://github.com/void-linux/void-packages/pull/49966#issuecomment-2075865045

Comment:
You know that you can write something like
```
sage/homology/moment_angle_complex.py
sage/algebras/quatalg/quaternion_algebra.py 
```
to a file `sagemath-check` in your void-packages directory. Then, when you run the check step, it will only check those two files.

You can also write something like
```
--random-seed=337742633039183257810362073317290869627
sage/algebras/quatalg/quaternion_algebra.py 
```
If you want to run with this particular random seed, which you can copy from the log output. This helps confirm if the doctest failure is random but deterministic with a fixed random seed.

If you don't have this file, *or* if everything is commented out with `#`, then all files are tested as usual.

Re: singular: update to 4.4.0.

[dkwo]

[-- Attachment #1: Type: text/plain, Size: 410 bytes --]

New comment by dkwo on void-packages repository

https://github.com/void-linux/void-packages/pull/49966#issuecomment-2075944568

Comment:
Thanks for the reminder. Both tests pass from within sage. also from sage, `sage -t -a` passes all tests, so this is good to go.

Btw, I'm getting tons of
`warning: sage/*: noexcept clause is ignored for function returning Python object`
at the beginning of do_build.

Re: singular: update to 4.4.0.

[tornaria]

[-- Attachment #1: Type: text/plain, Size: 604 bytes --]

New comment by tornaria on void-packages repository

https://github.com/void-linux/void-packages/pull/49966#issuecomment-2075958962

Comment:
> Thanks for the reminder. Both tests pass from within sage. also from sage, `sage -t -a` passes all tests, so this is good to go.
> 
> Btw, I'm getting tons of `warning: sage/*: noexcept clause is ignored for function returning Python object` at the beginning of do_build.

Yes, this is a new warning in cython 3.0.10, safe to ignore.

All of these warnings are gone in my beta branch of sagemath at #49571 (it's a bit outdated, will try to update soon).

Re: [PR PATCH] [Merged]: singular: update to 4.4.0.

[cinerea0]

[-- Attachment #1: Type: text/plain, Size: 1359 bytes --]

There's a merged pull request on the void-packages repository

singular: update to 4.4.0.
https://github.com/void-linux/void-packages/pull/49966

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

This needed bumping sagemath, so its testsuite is fully run here for a good test that singular works fine for us. One test fails due to the update of scipy to 1.13, so I added an easy fix (backported, already merged upstream).

@dkwo may want to test on aarch64.

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->